[GitHub] [kafka] dajac opened a new pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-24 Thread GitBox
dajac opened a new pull request #9334: URL: https://github.com/apache/kafka/pull/9334 This PR does two things: * As stated in KIP-599, we'd like to disable the automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in order to avoid letting the command hangs until `default.api.timeout.ms

[GitHub] [kafka] mimaison commented on pull request #9313: [mm2] Fix consumer/producer properties override

2020-09-24 Thread GitBox
mimaison commented on pull request #9313: URL: https://github.com/apache/kafka/pull/9313#issuecomment-698229647 @scanterog Thanks for the PR. Can you add a test for the changes? This is an automated message from the Apache Gi

[GitHub] [kafka] fredsh2k opened a new pull request #9335: Update quickstart.html

2020-09-24 Thread GitBox
fredsh2k opened a new pull request #9335: URL: https://github.com/apache/kafka/pull/9335 i've followed quickstart instructions here https://kafka.apache.org/documentation/#quickstart_send and when i run: `bin/kafka-console-producer.sh --topic quickstart-events --bootstrap-server loca

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494170995 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494171814 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494173396 ## File path: clients/src/main/resources/common/message/UpdateFeaturesResponse.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494174446 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FeatureMetadata.java ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] ijuma commented on pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-24 Thread GitBox
ijuma commented on pull request #9331: URL: https://github.com/apache/kafka/pull/9331#issuecomment-698233595 Unrelated flaky test failures: ``` Build / JDK 11 / kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup Build / JDK 15 /

[GitHub] [kafka] ijuma merged pull request #9331: MINOR: Use JUnit 5 in raft module

2020-09-24 Thread GitBox
ijuma merged pull request #9331: URL: https://github.com/apache/kafka/pull/9331 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494179911 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FeatureMetadata.java ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494180167 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1216,71 @@ default AlterClientQuotasResult alterClientQuotas(C

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494180021 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/FeatureMetadata.java ## @@ -0,0 +1,103 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [kafka] ijuma commented on pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-24 Thread GitBox
ijuma commented on pull request #9206: URL: https://github.com/apache/kafka/pull/9206#issuecomment-698237578 Unrelated flaky failures: ``` Build / JDK 15 / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateBelowLimit | 5 sec | 1 -- | -- | -- Bu

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494180601 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesResult.java ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494180305 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/Admin.java ## @@ -1214,6 +1216,71 @@ default AlterClientQuotasResult alterClientQuotas(C

[GitHub] [kafka] ijuma commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-24 Thread GitBox
ijuma commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r494182608 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means an except

[GitHub] [kafka] ijuma merged pull request #9206: MINOR: rewrite zipWithIndex by normal foreach to refrain unnecessary …

2020-09-24 Thread GitBox
ijuma merged pull request #9206: URL: https://github.com/apache/kafka/pull/9206 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494183456 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4078,113 @@ void handleFailure(Throwable throwable)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494183456 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java ## @@ -4071,6 +4078,113 @@ void handleFailure(Throwable throwable)

[jira] [Commented] (KAFKA-9075) Extend documentation for usage of GlobalKTable vs KTable

2020-09-24 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201421#comment-17201421 ] Ankit Kumar commented on KAFKA-9075: Thank you [~mjsax], I have an idea about creatin

[GitHub] [kafka] ijuma opened a new pull request #9336: MINOR: Don't publish javadocs for raft module

2020-09-24 Thread GitBox
ijuma opened a new pull request #9336: URL: https://github.com/apache/kafka/pull/9336 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] ijuma commented on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-09-24 Thread GitBox
ijuma commented on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529 @hachikuji Do we intend to various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider merging

[GitHub] [kafka] ijuma edited a comment on pull request #9336: MINOR: Don't publish javadocs for raft module

2020-09-24 Thread GitBox
ijuma edited a comment on pull request #9336: URL: https://github.com/apache/kafka/pull/9336#issuecomment-698252529 @hachikuji Do we intend the various non internal Raft classes to be a public API where we need a KIP to make any changes? If we don't want that or not yet, we should consider

[jira] [Created] (KAFKA-10520) InitProducerId may be blocked if least loaded node is not ready to send

2020-09-24 Thread Rajini Sivaram (Jira)
Rajini Sivaram created KAFKA-10520: -- Summary: InitProducerId may be blocked if least loaded node is not ready to send Key: KAFKA-10520 URL: https://issues.apache.org/jira/browse/KAFKA-10520 Project:

[jira] [Updated] (KAFKA-10520) InitProducerId may be blocked if least loaded node is not ready to send

2020-09-24 Thread Rajini Sivaram (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajini Sivaram updated KAFKA-10520: --- Description: >From the logs of a failing producer that shows InitProducerId timing out after

[GitHub] [kafka] viktorsomogyi commented on a change in pull request #4090: [KAFKA-6084] Propagate JSON parsing errors in ReassignPartitionsCommand

2020-09-24 Thread GitBox
viktorsomogyi commented on a change in pull request #4090: URL: https://github.com/apache/kafka/pull/4090#discussion_r494261046 ## File path: core/src/main/scala/kafka/utils/Json.scala ## @@ -69,8 +70,11 @@ object Json { * @return An `Either` which in case of `Left` means a

[jira] [Created] (KAFKA-10521) Remove ZK watch for completing partition reassignment

2020-09-24 Thread David Arthur (Jira)
David Arthur created KAFKA-10521: Summary: Remove ZK watch for completing partition reassignment Key: KAFKA-10521 URL: https://issues.apache.org/jira/browse/KAFKA-10521 Project: Kafka Issue T

[GitHub] [kafka] mimaison merged pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-24 Thread GitBox
mimaison merged pull request #8295: URL: https://github.com/apache/kafka/pull/8295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] mimaison commented on pull request #8295: KAFKA-9627: Replace ListOffset request/response with automated protocol

2020-09-24 Thread GitBox
mimaison commented on pull request #8295: URL: https://github.com/apache/kafka/pull/8295#issuecomment-698359953 Thanks @abbccdda and @dajac for the reviews! This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (KAFKA-9629) Replace Fetch request/response with automated protocol

2020-09-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-9629. --- Fix Version/s: 2.7.0 Resolution: Fixed > Replace Fetch request/response with automated

[jira] [Commented] (KAFKA-9629) Replace Fetch request/response with automated protocol

2020-09-24 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201543#comment-17201543 ] Mickael Maison commented on KAFKA-9629: --- Done in https://github.com/apache/kafka/pu

[GitHub] [kafka] vvcephei commented on pull request #9316: MINOR: clarify variables for skipping idempotent source updates

2020-09-24 Thread GitBox
vvcephei commented on pull request #9316: URL: https://github.com/apache/kafka/pull/9316#issuecomment-698378699 Test failure was unrelated. ``` Build / JDK 15 / org.apache.kafka.connect.mirror.MirrorConnectorsIntegrationTest.testReplication ``` ---

[GitHub] [kafka] luigiberrettini commented on pull request #3743: KAFKA-5494: enable idempotence with max.in.flight.requests.per.connection > 1

2020-09-24 Thread GitBox
luigiberrettini commented on pull request #3743: URL: https://github.com/apache/kafka/pull/3743#issuecomment-698379057 I saw that the [Sender](https://github.com/apache/kafka/blob/2.6.0/clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java#L602) checks for a `Errors

[GitHub] [kafka] vvcephei merged pull request #9316: MINOR: clarify variables for skipping idempotent source updates

2020-09-24 Thread GitBox
vvcephei merged pull request #9316: URL: https://github.com/apache/kafka/pull/9316 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] vvcephei commented on a change in pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-24 Thread GitBox
vvcephei commented on a change in pull request #8181: URL: https://github.com/apache/kafka/pull/8181#discussion_r494369894 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -581,8 +580,8 @@ public void punctuate(final Proces

[GitHub] [kafka] vvcephei commented on pull request #8181: KAFKA-9584 Headers ConcurrentModificationException

2020-09-24 Thread GitBox
vvcephei commented on pull request #8181: URL: https://github.com/apache/kafka/pull/8181#issuecomment-698385372 Hey @MicahRam , I'm ready to merge this now, but there are some merge conflicts. Can you rebase this PR against the current trunk? Thanks! --

[GitHub] [kafka] mimaison commented on pull request #9335: Update quickstart.html

2020-09-24 Thread GitBox
mimaison commented on pull request #9335: URL: https://github.com/apache/kafka/pull/9335#issuecomment-698388310 Which version of Kafka are you using? Since 2.6, `--bootstrap-server` is the recommended flag. `--broker-list` is now deprecated and will be removed in the next major versi

[GitHub] [kafka] yeralin commented on pull request #6592: KAFKA-8326: Introduce List Serde

2020-09-24 Thread GitBox
yeralin commented on pull request #6592: URL: https://github.com/apache/kafka/pull/6592#issuecomment-698414958 Any updates :)? This is an automated message from the Apache Git Service. To respond to the message, please log o

[jira] [Commented] (KAFKA-8318) Session Window Aggregations generate an extra tombstone

2020-09-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201590#comment-17201590 ] John Roesler commented on KAFKA-8318: - Hi [~ipasynkov] , thanks for your interest! I

[jira] [Updated] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-09-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10515: - Priority: Blocker (was: Major) > NPE: Foreign key join serde may not be initialized with defaul

[jira] [Updated] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-09-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10515: - Fix Version/s: 2.6.1 2.5.2 2.7.0 > NPE: Foreign key join s

[jira] [Created] (KAFKA-10522) Duplicate detection and max.in.flight.requests.per.connection details

2020-09-24 Thread Luigi Berrettini (Jira)
Luigi Berrettini created KAFKA-10522: Summary: Duplicate detection and max.in.flight.requests.per.connection details Key: KAFKA-10522 URL: https://issues.apache.org/jira/browse/KAFKA-10522 Project

[jira] [Created] (KAFKA-10523) Allow to provide producer ID

2020-09-24 Thread Luigi Berrettini (Jira)
Luigi Berrettini created KAFKA-10523: Summary: Allow to provide producer ID Key: KAFKA-10523 URL: https://issues.apache.org/jira/browse/KAFKA-10523 Project: Kafka Issue Type: New Feature

[jira] [Commented] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-09-24 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201603#comment-17201603 ] John Roesler commented on KAFKA-10515: -- Thanks for this report, [~thorsten.hake] !

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-24 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r494424452 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-24 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r494424452 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-24 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r494425944 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1040,21 +1040,36 @@ class GroupCoordinator(val brokerId: Int,

[GitHub] [kafka] feyman2016 commented on a change in pull request #9270: [WIP] KAFKA-10284: Group membership update due to static member rejoin should be persisted

2020-09-24 Thread GitBox
feyman2016 commented on a change in pull request #9270: URL: https://github.com/apache/kafka/pull/9270#discussion_r494426818 ## File path: core/src/test/scala/unit/kafka/coordinator/group/GroupCoordinatorTest.scala ## @@ -3882,6 +3942,21 @@ class GroupCoordinatorTest { Aw

[jira] [Created] (KAFKA-10524) Manpage help for kafka-configs.sh does not fully explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
Daniel Laing created KAFKA-10524: Summary: Manpage help for kafka-configs.sh does not fully explain broker-loggers Key: KAFKA-10524 URL: https://issues.apache.org/jira/browse/KAFKA-10524 Project: Kafk

[jira] [Updated] (KAFKA-10524) Manpage help for kafka-configs.sh does not fully explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: (was: Please see the example app to reproduce the issue: https://github.com/gab

[jira] [Commented] (KAFKA-9075) Extend documentation for usage of GlobalKTable vs KTable

2020-09-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201617#comment-17201617 ] Matthias J. Sax commented on KAFKA-9075: Well, there is a small mentioning of Glo

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Affects Version/s: 2.5.0 2.5.1 Description: When you run `./kaf

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: When you run `./kafka-configs.sh` the manpage help appears. The summary of the too

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: When you run `./kafka-configs.sh` the manpage help appears. The summary of the too

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: When you run `./kafka-configs.sh` the manpage help appears. The summary of the too

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: When you run `./kafka-configs.sh` the manpage help appears. The summary of the too

[jira] [Updated] (KAFKA-10524) Help for kafka-configs.sh does not explain broker-loggers

2020-09-24 Thread Daniel Laing (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Laing updated KAFKA-10524: - Description: When you run `./kafka-configs.sh` the manpage help appears. The summary of the too

[GitHub] [kafka] hachikuji commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-698458937 Yeah, I'm ok leaving that for https://issues.apache.org/jira/browse/KAFKA-10521. This is an automated message f

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494480847 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1764,6 +1769,145 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] hachikuji commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494494327 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLog.java ## @@ -310,10 +310,10 @@ public LogFetchInfo read(long startOffset, Isolation isolati

[GitHub] [kafka] hachikuji commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494494797 ## File path: raft/src/test/java/org/apache/kafka/raft/MockLogTest.java ## @@ -370,6 +365,23 @@ public void testReadOutOfRangeOffset() { Isol

[GitHub] [kafka] hachikuji commented on a change in pull request #9332: KAFKA-10511; Ensure monotonic start epoch/offset updates in `MockLog`

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9332: URL: https://github.com/apache/kafka/pull/9332#discussion_r494498741 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftEventSimulationTest.java ## @@ -712,11 +712,6 @@ void initializeElection(ElectionState election

[jira] [Assigned] (KAFKA-10519) Unit tests for VotedState

2020-09-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-10519: --- Assignee: Jason Gustafson > Unit tests for VotedState > - >

[GitHub] [kafka] hachikuji opened a new pull request #9337: KAFKA-10519; Add missing unit test for `VotedState`

2020-09-24 Thread GitBox
hachikuji opened a new pull request #9337: URL: https://github.com/apache/kafka/pull/9337 Add a simple unit test for `VotedState`. This was a leftover TODO from the initial Raft merge that was caught by #9331. ### Committer Checklist (excluded from commit message) - [ ] Verify de

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494519631 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -977,14 +1179,30 @@ class KafkaController(val config: KafkaConfig, /**

[GitHub] [kafka] mumrah commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
mumrah commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494523773 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1246,6 +1351,51 @@ class Partition(val topicPartition: TopicPartition, } } +

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494542156 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1865,192 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9334: KAFKA-10516; Disable automatic retry of `THROTTLING_QUOTA_EXCEEDED` errors in the `kafka-topics` command (KIP-599)

2020-09-24 Thread GitBox
rajinisivaram commented on a change in pull request #9334: URL: https://github.com/apache/kafka/pull/9334#discussion_r494510121 ## File path: core/src/main/scala/kafka/admin/TopicCommand.scala ## @@ -69,16 +71,26 @@ object TopicCommand extends Logging { else if (opts.has

[jira] [Commented] (KAFKA-10515) NPE: Foreign key join serde may not be initialized with default serde if application is distributed

2020-09-24 Thread Thorsten Hake (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201735#comment-17201735 ] Thorsten Hake commented on KAFKA-10515: --- @[~vvcephei] I would like to submit a pat

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494171814 ## File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json ## @@ -0,0 +1,33 @@ +// Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494569726 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,192 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [kafka] apovzner commented on pull request #9317: KAFKA-10509: Added throttle connection accept rate metric (KIP-612)

2020-09-24 Thread GitBox
apovzner commented on pull request #9317: URL: https://github.com/apache/kafka/pull/9317#issuecomment-698601105 PR Build failed due to know flaky tests: https://issues.apache.org/jira/browse/KAFKA-8266: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDi

[jira] [Created] (KAFKA-10525) Emit JSONs with new auto-generated schema

2020-09-24 Thread Anastasia Vela (Jira)
Anastasia Vela created KAFKA-10525: -- Summary: Emit JSONs with new auto-generated schema Key: KAFKA-10525 URL: https://issues.apache.org/jira/browse/KAFKA-10525 Project: Kafka Issue Type: Imp

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463915553 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,178 @@ class KafkaController(val config: KafkaConfig, } }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

2020-09-24 Thread GitBox
kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r494653251 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1865,192 @@ class KafkaController(val config: KafkaConfig, }

[jira] [Commented] (KAFKA-10134) High CPU issue during rebalance in Kafka consumer after upgrading to 2.5

2020-09-24 Thread Jerry Wei (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201807#comment-17201807 ] Jerry Wei commented on KAFKA-10134: --- [~guozhang] looks the fix version is 2.7.0 &2.6.1

[GitHub] [kafka] hachikuji commented on a change in pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on a change in pull request #9100: URL: https://github.com/apache/kafka/pull/9100#discussion_r494660983 ## File path: core/src/main/scala/kafka/cluster/Partition.scala ## @@ -1366,6 +1366,12 @@ class Partition(val topicPartition: TopicPartition, } }

[GitHub] [kafka] hachikuji commented on pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji commented on pull request #9100: URL: https://github.com/apache/kafka/pull/9100#issuecomment-698637507 I think the failing tests are known flakes and should be fixed by https://issues.apache.org/jira/browse/KAFKA-10514. ---

[GitHub] [kafka] hachikuji merged pull request #9100: Add AlterISR RPC and use it for ISR modifications

2020-09-24 Thread GitBox
hachikuji merged pull request #9100: URL: https://github.com/apache/kafka/pull/9100 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Resolved] (KAFKA-8836) Add inter-broker protocol to alter ISR

2020-09-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson resolved KAFKA-8836. Fix Version/s: 2.7.0 Assignee: David Arthur (was: Jason Gustafson) Resoluti

[jira] [Assigned] (KAFKA-10521) Remove ZK watch for completing partition reassignment

2020-09-24 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson reassigned KAFKA-10521: --- Assignee: David Arthur > Remove ZK watch for completing partition reassignment > --

[GitHub] [kafka] asdaraujo commented on a change in pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-09-24 Thread GitBox
asdaraujo commented on a change in pull request #9281: URL: https://github.com/apache/kafka/pull/9281#discussion_r494670714 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -1686,9 +1686,9 @@ class KafkaConfig(val props: java.util.Map[_, _], doLog: Boolea

[GitHub] [kafka] asdaraujo commented on pull request #9281: KAFKA-10478: Allow duplicated ports in advertised.listeners

2020-09-24 Thread GitBox
asdaraujo commented on pull request #9281: URL: https://github.com/apache/kafka/pull/9281#issuecomment-698644188 > Please also update the documentation, I think it's worth to note that in case of `listeners` it's not allowed but for `advertised.listeners` it is for the LB use-case. > Ot

[jira] [Created] (KAFKA-10526) Explore performance impact of leader fsync deferral

2020-09-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10526: --- Summary: Explore performance impact of leader fsync deferral Key: KAFKA-10526 URL: https://issues.apache.org/jira/browse/KAFKA-10526 Project: Kafka Iss

[jira] [Created] (KAFKA-10527) Voters should always initialize as followers

2020-09-24 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-10527: --- Summary: Voters should always initialize as followers Key: KAFKA-10527 URL: https://issues.apache.org/jira/browse/KAFKA-10527 Project: Kafka Issue Type

[GitHub] [kafka] guozhangwang commented on pull request #9337: KAFKA-10519; Add missing unit test for `VotedState`

2020-09-24 Thread GitBox
guozhangwang commented on pull request #9337: URL: https://github.com/apache/kafka/pull/9337#issuecomment-698706077 LGTM. This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [kafka] guozhangwang commented on pull request #9196: [DO NOT MERGE] KAFKA-10402: Upgrade system tests to python3

2020-09-24 Thread GitBox
guozhangwang commented on pull request #9196: URL: https://github.com/apache/kafka/pull/9196#issuecomment-698710912 https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4188/ triggered This is an automated messa

[jira] [Updated] (KAFKA-10513) Newly added topic or partitions are not assigned to running consumer groups using static membership

2020-09-24 Thread Marlon Ou (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marlon Ou updated KAFKA-10513: -- Summary: Newly added topic or partitions are not assigned to running consumer groups using static memb

[GitHub] [kafka] guozhangwang commented on a change in pull request #9020: KAFKA-10271 Performance regression while fetching a key from a single partition

2020-09-24 Thread GitBox
guozhangwang commented on a change in pull request #9020: URL: https://github.com/apache/kafka/pull/9020#discussion_r494747319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamStreamJoinIntegrationTest.java ## @@ -60,6 +60,34 @@ public void prepar

[GitHub] [kafka] thake opened a new pull request #9338: Fixed KAFKA-10515: Serdes used within metered state stores will now be initialized with the default serdes if not already set.

2020-09-24 Thread GitBox
thake opened a new pull request #9338: URL: https://github.com/apache/kafka/pull/9338 Also introduced the notion of WrappingNullableSerdes (aligned to the concept of WrappingNullableSerializer and WrappingNullableDeserializer) and centralized initialization in WrappungNullables. The

[jira] [Commented] (KAFKA-8266) Improve `testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup`

2020-09-24 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201921#comment-17201921 ] Chia-Ping Tsai commented on KAFKA-8266: --- [~dajac] Could I take over this issue? I h

[jira] [Commented] (KAFKA-9220) TimeoutException when using kafka-preferred-replica-election

2020-09-24 Thread Ankit Kumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17201931#comment-17201931 ] Ankit Kumar commented on KAFKA-9220: Hey [~hores], Are you planning on working on it