[GitHub] [kafka] hachikuji commented on pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
hachikuji commented on pull request #9619: URL: https://github.com/apache/kafka/pull/9619#issuecomment-730001511 cc @chia7712 @dajac This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] rajinisivaram commented on pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-11-18 Thread GitBox
rajinisivaram commented on pull request #9473: URL: https://github.com/apache/kafka/pull/9473#issuecomment-730006469 @jolshan Thanks for the updates, merging to trunk. This is an automated message from the Apache Git Service.

[GitHub] [kafka] rajinisivaram merged pull request #9473: KAFKA-10545: Create topic IDs in ZooKeeper and Controller

2020-11-18 Thread GitBox
rajinisivaram merged pull request #9473: URL: https://github.com/apache/kafka/pull/9473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on a change in pull request #9487: KAFKA-9331: Add a streams specific uncaught exception handler

2020-11-18 Thread GitBox
ableegoldman commented on a change in pull request #9487: URL: https://github.com/apache/kafka/pull/9487#discussion_r526477258 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -932,56 +1028,62 @@ public synchronized boolean close(final long t

[jira] [Commented] (KAFKA-10734) Speedup the processing of LeaderAndIsr request

2020-11-18 Thread Lucas Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235061#comment-17235061 ] Lucas Wang commented on KAFKA-10734: Thanks for your reply [~junrao]. In some cluste

[jira] [Updated] (KAFKA-10500) Add API to Start and Stop Stream Threads

2020-11-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10500: Labels: kip (was: needs-kip) > Add API to Start and Stop Stream Threads > ---

[jira] [Updated] (KAFKA-10500) Add API to Start and Stop Stream Threads

2020-11-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10500: Description: Currently, there is no possibility in Kafka Streams to increase or decrease t

[GitHub] [kafka] mjsax merged pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-18 Thread GitBox
mjsax merged pull request #9572: URL: https://github.com/apache/kafka/pull/9572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on pull request #9572: KAFKA-10500: Thread Cache Resizes

2020-11-18 Thread GitBox
mjsax commented on pull request #9572: URL: https://github.com/apache/kafka/pull/9572#issuecomment-730028264 Thanks for the PR @wcarlson5. Merged to `trunk`. This is an automated message from the Apache Git Service. To respon

[jira] [Resolved] (KAFKA-10500) Add API to Start and Stop Stream Threads

2020-11-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-10500. - Fix Version/s: 2.8.0 Resolution: Fixed > Add API to Start and Stop Stream Threads

[jira] [Updated] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2020-11-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10015: Labels: kip (was: needs-kip) > React Smartly to Unexpected Errors on Stream Threads > ---

[jira] [Updated] (KAFKA-10015) React Smartly to Unexpected Errors on Stream Threads

2020-11-18 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10015: Description: Currently, if an unexpected error occurs on a stream thread, the stream threa

[jira] [Resolved] (KAFKA-6943) Have option to shutdown KS cleanly if any threads crashes, or if all threads crash

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-6943. --- Resolution: Fixed > Have option to shutdown KS cleanly if any threads crashes

[jira] [Updated] (KAFKA-6943) Have option to shutdown KS cleanly if any threads crashes, or if all threads crash

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-6943: -- Fix Version/s: 2.8.0 > Have option to shutdown KS cleanly if any threads crashe

[jira] [Commented] (KAFKA-6943) Have option to shutdown KS cleanly if any threads crashes, or if all threads crash

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235069#comment-17235069 ] A. Sophie Blee-Goldman commented on KAFKA-6943: --- Resolved via https://githu

[jira] [Updated] (KAFKA-4748) Need a way to shutdown all workers in a Streams application at the same time

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-4748: -- Fix Version/s: 2.8.0 > Need a way to shutdown all workers in a Streams applicat

[jira] [Reopened] (KAFKA-10500) Add API to Start and Stop Stream Threads

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-10500: > Add API to Start and Stop Stream Threads > -

[jira] [Resolved] (KAFKA-4748) Need a way to shutdown all workers in a Streams application at the same time

2020-11-18 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-4748. --- Resolution: Fixed > Need a way to shutdown all workers in a Streams applicati

[GitHub] [kafka] abbccdda commented on a change in pull request #9617: MINOR: Factor out common response parsing logic

2020-11-18 Thread GitBox
abbccdda commented on a change in pull request #9617: URL: https://github.com/apache/kafka/pull/9617#discussion_r526499505 ## File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java ## @@ -974,21 +969,6 @@ private void handleInitiateApiVersionRequests(long

[GitHub] [kafka] rajinisivaram commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-11-18 Thread GitBox
rajinisivaram commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r526479473 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java ## @@ -139,4 +150,129 @@ * @return Iterator for ACL bind

[jira] [Assigned] (KAFKA-9672) Dead brokers in ISR cause isr-expiration to fail with exception

2020-11-18 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-9672: - Assignee: Jose Armando Garcia Sancio > Dead brokers in ISR cause

[GitHub] [kafka] hachikuji commented on a change in pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

2020-11-18 Thread GitBox
hachikuji commented on a change in pull request #9547: URL: https://github.com/apache/kafka/pull/9547#discussion_r526509285 ## File path: clients/src/main/java/org/apache/kafka/common/requests/OffsetsForLeaderEpochRequest.java ## @@ -51,169 +47,120 @@ */ public stat

[GitHub] [kafka] hachikuji commented on pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

2020-11-18 Thread GitBox
hachikuji commented on pull request #9547: URL: https://github.com/apache/kafka/pull/9547#issuecomment-730040680 @dajac The updates LGTM. This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] mjsax merged pull request #9570: KAFKA-9274: Handle TimeoutException on commit

2020-11-18 Thread GitBox
mjsax merged pull request #9570: URL: https://github.com/apache/kafka/pull/9570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] anatasiavela commented on a change in pull request #9526: KAFKA-10525: Emit JSONs with new auto-generated schema

2020-11-18 Thread GitBox
anatasiavela commented on a change in pull request #9526: URL: https://github.com/apache/kafka/pull/9526#discussion_r526511067 ## File path: core/src/main/scala/kafka/network/RequestConvertToJson.scala ## @@ -0,0 +1,362 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] [kafka] abbccdda closed pull request #9042: (Back-up draft) redirection with version bump

2020-11-18 Thread GitBox
abbccdda closed pull request #9042: URL: https://github.com/apache/kafka/pull/9042 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526525212 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1476,33 +1650,36 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metri

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526527000 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1404,60 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526527000 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1404,60 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526527000 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1324,7 +1404,60 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metric

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526528689 ## File path: core/src/test/scala/unit/kafka/network/ConnectionQuotasTest.scala ## @@ -633,18 +837,27 @@ class ConnectionQuotasTest {

[jira] [Created] (KAFKA-10744) Listener and broker connection rate quota tests should use mock time

2020-11-18 Thread David Mao (Jira)
David Mao created KAFKA-10744: - Summary: Listener and broker connection rate quota tests should use mock time Key: KAFKA-10744 URL: https://issues.apache.org/jira/browse/KAFKA-10744 Project: Kafka

[GitHub] [kafka] splett2 commented on a change in pull request #9386: KAFKA-10024: Add dynamic configuration and enforce quota for per-IP connection rate limits (KIP-612, part 2)

2020-11-18 Thread GitBox
splett2 commented on a change in pull request #9386: URL: https://github.com/apache/kafka/pull/9386#discussion_r526525212 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1476,33 +1650,36 @@ class ConnectionQuotas(config: KafkaConfig, time: Time, metri

[GitHub] [kafka] chia7712 commented on pull request #9547: KAFKA-9630; Replace OffsetsForLeaderEpoch request/response with automated protocol

2020-11-18 Thread GitBox
chia7712 commented on pull request #9547: URL: https://github.com/apache/kafka/pull/9547#issuecomment-730094552 @dajac +1 to nice updating. sorry that my commit causes conflicting files to you. This is an automated message f

[GitHub] [kafka] chia7712 commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
chia7712 commented on a change in pull request #9619: URL: https://github.com/apache/kafka/pull/9619#discussion_r526567417 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -130,13 +139,25 @@ public void writeVarlong(long i) { */

[GitHub] [kafka] chia7712 merged pull request #9507: KAFKA-10628: remove all the unnecessary parameters from the tests which are using TopologyTestDriver

2020-11-18 Thread GitBox
chia7712 merged pull request #9507: URL: https://github.com/apache/kafka/pull/9507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] chia7712 commented on pull request #9507: KAFKA-10628: remove all the unnecessary parameters from the tests which are using TopologyTestDriver

2020-11-18 Thread GitBox
chia7712 commented on pull request #9507: URL: https://github.com/apache/kafka/pull/9507#issuecomment-730104149 @showuon Thanks for this patch! This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] ijuma commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-11-18 Thread GitBox
ijuma commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r526570690 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1749,6 +1752,9 @@ class Log(@volatile private var _dir: File, checkIfMemoryMappedBuffe

[GitHub] [kafka] ijuma commented on a change in pull request #9590: KAFKA-7556: KafkaConsumer.beginningOffsets does not return actual first offsets

2020-11-18 Thread GitBox
ijuma commented on a change in pull request #9590: URL: https://github.com/apache/kafka/pull/9590#discussion_r526571061 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1749,6 +1752,9 @@ class Log(@volatile private var _dir: File, checkIfMemoryMappedBuffe

[GitHub] [kafka] hachikuji commented on pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
hachikuji commented on pull request #9619: URL: https://github.com/apache/kafka/pull/9619#issuecomment-730107392 @chia7712 To be honest, I'm not sure. I think it makes sense in general to try and batch the writes together to reduce number of calls to the kernel in any case, but I am not su

[GitHub] [kafka] chia7712 commented on a change in pull request #9617: MINOR: Factor out common response parsing logic

2020-11-18 Thread GitBox
chia7712 commented on a change in pull request #9617: URL: https://github.com/apache/kafka/pull/9617#discussion_r526577116 ## File path: core/src/main/scala/kafka/server/ForwardingManager.scala ## @@ -17,25 +17,17 @@ package kafka.server -import kafka.metrics.KafkaMetricsG

[jira] [Created] (KAFKA-10745) Please let me know how I check the time which Source connector receive the data from source table.

2020-11-18 Thread NAYUSIK (Jira)
NAYUSIK created KAFKA-10745: --- Summary: Please let me know how I check the time which Source connector receive the data from source table. Key: KAFKA-10745 URL: https://issues.apache.org/jira/browse/KAFKA-10745

[GitHub] [kafka] hachikuji commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
hachikuji commented on a change in pull request #9619: URL: https://github.com/apache/kafka/pull/9619#discussion_r526583778 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -39,6 +42,7 @@ */ public class SendBuilder implements Writ

[GitHub] [kafka] hachikuji commented on a change in pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
hachikuji commented on a change in pull request #9619: URL: https://github.com/apache/kafka/pull/9619#discussion_r526584156 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -130,13 +139,25 @@ public void writeVarlong(long i) { *

[GitHub] [kafka] chia7712 commented on pull request #9619: MINOR: Reduce sends created by `SendBuilder`

2020-11-18 Thread GitBox
chia7712 commented on pull request #9619: URL: https://github.com/apache/kafka/pull/9619#issuecomment-730134289 +1 to last commit This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 opened a new pull request #9620: MINOR: Get rid of generic from FetchResponse

2020-11-18 Thread GitBox
chia7712 opened a new pull request #9620: URL: https://github.com/apache/kafka/pull/9620 Except for LazyDownConversionRecords, we don't use the generic. We should handle the specify case directly instead of making generic in whole project. In short, this patch is a kind of cleanup.

[GitHub] [kafka] chia7712 commented on a change in pull request #9435: KAFKA-10606: Disable auto topic creation for fetch-all-topic-metadata request

2020-11-18 Thread GitBox
chia7712 commented on a change in pull request #9435: URL: https://github.com/apache/kafka/pull/9435#discussion_r526616584 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -1333,7 +1343,17 @@ class KafkaApis(val requestChannel: RequestChannel, }

[GitHub] [kafka] chia7712 commented on pull request #9204: KAFKA-6181 Examining log messages with {{--deep-iteration}} should show superset of fields

2020-11-18 Thread GitBox
chia7712 commented on pull request #9204: URL: https://github.com/apache/kafka/pull/9204#issuecomment-730154806 rebase patch to trigger QA This is an automated message from the Apache Git Service. To respond to the message,

<    1   2