[jira] [Commented] (KAFKA-9926) Flaky test PlaintextAdminIntegrationTest.testCreatePartitions

2020-12-04 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243819#comment-17243819 ] GeordieMai commented on KAFKA-9926: --- Can I take this issue ? I want to try if this test

[jira] [Assigned] (KAFKA-9926) Flaky test PlaintextAdminIntegrationTest.testCreatePartitions

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-9926: - Assignee: GeordieMai > Flaky test PlaintextAdminIntegrationTest.testCreatePartitions > -

[jira] [Commented] (KAFKA-9926) Flaky test PlaintextAdminIntegrationTest.testCreatePartitions

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243822#comment-17243822 ] Chia-Ping Tsai commented on KAFKA-9926: --- [~Geordie] I have assigned this issue to y

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243850#comment-17243850 ] Chia-Ping Tsai commented on KAFKA-10790: {quote} if it means throwing an excepti

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243852#comment-17243852 ] Chia-Ping Tsai commented on KAFKA-10790: [~grussell] Could I take over this issu

[GitHub] [kafka] mjsax opened a new pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax opened a new pull request #9688: URL: https://github.com/apache/kafka/pull/9688 Call for review @abbccdda @ableegoldman @guozhangwang This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535948426 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -105,8 +100,8 @@ public boolean inject

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243870#comment-17243870 ] Tom Bentley commented on KAFKA-2967: To summarize this thread, Ewen originally propos

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535948890 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -152,27 +147,6 @@ private final Atomic

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535949319 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -319,24 +293,26 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535949960 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -440,15 +419,18 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535950501 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -457,33 +439,46 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535951079 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -457,33 +439,46 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535951595 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -774,15 +769,18 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535951938 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -792,24 +790,35 @@ public void shouldUpgrad

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535952481 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -916,11 +917,12 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535953082 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -1074,19 +1077,27 @@ private void addAllKey

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535953242 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -1132,7 +1143,7 @@ public ErrorInjector(fin

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r535954201 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -1161,7 +1161,7 @@ public static void verifyKe

[jira] [Updated] (KAFKA-10740) Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol

2020-12-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10740: Summary: Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol (was: Replic

[jira] [Updated] (KAFKA-10740) Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol

2020-12-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10740?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-10740: Description: Follow up of KAFKA-9630. We can avoid extra conversation by using the auto-generated

[GitHub] [kafka] dajac opened a new pull request #9689: KAFKA-10740; Replace OffsetsForLeaderEpochRequest.PartitionData with automated protocol

2020-12-04 Thread GitBox
dajac opened a new pull request #9689: URL: https://github.com/apache/kafka/pull/9689 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes

[GitHub] [kafka] mjsax opened a new pull request #9690: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax opened a new pull request #9690: URL: https://github.com/apache/kafka/pull/9690 PR for `2.6` branch. "Main" PR for `trunk` and `2.7` is #9688 The difference is, that in `2.6` and eos-alpha, we commit tasks individually, while in `2.7` and eos-alpha, if one tasks needs a commit

[GitHub] [kafka] tombentley commented on a change in pull request #9676: KAFKA-10778: Fence appends after write failure

2020-12-04 Thread GitBox
tombentley commented on a change in pull request #9676: URL: https://github.com/apache/kafka/pull/9676#discussion_r535972740 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -1219,6 +1219,9 @@ class Log(@volatile private var _dir: File, appendInfo.logA

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread Ben Stopford (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17243911#comment-17243911 ] Ben Stopford commented on KAFKA-2967: - I think this is really important because the v

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MirrorMaker 2 internal topics naming convention

2020-12-04 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Description: MM2 internal topic names (heartbeats, checkpoints and offset-syncs) are hardcode

[jira] [Updated] (KAFKA-10777) Add additional configuration to control MirrorMaker 2 internal topics naming convention

2020-12-04 Thread Omnia Ibrahim (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Omnia Ibrahim updated KAFKA-10777: -- Description: MM2 internal topic names (heartbeats, checkpoints and offset-syncs) are hardcode

[GitHub] [kafka] chia7712 opened a new pull request #9691: HOTFIX: fix failed build caused by StreamThreadTest

2020-12-04 Thread GitBox
chia7712 opened a new pull request #9691: URL: https://github.com/apache/kafka/pull/9691 related to https://github.com/apache/kafka/commit/4cc6d204ec5cb21841a2f8f21e6333bb688cd892 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [

[GitHub] [kafka] chia7712 commented on pull request #9691: HOTFIX: fix failed build caused by StreamThreadTest

2020-12-04 Thread GitBox
chia7712 commented on pull request #9691: URL: https://github.com/apache/kafka/pull/9691#issuecomment-738711066 @mjsax Could you take a look? This is an automated message from the Apache Git Service. To respond to the message

[jira] [Created] (KAFKA-10808) Improve LogCleaner logs

2020-12-04 Thread Omnia Ibrahim (Jira)
Omnia Ibrahim created KAFKA-10808: - Summary: Improve LogCleaner logs Key: KAFKA-10808 URL: https://issues.apache.org/jira/browse/KAFKA-10808 Project: Kafka Issue Type: Improvement C

[GitHub] [kafka] dengziming commented on pull request #9574: MINOR: KIP-497 Not start Controller2ChannelManager when we are using zookeeper to notify isr change

2020-12-04 Thread GitBox
dengziming commented on pull request #9574: URL: https://github.com/apache/kafka/pull/9574#issuecomment-738772018 The #9677 add an `ApiVersion.isAlterIsrSupported` method, so just use this method. @mumrah ,Hi, will this optimization take effect? PTAL. -

[GitHub] [kafka] dengziming commented on pull request #9626: KAFKA-10545: Create topic IDs and propagate to brokers

2020-12-04 Thread GitBox
dengziming commented on pull request #9626: URL: https://github.com/apache/kafka/pull/9626#issuecomment-738773845 KAFKA-10729 add `KAFKA_2_8_IV0`, so you should bump the version again. This is an automated message from the Ap

[jira] [Created] (KAFKA-10809) Make all system tests run on Travis CI stably

2020-12-04 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-10809: -- Summary: Make all system tests run on Travis CI stably Key: KAFKA-10809 URL: https://issues.apache.org/jira/browse/KAFKA-10809 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-10805) More useful reporting from travis system tests

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10805: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Improvement) > More useful reporting

[jira] [Updated] (KAFKA-10804) Tune travis system tests to avoid timeouts

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10804: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > Tune travis system tests to a

[jira] [Updated] (KAFKA-10809) Make all system tests run on Travis CI stably

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10809: --- Description: It can encourage us to write more system tests if Travis CI can run a subset of

[jira] [Updated] (KAFKA-10289) fix failed connect_distributed_test.py (ConnectDistributedTest.test_bounce)

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10289: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix failed connect_distribute

[jira] [Commented] (KAFKA-10292) fix flaky streams/streams_broker_bounce_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244003#comment-17244003 ] Chia-Ping Tsai commented on KAFKA-10292: [~cadonna] The PR is merged so could th

[jira] [Updated] (KAFKA-10292) fix flaky streams/streams_broker_bounce_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10292: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix flaky streams/streams_bro

[jira] [Updated] (KAFKA-10288) fix flaky client/client_compatibility_features_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10288: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix flaky client/client_compa

[jira] [Updated] (KAFKA-10290) fix flaky core/compatibility_test_new_broker_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10290: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix flaky core/compatibility_

[jira] [Updated] (KAFKA-10291) fix flaky tools/log4j_appender_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10291: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix flaky tools/log4j_appende

[jira] [Updated] (KAFKA-10308) fix flaky core/round_trip_fault_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10308: --- Parent: KAFKA-10809 Issue Type: Sub-task (was: Bug) > fix flaky core/round_trip_fau

[jira] [Resolved] (KAFKA-10308) fix flaky core/round_trip_fault_test.py

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10308?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10308. Fix Version/s: 2.7.0 Resolution: Fixed > fix flaky core/round_trip_fault_test.py >

[jira] [Commented] (KAFKA-2834) kafka-merge-pr.py should run unit tests before pushing it to trunk

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244010#comment-17244010 ] Chia-Ping Tsai commented on KAFKA-2834: --- [~guozhang] Is kafka-merge-pr.py still use

[GitHub] [kafka] chia7712 merged pull request #9680: MINOR: a small refactor for LogManage#shutdown

2020-12-04 Thread GitBox
chia7712 merged pull request #9680: URL: https://github.com/apache/kafka/pull/9680 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] bbejeck commented on pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-04 Thread GitBox
bbejeck commented on pull request #9674: URL: https://github.com/apache/kafka/pull/9674#issuecomment-738799496 Failure on Java 11 unrelated This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Updated] (KAFKA-10809) Make all system tests stably run on either Travis CI or local

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-10809: --- Summary: Make all system tests stably run on either Travis CI or local (was: Make all syste

[GitHub] [kafka] bbejeck merged pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-04 Thread GitBox
bbejeck merged pull request #9674: URL: https://github.com/apache/kafka/pull/9674 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] bbejeck commented on pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-04 Thread GitBox
bbejeck commented on pull request #9674: URL: https://github.com/apache/kafka/pull/9674#issuecomment-738801798 merged #9674 into trunk This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] bbejeck commented on pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-04 Thread GitBox
bbejeck commented on pull request #9674: URL: https://github.com/apache/kafka/pull/9674#issuecomment-738801930 Thanks for the fix @showuon! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] bbejeck commented on pull request #9674: KAFKA-10665: close all kafkaStreams before purgeLocalStreamsState

2020-12-04 Thread GitBox
bbejeck commented on pull request #9674: URL: https://github.com/apache/kafka/pull/9674#issuecomment-738810006 cherry-picked to 2.7 This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] ijuma commented on pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on pull request #7409: URL: https://github.com/apache/kafka/pull/7409#issuecomment-738811943 Looks like the failures are unrelated, so this is ready for review @chia7712. The PR description needs a few tweaks, I will do that tomorrow. --

[GitHub] [kafka] chia7712 commented on pull request #9686: KAFKA-10804 add more subsets and exclude performance tests

2020-12-04 Thread GitBox
chia7712 commented on pull request #9686: URL: https://github.com/apache/kafka/pull/9686#issuecomment-738813070 @hachikuji It seems the free plan of Travis CI can't support Kafka system tests totally. Not sure whether we can get more free resources from Travis CI? If not, maybe we should r

[GitHub] [kafka] ijuma commented on pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on pull request #7409: URL: https://github.com/apache/kafka/pull/7409#issuecomment-738821732 Actually, I went ahead and updated the PR description. This is an automated message from the Apache Git Service. To

[jira] [Resolved] (KAFKA-10799) AlterIsr path does not update ISR shrink/expand meters

2020-12-04 Thread Bill Bejeck (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bill Bejeck resolved KAFKA-10799. - Resolution: Fixed > AlterIsr path does not update ISR shrink/expand meters > ---

[GitHub] [kafka] dajac commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
dajac commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536134783 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] chia7712 commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
chia7712 commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536149423 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[GitHub] [kafka] bertber opened a new pull request #9692: Update StreamsResetter.java

2020-12-04 Thread GitBox
bertber opened a new pull request #9692: URL: https://github.com/apache/kafka/pull/9692 Add a request that it will call resetToDatetime of description to resetByDuration of function. *More detailed description of your change, if necessary. The PR title and PR message become the

[GitHub] [kafka] bertber commented on pull request #9692: Update StreamsResetter.java

2020-12-04 Thread GitBox
bertber commented on pull request #9692: URL: https://github.com/apache/kafka/pull/9692#issuecomment-738861519 Hello! I have updated StreamsResetter of class. I add a request that it will call resetToDatetime of description to resetByDuration of function. --

[GitHub] [kafka] chia7712 merged pull request #9687: MINOR: Move lock method outside try block

2020-12-04 Thread GitBox
chia7712 merged pull request #9687: URL: https://github.com/apache/kafka/pull/9687 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536201266 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return ver

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536201521 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return ver

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536202421 ## File path: clients/src/main/java/org/apache/kafka/common/protocol/SendBuilder.java ## @@ -209,16 +210,13 @@ public static Send buildResponseSend( p

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536203019 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ApiVersionsRequest.java ## @@ -96,8 +92,8 @@ public boolean isValid() { } @O

[GitHub] [kafka] chia7712 commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
chia7712 commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536206138 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536206699 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestUtils.java ## @@ -90,4 +75,37 @@ public static boolean hasTransactionalRecords(Pr

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536208309 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestUtils.java ## @@ -90,4 +75,37 @@ public static boolean hasTransactionalRecords(Pr

[jira] [Commented] (KAFKA-10772) java.lang.IllegalStateException: There are insufficient bytes available to read assignment from the sync-group response (actual byte size 0)

2020-12-04 Thread Bradley Peterson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244087#comment-17244087 ] Bradley Peterson commented on KAFKA-10772: -- Hi Sophie, just fyi we're seeing th

[GitHub] [kafka] chia7712 commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
chia7712 commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536210797 ## File path: clients/src/main/java/org/apache/kafka/common/requests/RequestUtils.java ## @@ -90,4 +75,37 @@ public static boolean hasTransactionalRecords

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536211422 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return ver

[GitHub] [kafka] ijuma commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
ijuma commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536212437 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return ver

[GitHub] [kafka] chia7712 commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
chia7712 commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536215626 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn commented on KAFKA-2967: -- [~tombentley], this is a good point – I thin

[GitHub] [kafka] chia7712 commented on a change in pull request #7409: MINOR: Skip conversion to `Struct` when serializing generated requests/responses

2020-12-04 Thread GitBox
chia7712 commented on a change in pull request #7409: URL: https://github.com/apache/kafka/pull/7409#discussion_r536223340 ## File path: clients/src/main/java/org/apache/kafka/common/requests/AbstractRequest.java ## @@ -95,21 +93,33 @@ public short version() { return

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:30 PM: ---

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:30 PM: ---

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:31 PM: ---

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:31 PM: ---

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:32 PM: ---

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244101#comment-17244101 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 4:33 PM: ---

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread Gary Russell (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244110#comment-17244110 ] Gary Russell commented on KAFKA-10790: -- [~chia7712] I am just the reporter; I am no

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536238405 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -778,6 +793,10 @@ object ConfigCommand extends Config { val brokerLogger = pars

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244111#comment-17244111 ] Chia-Ping Tsai commented on KAFKA-10790: [~grussell] oh, I assume that you may w

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536240414 ## File path: core/src/main/scala/kafka/server/AdminManager.scala ## @@ -920,32 +954,51 @@ class AdminManager(val config: KafkaConfig, !name.isDefi

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends BaseRequest

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244118#comment-17244118 ] Tom Bentley commented on KAFKA-2967: [~JimGalasyn] so it looks like we could do usefu

[jira] [Assigned] (KAFKA-10161) Update Documentation

2020-12-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10161: --- Assignee: David Jacot > Update Documentation > > > Key

[GitHub] [kafka] bertber closed pull request #9692: MINOR: add a description for calling resetToDatetime's function to resetByDuration

2020-12-04 Thread GitBox
bertber closed pull request #9692: URL: https://github.com/apache/kafka/pull/9692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536250843 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] mjsax commented on a change in pull request #9668: MINOR: add test for repartition/source-topic/changelog optimization

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9668: URL: https://github.com/apache/kafka/pull/9668#discussion_r536256494 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -463,7 +463,36 @@ public void shouldReuseSourceTopicAsChangelogsW

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536257595 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness wit

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244159#comment-17244159 ] James Galasyn commented on KAFKA-2967: -- [~tombentley] I'm not sure that could genera

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244159#comment-17244159 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 5:37 PM: ---

[GitHub] [kafka] rhauch merged pull request #9669: KAFKA-10792: Prevent source task shutdown from blocking herder thread

2020-12-04 Thread GitBox
rhauch merged pull request #9669: URL: https://github.com/apache/kafka/pull/9669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2020-12-04 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-738925531 You're right @guozhangwang, `ScheduledFutureTask` contains a sequence number to break ties, so the executor _is_ FIFO. So you're saying that the wrong network thread handling o

[GitHub] [kafka] guozhangwang commented on pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-04 Thread GitBox
guozhangwang commented on pull request #9667: URL: https://github.com/apache/kafka/pull/9667#issuecomment-738931337 > Maybe add an explanation here for why to skip the member.id required exception? (as it's transient) Ack, will do. --

[GitHub] [kafka] guozhangwang commented on a change in pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-04 Thread GitBox
guozhangwang commented on a change in pull request #9667: URL: https://github.com/apache/kafka/pull/9667#discussion_r536282550 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -465,7 +465,11 @@ boolean joinGroupIfNe

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244180#comment-17244180 ] John Roesler commented on KAFKA-2967: - I just took a look at [~tombentley]'s proposal

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r536285505 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -845,67 +856,118 @@ private KafkaStreams(final InternalTopologyBuilder i

  1   2   >