[GitHub] [kafka] vamossagar12 opened a new pull request #9737: KAFKA-10828: Replacing endorsing with acknowledging for voters

2020-12-12 Thread GitBox
vamossagar12 opened a new pull request #9737: URL: https://github.com/apache/kafka/pull/9737 This PR replaces the terms endorsing with acknowledging for voters which have recognised the current leader. This is an automated m

[jira] [Commented] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-12 Thread Govinda (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248320#comment-17248320 ] Govinda commented on KAFKA-10841: - As it's a newbie Jira and I have never contributed to

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541212190 ## File path: jmh-benchmarks/src/main/java/org/apache/kafka/jmh/acl/AclAuthorizerBenchmark.java ## @@ -105,49 +120,76 @@ private void setFieldValue(Object

[GitHub] [kafka] mdespriee opened a new pull request #9738: [KAFKA-8744] update scala API to give names to processors

2020-12-12 Thread GitBox
mdespriee opened a new pull request #9738: URL: https://github.com/apache/kafka/pull/9738 * As it's only API extension to match the java API with Named object with lots of duplication, I only tested the logic once. ### Committer Checklist (excluded from commit message) - [ ] V

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r539782093 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -304,6 +308,105 @@ class AclAuthorizer extends Authorizer with Loggin

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r539787542 ## File path: core/src/main/scala/kafka/security/authorizer/AclAuthorizer.scala ## @@ -304,6 +308,105 @@ class AclAuthorizer extends Authorizer with Loggin

[jira] [Commented] (KAFKA-8744) Add Support to Scala API for KIP-307 and KIP-479

2020-12-12 Thread Mathieu DESPRIEE (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248458#comment-17248458 ] Mathieu DESPRIEE commented on KAFKA-8744: - can't find the "submit patch" button,

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r541779975 ## File path: core/src/test/scala/unit/kafka/security/authorizer/AclAuthorizerTest.scala ## @@ -1040,19 +1117,24 @@ class AclAuthorizerTest extends ZooKee

[GitHub] [kafka] d8tltanc edited a comment on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc edited a comment on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-740501882 ![image](https://user-images.githubusercontent.com/31675100/101454358-b62cfd00-38e5-11eb-9eee-200604895b16.png) Chart description (from left to right) 1. The performa

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-12 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-743884225 @rajinisivaram Thanks for another round of detailed review. I've 1. Add the corner case checks in AclAuthorizer when there's no deny ACL binding in AclAuthorizer. 2.

[jira] [Commented] (KAFKA-10841) LogReadResult should be able to converted to FetchPartitionData

2020-12-12 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17248495#comment-17248495 ] GeordieMai commented on KAFKA-10841: Hello , I'm a newbie too . So please let me

[GitHub] [kafka] feyman2016 opened a new pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2020-12-12 Thread GitBox
feyman2016 opened a new pull request #9739: URL: https://github.com/apache/kafka/pull/9739 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade note

[GitHub] [kafka] feyman2016 commented on a change in pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2020-12-12 Thread GitBox
feyman2016 commented on a change in pull request #9739: URL: https://github.com/apache/kafka/pull/9739#discussion_r541864843 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -68,7 +68,7 @@ class KafkaMetadataLog( val appendInfo = log.appendAsLead

[GitHub] [kafka] feyman2016 commented on a change in pull request #9739: KAFKA-10636 Bypass log validation for writes to raft log

2020-12-12 Thread GitBox
feyman2016 commented on a change in pull request #9739: URL: https://github.com/apache/kafka/pull/9739#discussion_r541865977 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1477,6 +1477,7 @@ private void appendBatch( ) { try {