ijuma merged pull request #9977:
URL: https://github.com/apache/kafka/pull/9977
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
ijuma commented on pull request #9977:
URL: https://github.com/apache/kafka/pull/9977#issuecomment-768290763
All JUnit tests passed.
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272942#comment-17272942
]
ASF GitHub Bot commented on KAFKA-8930:
---
omkreddy commented on pull request #324:
URL:
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565448514
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/CreateTopicsResult.java
##
@@ -68,6 +69,19 @@ protected CreateTopicsResult(Map> fu
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565448192
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel,
val
chia7712 commented on a change in pull request #9964:
URL: https://github.com/apache/kafka/pull/9964#discussion_r565287398
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/SubscriptionInfo.java
##
@@ -265,14 +265,7 @@ public
bbejeck commented on a change in pull request #9738:
URL: https://github.com/apache/kafka/pull/9738#discussion_r565371239
##
File path:
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KTableTest.scala
##
@@ -391,4 +390,57 @@ class KTableTest
tang7526 edited a comment on pull request #9939:
URL: https://github.com/apache/kafka/pull/9939#issuecomment-768321328
> @tang7526 How about using import for this issue? Other references in
Javadocs use import also.
Done
mdespriee commented on pull request #9738:
URL: https://github.com/apache/kafka/pull/9738#issuecomment-768282420
@bbejeck of course. Just rebased on trunk and added a couple of tests.
This is an automated message from the
[
https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272901#comment-17272901
]
feyman edited comment on KAFKA-9689 at 1/27/21, 2:57 PM:
-
The version detection
tombentley commented on pull request #9847:
URL: https://github.com/apache/kafka/pull/9847#issuecomment-768284951
@chia7712 any chance of a 2nd review here?
This is an automated message from the Apache Git Service.
To
dengziming opened a new pull request #9982:
URL: https://github.com/apache/kafka/pull/9982
*More detailed description of your change*
From `ArrayList newCollection = new ArrayList< Integer
>(arrayLength)` to `ArrayList newCollection = new ArrayList< Integer
>(arrayLength)`
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272938#comment-17272938
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck merged pull request #324:
URL:
chia7712 commented on pull request #9981:
URL: https://github.com/apache/kafka/pull/9981#issuecomment-768294345
failed tests pass on my local. will trigger QA again
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272901#comment-17272901
]
feyman commented on KAFKA-9689:
---
The version detection flow leveraging the versioning system is as
chia7712 commented on pull request #9939:
URL: https://github.com/apache/kafka/pull/9939#issuecomment-768277706
@tang7526 How about using import for this issue? Other references in
Javadocs use import also.
This is an
tang7526 commented on pull request #9939:
URL: https://github.com/apache/kafka/pull/9939#issuecomment-768321328
> @tang7526 How about using import for this issue? Other references in
Javadocs use import also.
I tried that before and it didn't work.
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272977#comment-17272977
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck commented on pull request #324:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273055#comment-17273055
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck commented on pull request #326:
URL:
wcarlson5 commented on a change in pull request #9969:
URL: https://github.com/apache/kafka/pull/9969#discussion_r565518232
##
File path: docs/streams/upgrade-guide.html
##
@@ -91,6 +91,29 @@ Streams API
We extended StreamJoined to include the options
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565517686
##
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##
@@ -511,6 +513,9 @@ public void testSerialization()
[
https://issues.apache.org/jira/browse/KAFKA-6223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273066#comment-17273066
]
ASF GitHub Bot commented on KAFKA-6223:
---
mimaison merged pull request #322:
URL:
wcarlson5 opened a new pull request #9984:
URL: https://github.com/apache/kafka/pull/9984
add timeout and static group rebalance to remove thread
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
miguno opened a new pull request #9983:
URL: https://github.com/apache/kafka/pull/9983
This adds a new user-facing documentation "Geo-replication (Cross-Cluster
Data Mirroring)" section to the Kafka Operations documentation that covers
MirrorMaker v2.
Was already merged to
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272987#comment-17272987
]
ASF GitHub Bot commented on KAFKA-8930:
---
miguno commented on pull request #324:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273030#comment-17273030
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck opened a new pull request #326:
URL:
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565591713
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel,
val
vvcephei commented on pull request #9836:
URL: https://github.com/apache/kafka/pull/9836#issuecomment-768546193
Most of those failures were known flaky tests, but one was an EasyMock
error. I'm not able to repro it locally after a rebase, though. Rebased,
pushed, and trying one more time
bbejeck commented on pull request #9983:
URL: https://github.com/apache/kafka/pull/9983#issuecomment-768429896
cherry-picked to 2.7 and 2.6
This is an automated message from the Apache Git Service.
To respond to the message,
vvcephei commented on a change in pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#discussion_r565519066
##
File path: streams/src/main/java/org/apache/kafka/streams/kstream/Branched.java
##
@@ -0,0 +1,149 @@
+/*
+ * Licensed to the Apache Software Foundation
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273059#comment-17273059
]
ASF GitHub Bot commented on KAFKA-8930:
---
miguno commented on pull request #326:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273073#comment-17273073
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck commented on pull request #326:
URL:
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565591713
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1930,29 +1932,43 @@ class KafkaApis(val requestChannel: RequestChannel,
val
bbejeck commented on pull request #9983:
URL: https://github.com/apache/kafka/pull/9983#issuecomment-768420998
merged #9983 into trunk
This is an automated message from the Apache Git Service.
To respond to the message,
bbejeck merged pull request #9983:
URL: https://github.com/apache/kafka/pull/9983
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565525057
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -3365,6 +3366,44 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r565575532
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel,
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael G. Noll reassigned KAFKA-8930:
--
Assignee: Michael G. Noll (was: Ryanne Dolan)
> MM2 documentation
>
hachikuji commented on a change in pull request #9979:
URL: https://github.com/apache/kafka/pull/9979#discussion_r565519812
##
File path:
clients/src/main/resources/common/message/DescribeProducersResponse.json
##
@@ -0,0 +1,46 @@
+// Licensed to the Apache Software
vvcephei commented on a change in pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#discussion_r565519912
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/BranchedKStream.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
junrao commented on a change in pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#discussion_r565473406
##
File path: Jenkinsfile
##
@@ -160,5 +160,23 @@ pipeline {
}
}
}
+stage("Arm Build") {
+ agent { label 'arm4' }
+
mdespriee commented on a change in pull request #9738:
URL: https://github.com/apache/kafka/pull/9738#discussion_r565497044
##
File path:
streams/streams-scala/src/test/scala/org/apache/kafka/streams/scala/kstream/KTableTest.scala
##
@@ -391,4 +390,57 @@ class KTableTest
mjsax commented on a change in pull request #9969:
URL: https://github.com/apache/kafka/pull/9969#discussion_r565515280
##
File path: docs/streams/upgrade-guide.html
##
@@ -91,6 +91,29 @@ Streams API
We extended StreamJoined to include the options
mjsax commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-768478775
@inponomarev the failing tests seems to be due to a known issue that was
fixed via https://github.com/apache/kafka/pull/9768
Can you rebase your PR to pickup the fix so we
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273075#comment-17273075
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck merged pull request #326:
URL:
[
https://issues.apache.org/jira/browse/KAFKA-8930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273074#comment-17273074
]
ASF GitHub Bot commented on KAFKA-8930:
---
bbejeck edited a comment on pull request #326:
URL:
jolshan commented on a change in pull request #9769:
URL: https://github.com/apache/kafka/pull/9769#discussion_r565575532
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1223,7 +1251,7 @@ class KafkaApis(val requestChannel: RequestChannel,
aloknnikhil commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565673883
##
File path: core/src/main/scala/kafka/raft/KafkaNetworkChannel.scala
##
@@ -34,6 +34,7 @@ import scala.collection.mutable
object
aloknnikhil commented on a change in pull request #9985:
URL: https://github.com/apache/kafka/pull/9985#discussion_r565673491
##
File path: raft/src/main/java/org/apache/kafka/raft/RaftConfig.java
##
@@ -36,7 +36,9 @@
public static final String QUORUM_VOTERS_CONFIG =
junrao commented on a change in pull request #9901:
URL: https://github.com/apache/kafka/pull/9901#discussion_r564872645
##
File path:
metadata/src/main/java/org/apache/kafka/timeline/timeline/SnapshottableHashTable.java
##
@@ -0,0 +1,410 @@
+/*
+ * Licensed to the Apache
ableegoldman commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565720574
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread
satishd commented on a change in pull request #9980:
URL: https://github.com/apache/kafka/pull/9980#discussion_r565730154
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -63,7 +63,7 @@ private[log] object ProducerStateEntry {
private[log] val
ableegoldman commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565731661
##
File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java
##
@@ -319,9 +319,9 @@ private void prepareStreamThread(final
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565746851
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -782,8 +783,27 @@ private KafkaStreams(final
skaundinya15 commented on a change in pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#discussion_r565772802
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -89,11 +89,25 @@ public MirrorMakerConfig(Map
gardnervickers commented on a change in pull request #9980:
URL: https://github.com/apache/kafka/pull/9980#discussion_r565781027
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -63,7 +63,7 @@ private[log] object ProducerStateEntry {
private[log]
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565784940
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565784940
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread
chia7712 commented on a change in pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#discussion_r565786393
##
File path: core/src/main/scala/kafka/server/Server.scala
##
@@ -46,6 +46,22 @@ object Server {
new Metrics(metricConfig, reporters, time, true,
ableegoldman commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565797234
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread
[
https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17272901#comment-17272901
]
feyman edited comment on KAFKA-9689 at 1/28/21, 3:54 AM:
-
The version detection
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565803134
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -54,14 +61,27 @@
private static final
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565805758
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -416,11 +524,15 @@ private void
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565806577
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -112,6 +118,19 @@ public void
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565823251
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread
dengziming commented on pull request #9982:
URL: https://github.com/apache/kafka/pull/9982#issuecomment-768802003
@chia7712 @cmccabe Hello, PTAL.
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565826783
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args)
[
https://issues.apache.org/jira/browse/KAFKA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-10658:
---
Affects Version/s: 2.6.0
> ErrantRecordReporter.report always return
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273244#comment-17273244
]
Chia-Ping Tsai commented on KAFKA-12220:
[~ijuma] How about splitting PR by package?
wcarlson5 commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565815347
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1208,24 +1227,28 @@ private Thread shutdownHelper(final boolean
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565834861
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##
@@ -1004,10 +998,6 @@ public void testWithRecords(Args
chia7712 merged pull request #9981:
URL: https://github.com/apache/kafka/pull/9981
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565783921
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1843,6 +1843,8 @@ class KafkaApis(val requestChannel: RequestChannel,
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-768769254
> @inponomarev the failing tests seems to be due to a known issue that was
fixed via #9768
>
> Can you rebase your PR to pickup the fix so we can get a green build?
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565802766
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1208,24 +1227,28 @@ private Thread shutdownHelper(final boolean
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565802847
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void
vvcephei commented on pull request #9840:
URL: https://github.com/apache/kafka/pull/9840#issuecomment-768782409
Hmm, the Java 8 build appears to have hung after an hour and 58 minutes.
It's been running for 3 hours and 30 minutes now. This is now the 16th build,
and there have been
vvcephei merged pull request #9840:
URL: https://github.com/apache/kafka/pull/9840
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
abbccdda commented on a change in pull request #9579:
URL: https://github.com/apache/kafka/pull/9579#discussion_r561594743
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1370,55 +1345,164 @@ class KafkaApis(val requestChannel: RequestChannel,
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
chia7712 commented on pull request #9981:
URL: https://github.com/apache/kafka/pull/9981#issuecomment-768681359
build pass
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mjsax commented on pull request #9708:
URL: https://github.com/apache/kafka/pull/9708#issuecomment-768685944
Thanks @lct45!
For reference: https://github.com/apache/kafka/pull/9951
This is an automated message from
[
https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273249#comment-17273249
]
Matthias J. Sax commented on KAFKA-6520:
i am wondering if
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565785613
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-768769711
For another, ```testWriteControlBatchNotAllowedMagicV0``` and
```testWriteControlBatchNotAllowedMagicV1``` are almost same. Could we merge
them into single test case?
[
https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck reassigned KAFKA-3745:
--
Assignee: Bill Bejeck
> Consider adding join key to ValueJoiner interface
>
mjsax commented on pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#issuecomment-768709672
@dongjinleekr -- the PR shows merge conflicts. Can you rebase once more.
Sorry about that.
This is an automated
[
https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-3745:
--
Assignee: (was: Bill Bejeck)
> Consider adding join key to ValueJoiner interface
hachikuji commented on pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#issuecomment-768742967
@chia7712 @ijuma Thanks for the comments thus far. This is ready for another
look when you have time.
This is
hachikuji commented on pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#issuecomment-768756102
@twobeeb Before I merge, would you mind updating the PR description? Also, I
will leave it to you to add the doc suggestion from @skaundinya15.
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565802173
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -927,6 +912,39 @@ private StreamThread
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565801932
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -782,8 +782,27 @@ private KafkaStreams(final
ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-768786220
Not done with the tests, but I'd appreciate some feedback on the non-testing
code and general idea -- any takers for review? @cadonna @vvcephei
@guozhangwang @wcarlson5
vvcephei commented on pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#issuecomment-768789634
Hey @dongjinleekr ,
Sorry for the force-push, but I had to rebase this and resolve a conflict
before merging. Note that the conflict was from
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565820783
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
[
https://issues.apache.org/jira/browse/KAFKA-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273328#comment-17273328
]
Boyang Chen commented on KAFKA-12169:
-
In general, the leader should be able to detect metadata
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565607533
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -610,17 +610,32 @@ public void
cadonna commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565615976
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -1147,6 +1162,10 @@ public String toString(final
1 - 100 of 153 matches
Mail list logo
