ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565746851
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -782,8 +783,27 @@ private KafkaStreams(final InternalTopologyBuild
chia7712 commented on pull request #9981:
URL: https://github.com/apache/kafka/pull/9981#issuecomment-768681359
build pass
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 merged pull request #9981:
URL: https://github.com/apache/kafka/pull/9981
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
mjsax commented on pull request #9708:
URL: https://github.com/apache/kafka/pull/9708#issuecomment-768685944
Thanks @lct45!
For reference: https://github.com/apache/kafka/pull/9951
This is an automated message from th
[
https://issues.apache.org/jira/browse/KAFKA-12220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273244#comment-17273244
]
Chia-Ping Tsai commented on KAFKA-12220:
[~ijuma] How about splitting PR by pack
[
https://issues.apache.org/jira/browse/KAFKA-6520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273249#comment-17273249
]
Matthias J. Sax commented on KAFKA-6520:
i am wondering if https://issues.apache.
mjsax commented on pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#issuecomment-768709672
@dongjinleekr -- the PR shows merge conflicts. Can you rebase once more.
Sorry about that.
This is an automated mes
[
https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-3745:
--
Assignee: (was: Bill Bejeck)
> Consider adding join key to ValueJoiner interface
>
hachikuji commented on pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#issuecomment-768742967
@chia7712 @ijuma Thanks for the comments thus far. This is ready for another
look when you have time.
This is a
skaundinya15 commented on a change in pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#discussion_r565772802
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -89,11 +89,25 @@ public MirrorMakerConfig(Map
gardnervickers commented on a change in pull request #9980:
URL: https://github.com/apache/kafka/pull/9980#discussion_r565781027
##
File path: core/src/main/scala/kafka/log/ProducerStateManager.scala
##
@@ -63,7 +63,7 @@ private[log] object ProducerStateEntry {
private[log]
hachikuji commented on pull request #9589:
URL: https://github.com/apache/kafka/pull/9589#issuecomment-768756102
@twobeeb Before I merge, would you mind updating the PR description? Also, I
will leave it to you to add the doc suggestion from @skaundinya15.
---
jolshan commented on a change in pull request #9684:
URL: https://github.com/apache/kafka/pull/9684#discussion_r565783921
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1843,6 +1843,8 @@ class KafkaApis(val requestChannel: RequestChannel,
.
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565784940
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread createAndAddStreamThread(fin
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565784940
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread createAndAddStreamThread(fin
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565785613
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void shouldRemov
chia7712 commented on a change in pull request #9967:
URL: https://github.com/apache/kafka/pull/9967#discussion_r565786393
##
File path: core/src/main/scala/kafka/server/Server.scala
##
@@ -46,6 +46,22 @@ object Server {
new Metrics(metricConfig, reporters, time, true, met
inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-768769254
> @inponomarev the failing tests seems to be due to a known issue that was
fixed via #9768
>
> Can you rebase your PR to pickup the fix so we can get a green build?
chia7712 commented on pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#issuecomment-768769711
For another, ```testWriteControlBatchNotAllowedMagicV0``` and
```testWriteControlBatchNotAllowedMagicV1``` are almost same. Could we merge
them into single test case?
-
ableegoldman commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565797234
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread createAndAddStreamThread(
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565801932
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -782,8 +782,27 @@ private KafkaStreams(final InternalTopologyBuild
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565802173
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -927,6 +912,39 @@ private StreamThread createAndAddStreamThread(fi
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565802766
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1208,24 +1227,28 @@ private Thread shutdownHelper(final boolean e
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565802847
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void shouldRemov
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565803134
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -54,14 +61,27 @@
private static final
[
https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17272901#comment-17272901
]
feyman edited comment on KAFKA-9689 at 1/28/21, 3:54 AM:
-
The ver
vvcephei commented on pull request #9840:
URL: https://github.com/apache/kafka/pull/9840#issuecomment-768782409
Hmm, the Java 8 build appears to have hung after an hour and 58 minutes.
It's been running for 3 hours and 30 minutes now. This is now the 16th build,
and there have been multipl
vvcephei merged pull request #9840:
URL: https://github.com/apache/kafka/pull/9840
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565805758
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java
##
@@ -416,11 +524,15 @@ private void cleanRemove
ableegoldman commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565806577
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java
##
@@ -112,6 +118,19 @@ public void create
ableegoldman commented on pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#issuecomment-768786220
Not done with the tests, but I'd appreciate some feedback on the non-testing
code and general idea -- any takers for review? @cadonna @vvcephei
@guozhangwang @wcarlson5 @lct4
[
https://issues.apache.org/jira/browse/KAFKA-3745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bill Bejeck reassigned KAFKA-3745:
--
Assignee: Bill Bejeck
> Consider adding join key to ValueJoiner interface
> --
vvcephei commented on pull request #9420:
URL: https://github.com/apache/kafka/pull/9420#issuecomment-768789634
Hey @dongjinleekr ,
Sorry for the force-push, but I had to rebase this and resolve a conflict
before merging. Note that the conflict was from
462c89e0b436abd56864bea8bbcaf
abbccdda commented on a change in pull request #9579:
URL: https://github.com/apache/kafka/pull/9579#discussion_r561594743
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -1370,55 +1345,164 @@ class KafkaApis(val requestChannel: RequestChannel,
!au
wcarlson5 commented on a change in pull request #9978:
URL: https://github.com/apache/kafka/pull/9978#discussion_r565815347
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1208,24 +1227,28 @@ private Thread shutdownHelper(final boolean erro
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565820783
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java
##
@@ -180,6 +182,19 @@ public void shouldRemov
dengziming commented on pull request #9982:
URL: https://github.com/apache/kafka/pull/9982#issuecomment-768802003
@chia7712 @cmccabe Hello, PTAL.
This is an automated message from the Apache Git Service.
To respond to the me
wcarlson5 commented on a change in pull request #9984:
URL: https://github.com/apache/kafka/pull/9984#discussion_r565823251
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -997,19 +1002,63 @@ private StreamThread createAndAddStreamThread(fin
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
chia7712 commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565826783
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args)
jsancio commented on a change in pull request #9816:
URL: https://github.com/apache/kafka/pull/9816#discussion_r565825661
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -66,32 +78,67 @@ class KafkaMetadataLog(
if (records.sizeInBytes == 0)
[
https://issues.apache.org/jira/browse/KAFKA-12169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273328#comment-17273328
]
Boyang Chen commented on KAFKA-12169:
-
In general, the leader should be able to dete
[
https://issues.apache.org/jira/browse/KAFKA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konstantine Karantasis updated KAFKA-10658:
---
Affects Version/s: 2.6.0
> ErrantRecordReporter.report always return complet
g1geordie commented on a change in pull request #9906:
URL: https://github.com/apache/kafka/pull/9906#discussion_r565834861
##
File path:
clients/src/test/java/org/apache/kafka/common/record/MemoryRecordsTest.java
##
@@ -1004,10 +998,6 @@ public void testWithRecords(Args args)
chia7712 merged pull request #9525:
URL: https://github.com/apache/kafka/pull/9525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
chia7712 commented on pull request #9525:
URL: https://github.com/apache/kafka/pull/9525#issuecomment-768828561
merge to trunk, 2.7 and 2.6
This is an automated message from the Apache Git Service.
To respond to the message,
[
https://issues.apache.org/jira/browse/KAFKA-10658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-10658.
Fix Version/s: 2.6.2
2.7.1
2.8.0
Resolution: F
showuon commented on pull request #9791:
URL: https://github.com/apache/kafka/pull/9791#issuecomment-768830962
@kkonstantine , Thanks for the comments. So you mean this issue can be kept
as is? Or we should find another way to implement it instead of bookkeeping way?
-
xiao-penglei commented on a change in pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#discussion_r565854978
##
File path: Jenkinsfile
##
@@ -160,5 +160,23 @@ pipeline {
}
}
}
+stage("Arm Build") {
+ agent { label 'arm4' }
+
xiao-penglei commented on a change in pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#discussion_r565854978
##
File path: Jenkinsfile
##
@@ -160,5 +160,23 @@ pipeline {
}
}
}
+stage("Arm Build") {
+ agent { label 'arm4' }
+
[
https://issues.apache.org/jira/browse/KAFKA-9689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17273379#comment-17273379
]
Boyang Chen commented on KAFKA-9689:
I agree with A) since it is internal struct.
>
xiao-penglei commented on pull request #9872:
URL: https://github.com/apache/kafka/pull/9872#issuecomment-768859211
> @xiao-penglei : Thanks for the PR. Did the "Arm Build" get triggered in
jenkins? I can't seem to find it.
@junrao When you create a Jenkins pipline, there are two con
101 - 153 of 153 matches
Mail list logo
