[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang reassigned KAFKA-12747:
-
Fix Version/s: 3.0.0
Assignee: Guozhang Wang
Resolution: Fixed
> Flaky
guozhangwang commented on pull request #10643:
URL: https://github.com/apache/kafka/pull/10643#issuecomment-837205952
Will cherry-pick to old branches as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
ableegoldman commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r629637264
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@
[
https://issues.apache.org/jira/browse/KAFKA-12728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dejan Stojadinović updated KAFKA-12728:
---
Summary: Version upgrades: gradle (6.8.3 -->> 7.0.1) and gradle shadow
plugin
wcarlson5 commented on a change in pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#discussion_r629609542
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -900,6 +902,14 @@ private long pollPhase() {
Dejan Stojadinović created KAFKA-12770:
--
Summary: Jenkins build: allow the CheckStyle version to be
specified via parameter
Key: KAFKA-12770
URL: https://issues.apache.org/jira/browse/KAFKA-12770
g1geordie opened a new pull request #10663:
URL: https://github.com/apache/kafka/pull/10663
Rewrite org.apache.kafka.test.Microbenchmarks by JMH
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mdedetrich edited a comment on pull request #10648:
URL: https://github.com/apache/kafka/pull/10648#issuecomment-837469565
KIP has been created at
https://cwiki.apache.org/confluence/display/KAFKA/KIP-737%3A+Add+canTrackSource+to+ReplicationPolicy
and a new thread has been started in the
ijuma commented on pull request #10606:
URL: https://github.com/apache/kafka/pull/10606#issuecomment-837551412
Looks like there is a change in behavior in Gradle 7 related to resource
files that's causing a bunch of tests to fail
--
This is an automated message from the Apache Git
Vincent created KAFKA-12768:
---
Summary: Mirrormaker2 consumer config not using newly assigned
client id
Key: KAFKA-12768
URL: https://issues.apache.org/jira/browse/KAFKA-12768
Project: Kafka
Issue
Josep Prat created KAFKA-12769:
--
Summary: Backport of KAFKA-8562
Key: KAFKA-12769
URL: https://issues.apache.org/jira/browse/KAFKA-12769
Project: Kafka
Issue Type: Task
Components:
[
https://issues.apache.org/jira/browse/KAFKA-12769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342144#comment-17342144
]
Josep Prat commented on KAFKA-12769:
I'll work on this
> Backport of KAFKA-8562
>
ijuma commented on a change in pull request #10620:
URL: https://github.com/apache/kafka/pull/10620#discussion_r629703346
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java
##
@@ -710,8 +710,11 @@ private boolean
dejan2609 commented on pull request #10656:
URL: https://github.com/apache/kafka/pull/10656#issuecomment-837469070
@romani, @ijuma
> Do you want to contribute the change to allow the checkstyle version to be
specified via a parameter?
Sure, I created this JIRA ticket for my
ableegoldman merged pull request #10657:
URL: https://github.com/apache/kafka/pull/10657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342123#comment-17342123
]
A. Sophie Blee-Goldman commented on KAFKA-12766:
Personally I agree that throwing an
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman updated KAFKA-12766:
---
Fix Version/s: 3.0.0
> Consider Disabling WAL-related Options in RocksDB
>
[
https://issues.apache.org/jira/browse/KAFKA-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent updated KAFKA-12768:
Description:
Component: MirrorMaker2 from the 2.6.0 distribution.
We tried to set quotas based client.id
g1geordie commented on pull request #10663:
URL: https://github.com/apache/kafka/pull/10663#issuecomment-837173030
@chia7712 can you help me take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
guozhangwang merged pull request #10643:
URL: https://github.com/apache/kafka/pull/10643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
[
https://issues.apache.org/jira/browse/KAFKA-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342120#comment-17342120
]
A. Sophie Blee-Goldman commented on KAFKA-12749:
Thanks [~vishranganathan], assigned the
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-12747:
--
Fix Version/s: 2.8.1
> Flaky Test RocksDBStoreTest.shouldReturnUUIDsWithStringPrefix
>
[
https://issues.apache.org/jira/browse/KAFKA-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent updated KAFKA-12768:
Attachment: (was: instance2_log)
> Mirrormaker2 consumer config not using newly assigned client id
>
[
https://issues.apache.org/jira/browse/KAFKA-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent updated KAFKA-12768:
Attachment: (was: instance1_log)
> Mirrormaker2 consumer config not using newly assigned client id
>
[
https://issues.apache.org/jira/browse/KAFKA-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent updated KAFKA-12768:
Attachment: (was: mirrormaker.log)
> Mirrormaker2 consumer config not using newly assigned client id
[
https://issues.apache.org/jira/browse/KAFKA-12768?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vincent updated KAFKA-12768:
Attachment: (was: mirroramker2.properties)
> Mirrormaker2 consumer config not using newly assigned
[
https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dejan Stojadinović updated KAFKA-12771:
---
Description:
^*Prologue*:
Dejan Stojadinović created KAFKA-12771:
--
Summary: CheckStyle attempted upgrade (8.36.2 -->> 8.41.1) summons
a pack of 'Indentation' errors
Key: KAFKA-12771
URL:
mdedetrich commented on pull request #10648:
URL: https://github.com/apache/kafka/pull/10648#issuecomment-837469565
KIP has been created at
https://cwiki.apache.org/confluence/display/KAFKA/KIP-737%3A+Add+canTrackSource+to+ReplicationPolicy
and a new thread has been started in the
ableegoldman commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-837549700
Merged to trunk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wcarlson5 commented on pull request #10634:
URL: https://github.com/apache/kafka/pull/10634#issuecomment-837165677
@ableegoldman Thanks for the review! I think I got to your comments. There
was one miss understanding about how the `TaskMetadata` is updated but let me
know if you still
[
https://issues.apache.org/jira/browse/KAFKA-12749?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
A. Sophie Blee-Goldman reassigned KAFKA-12749:
--
Assignee: Viswanathan Ranganathan
> Changelog topic config on
ijuma commented on pull request #10306:
URL: https://github.com/apache/kafka/pull/10306#issuecomment-837508654
@cmccabe We should update the KIP and share a note in the mailing list
thread. Also, was this released with `127` as the default or did we change it
before the first release? If
[
https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342261#comment-17342261
]
Luke Chen commented on KAFKA-9009:
--
investigating
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-9009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-9009:
Assignee: Luke Chen
> Flaky Test
>
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342272#comment-17342272
]
Satish Duggana commented on KAFKA-12757:
[~junrao] I am not aware of cases like common classes
ableegoldman commented on a change in pull request #6592:
URL: https://github.com/apache/kafka/pull/6592#discussion_r629768563
##
File path:
clients/src/main/java/org/apache/kafka/common/serialization/Serdes.java
##
@@ -265,4 +287,14 @@ public UUIDSerde() {
static public
ableegoldman commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-837607688
cc any of @cadonna @vvcephei @lct45 @wcarlson5 @mjsax @guozhangwang to
review this
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342293#comment-17342293
]
Matthias J. Sax commented on KAFKA-12718:
-
[~gonzur] it seems [~byusti] lost interest to work on
ijuma commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r629848073
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -525,6 +525,11 @@ private TransactionManager
vitojeng commented on pull request #10657:
URL: https://github.com/apache/kafka/pull/10657#issuecomment-837571301
@ableegoldman Thanks. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/KAFKA-12771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342288#comment-17342288
]
Dongjin Lee commented on KAFKA-12771:
-
Hi [~dejan2609], This issue is addressed in KAFKA-12572.
[
https://issues.apache.org/jira/browse/KAFKA-12760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax resolved KAFKA-12760.
-
Resolution: Invalid
[~byusti] – we cannot delete your account either.
You could try to
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r629845576
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/MockProducer.java
##
@@ -179,10 +179,18 @@ public void beginTransaction() throws
ableegoldman opened a new pull request #10666:
URL: https://github.com/apache/kafka/pull/10666
Currently `KafkaStreams#cleanUp` only throw an IllegalStateException if the
state is RUNNING or REBALANCING, however the application could be in the
process of shutting down in which case
ableegoldman commented on pull request #10637:
URL: https://github.com/apache/kafka/pull/10637#issuecomment-837691327
Is it possible to set up the gitignore to automatically ignore anything
under a `generated/` subdirectory?
--
This is an automated message from the Apache Git Service.
showuon opened a new pull request #10665:
URL: https://github.com/apache/kafka/pull/10665
We used to set a low `replica.lag.time.max.ms` value (2 sec) to speed up the
test, but the 2 sec is not long enough in slow Jenkins env, and caused the
follower got kicked out from ISR, so the
mjsax commented on a change in pull request #10573:
URL: https://github.com/apache/kafka/pull/10573#discussion_r629845081
##
File path:
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java
##
@@ -525,6 +525,11 @@ private TransactionManager
vichu opened a new pull request #10664:
URL: https://github.com/apache/kafka/pull/10664
Refactored `logConfig` to be passed appropriately when using
`shutDownWhenFull` or `emitEarlyWhenFull`. Removed the constructor that doesn't
accept a `logConfig` parameter so you're forced to specify
showuon commented on pull request #10665:
URL: https://github.com/apache/kafka/pull/10665#issuecomment-837734046
@edoardocomar @mimaison , could you help review this PR to make the test
reliable. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the
vichu commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-837597679
@ableegoldman Would appreciate it if you can take a look at this PR when you
get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/KAFKA-12718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax reassigned KAFKA-12718:
---
Assignee: Juan C. Gonzalez-Zurita
> SessionWindows are closed too early
>
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342302#comment-17342302
]
Frank Yi commented on KAFKA-12635:
--
fix works for me! Thanks
> Mirrormaker 2 offset sync is incorrect
[
https://issues.apache.org/jira/browse/KAFKA-12635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342308#comment-17342308
]
Ning Zhang commented on KAFKA-12635:
great, thanks for the feedback. I will proceed to finalize the
jlprat commented on pull request #10651:
URL: https://github.com/apache/kafka/pull/10651#issuecomment-836338082
For the record:
The contribution is my original work and that I license the work to the
project under the project's open source license.
--
This is an automated message
kowshik removed a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-836253885
@junrao This PR is ready for another round of review. I've rebased the PR
onto latest AK trunk, iterated on the implementation bit more and added new
unit tests for
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-836253885
@junrao This PR is ready for another round of review. I've rebased the PR
onto latest AK trunk, iterated on the implementation bit more and added new
unit tests for `LocalLog`
cadonna commented on a change in pull request #10568:
URL: https://github.com/apache/kafka/pull/10568#discussion_r629163797
##
File path:
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java
##
@@
[
https://issues.apache.org/jira/browse/KAFKA-8897?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-8897.
--
Resolution: Fixed
> Increase Version of RocksDB
> ---
>
>
chia7712 opened a new pull request #10659:
URL: https://github.com/apache/kafka/pull/10659
related to #10630
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify
kowshik commented on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-836254631
@junrao This PR is ready for another round of review. I've rebased the PR
onto latest AK trunk, iterated on the implementation bit more and added new
unit tests for `LocalLog`
kowshik edited a comment on pull request #10280:
URL: https://github.com/apache/kafka/pull/10280#issuecomment-836254631
@junrao This PR is ready for another round of review. I've rebased the PR
onto latest AK trunk, iterated on the implementation bit more and added new
unit tests for
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341782#comment-17341782
]
Bruno Cadonna commented on KAFKA-12766:
---
I think throwing an exception is too harsh. Additionally,
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629079021
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -307,32 +306,35 @@ private boolean
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629100529
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +403,125 @@ private boolean
showuon commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629100529
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +403,125 @@ private boolean
[
https://issues.apache.org/jira/browse/KAFKA-12766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-12766:
--
Issue Type: Improvement (was: Test)
> Consider Disabling WAL-related Options in RocksDB
>
Bruno Cadonna created KAFKA-12766:
-
Summary: Consider Disabling WAL-related Options in RocksDB
Key: KAFKA-12766
URL: https://issues.apache.org/jira/browse/KAFKA-12766
Project: Kafka
Issue
jlprat commented on pull request #10643:
URL: https://github.com/apache/kafka/pull/10643#issuecomment-836631952
You can also take a look at
https://github.com/apache/kafka/pull/10662/files#diff-944ff4a8c4eab2003ab210f5a2fceac1d124e71fcfe383b736add11803a4fd4cR468
(in there I was checking
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341872#comment-17341872
]
Josep Prat commented on KAFKA-12747:
There was already another PR
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat reassigned KAFKA-12747:
--
Assignee: (was: Josep Prat)
> Flaky Test
showuon commented on pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#issuecomment-836655715
I'll have some refine to this PR. Please wait for a while . Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jlprat commented on pull request #10662:
URL: https://github.com/apache/kafka/pull/10662#issuecomment-836630173
Now I see another PR was already there:
https://github.com/apache/kafka/pull/10643
--
This is an automated message from the Apache Git Service.
To respond to the message,
jlprat closed pull request #10662:
URL: https://github.com/apache/kafka/pull/10662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
jlprat commented on a change in pull request #10643:
URL: https://github.com/apache/kafka/pull/10643#discussion_r629341305
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java
##
@@ -451,17 +453,14 @@ public void
tombentley merged pull request #10659:
URL: https://github.com/apache/kafka/pull/10659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
mimaison opened a new pull request #10660:
URL: https://github.com/apache/kafka/pull/10660
We need to wait for the artifact to show up in Maven before merging
Also I don't have permissions to push the artifacts to our S3 bucket. Can
someone do it for me? Thanks
### Committer
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Summary: Move server related common and public classes into separate
modules. (was: Move
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Summary: Move server related common and public classes into separate
module(s). (was: Move
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Josep Prat reassigned KAFKA-12747:
--
Assignee: Josep Prat
> Flaky Test RocksDBStoreTest.shouldReturnUUIDsWithStringPrefix
>
[
https://issues.apache.org/jira/browse/KAFKA-12747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341834#comment-17341834
]
Josep Prat commented on KAFKA-12747:
I'd like to try to solve this one.
> Flaky Test
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Description:
There are two sets of classes that we want to pull out here for server
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17341829#comment-17341829
]
Satish Duggana commented on KAFKA-12757:
cc [~junrao] [~ijuma]
> Move server related common and
chia7712 opened a new pull request #10661:
URL: https://github.com/apache/kafka/pull/10661
The following error happens on my mac m1 when building docker image for
system tests.
```
Collecting pynacl
Using cached PyNaCl-1.4.0.tar.gz (3.4 MB)
Installing build dependencies
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Description:
There are two sets of classes that we want to pull out here for server
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Description:
There are two sets of classes that we want to pull out here for server
jlprat opened a new pull request #10662:
URL: https://github.com/apache/kafka/pull/10662
…ingPrefix
Fixes the test by checking if there is a prefix collision.
Following comment on [JIRA
satishd commented on a change in pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#discussion_r629269557
##
File path: build.gradle
##
@@ -1345,6 +1349,62 @@ project(':raft') {
}
}
+project(':server-common') {
+ archivesBaseName =
satishd edited a comment on pull request #10638:
URL: https://github.com/apache/kafka/pull/10638#issuecomment-834307680
Thanks @junrao for the review comments. Pl see inline replies and the latest
commits.
--
This is an automated message from the Apache Git Service.
To respond to the
chia7712 commented on a change in pull request #10660:
URL: https://github.com/apache/kafka/pull/10660#discussion_r629292359
##
File path: tests/docker/Dockerfile
##
@@ -61,7 +61,7 @@ RUN mkdir -p "/opt/kafka-2.3.1" && chmod a+rw
/opt/kafka-2.3.1 && curl -s "$KAFK
RUN mkdir
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Description:
There are two sets of classes that we want to pull out here for server
mimaison commented on a change in pull request #10660:
URL: https://github.com/apache/kafka/pull/10660#discussion_r629427422
##
File path: tests/docker/Dockerfile
##
@@ -61,7 +61,7 @@ RUN mkdir -p "/opt/kafka-2.3.1" && chmod a+rw
/opt/kafka-2.3.1 && curl -s "$KAFK
RUN mkdir
dejan2609 commented on a change in pull request #10658:
URL: https://github.com/apache/kafka/pull/10658#discussion_r629430530
##
File path: checkstyle/checkstyle.xml
##
@@ -91,7 +91,7 @@
-
+
Review comment:
Roger that @romani.
Ok,
[
https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-12757:
---
Description:
There are two sets of classes that we want to pull out here for server
C0urante commented on pull request #10659:
URL: https://github.com/apache/kafka/pull/10659#issuecomment-836857466
Blegh, sorry guys. Thanks for catching this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dejan2609 commented on pull request #10658:
URL: https://github.com/apache/kafka/pull/10658#issuecomment-836815768
Rebased onto trunk and force-pushed (as explained in a conversation above).
--
This is an automated message from the Apache Git Service.
To respond to the message, please
dejan2609 edited a comment on pull request #10658:
URL: https://github.com/apache/kafka/pull/10658#issuecomment-836815768
Rebased onto trunk and force-pushed (as explained in a conversation/review
above).
--
This is an automated message from the Apache Git Service.
To respond to the
guozhangwang commented on pull request #10662:
URL: https://github.com/apache/kafka/pull/10662#issuecomment-836978921
Hey @jlprat sorry I was not aware you're also working on this ticket..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
guozhangwang commented on a change in pull request #10552:
URL: https://github.com/apache/kafka/pull/10552#discussion_r629529360
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java
##
@@ -387,58 +403,125 @@ private
mumrah commented on a change in pull request #10431:
URL: https://github.com/apache/kafka/pull/10431#discussion_r629529239
##
File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala
##
@@ -242,85 +246,116 @@ final class KafkaMetadataLog private (
}
override
1 - 100 of 119 matches
Mail list logo