[GitHub] [kafka] jlprat commented on pull request #10662: KAFKA-12747: Fix flaky test RocksDBStoreTest.shouldReturnUUIDsWithStr…

jlprat commented on pull request #10662: URL: https://github.com/apache/kafka/pull/10662#issuecomment-836981716 The other way around, I haven't seen your PR, you were first  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] guozhangwang commented on a change in pull request #10643: KAFKA-12747: Fix flakiness in shouldReturnUUIDsWithStringPrefix

guozhangwang commented on a change in pull request #10643: URL: https://github.com/apache/kafka/pull/10643#discussion_r629530576 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/RocksDBStoreTest.java ## @@ -451,17 +453,14 @@ public void

[GitHub] [kafka] mumrah commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

mumrah commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r629531449 ## File path: raft/src/main/java/org/apache/kafka/snapshot/FileRawSnapshotReader.java ## @@ -54,8 +54,12 @@ public Records records() { }

[jira] [Commented] (KAFKA-12757) Move server related common and public classes into separate module(s).

[ https://issues.apache.org/jira/browse/KAFKA-12757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342023#comment-17342023 ] Jun Rao commented on KAFKA-12757: - [~satish.duggana]: The implementation of server side APIs may depend

[GitHub] [kafka] guozhangwang commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

guozhangwang commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r629538083 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@

[GitHub] [kafka] cadonna commented on a change in pull request #10568: KAFKA-8897: Upgrade RocksDB to 6.19.3

cadonna commented on a change in pull request #10568: URL: https://github.com/apache/kafka/pull/10568#discussion_r629541422 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBGenericOptionsToDbOptionsColumnFamilyOptionsAdapter.java ## @@

[GitHub] [kafka] lbradstreet commented on a change in pull request #10620: KAFKA-12736: KafkaProducer.flush holds onto completed ProducerBatch(s) until flush completes

lbradstreet commented on a change in pull request #10620: URL: https://github.com/apache/kafka/pull/10620#discussion_r629543903 ## File path: clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java ## @@ -710,8 +710,11 @@ private boolean

[GitHub] [kafka] mumrah commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

mumrah commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r629541231 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -161,19 +162,24 @@ final class KafkaMetadataLog private ( override def

[GitHub] [kafka] mumrah commented on a change in pull request #10431: KAFKA-12543: Change RawSnapshotReader ownership model

mumrah commented on a change in pull request #10431: URL: https://github.com/apache/kafka/pull/10431#discussion_r629541231 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -161,19 +162,24 @@ final class KafkaMetadataLog private ( override def

[jira] [Created] (KAFKA-12767) Properly set Streams system test runtime classpath

John Roesler created KAFKA-12767: Summary: Properly set Streams system test runtime classpath Key: KAFKA-12767 URL: https://issues.apache.org/jira/browse/KAFKA-12767 Project: Kafka Issue

[GitHub] [kafka] vvcephei commented on pull request #10631: MINOR: Stop using hamcrest in system tests

vvcephei commented on pull request #10631: URL: https://github.com/apache/kafka/pull/10631#issuecomment-836964248 Thanks for this fix, @lct45 and @cadonna ! It's great to get these tests running again. FYI, I went ahead and filed https://issues.apache.org/jira/browse/KAFKA-12767

[jira] [Commented] (KAFKA-12767) Properly set Streams system test runtime classpath

[ https://issues.apache.org/jira/browse/KAFKA-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342014#comment-17342014 ] John Roesler commented on KAFKA-12767: -- Marked "affects version" to 3.0.0, since this problem was

[jira] [Updated] (KAFKA-12767) Properly set Streams system test runtime classpath

[ https://issues.apache.org/jira/browse/KAFKA-12767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12767: - Affects Version/s: 3.0.0 > Properly set Streams system test runtime classpath >

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r629592700 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r629595406 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/TaskMetadataIntegrationTest.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to the

[jira] [Assigned] (KAFKA-12708) Rewrite org.apache.kafka.test.Microbenchmarks by JMH

[ https://issues.apache.org/jira/browse/KAFKA-12708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] GeordieMai reassigned KAFKA-12708: -- Assignee: GeordieMai > Rewrite org.apache.kafka.test.Microbenchmarks by JMH >

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r629599232 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -1193,6 +1196,11 @@ public void

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r629603915 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -302,6 +302,11 @@ public void

[GitHub] [kafka] wcarlson5 commented on a change in pull request #10634: KAFKA-12754: Improve endOffsets for TaskMetadata

wcarlson5 commented on a change in pull request #10634: URL: https://github.com/apache/kafka/pull/10634#discussion_r629604506 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -1162,6 +1162,15 @@ private void

<    1   2