[GitHub] [kafka] dajac commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-04-07 Thread GitBox
dajac commented on PR #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1091191284 We have found the root cause of the original issue. It was a bug in our benchmark setup so it had nothing to do with this change in the end. We can still keep this change as it looks better

[jira] [Commented] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-07 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518660#comment-17518660 ] RivenSun commented on KAFKA-13793: -- Kafka itself supports five sasl mechanisms, GSSAPI

[GitHub] [kafka] dajac merged pull request #11998: KAFKA-13801: Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-07 Thread GitBox
dajac merged PR #11998: URL: https://github.com/apache/kafka/pull/11998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Resolved] (KAFKA-13801) Kafka server does not respect MetricsReporter interface contract for dynamically configured reporters

2022-04-07 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13801?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot resolved KAFKA-13801. - Fix Version/s: 3.3.0 Reviewer: David Jacot Assignee: Xavier Léauté Resol

[GitHub] [kafka] showuon commented on pull request #11971: KAFKA-13783; Remove reason prefixing in JoinGroupRequest and LeaveGroupRequest

2022-04-07 Thread GitBox
showuon commented on PR #11971: URL: https://github.com/apache/kafka/pull/11971#issuecomment-1091344371 > We have found the root cause of the original issue. It was a bug in our benchmark setup so it had nothing to do with this change in the end. We can still keep this change as it looks be

[GitHub] [kafka] ddrid commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-07 Thread GitBox
ddrid commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r844881404 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] bozhao12 closed pull request #12007: MINOR: Fix method annotation

2022-04-07 Thread GitBox
bozhao12 closed pull request #12007: MINOR: Fix method annotation URL: https://github.com/apache/kafka/pull/12007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[GitHub] [kafka] bozhao12 opened a new pull request, #12009: MINOR: fix typo and method annotation

2022-04-07 Thread GitBox
bozhao12 opened a new pull request, #12009: URL: https://github.com/apache/kafka/pull/12009 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgr

[GitHub] [kafka] bozhao12 commented on pull request #12009: MINOR: Fix method annotation

2022-04-07 Thread GitBox
bozhao12 commented on PR #12009: URL: https://github.com/apache/kafka/pull/12009#issuecomment-1091395431 @showuon Sorry, I deleted the remote branch by mistake, I submitted a new Pull Request. Thanks -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] RivenSun2 opened a new pull request, #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-07 Thread GitBox
RivenSun2 opened a new pull request, #12010: URL: https://github.com/apache/kafka/pull/12010 Add validators for configs that lack validators -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-07 Thread GitBox
RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1091397361 Hi @showuon could you help to review the PR? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] bozhao12 closed pull request #12009: MINOR: Fix method annotation

2022-04-07 Thread GitBox
bozhao12 closed pull request #12009: MINOR: Fix method annotation URL: https://github.com/apache/kafka/pull/12009 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe

[jira] [Commented] (KAFKA-13793) Add validators for serialization and deserialization related configuration

2022-04-07 Thread RivenSun (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518732#comment-17518732 ] RivenSun commented on KAFKA-13793: -- Hi [~showuon] , please help review PR-12010. Thanks

[GitHub] [kafka] showuon commented on pull request #12007: MINOR: Fix method annotation

2022-04-07 Thread GitBox
showuon commented on PR #12007: URL: https://github.com/apache/kafka/pull/12007#issuecomment-1091493302 Failed tests are unrelated: ``` Build / ARM / kafka.network.ConnectionQuotasTest.testListenerConnectionRateLimitWhenActualRateAboveLimit() ``` -- This is an automated message f

[GitHub] [kafka] showuon merged pull request #12007: MINOR: Fix method javadoc and typo in comments

2022-04-07 Thread GitBox
showuon merged PR #12007: URL: https://github.com/apache/kafka/pull/12007 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] EvansJahja opened a new pull request, #12011: MINOR: add print.topic property in console consumer

2022-04-07 Thread GitBox
EvansJahja opened a new pull request, #12011: URL: https://github.com/apache/kafka/pull/12011 ``` Usage: ./kafka-console-consumer.sh --bootstrap-server kafka:9092 --include '.*' --property print.topic=true Example output: Topic:hello.world{"msg": "abc"} ``` Pur

[jira] [Created] (KAFKA-13804) Log broker shutdown reason at the end of log output

2022-04-07 Thread Luke Chen (Jira)
Luke Chen created KAFKA-13804: - Summary: Log broker shutdown reason at the end of log output Key: KAFKA-13804 URL: https://issues.apache.org/jira/browse/KAFKA-13804 Project: Kafka Issue Type: Imp

[jira] [Updated] (KAFKA-13804) Log broker shutdown reason at the end of log output

2022-04-07 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13804?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13804: -- Description: Currently, when the broker hit exception, or SIGINT signal received, we will first log t

[GitHub] [kafka] EvansJahja closed pull request #12011: MINOR: add print.topic property in console consumer

2022-04-07 Thread GitBox
EvansJahja closed pull request #12011: MINOR: add print.topic property in console consumer URL: https://github.com/apache/kafka/pull/12011 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [kafka] EvansJahja opened a new pull request, #12012: MINOR: add print.topic property in console consumer

2022-04-07 Thread GitBox
EvansJahja opened a new pull request, #12012: URL: https://github.com/apache/kafka/pull/12012 ``` Usage: ./kafka-console-consumer.sh --bootstrap-server kafka:9092 --include '.*' --property print.topic=true Example output: Topic:hello.world{"msg": "abc"} ``` Pur

[jira] [Commented] (KAFKA-13762) Kafka brokers are not coming up

2022-04-07 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518845#comment-17518845 ] Jordan Moore commented on KAFKA-13762: -- [~kkameshm90] Please lower the priority as

[jira] [Commented] (KAFKA-13571) Enabling MirrorMaker 2.0 with TLS

2022-04-07 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518846#comment-17518846 ] Jordan Moore commented on KAFKA-13571: -- It should work just fine. Please check the

[jira] [Comment Edited] (KAFKA-13571) Enabling MirrorMaker 2.0 with TLS

2022-04-07 Thread Jordan Moore (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17518846#comment-17518846 ] Jordan Moore edited comment on KAFKA-13571 at 4/7/22 12:21 PM: ---

[GitHub] [kafka] ddrid commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-07 Thread GitBox
ddrid commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r844881404 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[jira] [Created] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Shivakumar (Jira)
Shivakumar created KAFKA-13805: -- Summary: Upgrade vulnerable dependencies march 2022 Key: KAFKA-13805 URL: https://issues.apache.org/jira/browse/KAFKA-13805 Project: Kafka Issue Type: Bug Af

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Shivakumar (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shivakumar updated KAFKA-13805: --- Description: |Packages|Package Version|CVSS|Fix Status| |com.fasterxml.jackson.core_jackson-databind

[jira] [Updated] (KAFKA-6204) Interceptor and MetricsReporter should implement java.io.Closeable

2022-04-07 Thread Jira
[ https://issues.apache.org/jira/browse/KAFKA-6204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Xavier Léauté updated KAFKA-6204: - Fix Version/s: 3.3.0 (was: 3.2.0) > Interceptor and MetricsReporter should

[jira] [Updated] (KAFKA-8575) Investigate removing EAGER protocol & cleaning up task suspension in Streams rebalancing

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-8575: - Fix Version/s: (was: 3.2.0) > Investigate removing EAGER protocol & cleaning up task suspens

[jira] [Updated] (KAFKA-8575) Investigate removing EAGER protocol & cleaning up task suspension in Streams rebalancing

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-8575: - Priority: Critical (was: Blocker) > Investigate removing EAGER protocol & cleaning up task susp

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Fix Version/s: (was: 3.0.1) (was: 3.2.0) (was

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Affects Version/s: 3.0.1 3.1.1 > Upgrade vulnerable dependencies march

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Priority: Blocker (was: Major) > Upgrade vulnerable dependencies march 2022 > ---

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Fix Version/s: 3.1.2 2.8.2 3.0.2 > Upgrade vulnerable de

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519059#comment-17519059 ] Bruno Cadonna commented on KAFKA-13805: --- [~shivakumar] Are you referring to the fo

[jira] [Comment Edited] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519059#comment-17519059 ] Bruno Cadonna edited comment on KAFKA-13805 at 4/7/22 5:45 PM: ---

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Affects Version/s: (was: 3.1.1) > Upgrade vulnerable dependencies march 2022 > ---

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Fix Version/s: (was: 3.1.2) > Upgrade vulnerable dependencies march 2022 > ---

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519073#comment-17519073 ] Kirk True commented on KAFKA-13805: --- According to [https://mvnrepository.com/artifact

[jira] [Comment Edited] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519073#comment-17519073 ] Kirk True edited comment on KAFKA-13805 at 4/7/22 6:07 PM: --- Ac

[GitHub] [kafka] artemlivshits commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-07 Thread GitBox
artemlivshits commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r845433136 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPa

[GitHub] [kafka] kirktrue commented on a diff in pull request #11998: KAFKA-13801: Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-07 Thread GitBox
kirktrue commented on code in PR #11998: URL: https://github.com/apache/kafka/pull/11998#discussion_r845436714 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -1813,14 +1812,20 @@ class TestMetricsReporter extends MetricsReporter wit

[jira] [Created] (KAFKA-13806) Check CRC when reading snapshots

2022-04-07 Thread Jose Armando Garcia Sancio (Jira)
Jose Armando Garcia Sancio created KAFKA-13806: -- Summary: Check CRC when reading snapshots Key: KAFKA-13806 URL: https://issues.apache.org/jira/browse/KAFKA-13806 Project: Kafka

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519082#comment-17519082 ] Bruno Cadonna commented on KAFKA-13805: --- [~kirktrue] Under "Known Affected Softwar

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519087#comment-17519087 ] Kirk True commented on KAFKA-13805: --- [~cadonna] - Sorry for the confusion... I was men

[jira] [Comment Edited] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519087#comment-17519087 ] Kirk True edited comment on KAFKA-13805 at 4/7/22 6:37 PM: --- [~

[GitHub] [kafka] cadonna opened a new pull request, #12013: Reenable flaky tests

2022-04-07 Thread GitBox
cadonna opened a new pull request, #12013: URL: https://github.com/apache/kafka/pull/12013 Just a test ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (incl

[GitHub] [kafka] xvrl commented on a diff in pull request #11998: KAFKA-13801: Kafka server does not respect MetricsReporter contract for dynamically configured reporters

2022-04-07 Thread GitBox
xvrl commented on code in PR #11998: URL: https://github.com/apache/kafka/pull/11998#discussion_r845459993 ## core/src/test/scala/integration/kafka/server/DynamicBrokerReconfigurationTest.scala: ## @@ -1813,14 +1812,20 @@ class TestMetricsReporter extends MetricsReporter with R

[jira] [Updated] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-13805: -- Description: https://nvd.nist.gov/vuln/detail/CVE-2020-36518 |Packages|Package Version|CVSS|F

[jira] [Commented] (KAFKA-13805) Upgrade vulnerable dependencies march 2022

2022-04-07 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519093#comment-17519093 ] Bruno Cadonna commented on KAFKA-13805: --- [~kirktrue] Ah, got it! You are right! I

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845466434 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845466834 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [kafka] cadonna commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-04-07 Thread GitBox
cadonna commented on PR #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1092089272 @showuon @dengziming @hachikuji @dajac What is the status of this PR? This PR would resolve a blocker for the 3.2.0 release. Would be great if we could merge this PR as soon as possible?

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845468553 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [kafka] jeqo commented on pull request #11999: [MINOR] fix(streams): align variable names

2022-04-07 Thread GitBox
jeqo commented on PR #11999: URL: https://github.com/apache/kafka/pull/11999#issuecomment-1092096823 cc @vvcephei -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845476205 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -213,62 +174,6 @@ class ReplicaFetcherThread(name: String, "equal or larger than your settin

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845476760 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845476205 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -213,62 +174,6 @@ class ReplicaFetcherThread(name: String, "equal or larger than your settin

[GitHub] [kafka] dajac commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
dajac commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845478395 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[jira] [Commented] (KAFKA-7491) Kafka streams and Kafka streams test utils have split packages

2022-04-07 Thread Karsten Schnitter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519124#comment-17519124 ] Karsten Schnitter commented on KAFKA-7491: -- Hi, this issue has not seen much act

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845546314 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Updated] (KAFKA-13803) Refactor Leader API Access

2022-04-07 Thread Rittika Adhikari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rittika Adhikari updated KAFKA-13803: - Description: Currently, AbstractFetcherThread has a series of protected APIs which contr

[GitHub] [kafka] rittikaadhikari commented on a diff in pull request #12005: KAFKA-13803: Refactor Leader API Access

2022-04-07 Thread GitBox
rittikaadhikari commented on code in PR #12005: URL: https://github.com/apache/kafka/pull/12005#discussion_r845546314 ## core/src/main/scala/kafka/server/LeaderEndPoint.scala: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

[jira] [Commented] (KAFKA-12909) Allow users to opt-into spurious left/outer stream-stream join improvement

2022-04-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519175#comment-17519175 ] Matthias J. Sax commented on KAFKA-12909: - Not that _inner_ join result are stil

[GitHub] [kafka] ijuma opened a new pull request, #12014: MINOR: Fix support for custom commit ids in the build

2022-04-07 Thread GitBox
ijuma opened a new pull request, #12014: URL: https://github.com/apache/kafka/pull/12014 This regressed in ca375d8004c1 due to a typo. We need tests for our builds. :) ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify t

[jira] [Commented] (KAFKA-9296) Correlation id for response () does not match request ()

2022-04-07 Thread Jun Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519194#comment-17519194 ] Jun Rao commented on KAFKA-9296: [~vongosling] : It would be useful to provide a bit more

[jira] [Commented] (KAFKA-7509) Kafka Connect logs unnecessary warnings about unused configurations

2022-04-07 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17519199#comment-17519199 ] Matthias J. Sax commented on KAFKA-7509: Thanks for staying on top of this. The f

[GitHub] [kafka] mjsax commented on a diff in pull request #11896: KAFKA-13785: [Emit final][5/N] emit final for TimeWindowedKStreamImpl

2022-04-07 Thread GitBox
mjsax commented on code in PR #11896: URL: https://github.com/apache/kafka/pull/11896#discussion_r845465254 ## streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamWindowAggregate.java: ## @@ -80,22 +109,54 @@ public void enableSendingOldValues() { pr

[GitHub] [kafka] tmbull commented on pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

2022-04-07 Thread GitBox
tmbull commented on PR #8103: URL: https://github.com/apache/kafka/pull/8103#issuecomment-1092308800 Is there any update on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[jira] [Created] (KAFKA-13807) Ensure that we can set log.flush.interval.ms with IncrementalAlterConfigs

2022-04-07 Thread Colin McCabe (Jira)
Colin McCabe created KAFKA-13807: Summary: Ensure that we can set log.flush.interval.ms with IncrementalAlterConfigs Key: KAFKA-13807 URL: https://issues.apache.org/jira/browse/KAFKA-13807 Project: Ka

[GitHub] [kafka] dengziming commented on a diff in pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-04-07 Thread GitBox
dengziming commented on code in PR #11681: URL: https://github.com/apache/kafka/pull/11681#discussion_r845640296 ## core/src/test/java/kafka/testkit/KafkaClusterTestKit.java: ## @@ -373,13 +373,19 @@ public void startup() throws ExecutionException, InterruptedException {

[GitHub] [kafka] ddrid commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-07 Thread GitBox
ddrid commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r845672887 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartition

[GitHub] [kafka] showuon commented on a diff in pull request #12006: KAFKA-13794: Follow up to fix comparator

2022-04-07 Thread GitBox
showuon commented on code in PR #12006: URL: https://github.com/apache/kafka/pull/12006#discussion_r845677599 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPartitio

[GitHub] [kafka] showuon commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-07 Thread GitBox
showuon commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r845685014 ## clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java: ## @@ -1083,6 +1083,26 @@ public String toString() { } } +public static class

[GitHub] [kafka] EvansJahja commented on pull request #12012: MINOR: (console consumer) add print.topic property

2022-04-07 Thread GitBox
EvansJahja commented on PR #12012: URL: https://github.com/apache/kafka/pull/12012#issuecomment-1092379826 Hi @dajac, could I ask for your review on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] RivenSun2 commented on a diff in pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-07 Thread GitBox
RivenSun2 commented on code in PR #12010: URL: https://github.com/apache/kafka/pull/12010#discussion_r845759271 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -49,15 +53,15 @@ public void testClusterConfigProperties() {

[GitHub] [kafka] RivenSun2 commented on pull request #12010: KAFKA-13793: Add validators for configs that lack validators

2022-04-07 Thread GitBox
RivenSun2 commented on PR #12010: URL: https://github.com/apache/kafka/pull/12010#issuecomment-1092480807 Hi @showuon I'll tease out a KIP later that aims to add it for configs with missing validators. The changes involved in the public interface will be pointed out in the text. Than