[
https://issues.apache.org/jira/browse/KAFKA-15044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-15044:
--
Fix Version/s: 3.5.0
> Snappy v.1.1.9.1 NoClassDefFound on ARM machines
>
cadonna merged PR #13774:
URL: https://github.com/apache/kafka/pull/13774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15046:
-
Description:
* Phenomenon:
** !image-2023-06-01-12-46-30-058.png|width=259,height=236!
** Prod
showuon commented on code in PR #13790:
URL: https://github.com/apache/kafka/pull/13790#discussion_r1212741250
##
.asf.yaml:
##
@@ -25,28 +25,29 @@ notifications:
#
https://cwiki.apache.org/confluence/pages/viewpage.action?spaceKey=INFRA&title=Git+-+.asf.yaml+features#Git.asf.
jlprat commented on PR #13790:
URL: https://github.com/apache/kafka/pull/13790#issuecomment-1571555084
We could just do the reordering, to see if the invites are sent again (for
the 2 that didn't accept in time)
--
This is an automated message from the Apache Git Service.
To respond to th
showuon closed pull request #13790: MINOR: update collaborator (v3.4.1 release)
URL: https://github.com/apache/kafka/pull/13790
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
cadonna commented on PR #13790:
URL: https://github.com/apache/kafka/pull/13790#issuecomment-1571560100
I would also opt for major releases. Minor releases are usually done around
major releases and sometimes we also do multiple minor releases around a major
release. So we would update the
jlprat commented on PR #13790:
URL: https://github.com/apache/kafka/pull/13790#issuecomment-1571562621
@showuon we could still do the reordering to see if the invites are sent
again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
showuon commented on PR #13790:
URL: https://github.com/apache/kafka/pull/13790#issuecomment-1571574041
> @showuon we could still do the reordering to see if the invites are sent
again
Let's give it a try!
--
This is an automated message from the Apache Git Service.
To respond to t
Hangleton commented on code in PR #13584:
URL: https://github.com/apache/kafka/pull/13584#discussion_r1212777323
##
core/src/test/scala/unit/kafka/log/LogSegmentTest.scala:
##
@@ -65,6 +68,32 @@ class LogSegmentTest {
Utils.delete(logDir)
}
+ /**
+ * LogSegmentOffse
Hangleton commented on PR #13584:
URL: https://github.com/apache/kafka/pull/13584#issuecomment-1571584730
@showuon Thanks for the follow-up and apologies for the delay, the PR seems
good to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728260#comment-17728260
]
Divij Vaidya commented on KAFKA-15046:
--
Thank you for the investigation folks. We h
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728262#comment-17728262
]
Haruki Okada commented on KAFKA-15046:
--
Oh I haven't noticed there's another ticket
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-9693:
Fix Version/s: 3.6.0
> Kafka latency spikes caused by log segment flush on roll
> -
[
https://issues.apache.org/jira/browse/KAFKA-9693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728265#comment-17728265
]
Divij Vaidya commented on KAFKA-9693:
-
Asynchronously rolling producer snapshot looks
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15046:
-
Component/s: core
> Produce performance issue under high disk load
> ---
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Divij Vaidya updated KAFKA-15046:
-
Labels: performance (was: )
> Produce performance issue under high disk load
>
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728266#comment-17728266
]
Haruki Okada commented on KAFKA-15046:
--
Hm, when I dug into further this, I noticed
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728266#comment-17728266
]
Haruki Okada edited comment on KAFKA-15046 at 6/1/23 8:39 AM:
divijvaidya commented on PR #13786:
URL: https://github.com/apache/kafka/pull/13786#issuecomment-1571610910
As a thought exercise, could we have detected this ARM specific bug if we
were running our tests on ARM machines? What requirement do we have to enable
testing on ARM again?
--
Thi
kamalcph commented on PR #13561:
URL: https://github.com/apache/kafka/pull/13561#issuecomment-1571615955
@satishd
Will you open a separate PR to delete the active segment once it breaches
the retention time? Or, will handle it in this patch.
--
This is an automated message from th
mimaison opened a new pull request, #13791:
URL: https://github.com/apache/kafka/pull/13791
To be backported to 3.5 too
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify do
showuon merged PR #13584:
URL: https://github.com/apache/kafka/pull/13584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728275#comment-17728275
]
Divij Vaidya commented on KAFKA-15046:
--
Yes that is right, leaderEpochCheckpoint is
mimaison merged PR #13791:
URL: https://github.com/apache/kafka/pull/13791
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-15046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Haruki Okada updated KAFKA-15046:
-
Description:
* Phenomenon:
** !image-2023-06-01-12-46-30-058.png|width=259,height=236!
** Prod
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212931402
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -98,8 +97,7 @@
private final Metrics metrics;
private f
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212936370
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -130,20 +136,20 @@ public PrototypeAsyncConsumer(final ConsumerCo
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212938962
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -85,7 +87,6 @@
private static final String CLIENT_ID_METRIC_
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212945606
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -96,6 +97,10 @@
private final Metrics metrics;
private
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212948810
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -96,6 +97,10 @@
private final Metrics metrics;
private
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212959825
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -114,14 +119,14 @@ public PrototypeAsyncConsumer(final ConsumerCo
mimaison opened a new pull request, #13792:
URL: https://github.com/apache/kafka/pull/13792
Moved the ZK and KRaft steps into `h5` sections so they are below the `h4`
Upgrading to 3.5.0 from any version 0.8.x through 3.4.x section.
### Committer Checklist (excluded from commit message
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212959825
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -114,14 +119,14 @@ public PrototypeAsyncConsumer(final ConsumerCo
mimaison commented on PR #13792:
URL: https://github.com/apache/kafka/pull/13792#issuecomment-1571810081
@tombentley @dajac Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1212978727
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -33,6 +33,92 @@
public class PartitionRegistration {
+
+/**
+ * A bui
andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1212980304
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -77,39 +77,75 @@ public void testChangeRecordIsNoOp() {
);
}
andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1212980561
##
metadata/src/test/java/org/apache/kafka/controller/PartitionChangeBuilderTest.java:
##
@@ -77,39 +77,75 @@ public void testChangeRecordIsNoOp() {
);
}
gr-m-9 commented on code in PR #13490:
URL: https://github.com/apache/kafka/pull/13490#discussion_r1212990392
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/PrototypeAsyncConsumer.java:
##
@@ -447,6 +482,19 @@ public void close() {
@Override
pub
Satish Duggana created KAFKA-15047:
--
Summary: Handle rolling segments when the active segment's
retention is breached incase of tiered storage is enabled.
Key: KAFKA-15047
URL: https://issues.apache.org/jira/brow
Hangleton commented on PR #13240:
URL: https://github.com/apache/kafka/pull/13240#issuecomment-1571989946
Hello David (@dajac), I was discussing this with Christo today as part of
his work on the OffsetFetch API. Would you like this PR on OffsetCommit to be
split to make the review easier a
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213100593
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +629,193 @@ public void run() {
}
}
+public void handleLogSta
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213102668
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +629,193 @@ public void run() {
}
}
+public void handleLogSta
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213107255
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +629,193 @@ public void run() {
}
}
+public void handleLogSta
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213107956
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -618,6 +629,193 @@ public void run() {
}
}
+public void handleLogSta
dajac opened a new pull request, #13793:
URL: https://github.com/apache/kafka/pull/13793
As the title says.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
dajac opened a new pull request, #13794:
URL: https://github.com/apache/kafka/pull/13794
As the title says.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213112946
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -154,16 +154,41 @@ class UnifiedLog(@volatile var logStartOffset: Long,
locally {
initializePartitionMe
satishd commented on code in PR #13561:
URL: https://github.com/apache/kafka/pull/13561#discussion_r1213113458
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -1383,20 +1421,30 @@ class UnifiedLog(@volatile var logStartOffset: Long,
}
}
+ private[log] def loc
dajac opened a new pull request, #13795:
URL: https://github.com/apache/kafka/pull/13795
This PR includes temporary https://github.com/apache/kafka/pull/13666,
https://github.com/apache/kafka/pull/13675,
https://github.com/apache/kafka/pull/13793 and
https://github.com/apache/kafka/pull/13
hudeqi commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1572025066
> No, you are correct, I had another look at the neighbouring code after I
wrote my previous comment and I agree that this appears to not cause any
leadership movements. Okay, I am happy t
novosibman commented on PR #13782:
URL: https://github.com/apache/kafka/pull/13782#issuecomment-1572027303
> Are all the graphs shared for OMB and Kafka Tussle generated for Kafka
with the fix in this PR?
Graphs with the fix noted in first description comment - marked with
`kafka_2.13-3
[
https://issues.apache.org/jira/browse/KAFKA-15047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satish Duggana updated KAFKA-15047:
---
Description:
Active segments are not copied by remote storage subsystem. But they can be
el
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213163941
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEventProcessor.java:
##
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213165026
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Softwa
jeffkbkim commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213190623
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache So
dajac commented on code in PR #13769:
URL: https://github.com/apache/kafka/pull/13769#discussion_r1213186879
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -36,45 +36,58 @@ class TransactionDataAndCallbacks(val transactionData:
AddPartitionsToTxnTran
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213213734
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Softwa
jeffkbkim commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213191767
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Found
jeffkbkim commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213221009
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache So
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213222820
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/CoordinatorEvent.java:
##
@@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundatio
dajac commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213232889
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache Softwa
tombentley commented on code in PR #13792:
URL: https://github.com/apache/kafka/pull/13792#discussion_r1213226340
##
docs/upgrade.html:
##
@@ -59,6 +59,65 @@ Notable changes in 3
+Upgrading
ZooKeeper-based clusters
+If you are upgrading from a version
mumrah merged PR #13758:
URL: https://github.com/apache/kafka/pull/13758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
jsancio commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1213240584
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -33,6 +33,92 @@
public class PartitionRegistration {
+
+/**
+ * A bui
jeffkbkim commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213254844
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,212 @@
+/*
+ * Licensed to the Apache So
urbandan opened a new pull request, #13796:
URL: https://github.com/apache/kafka/pull/13796
…atches to complete before resetting the sequence number
The idempotent producer resets the sequence number when a batch fails with a
non-retriable error. This can violate the idempotent guaran
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213267178
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig,
}
/**
- * Append the messages
urbandan commented on PR #13796:
URL: https://github.com/apache/kafka/pull/13796#issuecomment-1572188562
@viktorsomogyi Could you please review this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213268934
##
core/src/main/scala/kafka/coordinator/group/PartitionWriterImpl.scala:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213271843
##
core/src/test/scala/unit/kafka/coordinator/group/PartitionWriterImplTest.scala:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213273088
##
core/src/test/scala/unit/kafka/coordinator/group/PartitionWriterImplTest.scala:
##
@@ -0,0 +1,225 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213274631
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
andymg3 commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1213276160
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -33,6 +33,92 @@
public class PartitionRegistration {
+
+/**
+ * A bui
[
https://issues.apache.org/jira/browse/KAFKA-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano resolved KAFKA-15017.
---
Resolution: Fixed
> New ClientQuotas are not written to ZK from snapshot
>
[
https://issues.apache.org/jira/browse/KAFKA-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17728390#comment-17728390
]
Proven Provenzano commented on KAFKA-15017:
---
Fix is on 3.5 branch.
> New Clie
mimaison commented on code in PR #13792:
URL: https://github.com/apache/kafka/pull/13792#discussion_r1213332860
##
docs/upgrade.html:
##
@@ -59,6 +59,65 @@ Notable changes in 3
+Upgrading
ZooKeeper-based clusters
+If you are upgrading from a version pr
mimaison commented on code in PR #13792:
URL: https://github.com/apache/kafka/pull/13792#discussion_r121808
##
docs/upgrade.html:
##
@@ -59,6 +59,65 @@ Notable changes in 3
+Upgrading
ZooKeeper-based clusters
+If you are upgrading from a version pr
jsancio commented on PR #13765:
URL: https://github.com/apache/kafka/pull/13765#issuecomment-1572275711
Thanks for your feedback @divijvaidya @dajac. I am replying to both your
comments in you message.
> With this change, we are changing the semantics of what a leadership epoch
means. Pr
mimaison commented on code in PR #13792:
URL: https://github.com/apache/kafka/pull/13792#discussion_r1213336329
##
docs/upgrade.html:
##
@@ -59,6 +59,65 @@ Notable changes in 3
+Upgrading
ZooKeeper-based clusters
+If you are upgrading from a version pr
jsancio commented on code in PR #13788:
URL: https://github.com/apache/kafka/pull/13788#discussion_r1213346871
##
metadata/src/main/java/org/apache/kafka/metadata/PartitionRegistration.java:
##
@@ -33,6 +33,92 @@
public class PartitionRegistration {
+
+/**
+ * A bui
mimaison merged PR #13792:
URL: https://github.com/apache/kafka/pull/13792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
dajac commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213267178
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig,
}
/**
- * Append the messages
jolshan commented on code in PR #13769:
URL: https://github.com/apache/kafka/pull/13769#discussion_r1213389003
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -93,17 +93,22 @@ class AddPartitionsToTxnManagerTest {
val transaction1AgainE
jolshan commented on code in PR #13769:
URL: https://github.com/apache/kafka/pull/13769#discussion_r1213389903
##
core/src/test/scala/unit/kafka/server/AddPartitionsToTxnManagerTest.scala:
##
@@ -93,17 +93,22 @@ class AddPartitionsToTxnManagerTest {
val transaction1AgainE
vcrfxia commented on code in PR #13756:
URL: https://github.com/apache/kafka/pull/13756#discussion_r1212267772
##
streams/src/main/java/org/apache/kafka/streams/state/internals/RocksDBTimeOrderedKeyValueBuffer.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Software Fo
philipnee opened a new pull request, #13797:
URL: https://github.com/apache/kafka/pull/13797
In this PR: I implemented assign() and assignment(). Ported the original
tests from the KafkaConsumerTest.java
Different to the original Implementation:
We will explicitly send a commit
philipnee commented on PR #13605:
URL: https://github.com/apache/kafka/pull/13605#issuecomment-1572469830
closingi this in light of https://github.com/apache/kafka/pull/13797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
philipnee closed pull request #13605: KAFKA-14950: implement assign() and
assignment()
URL: https://github.com/apache/kafka/pull/13605
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
jolshan commented on code in PR #13666:
URL: https://github.com/apache/kafka/pull/13666#discussion_r1213460495
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessor.java:
##
@@ -0,0 +1,188 @@
+/*
+ * Licensed to the Apache Soft
jolshan commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213469954
##
core/src/main/scala/kafka/coordinator/group/PartitionWriterImpl.scala:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
jolshan commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213473971
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1019,13 +1029,14 @@ class ReplicaManager(val config: KafkaConfig,
}
/**
- * Append the messag
jolshan commented on code in PR #13675:
URL: https://github.com/apache/kafka/pull/13675#discussion_r1213474996
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/RecordSerializer.java:
##
@@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
jolshan commented on PR #13793:
URL: https://github.com/apache/kafka/pull/13793#issuecomment-1572514821
Can we update the description to give the rationale for this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
dajac commented on PR #13793:
URL: https://github.com/apache/kafka/pull/13793#issuecomment-1572521296
@jolshan Updated the description. This is basically a minor refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jolshan commented on PR #13794:
URL: https://github.com/apache/kafka/pull/13794#issuecomment-1572526297
Let's add a brief description to explain the rationale for these interfaces
to the description
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
jolshan commented on code in PR #13794:
URL: https://github.com/apache/kafka/pull/13794#discussion_r1213491922
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/runtime/Replayable.java:
##
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (A
jsancio commented on code in PR #13765:
URL: https://github.com/apache/kafka/pull/13765#discussion_r1213501789
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -1087,12 +1087,14 @@ class Partition(val topicPartition: TopicPartition,
// avoid unnecessary collectio
novosibman commented on PR #13782:
URL: https://github.com/apache/kafka/pull/13782#issuecomment-1572620634
Provided updated change:
returned original try-with-resource on writing, added utility method for
flushing:
```
try (FileChannel fileChannel = FileChannel.open(file.toP
C0urante commented on code in PR #13776:
URL: https://github.com/apache/kafka/pull/13776#discussion_r1213569347
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/connect/ReplaceFieldBenchmark.java:
##
@@ -0,0 +1,78 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
1 - 100 of 131 matches
Mail list logo
