Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] MINOR: Add LEAVE_GROUP_EPOCH to GroupMetadataManager [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on PR #14463: URL: https://github.com/apache/kafka/pull/14463#issuecomment-1746423437 Thanks @kirktrue , LGTM (I had already approved). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] KAFKA-15526: Simplify the LogAppendInfo class [kafka]

2023-10-04 Thread via GitHub
ijuma commented on code in PR #14470: URL: https://github.com/apache/kafka/pull/14470#discussion_r1345296313 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -96,10 +96,10 @@ final class KafkaMetadataLog private ( } private def

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
divijvaidya commented on PR #14480: URL: https://github.com/apache/kafka/pull/14480#issuecomment-1746315640 > If we don't already report the AddPartitionsToTxn request metrics in this file, it doesn't make sense to add the verification variant. (As well as all the other APIs we report)

Re: [PR] KAFKA-14516: [1/N] Static Member leave request handling [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on code in PR #14432: URL: https://github.com/apache/kafka/pull/14432#discussion_r1345450086 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -593,6 +609,9 @@ private void

[jira] [Commented] (KAFKA-15169) Add tests for RemoteIndexCache

2023-10-04 Thread Arpit Goyal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771713#comment-17771713 ] Arpit Goyal commented on KAFKA-15169: - [~divijvaidya] [~satish.duggana] [~showuon] Added few test

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
divijvaidya commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345355926 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest {

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345392660 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] remove meaningless lines [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on PR #14423: URL: https://github.com/apache/kafka/pull/14423#issuecomment-1746443694 Thanks for the PR @sangyongchoi. Couple of thoughts => 1. If there are other instances of such lines which are meaningless, could you also add them. 2. Can you add `[MINOR]`

Re: [PR] KAFKA-15355: Message schema changes [kafka]

2023-10-04 Thread via GitHub
soarez commented on code in PR #14290: URL: https://github.com/apache/kafka/pull/14290#discussion_r1345336375 ## generator/src/main/java/org/apache/kafka/message/FieldSpec.java: ## @@ -157,11 +157,6 @@ private void checkTagInvariants() { this.taggedVersions

Re: [PR] KAFKA-15330: Add missing documentation of metrics introduced as part of KAFKA-15028 [kafka]

2023-10-04 Thread via GitHub
divijvaidya commented on code in PR #14480: URL: https://github.com/apache/kafka/pull/14480#discussion_r1345351170 ## docs/ops.html: ## @@ -1789,6 +1789,16 @@

Re: [PR] KAFKA-14593: fix gradle build [kafka]

2023-10-04 Thread via GitHub
raboof commented on PR #14474: URL: https://github.com/apache/kafka/pull/14474#issuecomment-1746368814 This fix was also in #14475 which has been merged -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14593: fix gradle build [kafka]

2023-10-04 Thread via GitHub
raboof closed pull request #14474: KAFKA-14593: fix gradle build URL: https://github.com/apache/kafka/pull/14474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345392660 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-15526: Simplify the LogAppendInfo class [kafka]

2023-10-04 Thread via GitHub
ijuma commented on code in PR #14470: URL: https://github.com/apache/kafka/pull/14470#discussion_r1345292439 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -768,10 +768,10 @@ class UnifiedLog(@volatile var logStartOffset: Long, // This will ensure that any log

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345438999 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345403872 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on PR #13247: URL: https://github.com/apache/kafka/pull/13247#issuecomment-1746528192 @tledkov > `ReplicationQuotasTestRig` no longer needed? This class not used through current codebase. But it has dependency on `ReassignPartitionCommand`. So, for

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345629562 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-10199: Enable state updater by default [kafka]

2023-10-04 Thread via GitHub
cadonna merged PR #13927: URL: https://github.com/apache/kafka/pull/13927 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[jira] [Commented] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771842#comment-17771842 ] Luke Chen commented on KAFKA-15537: --- [~fvaleri], thanks for raising this issue. Since you've dived

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade in case one of the metadata

[PR] KAFKA-15537: Fix metadata downgrade documentation [kafka]

2023-10-04 Thread via GitHub
fvaleri opened a new pull request, #14484: URL: https://github.com/apache/kafka/pull/14484 In KIP-778 we introduced the "unsafe" downgrade in case one of the metadata versions between target and current have changes, as defined in MetadataVersion. This is a lossy downgrade where each node

Re: [PR] KAFKA-15532: non active controllers return 0 for ZkWriteBeforelag [kafka]

2023-10-04 Thread via GitHub
mumrah commented on PR #14478: URL: https://github.com/apache/kafka/pull/14478#issuecomment-1746847899 Changes look good, but there are some failing tests. https://github.com/apache/kafka/assets/55116/411b8ee4-fb1c-4537-a578-56550618d1aa;> -- This is an automated message from

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-04 Thread via GitHub
dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1345534442 ## core/src/main/scala/kafka/coordinator/group/CoordinatorPartitionWriter.scala: ## @@ -123,50 +124,79 @@ class CoordinatorPartitionWriter[T]( val maxBatchSize

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345657229 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade functionality in case one of

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Affects Version/s: 3.5.1 > Unsafe metadata.version downgrade is not supported >

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade in case one of the metadata

Re: [PR] KAFKA-15278: Implement HeartbeatRequestManager to handle heartbeat requests [kafka]

2023-10-04 Thread via GitHub
dajac commented on PR #14364: URL: https://github.com/apache/kafka/pull/14364#issuecomment-1746844528 > @dajac @lianetm Thanks for the feedback. I addressed more of your comments. I wanted to point out that I filed 3 follow-up tickets to close some of the gaps. These are: > > *

[jira] [Assigned] (KAFKA-15481) Concurrency bug in RemoteIndexCache leads to IOException

2023-10-04 Thread Jeel Jotaniya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jeel Jotaniya reassigned KAFKA-15481: - Assignee: Jeel Jotaniya > Concurrency bug in RemoteIndexCache leads to IOException >

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345514076 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345531820 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345533167 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] MINOR: Add LEAVE_GROUP_EPOCH to GroupMetadataManager [kafka]

2023-10-04 Thread via GitHub
dajac merged PR #14463: URL: https://github.com/apache/kafka/pull/14463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345642089 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345691324 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14506: Implement DeleteGroups API and OffsetDelete API [kafka]

2023-10-04 Thread via GitHub
dajac merged PR #14408: URL: https://github.com/apache/kafka/pull/14408 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-14504: Implement DescribeGroups API [kafka]

2023-10-04 Thread via GitHub
dajac commented on code in PR #14462: URL: https://github.com/apache/kafka/pull/14462#discussion_r1345506634 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ## @@ -8686,6 +8695,88 @@ public void testListGroups() {

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345526998 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

[PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
jeel2420 opened a new pull request, #14483: URL: https://github.com/apache/kafka/pull/14483 This PR fixes the concurrency bug in RemoteIndexCache. (From Jira description) RemoteIndexCache has a concurrency bug which leads to IOException while fetching data from remote tier.

Re: [PR] KAFKA-15481: Fix concurrency bug in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
jeel2420 commented on code in PR #14483: URL: https://github.com/apache/kafka/pull/14483#discussion_r1345548349 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -132,7 +133,7 @@ class RemoteIndexCacheTest { // this call should have invoked

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-04 Thread via GitHub
msn-tldr commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1345590803 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -94,9 +100,40 @@ public ProducerBatch(TopicPartition tp,

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345590444 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345673613 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade functionality in case one of

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345533167 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

[jira] [Commented] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771844#comment-17771844 ] Federico Valeri commented on KAFKA-15537: - Sure. I already opened a PR to fix the documentation

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade in case one of the metadata

[jira] [Assigned] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri reassigned KAFKA-15537: --- Assignee: Federico Valeri > Unsafe metadata.version downgrade is not supported >

[jira] [Comment Edited] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771844#comment-17771844 ] Federico Valeri edited comment on KAFKA-15537 at 10/4/23 1:10 PM: --

[jira] [Updated] (KAFKA-15535) Add documentation of "remote.log.index.file.cache.total.size.bytes" configuration property.

2023-10-04 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15535?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-15535: - Labels: tiered-storage (was: ) > Add documentation of

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345524979 ## tools/src/main/java/org/apache/kafka/tools/reassign/Tuple2.java: ## @@ -0,0 +1,48 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] KAFKA-15169: Added TestCase in RemoteIndexCache [kafka]

2023-10-04 Thread via GitHub
iit2009060 commented on code in PR #14482: URL: https://github.com/apache/kafka/pull/14482#discussion_r1345526187 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -541,6 +541,126 @@ class RemoteIndexCacheTest { verifyFetchIndexInvocation(count

Re: [PR] KAFKA-14987; Implement Group/Offset expiration in the new coordinator [kafka]

2023-10-04 Thread via GitHub
dajac commented on code in PR #14467: URL: https://github.com/apache/kafka/pull/14467#discussion_r1345541333 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/OffsetMetadataManager.java: ## @@ -539,26 +564,59 @@ public

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-04 Thread via GitHub
msn-tldr commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1345592537 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -156,6 +157,8 @@ public class SenderTest { private

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345633642 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345648074 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Resolved] (KAFKA-10199) Separate state restoration into separate threads

2023-10-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna resolved KAFKA-10199. --- Resolution: Done > Separate state restoration into separate threads >

[jira] [Updated] (KAFKA-10199) Separate state restoration into separate threads

2023-10-04 Thread Bruno Cadonna (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Cadonna updated KAFKA-10199: -- Fix Version/s: 3.7.0 > Separate state restoration into separate threads >

[jira] [Created] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
Federico Valeri created KAFKA-15537: --- Summary: Unsafe metadata.version downgrade is not supported Key: KAFKA-15537 URL: https://issues.apache.org/jira/browse/KAFKA-15537 Project: Kafka

Re: [PR] KAFKA-14048:Implement regex subscriptions [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on PR #14327: URL: https://github.com/apache/kafka/pull/14327#issuecomment-1746457140 @JimmyWang6 , In the PR title, you have mentioned `KAFKA-14048` which is the uber ticket for KIP-848. Please change it to `KAFKA-14517` instead. -- This is an automated message

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1345647289 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1501 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade functionality in case one of

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Component/s: documentation > Unsafe metadata.version downgrade is not supported >

Re: [PR] MINOR: KAFKA-15526 followup [kafka]

2023-10-04 Thread via GitHub
splett2 commented on code in PR #14485: URL: https://github.com/apache/kafka/pull/14485#discussion_r1345807911 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -96,7 +96,7 @@ final class KafkaMetadataLog private ( } private def

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1346001263 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1523 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-04 Thread via GitHub
dajac commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1747117455 Thanks @vamossagar12! I will get to this PR soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1346088298 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1523 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-14516: [1/N] Static Member leave, join, re-join request using ConsumerGroupHeartbeats [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on PR #14432: URL: https://github.com/apache/kafka/pull/14432#issuecomment-1747157933 > Thanks @vamossagar12! I will get to this PR soon. Thank you. I am still coming to terms with the new group coordinator so there might be rough edges in this PR (upfront

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
tledkov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1346111546 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1523 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] KAFKA-15356: Generate and persist directory IDs [kafka]

2023-10-04 Thread via GitHub
pprovenzano commented on PR #14291: URL: https://github.com/apache/kafka/pull/14291#issuecomment-1747196899 LGTM! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] KAFKA-14595 Move ReassignPartitionsCommand to java [kafka]

2023-10-04 Thread via GitHub
nizhikov commented on code in PR #13247: URL: https://github.com/apache/kafka/pull/13247#discussion_r1346148455 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -0,0 +1,1523 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] MINOR: KAFKA-15526 followup [kafka]

2023-10-04 Thread via GitHub
splett2 commented on code in PR #14485: URL: https://github.com/apache/kafka/pull/14485#discussion_r1345806386 ## core/src/main/scala/kafka/log/UnifiedLog.scala: ## @@ -770,8 +770,8 @@ class UnifiedLog(@volatile var logStartOffset: Long, val appendInfo =

Re: [PR] MINOR: KAFKA-15526 followup [kafka]

2023-10-04 Thread via GitHub
splett2 commented on code in PR #14485: URL: https://github.com/apache/kafka/pull/14485#discussion_r1345807911 ## core/src/main/scala/kafka/raft/KafkaMetadataLog.scala: ## @@ -96,7 +96,7 @@ final class KafkaMetadataLog private ( } private def

[PR] MINOR: Update the list of collaborators [kafka]

2023-10-04 Thread via GitHub
yashmayya opened a new pull request, #14486: URL: https://github.com/apache/kafka/pull/14486 - The collaborators list was initially added in https://github.com/apache/kafka/pull/13713 (following the policy specified here - https://github.com/apache/kafka-site/pull/510). - The list is

[jira] [Updated] (KAFKA-15540) Handle heartbeat and assignment release when consumer leaves group

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15540: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Task) > Handle heartbeat and

[jira] [Created] (KAFKA-15542) Release member assignments on errors

2023-10-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15542: -- Summary: Release member assignments on errors Key: KAFKA-15542 URL: https://issues.apache.org/jira/browse/KAFKA-15542 Project: Kafka Issue Type:

[jira] [Created] (KAFKA-15543) Send HB request right after reconciliation completes

2023-10-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15543: -- Summary: Send HB request right after reconciliation completes Key: KAFKA-15543 URL: https://issues.apache.org/jira/browse/KAFKA-15543 Project: Kafka

Re: [PR] KAFKA-13976: Improvements for OpenAPI specs [kafka]

2023-10-04 Thread via GitHub
vamossagar12 commented on PR #12306: URL: https://github.com/apache/kafka/pull/12306#issuecomment-1747003852 @mimaison , yes sorry this completely missed my radar. Let me get to it some time next week. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-15544) Enable existing client integration tests for new protocol

2023-10-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15544: -- Summary: Enable existing client integration tests for new protocol Key: KAFKA-15544 URL: https://issues.apache.org/jira/browse/KAFKA-15544 Project: Kafka

Re: [PR] KAFKA-15415: On producer-batch retry, skip-backoff on a new leader [kafka]

2023-10-04 Thread via GitHub
wcarlson5 commented on code in PR #14384: URL: https://github.com/apache/kafka/pull/14384#discussion_r1346128343 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/ProducerBatch.java: ## @@ -94,9 +100,42 @@ public ProducerBatch(TopicPartition tp,

[jira] [Commented] (KAFKA-14811) The forwarding requests are discarded when network client is changed to/from zk/Kraft

2023-10-04 Thread Doguscan Namal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771912#comment-17771912 ] Doguscan Namal commented on KAFKA-14811: This was fixed in

[jira] [Commented] (KAFKA-15483) Update metrics documentation for the new metrics implemented as part of KIP-938

2023-10-04 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771848#comment-17771848 ] ASF GitHub Bot commented on KAFKA-15483: mumrah merged PR #548: URL:

[jira] [Created] (KAFKA-15538) Resolve regex on client side when using java regex in new consumer

2023-10-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15538: -- Summary: Resolve regex on client side when using java regex in new consumer Key: KAFKA-15538 URL: https://issues.apache.org/jira/browse/KAFKA-15538 Project:

[PR] MINOR: KAFKA-15526 followup [kafka]

2023-10-04 Thread via GitHub
splett2 opened a new pull request, #14485: URL: https://github.com/apache/kafka/pull/14485 ### What Addressing feedback left post-merge on #14470 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI

[jira] [Updated] (KAFKA-15537) Unsafe metadata.version downgrade is not supported

2023-10-04 Thread Federico Valeri (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Federico Valeri updated KAFKA-15537: Description: In KIP-778 we introduced the "unsafe" downgrade in case metadata has changes

[jira] [Created] (KAFKA-15540) Handle heartbeat and assignment release when consumer leaves group

2023-10-04 Thread Lianet Magrans (Jira)
Lianet Magrans created KAFKA-15540: -- Summary: Handle heartbeat and assignment release when consumer leaves group Key: KAFKA-15540 URL: https://issues.apache.org/jira/browse/KAFKA-15540 Project:

[jira] [Created] (KAFKA-15541) RocksDB Iterator Metrics

2023-10-04 Thread Nicholas Telford (Jira)
Nicholas Telford created KAFKA-15541: Summary: RocksDB Iterator Metrics Key: KAFKA-15541 URL: https://issues.apache.org/jira/browse/KAFKA-15541 Project: Kafka Issue Type: Improvement

[jira] [Updated] (KAFKA-15538) Resolve regex on client side when using java regex in new consumer

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15538: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Task) > Resolve regex on client

[jira] [Updated] (KAFKA-15539) Stop fetching while partitions being revoked

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15539: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Task) > Stop fetching while

[jira] [Updated] (KAFKA-15539) Stop fetching while partitions being revoked

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15539: --- Labels: kip-848-client-support (was: ) > Stop fetching while partitions being revoked >

[jira] [Updated] (KAFKA-15540) Handle heartbeat and assignment release when consumer leaves group

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15540: --- Labels: kip-848 kip-848-client-support (was: ) > Handle heartbeat and assignment release

[jira] [Resolved] (KAFKA-15438) Review exception caching logic used for reset/validate positions in async consumer

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans resolved KAFKA-15438. Resolution: Fixed > Review exception caching logic used for reset/validate positions in

[jira] [Updated] (KAFKA-15327) Async consumer should commit offsets on close

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lianet Magrans updated KAFKA-15327: --- Parent: KAFKA-14048 Issue Type: Sub-task (was: Bug) > Async consumer should commit

[jira] [Commented] (KAFKA-15438) Review exception caching logic used for reset/validate positions in async consumer

2023-10-04 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-15438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17771869#comment-17771869 ] Lianet Magrans commented on KAFKA-15438: Leaving as it is for now, given that it achieves the

  1   2   3   >