chia7712 commented on PR #15459:
URL: https://github.com/apache/kafka/pull/15459#issuecomment-1975090889
@FrankYang0529 Could you update the description with a bit context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Chia-Ping Tsai created KAFKA-16322:
--
Summary: Fix CVE-2023-50572 by updating jline from 3.22.0 to 3.25.1
Key: KAFKA-16322
URL: https://issues.apache.org/jira/browse/KAFKA-16322
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823021#comment-17823021
]
Luke Chen commented on KAFKA-16028:
---
[~omersiar], it would be good if you could attach complete log in
[
https://issues.apache.org/jira/browse/KAFKA-16252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cheng-Kai, Zhang reassigned KAFKA-16252:
Assignee: Cheng-Kai, Zhang
> Maligned Metrics formatting
>
pjl1070048431 commented on PR #15321:
URL: https://github.com/apache/kafka/pull/15321#issuecomment-1975644361
Hi, can you take a look at this issue. @dajac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
github-actions[bot] commented on PR #14919:
URL: https://github.com/apache/kafka/pull/14919#issuecomment-1975645879
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has
[
https://issues.apache.org/jira/browse/KAFKA-16222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
PoAn Yang reassigned KAFKA-16222:
-
Assignee: PoAn Yang
> KRaft Migration: Incorrect default user-principal quota after migration
[
https://issues.apache.org/jira/browse/KAFKA-16283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan-Po Tseng reassigned KAFKA-16283:
-
Assignee: Kuan-Po Tseng
> RoundRobinPartitioner will only send to half of the
showuon commented on PR #15461:
URL: https://github.com/apache/kafka/pull/15461#issuecomment-1975543018
Will check it today. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
chia7712 commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975411816
unrelated to this PR, but it seems `KafkaMetricsReporterMBean` has unused
method `startReporter` and `stopReporter` after this gets merged. Maybe we
should deprecate
appchemist commented on PR #15388:
URL: https://github.com/apache/kafka/pull/15388#issuecomment-1975501619
@chia7712 Thanks for review!
This comment is added by https://github.com/apache/kafka/pull/12862
The method with the comment was originally named `updateLastSend`, but its
ijuma commented on code in PR #15447:
URL: https://github.com/apache/kafka/pull/15447#discussion_r1510515422
##
raft/src/test/java/org/apache/kafka/raft/internals/TimeRatioTest.java:
##
@@ -17,6 +17,7 @@
package org.apache.kafka.raft.internals;
import
ijuma commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975791773
Perhaps this is actually a public interface from the days where these things
didn't follow a consistent pattern. For example:
ijuma commented on PR #15240:
URL: https://github.com/apache/kafka/pull/15240#issuecomment-1975792004
I will close this for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
ijuma closed pull request #15240: MINOR: Delete KafkaCSVMetricsReporter
URL: https://github.com/apache/kafka/pull/15240
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Johnny Hsu created KAFKA-16323:
--
Summary: Failing test: fix testRemoteFetchExpiresPerSecMetric
Key: KAFKA-16323
URL: https://issues.apache.org/jira/browse/KAFKA-16323
Project: Kafka
Issue
[
https://issues.apache.org/jira/browse/KAFKA-16323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu updated KAFKA-16323:
---
Labels: test-failure (was: )
> Failing test: fix testRemoteFetchExpiresPerSecMetric
>
cadonna commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975855514
> Not sure how this PR related to #3897 though. Is it a successor?
@ijuma what relation between this PR and #3897 you are referring at?
I do not see any connection between those
[
https://issues.apache.org/jira/browse/KAFKA-16323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Johnny Hsu updated KAFKA-16323:
---
Priority: Major (was: Minor)
> Failing test: fix testRemoteFetchExpiresPerSecMetric
>
ijuma merged PR #15460:
URL: https://github.com/apache/kafka/pull/15460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #15430:
URL: https://github.com/apache/kafka/pull/15430#issuecomment-1975916553
Unrelated to this PR, but the description of the class calls it `concurrent`
while we seem to acquire locks during the operations. Perhaps thread-safe is a
better description for what's
ijuma commented on PR #15460:
URL: https://github.com/apache/kafka/pull/15460#issuecomment-1975893885
Failures are unrelated (I checked that none of them were due to missing
easymock/powermock).
--
This is an automated message from the Apache Git Service.
To respond to the message,
ijuma commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975909858
There is a `1` missing. :) I meant https://github.com/apache/kafka/pull/13897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
chia7712 merged PR #14365:
URL: https://github.com/apache/kafka/pull/14365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
echooymxq commented on PR #15085:
URL: https://github.com/apache/kafka/pull/15085#issuecomment-1975225512
@afshing Where is the pr for
[KAFKA-16044](https://issues.apache.org/jira/browse/KAFKA-16044) ? I'm
interested in your implementation of the topic quota.
--
This is an automated
chia7712 merged PR #15412:
URL: https://github.com/apache/kafka/pull/15412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
chia7712 commented on PR #15412:
URL: https://github.com/apache/kafka/pull/15412#issuecomment-1975231191
@AyoubOm thanks for your contribution!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
KevinZTW opened a new pull request, #15461:
URL: https://github.com/apache/kafka/pull/15461
When add the message with timestamp through producer, get offset with max
timestamp didn't get the expected offset
jira ticket: https://issues.apache.org/jira/browse/KAFKA-16310
###
chia7712 commented on code in PR #15435:
URL: https://github.com/apache/kafka/pull/15435#discussion_r1510329193
##
core/src/test/scala/integration/kafka/server/KRaftClusterTest.scala:
##
@@ -792,6 +792,43 @@ class KRaftClusterTest {
}
}
+ /**
+ * Test that setting
chia7712 commented on PR #15388:
URL: https://github.com/apache/kafka/pull/15388#issuecomment-1975228326
@appchemist Could you dig in the context for us? For example: the comment
was added by which commit? and it gets stale by which comment? thanks!
btw, that change LGTM
--
This
ijuma opened a new pull request, #15460:
URL: https://github.com/apache/kafka/pull/15460
These projects don't actually use easymock.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
-
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16310:
--
Assignee: Cheng-Kai, Zhang
> ListOffsets doesn't report the offset with maxTimestamp
chia7712 merged PR #15459:
URL: https://github.com/apache/kafka/pull/15459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
ijuma commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975226112
Not sure how this PR related to #3897 though. Is it a successor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
ijuma commented on PR #15254:
URL: https://github.com/apache/kafka/pull/15254#issuecomment-1975225882
Is this ready to review? @divijvaidya @cadonna Any chance you can help
review this? Looks like there are only two tests in streams that still use
mockito (and this is one of them).
--
AndrewJSchofield commented on code in PR #15455:
URL: https://github.com/apache/kafka/pull/15455#discussion_r1510342872
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -153,15 +154,17 @@ public void
AndrewJSchofield commented on code in PR #15426:
URL: https://github.com/apache/kafka/pull/15426#discussion_r1510345836
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImpl.java:
##
@@ -1372,4 +1373,8 @@ public PollResult poll(final long
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822981#comment-17822981
]
Chia-Ping Tsai commented on KAFKA-16310:
the bug is related to
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822981#comment-17822981
]
Chia-Ping Tsai edited comment on KAFKA-16310 at 3/3/24 8:11 PM:
the bug
[
https://issues.apache.org/jira/browse/KAFKA-16310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17822991#comment-17822991
]
Ismael Juma commented on KAFKA-16310:
-
Yes, [~jolshan] and [~hachikuji] looked into this and arrived
[
https://issues.apache.org/jira/browse/KAFKA-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield reassigned KAFKA-16245:
Assignee: Andrew Schofield
> DescribeConsumerGroupTest failing
>
[
https://issues.apache.org/jira/browse/KAFKA-16245?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17823002#comment-17823002
]
Andrew Schofield commented on KAFKA-16245:
--
I see a couple of failures in my testing, one of
42 matches
Mail list logo
