[jira] [Updated] (KAFKA-16474) AsyncKafkaConsumer might send out heartbeat request without waiting for its response

2024-04-05 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16474: -- Component/s: clients > AsyncKafkaConsumer might send out heartbeat request without waiting for its >

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554446742 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-05 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1554466415 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] KAFKA-15538: Client support for java regex based subscription [kafka]

2024-04-05 Thread via GitHub
Phuc-Hong-Tran commented on code in PR #15585: URL: https://github.com/apache/kafka/pull/15585#discussion_r1554474003 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1750,8 +1753,14 @@ private void subscribeInternal(Pattern pa

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040889410 I'm going to merge this PR in order to make other tool tests can run with KRaft. We can address all late reviews in other PRs. -- This is an automated message from the Apache Git Servi

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
chia7712 merged PR #15663: URL: https://github.com/apache/kafka/pull/15663 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Updated] (KAFKA-16472) Integration tests in Java don't really run kraft case

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-16472: --- Fix Version/s: 3.8.0 3.7.1 > Integration tests in Java don't really run k

[jira] [Resolved] (KAFKA-16472) Integration tests in Java don't really run kraft case

2024-04-05 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-16472. Resolution: Fixed > Integration tests in Java don't really run kraft case > --

Re: [PR] MINOR: Default test name added to tools [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on PR #15666: URL: https://github.com/apache/kafka/pull/15666#issuecomment-2040912811 @nizhikov Could you please rebase code to see the display name of tools test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] KAFKA-16047: Leverage the fenceProducers timeout in the InitProducerId [kafka]

2024-04-05 Thread via GitHub
github-actions[bot] commented on PR #15078: URL: https://github.com/apache/kafka/pull/15078#issuecomment-2040935039 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge

Re: [PR] KAFKA-15853: Move Sasl and SSL configs out of core [kafka]

2024-04-05 Thread via GitHub
chia7712 commented on code in PR #15656: URL: https://github.com/apache/kafka/pull/15656#discussion_r1554518847 ## server/src/main/java/org/apache/kafka/server/config/KafkaConfig.java: ## @@ -0,0 +1,156 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or mor

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554519247 ## tools/src/main/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommand.java: ## @@ -654,6 +654,13 @@ static Map> getReplicaAssignmentForPartitions(Admi

Re: [PR] KAFKA-16477: Detect thread leaked client-metrics-reaper in tests [kafka]

2024-04-05 Thread via GitHub
brandboat commented on PR #15668: URL: https://github.com/apache/kafka/pull/15668#issuecomment-2040977883 > @brandboat nice finding! Should we add the thread prefix to https://github.com/apache/kafka/blob/a2ee0855ee5e73f3a74555d52294bb4acfd28945/core/src/test/scala/unit/kafka/utils/TestUtils

[PR] MINOR: Cleanup in MetadataShell [kafka]

2024-04-05 Thread via GitHub
wernerdv opened a new pull request, #15672: URL: https://github.com/apache/kafka/pull/15672 Removed unnecessary exceptions from the throw list. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build s

Re: [PR] MINOR: Improvements to release.py [kafka]

2024-04-05 Thread via GitHub
omkreddy commented on code in PR #15651: URL: https://github.com/apache/kafka/pull/15651#discussion_r1554531283 ## release.py: ## @@ -348,6 +348,9 @@ def command_release_announcement_email(): +An overview of the release and its notable changes can be found in the +release

[jira] [Created] (KAFKA-16480) ListOffsets change should have an associated API/IBP version update

2024-04-05 Thread Christo Lolov (Jira)
Christo Lolov created KAFKA-16480: - Summary: ListOffsets change should have an associated API/IBP version update Key: KAFKA-16480 URL: https://issues.apache.org/jira/browse/KAFKA-16480 Project: Kafka

[PR] KAFKA-16480: Bump ListOffsets version, IBP version and mark last version of ListOffsets as unstable [kafka]

2024-04-05 Thread via GitHub
clolov opened a new pull request, #15673: URL: https://github.com/apache/kafka/pull/15673 ### Summary This is a follow-up of https://github.com/apache/kafka/pull/15213 where I missed updating the API version and the IBP version. I chose to mark the latest version of the ListOffsets A

Re: [PR] MINOR: Cleanup in MetadataShell [kafka]

2024-04-05 Thread via GitHub
wernerdv commented on PR #15672: URL: https://github.com/apache/kafka/pull/15672#issuecomment-2040983038 @cmccabe @chia7712 Hello, PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
showuon commented on PR #15335: URL: https://github.com/apache/kafka/pull/15335#issuecomment-2040991135 Failed tests are unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] KAFKA-16234: Log directory failure re-creates partitions in another logdir automatically [kafka]

2024-04-05 Thread via GitHub
showuon merged PR #15335: URL: https://github.com/apache/kafka/pull/15335 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Resolved] (KAFKA-16234) Log directory failure re-creates partitions in another logdir automatically

2024-04-05 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen resolved KAFKA-16234. --- Resolution: Fixed > Log directory failure re-creates partitions in another logdir automatically > --

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
showuon commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554536274 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Exception

Re: [PR] KAFKA-16472: Fix integration tests in Java with parameter name [kafka]

2024-04-05 Thread via GitHub
showuon commented on PR #15663: URL: https://github.com/apache/kafka/pull/15663#issuecomment-2040993296 LGTM! Thanks @FrankYang0529 ! Really nice catch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] KAFKA-16455: Check partition exists before send reassignments to server in ReassignPartitionsCommand [kafka]

2024-04-05 Thread via GitHub
brandboat commented on code in PR #15659: URL: https://github.com/apache/kafka/pull/15659#discussion_r1554537353 ## tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsUnitTest.java: ## @@ -300,6 +300,12 @@ public void testGetReplicaAssignments() throws Excepti

<    1   2