chia7712 merged PR #15776:
URL: https://github.com/apache/kafka/pull/15776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-16559:
---
Fix Version/s: 3.7.1
> allow defining number of disks per broker in TestKitNodes
> -
[
https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy reassigned KAFKA-16599:
--
Assignee: Lucas Brutschy
> Always await async commit callbacks in commitSync and clos
chia7712 commented on PR #15777:
URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070011423
#15776 is merged so please rebase code :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16599:
---
Description:
The javadoc for KafkaConsumer.commitSync says:
{code:java}
Note that asynchron
[
https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16599:
---
Component/s: clients
consumer
> Always await async commit callbacks in comm
gaurav-narula commented on PR #15777:
URL: https://github.com/apache/kafka/pull/15777#issuecomment-2070018194
@chia7712 Rebased. PTAL :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/KAFKA-16599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy updated KAFKA-16599:
---
Summary: LegacyConsumer: Always await async commit callbacks in commitSync
and close (was:
[
https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839765#comment-17839765
]
Lucas Brutschy commented on KAFKA-16103:
changes in legacy consumer in https://i
[
https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lucas Brutschy resolved KAFKA-16103.
Resolution: Fixed
> Review client logic for triggering offset commit callbacks
> -
ilyazr commented on code in PR #15701:
URL: https://github.com/apache/kafka/pull/15701#discussion_r1575046814
##
metadata/src/main/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfo.java:
##
@@ -191,6 +191,10 @@ public String failureMessage(
}
ilyazr commented on code in PR #15701:
URL: https://github.com/apache/kafka/pull/15701#discussion_r1575051333
##
metadata/src/test/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfoTest.java:
##
@@ -72,6 +73,11 @@ public class EventHandlerExceptionInfoTest {
ilyazr commented on code in PR #15701:
URL: https://github.com/apache/kafka/pull/15701#discussion_r1575054055
##
metadata/src/test/java/org/apache/kafka/controller/errors/EventHandlerExceptionInfoTest.java:
##
@@ -174,10 +180,18 @@ public void testUnexpectedBaseOffsetExceptionIn
ilyazr commented on PR #15701:
URL: https://github.com/apache/kafka/pull/15701#issuecomment-2070177669
@soarez
Hi! Thanks for pointing out problems with the tests. I didn't know that.
p.s: added suggested changes
--
This is an automated message from the Apache Git Service.
To respon
[
https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Hawkins updated KAFKA-7878:
Affects Version/s: 3.7.0
> Connect Task already exists in this worker when failed to create consume
[
https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839784#comment-17839784
]
John Hawkins commented on KAFKA-7878:
-
I see this quite often when I'm loading the JD
[
https://issues.apache.org/jira/browse/KAFKA-7878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839784#comment-17839784
]
John Hawkins edited comment on KAFKA-7878 at 4/22/24 4:42 PM:
-
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575053494
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -173,63 +199,104 @@ public static class Builder {
private String listenerName;
private Fil
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17838979#comment-17838979
]
Stanislav Spiridonov edited comment on KAFKA-16585 at 4/22/24 4:47 PM:
---
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575079922
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839791#comment-17839791
]
Stanislav Spiridonov commented on KAFKA-16585:
--
If you check the example on
jsancio opened a new pull request, #15781:
URL: https://github.com/apache/kafka/pull/15781
DRAFT - needs https://github.com/apache/kafka/pull/15671
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI bui
brandboat commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575101365
##
core/src/test/java/kafka/test/ClusterConfig.java:
##
@@ -173,63 +199,104 @@ public static class Builder {
private String listenerName;
private Fi
vamossagar12 commented on code in PR #15762:
URL: https://github.com/apache/kafka/pull/15762#discussion_r1575112513
##
clients/src/main/java/org/apache/kafka/common/config/ConfigDef.java:
##
@@ -1256,6 +1256,16 @@ public static class ConfigKey {
public final boolean int
vamossagar12 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2070321267
Thanks @chia7712 , for now I have made the constructor added as part of
https://github.com/apache/kafka/pull/13909 as private.
Regarding
> I guess we need a KIP to deprec
vamossagar12 commented on PR #15305:
URL: https://github.com/apache/kafka/pull/15305#issuecomment-2070326565
@showuon , I made some changes to the test so that we just heartbeat and not
have to rely upon FindCoordinator requests. Let me know what yo think. Thanks!
--
This is an automated
lianetm commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070678792
Hey @m1a2st , the way to get the servers' addresses is
`cluster.bootstrapServers()`, you got it right, but I see you're not inheriting
from `ConsumerGroupCommandTest` anymore, so that rem
chia7712 commented on PR #15772:
URL: https://github.com/apache/kafka/pull/15772#issuecomment-2070748890
Should we move following configs to `SocketServerConfigs`?
1. `controller.listener.names`
https://github.com/apache/kafka/blob/59c781415fc37c89aa087d7c2999cec7f82f6188/core/src/
Alex Leung created KAFKA-16600:
--
Summary: Periodically receive "Failed to transition to
PENDING_SHUTDOWN, current state is PENDING_SHUTDOWN" during streams close
Key: KAFKA-16600
URL: https://issues.apache.org/jira/b
chia7712 commented on PR #15779:
URL: https://github.com/apache/kafka/pull/15779#issuecomment-2070801312
@m1a2st Please add following server property:
```java
@ClusterTestDefaults(clusterType = Type.ALL, serverProperties = {
@ClusterConfigProperty(key =
GroupCoordinatorConfig.OF
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575295376
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
TaiJuWu opened a new pull request, #15782:
URL: https://github.com/apache/kafka/pull/15782
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (includi
chia7712 commented on code in PR #15761:
URL: https://github.com/apache/kafka/pull/15761#discussion_r1575290259
##
core/src/test/java/kafka/testkit/BrokerNode.java:
##
@@ -66,11 +74,27 @@ public Builder setNumLogDirectories(int numLogDirectories) {
return this;
chia7712 commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070865680
@TaiJuWu thanks for your contribution. Could you fix
https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776
also?
--
This is an a
TaiJuWu commented on PR #15782:
URL: https://github.com/apache/kafka/pull/15782#issuecomment-2070867568
> @TaiJuWu thanks for your contribution. Could you fix
https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/TopicCommand.java#L776
also?
Sure.
--
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575308633
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575308633
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16103:
--
Summary: AsyncKafkaConsumer: Always await async commit callbacks in
commitSync and close (was: Review
kirktrue commented on PR #15746:
URL: https://github.com/apache/kafka/pull/15746#issuecomment-2070928518
@lucasbru—Can you review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
lianetm commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1575354663
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java:
##
@@ -17,279 +17,448 @@
package org.apache.kafka.tools.consumer.group;
[
https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839850#comment-17839850
]
A. Sophie Blee-Goldman commented on KAFKA-16600:
Thanks [~aleung181] – d
kirktrue commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1575365134
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def __init__(
kirktrue commented on PR #15737:
URL: https://github.com/apache/kafka/pull/15737#issuecomment-2070963749
@lucasbru—Can you review this change to the consumer system test harness?
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-16461?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16461:
--
Reviewer: Lucas Brutschy
> New consumer fails to consume records in security_test.py system test
> ---
[
https://issues.apache.org/jira/browse/KAFKA-16565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk True updated KAFKA-16565:
--
Reviewer: Lucas Brutschy
Description:
In {{verifiable_consumer.py}}, the
{{IncrementalAssignme
appchemist opened a new pull request, #15783:
URL: https://github.com/apache/kafka/pull/15783
Remove a unnecessary "}" in logging of KafkaStreams close
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI
[
https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alex Leung updated KAFKA-16600:
---
Attachment: kafka-16600.log
> Periodically receive "Failed to transition to PENDING_SHUTDOWN, curren
[
https://issues.apache.org/jira/browse/KAFKA-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839871#comment-17839871
]
Alex Leung commented on KAFKA-16600:
Hi [~ableegoldman] – added a log with more cont
kirktrue commented on PR #15723:
URL: https://github.com/apache/kafka/pull/15723#issuecomment-2071054599
@lucasbru, @lianetm, @philipnee—I have re-introduced the `lastSentMs`
instance variable, not as a driver for logic, but for informational purposes in
the logs.
This is ready for r
kirktrue opened a new pull request, #15784:
URL: https://github.com/apache/kafka/pull/15784
WIP
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including u
Igor Soarez created KAFKA-16601:
---
Summary: Flaky test –
org.apache.kafka.controller.QuorumControllerMetricsIntegrationTest.testClosingQuorumControllerClosesMetrics()
Key: KAFKA-16601
URL: https://issues.apache.org/j
Igor Soarez created KAFKA-16602:
---
Summary: Flaky test –
org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord()
Key: KAFKA-16602
URL: https://issues.apache.org/jira/browse/KAFKA-16602
soarez commented on PR #15701:
URL: https://github.com/apache/kafka/pull/15701#issuecomment-2071198673
Failing tests are unrelated, except for
`org.apache.kafka.controller.QuorumControllerTest.testBootstrapZkMigrationRecord()`
([KAFKA-16602](https://issues.apache.org/jira/browse/KAFKA-16602
soarez merged PR #15701:
URL: https://github.com/apache/kafka/pull/15701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
[
https://issues.apache.org/jira/browse/KAFKA-16466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839902#comment-17839902
]
Igor Soarez commented on KAFKA-16466:
-
Cherry-picked to 3.7
> QuorumController is s
[
https://issues.apache.org/jira/browse/KAFKA-16514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839905#comment-17839905
]
Matthias J. Sax commented on KAFKA-16514:
-
Well, in general we can, but the inte
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16567:
Fix Version/s: (was: 4.0.0)
> Add New Stream Metrics based on KIP-869
> --
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias J. Sax updated KAFKA-16567:
Priority: Major (was: Blocker)
> Add New Stream Metrics based on KIP-869
> --
[
https://issues.apache.org/jira/browse/KAFKA-16567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839907#comment-17839907
]
Matthias J. Sax commented on KAFKA-16567:
-
Thanks Bruno – makes sense to me – sh
[
https://issues.apache.org/jira/browse/KAFKA-16585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839910#comment-17839910
]
Matthias J. Sax commented on KAFKA-16585:
-
Well, the use-case make sense, but th
kamalcph commented on PR #15748:
URL: https://github.com/apache/kafka/pull/15748#issuecomment-2071274526
@showuon
Test failures are fixed! Please take another look. Let me know if we have to
fix the tests in 3.7 and trunk (but they weren't flaky).
--
This is an automated message f
kamalcph commented on PR #15780:
URL: https://github.com/apache/kafka/pull/15780#issuecomment-2071280063
Test failures are unrelated. 3 remote storage tests were failed, those are
existing flaky tests.
--
This is an automated message from the Apache Git Service.
To respond to the message,
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575558298
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTest {
showuon merged PR #15780:
URL: https://github.com/apache/kafka/pull/15780
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
showuon commented on code in PR #15748:
URL: https://github.com/apache/kafka/pull/15748#discussion_r1575561675
##
core/src/test/scala/unit/kafka/log/LogCleanerParameterizedIntegrationTest.scala:
##
@@ -121,9 +121,9 @@ class LogCleanerParameterizedIntegrationTest extends
Abstrac
Anil Dasari created KAFKA-16603:
---
Summary: Data loss when kafka connect sending data to Kafka
Key: KAFKA-16603
URL: https://issues.apache.org/jira/browse/KAFKA-16603
Project: Kafka
Issue Type:
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTe
FrankYang0529 commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575583127
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTe
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anil Dasari updated KAFKA-16603:
Description:
We are experiencing a data loss when Kafka Source connector is failed to send
data t
[
https://issues.apache.org/jira/browse/KAFKA-16603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anil Dasari updated KAFKA-16603:
Description:
We are experiencing a data loss when Kafka Source connector is failed to send
data t
showuon commented on code in PR #15616:
URL: https://github.com/apache/kafka/pull/15616#discussion_r1575591635
##
core/src/test/scala/unit/kafka/server/AlterReplicaLogDirsRequestTest.scala:
##
@@ -116,6 +124,56 @@ class AlterReplicaLogDirsRequestTest extends
BaseRequestTest {
github-actions[bot] commented on PR #15231:
URL: https://github.com/apache/kafka/pull/15231#issuecomment-2071344453
This PR is being marked as stale since it has not had any activity in 90
days. If you would like to keep this PR alive, please ask a committer for
review. If the PR has merge
rreddy-22 opened a new pull request, #15785:
URL: https://github.com/apache/kafka/pull/15785
When all the subscriptions are equal, we iterate through every member and
check equality for the topic lists - very expensive when there’s more members
--
This is an automated message from the
showuon commented on PR #15773:
URL: https://github.com/apache/kafka/pull/15773#issuecomment-2071375745
> Yeah, I tried to use unit test. However, I didn't find a good way to check
whether kafka-delete-logs task has run or not. I also tried to check whether
scheduler can be stopped. However
vamossagar12 commented on PR #13283:
URL: https://github.com/apache/kafka/pull/13283#issuecomment-2071431998
No worries and thanks for the proposed help! There are some things which I
need to close out but I do hope to close it out.
--
This is an automated message from the Apache Git Ser
101 - 175 of 175 matches
Mail list logo
