[jira] [Commented] (KAFKA-5627) Reduce classes needed for LeaderAndIsrPartitionState and MetadataPartitionState

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097484#comment-16097484
 ] 

ASF GitHub Bot commented on KAFKA-5627:
---

GitHub user lindong28 opened a pull request:

https://github.com/apache/kafka/pull/3565

KAFKA-5627; Reduce classes needed for LeaderAndIsrPartitionState and 
MetadataPartitionState



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lindong28/kafka KAFKA-5627

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3565.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3565


commit e42e6a2391313b66874d612195a1bf904f93e8d5
Author: Dong Lin 
Date:   2017-07-23T02:35:41Z

KAFKA-5627; Reduce classes needed for LeaderAndIsrPartitionState and 
MetadataPartitionState




> Reduce classes needed for LeaderAndIsrPartitionState and 
> MetadataPartitionState
> ---
>
> Key: KAFKA-5627
> URL: https://issues.apache.org/jira/browse/KAFKA-5627
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Dong Lin
>Assignee: Dong Lin
>
> It will be cleaner to replace LeaderAndIsrPartitionState and 
> MetadataPartitionState in LeaderAndIsr.scala with 
> org.apache.kafka.common.requests.PartitionState and
> UpdateMetadataRequest.PartitionState respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (KAFKA-5627) Reduce classes needed for LeaderAndIsrPartitionState and MetadataPartitionState

[Dong Lin (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-5627?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dong Lin reassigned KAFKA-5627:
---

Assignee: Dong Lin

> Reduce classes needed for LeaderAndIsrPartitionState and 
> MetadataPartitionState
> ---
>
> Key: KAFKA-5627
> URL: https://issues.apache.org/jira/browse/KAFKA-5627
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Dong Lin
>Assignee: Dong Lin
>
> It will be cleaner to replace LeaderAndIsrPartitionState and 
> MetadataPartitionState in LeaderAndIsr.scala with 
> org.apache.kafka.common.requests.PartitionState and
> UpdateMetadataRequest.PartitionState respectively.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-4763) Handle disk failure for JBOD (KIP-112)

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097414#comment-16097414
 ] 

ASF GitHub Bot commented on KAFKA-4763:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/2929


> Handle disk failure for JBOD (KIP-112)
> --
>
> Key: KAFKA-4763
> URL: https://issues.apache.org/jira/browse/KAFKA-4763
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Dong Lin
>Assignee: Dong Lin
>
> See 
> https://cwiki.apache.org/confluence/display/KAFKA/KIP-112%3A+Handle+disk+failure+for+JBOD
>  for motivation and design.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (KAFKA-4750) KeyValueIterator returns null values

[Matthias J. Sax (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097368#comment-16097368
 ] 

Matthias J. Sax edited comment on KAFKA-4750 at 7/22/17 3:41 PM:
-

IMHO, we can also improve the code by not calling the serializer in the first 
place if we get a {{put(key, null)}}. Thus, we can insure that {{rawValue}} 
will be {{null}} even if the serializer might not return {{null}}.


was (Author: mjsax):
IMHO, we can also improve the code by not calling the serializer in the first 
place if we get a `put(key, null)`. Thus, we can insure that `rawValue` will be 
`null` even if the serializer might not return `null`.

> KeyValueIterator returns null values
> 
>
> Key: KAFKA-4750
> URL: https://issues.apache.org/jira/browse/KAFKA-4750
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Michal Borowiecki
>Assignee: Evgeny Veretennikov
>  Labels: newbie
> Attachments: DeleteTest.java
>
>
> The API for ReadOnlyKeyValueStore.range method promises the returned iterator 
> will not return null values. However, after upgrading from 0.10.0.0 to 
> 0.10.1.1 we found null values are returned causing NPEs on our side.
> I found this happens after removing entries from the store and I found 
> resemblance to SAMZA-94 defect. The problem seems to be as it was there, when 
> deleting entries and having a serializer that does not return null when null 
> is passed in, the state store doesn't actually delete that key/value pair but 
> the iterator will return null value for that key.
> When I modified our serilizer to return null when null is passed in, the 
> problem went away. However, I believe this should be fixed in kafka streams, 
> perhaps with a similar approach as SAMZA-94.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-4750) KeyValueIterator returns null values

[Matthias J. Sax (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097368#comment-16097368
 ] 

Matthias J. Sax commented on KAFKA-4750:


IMHO, we can also improve the code by not calling the serializer in the first 
place if we get a `put(key, null)`. Thus, we can insure that `rawValue` will be 
`null` even if the serializer might not return `null`.

> KeyValueIterator returns null values
> 
>
> Key: KAFKA-4750
> URL: https://issues.apache.org/jira/browse/KAFKA-4750
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Michal Borowiecki
>Assignee: Evgeny Veretennikov
>  Labels: newbie
> Attachments: DeleteTest.java
>
>
> The API for ReadOnlyKeyValueStore.range method promises the returned iterator 
> will not return null values. However, after upgrading from 0.10.0.0 to 
> 0.10.1.1 we found null values are returned causing NPEs on our side.
> I found this happens after removing entries from the store and I found 
> resemblance to SAMZA-94 defect. The problem seems to be as it was there, when 
> deleting entries and having a serializer that does not return null when null 
> is passed in, the state store doesn't actually delete that key/value pair but 
> the iterator will return null value for that key.
> When I modified our serilizer to return null when null is passed in, the 
> problem went away. However, I believe this should be fixed in kafka streams, 
> perhaps with a similar approach as SAMZA-94.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Comment Edited] (KAFKA-4750) KeyValueIterator returns null values

[Evgeny Veretennikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097357#comment-16097357
 ] 

Evgeny Veretennikov edited comment on KAFKA-4750 at 7/22/17 3:02 PM:
-

So, to sum up discussion. I should close current PR and create new PR with 
javadoc change, as [~guozhang] suggested. Am I right?


was (Author: evis):
So, to sum up discussion. I should close current PR and create new PR with 
javadoc changing, as [~guozhang] suggested. Am I right?

> KeyValueIterator returns null values
> 
>
> Key: KAFKA-4750
> URL: https://issues.apache.org/jira/browse/KAFKA-4750
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Michal Borowiecki
>Assignee: Evgeny Veretennikov
>  Labels: newbie
> Attachments: DeleteTest.java
>
>
> The API for ReadOnlyKeyValueStore.range method promises the returned iterator 
> will not return null values. However, after upgrading from 0.10.0.0 to 
> 0.10.1.1 we found null values are returned causing NPEs on our side.
> I found this happens after removing entries from the store and I found 
> resemblance to SAMZA-94 defect. The problem seems to be as it was there, when 
> deleting entries and having a serializer that does not return null when null 
> is passed in, the state store doesn't actually delete that key/value pair but 
> the iterator will return null value for that key.
> When I modified our serilizer to return null when null is passed in, the 
> problem went away. However, I believe this should be fixed in kafka streams, 
> perhaps with a similar approach as SAMZA-94.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-4750) KeyValueIterator returns null values

[Evgeny Veretennikov (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097357#comment-16097357
 ] 

Evgeny Veretennikov commented on KAFKA-4750:


So, to sum up discussion. I should close current PR and create new PR with 
javadoc changing, as [~guozhang] suggested. Am I right?

> KeyValueIterator returns null values
> 
>
> Key: KAFKA-4750
> URL: https://issues.apache.org/jira/browse/KAFKA-4750
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Affects Versions: 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Michal Borowiecki
>Assignee: Evgeny Veretennikov
>  Labels: newbie
> Attachments: DeleteTest.java
>
>
> The API for ReadOnlyKeyValueStore.range method promises the returned iterator 
> will not return null values. However, after upgrading from 0.10.0.0 to 
> 0.10.1.1 we found null values are returned causing NPEs on our side.
> I found this happens after removing entries from the store and I found 
> resemblance to SAMZA-94 defect. The problem seems to be as it was there, when 
> deleting entries and having a serializer that does not return null when null 
> is passed in, the state store doesn't actually delete that key/value pair but 
> the iterator will return null value for that key.
> When I modified our serilizer to return null when null is passed in, the 
> problem went away. However, I believe this should be fixed in kafka streams, 
> perhaps with a similar approach as SAMZA-94.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-4501) Support Java 9

[Ismael Juma (JIRA)]

[ 
https://issues.apache.org/jira/browse/KAFKA-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16097188#comment-16097188
 ] 

Ismael Juma commented on KAFKA-4501:


Gradle 4.1 includes a number of fixes for Java 9 including the fix for the NPE 
as part of the upgrade to Zinc 0.3.15:

https://github.com/gradle/gradle/releases/tag/v4.1.0-RC1

There are a couple of cases (somewhat easy to workaround) where Scala code no 
longer compiles with Java 9:

https://github.com/scala/bug/issues/10418

The next issue is that neither EasyMock or PowerMock work with Java 9:

https://github.com/easymock/easymock/issues/193
https://github.com/powermock/powermock/issues/783

> Support Java 9
> --
>
> Key: KAFKA-4501
> URL: https://issues.apache.org/jira/browse/KAFKA-4501
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Ismael Juma
>Assignee: Ismael Juma
> Fix For: 0.11.1.0
>
>
> Java 9 is scheduled to be released in July 2017. We should support it.
> The new module system enforces access control and things like `setAccessible` 
> cannot, by default, be used to circumvent access control in other modules. 
> There are command-line flags available to disable the behaviour on a module 
> by module basis.
> Right now, Gradle fails with the latest Java 9 snapshot and Scala 2.12.1 is 
> required if building with Java 9. So we are blocked until the Gradle issues 
> are fixed.
> I set the "Fix version" to 0.10.2.0, but it's likely to happen for the 
> release after that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Assigned] (KAFKA-4501) Support Java 9

[Ismael Juma (JIRA)]

 [ 
https://issues.apache.org/jira/browse/KAFKA-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ismael Juma reassigned KAFKA-4501:
--

Assignee: Ismael Juma

> Support Java 9
> --
>
> Key: KAFKA-4501
> URL: https://issues.apache.org/jira/browse/KAFKA-4501
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Ismael Juma
>Assignee: Ismael Juma
> Fix For: 0.11.1.0
>
>
> Java 9 is scheduled to be released in July 2017. We should support it.
> The new module system enforces access control and things like `setAccessible` 
> cannot, by default, be used to circumvent access control in other modules. 
> There are command-line flags available to disable the behaviour on a module 
> by module basis.
> Right now, Gradle fails with the latest Java 9 snapshot and Scala 2.12.1 is 
> required if building with Java 9. So we are blocked until the Gradle issues 
> are fixed.
> I set the "Fix version" to 0.10.2.0, but it's likely to happen for the 
> release after that.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)