[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411866242 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411866042 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411864699 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411864205 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411863881 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411863591 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411858555 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1610,79 +1610,6 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411858808 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1610,79 +1610,6 @@ public

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088262#comment-17088262 ] Matthias J. Sax commented on KAFKA-9013:

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411847662 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[jira] [Created] (KAFKA-9897) Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores

Matthias J. Sax created KAFKA-9897: -- Summary: Flaky Test StoreQueryIntegrationTest#shouldQuerySpecificActivePartitionStores Key: KAFKA-9897 URL: https://issues.apache.org/jira/browse/KAFKA-9897

[jira] [Created] (KAFKA-9896) Flaky Test StandbyTaskEOSIntegrationTest#surviveWithOneTaskAsStandby[exactly_once_beta]

Matthias J. Sax created KAFKA-9896: -- Summary: Flaky Test StandbyTaskEOSIntegrationTest#surviveWithOneTaskAsStandby[exactly_once_beta] Key: KAFKA-9896 URL: https://issues.apache.org/jira/browse/KAFKA-9896

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411846617 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411845809 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616934105 Java 8: `org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.surviveWithOneTaskAsStandby[exactly_once_beta]` Java 11:

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411841909 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411840027 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411828565 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411828397 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r41182 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[jira] [Commented] (KAFKA-9868) Flaky Test EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore

[ https://issues.apache.org/jira/browse/KAFKA-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088233#comment-17088233 ] Boyang Chen commented on KAFKA-9868: [https://github.com/apache/kafka/pull/8522] > Flaky Test >

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616917436 Got 2/3 green, one failed test is due to ``` kafka.api.SaslSslConsumerTest.testCoordinatorFailover java.lang.AssertionError: expected: but was: ```

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411826785 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411826782 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411825756 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411821681 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411818919 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411818806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[jira] [Created] (KAFKA-9895) Truncation request on broker start up may cause OffsetOutOfRangeException

Boquan Tang created KAFKA-9895: -- Summary: Truncation request on broker start up may cause OffsetOutOfRangeException Key: KAFKA-9895 URL: https://issues.apache.org/jira/browse/KAFKA-9895 Project: Kafka

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411815724 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411815738 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411814466 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813832 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813351 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813053 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411812127 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411810700 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[jira] [Commented] (KAFKA-9224) State store should not see uncommitted transaction result

[ https://issues.apache.org/jira/browse/KAFKA-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088201#comment-17088201 ] John Roesler commented on KAFKA-9224: - Thanks [~mjsax] , This is a really good point. Actually, we

[jira] [Commented] (KAFKA-9882) Add Block getAssignments()

[ https://issues.apache.org/jira/browse/KAFKA-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088199#comment-17088199 ] Jesse Anderson commented on KAFKA-9882: --- The use case is whenever you have to call a KafkaConsumer

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411799045 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411797135 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411797135 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] highluck commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

highluck commented on a change in pull request #8114: URL: https://github.com/apache/kafka/pull/8114#discussion_r411791026 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -208,13 +208,13 @@ * streamBuilder.table(topic,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411787822 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411779855 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with Logging {

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411779358 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ijuma commented on issue #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-616875521 Unrelated flaky test: > org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta]

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411743597 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411739644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411739644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411738965 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] mjsax commented on issue #8114: KAFKA-9290: Update IQ related JavaDocs

mjsax commented on issue #8114: URL: https://github.com/apache/kafka/pull/8114#issuecomment-616848801 Ah. Thanks for pointing out the hotfix @highluck. Can you address Sophie's comment? This is an automated message from the

[jira] [Commented] (KAFKA-9224) State store should not see uncommitted transaction result

[ https://issues.apache.org/jira/browse/KAFKA-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088143#comment-17088143 ] Matthias J. Sax commented on KAFKA-9224: What you say makes sense. However, I believe that this

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411734468 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -89,95 +88,72 @@

[GitHub] [kafka] LiamClarkeNZ commented on issue #8520: Add explicit grace period to tumbling window example

LiamClarkeNZ commented on issue #8520: URL: https://github.com/apache/kafka/pull/8520#issuecomment-616842780 Yep, fine by me. :) On Tue, Apr 21, 2020 at 9:32 AM John Roesler wrote: > *@vvcephei* commented on this pull request. > > Hey @LiamClarkeNZ

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616840036 @mjsax I suppose this should help for all integration tests, as they share `EmbeddedBroker` This is an automated

[jira] [Comment Edited] (KAFKA-8924) Default grace period (-1) of TimeWindows causes suppress to emit events after 24h

[ https://issues.apache.org/jira/browse/KAFKA-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088093#comment-17088093 ] John Roesler edited comment on KAFKA-8924 at 4/20/20, 10:14 PM: Hey

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616839537 Run 350 times on local and no failure. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] abbccdda commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411727585 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -84,7 +84,7 @@ public

[jira] [Resolved] (KAFKA-9894) Support Java 14

[ https://issues.apache.org/jira/browse/KAFKA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-9894. Resolution: Fixed Fixed via [https://github.com/apache/kafka/pull/8519. 

[jira] [Commented] (KAFKA-9224) State store should not see uncommitted transaction result

[ https://issues.apache.org/jira/browse/KAFKA-9224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088126#comment-17088126 ] John Roesler commented on KAFKA-9224: - Thanks for the points, all. I think my objection is partly

[jira] [Updated] (KAFKA-9894) Support Java 14

[ https://issues.apache.org/jira/browse/KAFKA-9894?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-9894: --- Description: There have been 3 releases since Java 11, so we are halfway to the next long-term

[jira] [Created] (KAFKA-9894) Support Java 14

Ismael Juma created KAFKA-9894: -- Summary: Support Java 14 Key: KAFKA-9894 URL: https://issues.apache.org/jira/browse/KAFKA-9894 Project: Kafka Issue Type: Improvement Reporter:

[GitHub] [kafka] mjsax commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

mjsax commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411719647 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -84,7 +84,7 @@ public

[GitHub] [kafka] mjsax commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

mjsax commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616831664 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616828656 Updated this PR. Will merge after Jenkins passe. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] mjsax commented on a change in pull request #8508: MINOR: Improve usage of LogCaptureAppender

mjsax commented on a change in pull request #8508: URL: https://github.com/apache/kafka/pull/8508#discussion_r411712314 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -84,6 +87,10 @@ @Before

[GitHub] [kafka] vvcephei commented on a change in pull request #8520: Add explicit grace period to tumbling window example

vvcephei commented on a change in pull request #8520: URL: https://github.com/apache/kafka/pull/8520#discussion_r411704050 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -3262,12 +3262,15 @@ KTable-KTable Foreign-Key import

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

ConcurrencyPractitioner commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616819297 @junrao Alright, got it done. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #8523: Adding github whitelist

ConcurrencyPractitioner commented on issue #8523: URL: https://github.com/apache/kafka/pull/8523#issuecomment-616818171 @junrao So then we can merge this, right? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] ConcurrencyPractitioner opened a new pull request #8523: Adding github whitelist

ConcurrencyPractitioner opened a new pull request #8523: URL: https://github.com/apache/kafka/pull/8523 This PR is meant to add ConcurrencyPractitioner to the Jenkins whitelist so that this user can trigger tests. This

[jira] [Assigned] (KAFKA-9893) Configurable TCP connection timeout for AdminClient

[ https://issues.apache.org/jira/browse/KAFKA-9893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cheng Tan reassigned KAFKA-9893: Assignee: Cheng Tan > Configurable TCP connection timeout for AdminClient >

[jira] [Commented] (KAFKA-8924) Default grace period (-1) of TimeWindows causes suppress to emit events after 24h

[ https://issues.apache.org/jira/browse/KAFKA-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088093#comment-17088093 ] John Roesler commented on KAFKA-8924: - Hey [~atais] , it's been quite a while since the last activity

[jira] [Created] (KAFKA-9893) Configurable TCP connection timeout for AdminClient

Cheng Tan created KAFKA-9893: Summary: Configurable TCP connection timeout for AdminClient Key: KAFKA-9893 URL: https://issues.apache.org/jira/browse/KAFKA-9893 Project: Kafka Issue Type: New

[jira] [Comment Edited] (KAFKA-8924) Default grace period (-1) of TimeWindows causes suppress to emit events after 24h

[ https://issues.apache.org/jira/browse/KAFKA-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088091#comment-17088091 ] John Roesler edited comment on KAFKA-8924 at 4/20/20, 9:20 PM: --- I just had

[jira] [Commented] (KAFKA-8924) Default grace period (-1) of TimeWindows causes suppress to emit events after 24h

[ https://issues.apache.org/jira/browse/KAFKA-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088091#comment-17088091 ] John Roesler commented on KAFKA-8924: - I just had another conversation with someone else who got bit

[jira] [Commented] (KAFKA-9882) Add Block getAssignments()

[ https://issues.apache.org/jira/browse/KAFKA-9882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088086#comment-17088086 ] Boyang Chen commented on KAFKA-9882: Thanks for the ticket. Are there any concrete use cases for

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r411692621 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616808689 @vvcephei @mjsax Call for a review This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616806079 Java 8 passed. Java11: `kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup` Java14 failed due to #8519 (already merged).

[GitHub] [kafka] ijuma commented on issue #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

ijuma commented on issue #8519: URL: https://github.com/apache/kafka/pull/8519#issuecomment-616802690 2 flaky tests, one in each job: * org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta] *

[GitHub] [kafka] abbccdda commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411680309 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -98,6 +98,7 @@ public void start() throws

[GitHub] [kafka] abbccdda opened a new pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

abbccdda opened a new pull request #8522: URL: https://github.com/apache/kafka/pull/8522 This PR tries to fix the flaky EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore by making the bootstrapping of the test to be less painful with fewer number of

[jira] [Updated] (KAFKA-9868) Flaky Test EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore

[ https://issues.apache.org/jira/browse/KAFKA-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen updated KAFKA-9868: --- Description: h3. Error Message java.lang.AssertionError: Condition not met within timeout 15000.

[jira] [Assigned] (KAFKA-9868) Flaky Test EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore

[ https://issues.apache.org/jira/browse/KAFKA-9868?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-9868: -- Assignee: Boyang Chen > Flaky Test >

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411676361 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411673115 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411672041 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ValidClientsByTaskLoadQueue.java ## @@ -0,0 +1,108 @@ +/* + *

[GitHub] [kafka] vvcephei commented on a change in pull request #8508: MINOR: Improve usage of LogCaptureAppender

vvcephei commented on a change in pull request #8508: URL: https://github.com/apache/kafka/pull/8508#discussion_r411667311 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -84,6 +87,10 @@ @Before

[GitHub] [kafka] junrao commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

junrao commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616787194 @ConcurrencyPractitioner : You can just submit a separate PR to add yourself in .asf.yml. This is an automated message

[GitHub] [kafka] soenkeliebau commented on issue #8464: KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms

soenkeliebau commented on issue #8464: URL: https://github.com/apache/kafka/pull/8464#issuecomment-616782288 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] cadonna commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

cadonna commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411366111 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -89,95 +88,72 @@

[GitHub] [kafka] cmccabe commented on a change in pull request #8396: KAFKA-9754 - Trogdor - Ignore produce errors, better error statistics.

cmccabe commented on a change in pull request #8396: URL: https://github.com/apache/kafka/pull/8396#discussion_r411654793 ## File path: tools/src/main/java/org/apache/kafka/trogdor/workload/ProduceBenchSpec.java ## @@ -72,6 +75,8 @@ private final TopicsSpec activeTopics;

[jira] [Assigned] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-9891: -- Assignee: Boyang Chen > Invalid state store content after task migration with exactly_once

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088044#comment-17088044 ] Boyang Chen commented on KAFKA-9891: Thanks for the report, will take a look this week. > Invalid

  1   2   >