[jira] [Updated] (KAFKA-10143) Can no longer change replication throttle with reassignment tool

2020-06-10 Thread Jason Gustafson (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-10143: Description: Previously we could use --execute with the --throttle option in order to

[GitHub] [kafka] aakashnshah commented on pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-10 Thread GitBox
aakashnshah commented on pull request #8829: URL: https://github.com/apache/kafka/pull/8829#issuecomment-642418469 I've updated the KIP: https://cwiki.apache.org/confluence/display/KAFKA/KIP-610%3A+Error+Reporting+in+Sink+Connectors @rhauch @wicknicks

[jira] [Resolved] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9216. -- Reviewer: Randall Hauch Resolution: Fixed Merged to `trunk` the second PR that enforces

[jira] [Resolved] (KAFKA-9845) plugin.path property does not work with config provider

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9845. -- Fix Version/s: 2.7.0 Reviewer: Randall Hauch Resolution: Fixed Merged to

[jira] [Resolved] (KAFKA-6942) Connect connectors api doesn't show versions of connectors

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-6942. -- Resolution: Invalid I'm going to close this as INVALID because the versions are available in

[GitHub] [kafka] kkonstantine commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642405060 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642404708 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kkonstantine commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642404597 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] C0urante commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642402730 I believe I've identified the cause of the failure in https://builds.apache.org/job/kafka-pr-jdk14-scala2.13/1048. I've pushed a new commit to fix the logic; it passed tests

[jira] [Resolved] (KAFKA-10115) Incorporate errors.tolerance with the Errant Record Reporter

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-10115. --- Reviewer: Randall Hauch Resolution: Fixed Merged to `2.6` rather than `trunk`

[jira] [Resolved] (KAFKA-9066) Kafka Connect JMX : source & sink task metrics missing for tasks in failed state

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch resolved KAFKA-9066. -- Fix Version/s: 2.7.0 Reviewer: Randall Hauch Resolution: Fixed Merged to

[GitHub] [kafka] vvcephei commented on a change in pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
vvcephei commented on a change in pull request #8851: URL: https://github.com/apache/kafka/pull/8851#discussion_r438533186 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -959,28 +992,23 @@ private void

[GitHub] [kafka] mjsax commented on pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on pull request #8851: URL: https://github.com/apache/kafka/pull/8851#issuecomment-642396153 Closing in favor of #8852 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax closed pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax closed pull request #8851: URL: https://github.com/apache/kafka/pull/8851 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533555 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533429 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -97,13 +97,9 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533374 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -57,30 +59,31 @@ * @param stateDirectory the

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533205 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -16,82 +16,85 @@ */ package

[GitHub] [kafka] mjsax commented on a change in pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8852: URL: https://github.com/apache/kafka/pull/8852#discussion_r438533174 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -16,82 +16,85 @@ */ package

[GitHub] [kafka] mjsax opened a new pull request #8852: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax opened a new pull request #8852: URL: https://github.com/apache/kafka/pull/8852 Not functional change. Pure code cleanup Call for review @vvcephei This is an automated message from the Apache Git Service. To

[GitHub] [kafka] brary commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-06-10 Thread GitBox
brary commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642394605 LGTM! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642394105 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8851: URL: https://github.com/apache/kafka/pull/8851#discussion_r438531936 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -116,89 +112,100 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8851: URL: https://github.com/apache/kafka/pull/8851#discussion_r438531698 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -97,13 +97,9 @@ public boolean isValidTransition(final

[GitHub] [kafka] mjsax commented on a change in pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8851: URL: https://github.com/apache/kafka/pull/8851#discussion_r438531571 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -97,13 +97,9 @@ public boolean isValidTransition(final

[GitHub] [kafka] brary commented on a change in pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-06-10 Thread GitBox
brary commented on a change in pull request #8200: URL: https://github.com/apache/kafka/pull/8200#discussion_r438531599 ## File path: streams/src/main/java/org/apache/kafka/streams/errors/InvalidStateStoreException.java ## @@ -18,13 +18,11 @@ /** - * Indicates that there

[jira] [Commented] (KAFKA-9841) Connector and Task duplicated when a worker join with old generation assignment

2020-06-10 Thread Yu Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132901#comment-17132901 ] Yu Wang commented on KAFKA-9841: Thank you for checking [~vvcephei]  and thank you for your help 

[GitHub] [kafka] mjsax commented on a change in pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8851: URL: https://github.com/apache/kafka/pull/8851#discussion_r438531045 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/AbstractTask.java ## @@ -16,82 +16,85 @@ */ package

[jira] [Commented] (KAFKA-9270) KafkaStream crash on offset commit failure

2020-06-10 Thread Rohan Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132899#comment-17132899 ] Rohan Kulkarni commented on KAFKA-9270: --- [~mjsax] - Sure. I will track the other issue KAFKA-9274

[jira] [Created] (KAFKA-10146) Backport KAFKA-9066 to 2.5 and 2.4 branches

2020-06-10 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10146: - Summary: Backport KAFKA-9066 to 2.5 and 2.4 branches Key: KAFKA-10146 URL: https://issues.apache.org/jira/browse/KAFKA-10146 Project: Kafka Issue Type:

[GitHub] [kafka] mjsax opened a new pull request #8851: MINOR: code cleanup for Kafka Streams task classes

2020-06-10 Thread GitBox
mjsax opened a new pull request #8851: URL: https://github.com/apache/kafka/pull/8851 Not functional change. Pure code cleanup Call for review @vvcephei This is an automated message from the Apache Git Service. To

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642392428 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642391750 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642391773 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642391327 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642391433 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642391252 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] C0urante commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
C0urante commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642390162 Fixed the merge conflicts; should be safe to do a new test run now. This is an automated message from the Apache

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642388373 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642388044 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642387968 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642387910 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] rhauch merged pull request #8829: KAFKA-10115: Incorporate errors.tolerance with the Errant Record Reporter

2020-06-10 Thread GitBox
rhauch merged pull request #8829: URL: https://github.com/apache/kafka/pull/8829 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10086) Standby state isn't always re-used when transitioning to active

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Description: This ticket was initially just to write an integration test, but I escalated it

[GitHub] [kafka] vitojeng commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-06-10 Thread GitBox
vitojeng commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642387584 Got it! This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (KAFKA-9216) Enforce connect internal topic configuration at startup

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132887#comment-17132887 ] Randall Hauch commented on KAFKA-9216: -- Thanks, [~ChrisEgerton]. I think we came to consensus on the

[GitHub] [kafka] rhauch merged pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-10 Thread GitBox
rhauch merged pull request #8828: URL: https://github.com/apache/kafka/pull/8828 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-10086) Cooperative Rebalance causes standby state not to be re-used when transitioning to active

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Description: This ticket was initially just to write an integration test, but I escalated it

[GitHub] [kafka] kkonstantine commented on pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-06-10 Thread GitBox
kkonstantine commented on pull request #8069: URL: https://github.com/apache/kafka/pull/8069#issuecomment-642386762 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
ableegoldman commented on a change in pull request #8849: URL: https://github.com/apache/kafka/pull/8849#discussion_r438524798 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -137,7 +137,7 @@ public void resume() {

[jira] [Updated] (KAFKA-10086) Standby state isn't always re-used when transitioning to active

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Summary: Standby state isn't always re-used when transitioning to active (was: Cooperative

[jira] [Updated] (KAFKA-10086) Cooperative Rebalance causes standby state not to be re-used when transitioning to active

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Summary: Cooperative Rebalance causes standby state not to be re-used when transitioning to

[jira] [Updated] (KAFKA-10086) Cooperative Rebalance causes standby state not to be re-used when transitioning to active

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Description: This ticket was initially just to write an integration test, but I escalated it

[jira] [Updated] (KAFKA-10086) Write Integration Test for StreamsTaskAssignor/HighAvailabilityTaskAssignor

2020-06-10 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10086?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10086: - Priority: Blocker (was: Critical) > Write Integration Test for

[GitHub] [kafka] ableegoldman commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
ableegoldman commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642386255 Alright, tests/checkstyle/etc are all ready for the builds to be triggered This is an automated message from

[GitHub] [kafka] skaundinya15 opened a new pull request #8850: KAFKA-10141: Add more detail to log segment delete messages

2020-06-10 Thread GitBox
skaundinya15 opened a new pull request #8850: URL: https://github.com/apache/kafka/pull/8850 As specified in https://issues.apache.org/jira/browse/KAFKA-10141, it would be helpful to include as much information as possible when deleting log segments. This patch introduces log messages

[jira] [Updated] (KAFKA-9066) Kafka Connect JMX : source & sink task metrics missing for tasks in failed state

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9066: - Fix Version/s: 2.6.0 > Kafka Connect JMX : source & sink task metrics missing for tasks in

[GitHub] [kafka] rhauch commented on a change in pull request #8828: KAFKA-9216: Enforce that Connect’s internal topics use `compact` cleanup policy

2020-06-10 Thread GitBox
rhauch commented on a change in pull request #8828: URL: https://github.com/apache/kafka/pull/8828#discussion_r438521713 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/util/TopicAdmin.java ## @@ -375,6 +383,162 @@ public boolean createTopic(NewTopic

[jira] [Resolved] (KAFKA-9653) Duplicate tasks on workers after rebalance

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-9653. --- Resolution: Duplicate > Duplicate tasks on workers after rebalance >

[jira] [Updated] (KAFKA-9653) Duplicate tasks on workers after rebalance

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9653: -- Fix Version/s: 2.5.1 2.4.2 2.6.0

[jira] [Commented] (KAFKA-9653) Duplicate tasks on workers after rebalance

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132876#comment-17132876 ] Konstantine Karantasis commented on KAFKA-9653: --- Closing this issue as fixed but also

[jira] [Commented] (KAFKA-9841) Connector and Task duplicated when a worker join with old generation assignment

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132874#comment-17132874 ] Konstantine Karantasis commented on KAFKA-9841: --- This fix is now merged. Seems it can make

[GitHub] [kafka] mjsax commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
mjsax commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642381041 Btw: checkstyle failed :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on pull request #8847: KAFKA-7833: Add missing test

2020-06-10 Thread GitBox
mjsax commented on pull request #8847: URL: https://github.com/apache/kafka/pull/8847#issuecomment-642380670 Merged to `trunk` and cherry-picked to `2.6` branch. This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-9845) plugin.path property does not work with config provider

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9845: - Fix Version/s: 2.5.1 2.4.2 2.6.0 > plugin.path property

[jira] [Created] (KAFKA-10145) Enhance to support the multiple join operation

2020-06-10 Thread lqjacklee (Jira)
lqjacklee created KAFKA-10145: - Summary: Enhance to support the multiple join operation Key: KAFKA-10145 URL: https://issues.apache.org/jira/browse/KAFKA-10145 Project: Kafka Issue Type:

[jira] [Updated] (KAFKA-9985) Sink connector consuming DLQ topic may exhaust broker

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9985: - Fix Version/s: (was: 2.5.2) 2.5.1 > Sink connector consuming DLQ topic

[jira] [Updated] (KAFKA-9841) Connector and Task duplicated when a worker join with old generation assignment

2020-06-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-9841: -- Fix Version/s: 2.4.2 2.6.0 2.3.2 >

[GitHub] [kafka] rhauch merged pull request #8455: KAFKA-9845: Warn users about using config providers with plugin.path property

2020-06-10 Thread GitBox
rhauch merged pull request #8455: URL: https://github.com/apache/kafka/pull/8455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax merged pull request #8847: KAFKA-7833: Add missing test

2020-06-10 Thread GitBox
mjsax merged pull request #8847: URL: https://github.com/apache/kafka/pull/8847 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] vvcephei commented on a change in pull request #8818: KAFKA-10086: Integration test for ensuring warmups are effective

2020-06-10 Thread GitBox
vvcephei commented on a change in pull request #8818: URL: https://github.com/apache/kafka/pull/8818#discussion_r438517226 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -86,7 +87,7 @@ private boolean

[GitHub] [kafka] rhauch merged pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
rhauch merged pull request #8502: URL: https://github.com/apache/kafka/pull/8502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on pull request #8200: KAFKA-5876: IQ should throw different exceptions for different errors(part 1)

2020-06-10 Thread GitBox
mjsax commented on pull request #8200: URL: https://github.com/apache/kafka/pull/8200#issuecomment-642377008 @vitojeng -- Jenkins got locked down a couple of week ago. Only committer can trigger builds now. This is an

[GitHub] [kafka] vvcephei commented on pull request #8818: KAFKA-10086: Integration test for ensuring warmups are effective

2020-06-10 Thread GitBox
vvcephei commented on pull request #8818: URL: https://github.com/apache/kafka/pull/8818#issuecomment-642376894 Thanks for the review, @mjsax ; I've addressed your comments. This is an automated message from the Apache Git

[GitHub] [kafka] C0urante commented on pull request #8455: KAFKA-9845: Warn users about using config providers with plugin.path property

2020-06-10 Thread GitBox
C0urante commented on pull request #8455: URL: https://github.com/apache/kafka/pull/8455#issuecomment-642375059 @rhauch fine by me, applied the suggestions. Thanks for taking a look! This is an automated message from the

[GitHub] [kafka] vvcephei commented on pull request #8835: MINOR: reduce sizeInBytes for percentiles metrics

2020-06-10 Thread GitBox
vvcephei commented on pull request #8835: URL: https://github.com/apache/kafka/pull/8835#issuecomment-642375091 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ableegoldman commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
ableegoldman commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642374804 Tests are still a WIP. Just wanted to open it up for input on the problem/fix This is an automated message

[GitHub] [kafka] rhauch merged pull request #8848: MINOR: Fix PluginUtilsTest that resulted from a bad backport

2020-06-10 Thread GitBox
rhauch merged pull request #8848: URL: https://github.com/apache/kafka/pull/8848 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on a change in pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
mjsax commented on a change in pull request #8849: URL: https://github.com/apache/kafka/pull/8849#discussion_r438514181 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskEOSIntegrationTest.java ## @@ -92,7 +92,7 @@ public void createTopics()

[GitHub] [kafka] rhauch commented on a change in pull request #8455: KAFKA-9845: Warn users about using config providers with plugin.path property

2020-06-10 Thread GitBox
rhauch commented on a change in pull request #8455: URL: https://github.com/apache/kafka/pull/8455#discussion_r438513748 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerConfig.java ## @@ -379,6 +382,22 @@ private void

[GitHub] [kafka] mjsax commented on pull request #8835: MINOR: reduce sizeInBytes for percentiles metrics

2020-06-10 Thread GitBox
mjsax commented on pull request #8835: URL: https://github.com/apache/kafka/pull/8835#issuecomment-642373516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] vvcephei commented on pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
vvcephei commented on pull request #8849: URL: https://github.com/apache/kafka/pull/8849#issuecomment-642373459 Test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] kkonstantine commented on pull request #8848: MINOR: Fix PluginUtilsTest that resulted from a bad backport

2020-06-10 Thread GitBox
kkonstantine commented on pull request #8848: URL: https://github.com/apache/kafka/pull/8848#issuecomment-642370342 Thanks @rhauch. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] whsoul commented on pull request #7965: New Kafka Connect SMT for plainText => Struct(or Map)

2020-06-10 Thread GitBox
whsoul commented on pull request #7965: URL: https://github.com/apache/kafka/pull/7965#issuecomment-642370021 @rhauch thanks rhauch I already create JIRA issue (https://issues.apache.org/jira/browse/KAFKA-9436) but forgot label "needs-kip"... but now added Thanks~

[jira] [Updated] (KAFKA-9436) New Kafka Connect SMT for plainText => Struct(or Map)

2020-06-10 Thread whsoul (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9436?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] whsoul updated KAFKA-9436: -- Labels: needs-kip (was: ) > New Kafka Connect SMT for plainText => Struct(or Map) >

[GitHub] [kafka] rhauch edited a comment on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
rhauch edited a comment on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642360742 @C0urante the original PR description doesn't mention that the task metrics for a failed task will also be removed when the connector is deleted (in addition to the worker

[GitHub] [kafka] ableegoldman opened a new pull request #8849: KAFKA-10144: clean up corrupted standby tasks before attempting a commit

2020-06-10 Thread GitBox
ableegoldman opened a new pull request #8849: URL: https://github.com/apache/kafka/pull/8849 We need to make sure that corrupted standby tasks are actually cleaned up upon a TaskCorruptedException. However due to the `commit` prior to invoking `handleCorruption`, it's possible to throw a

[jira] [Created] (KAFKA-10144) Corrupted standby tasks are not always cleaned up

2020-06-10 Thread Sophie Blee-Goldman (Jira)
Sophie Blee-Goldman created KAFKA-10144: --- Summary: Corrupted standby tasks are not always cleaned up Key: KAFKA-10144 URL: https://issues.apache.org/jira/browse/KAFKA-10144 Project: Kafka

[GitHub] [kafka] rhauch opened a new pull request #8848: MINOR: Fix PluginUtilsTest that resulted from a bad backport

2020-06-10 Thread GitBox
rhauch opened a new pull request #8848: URL: https://github.com/apache/kafka/pull/8848 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade

[GitHub] [kafka] C0urante commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
C0urante commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642362050 @rhauch sure, I can update the description to make it clear that we will still remove task metrics when a connector is deleted.

[GitHub] [kafka] jiameixie commented on pull request #8845: KAFKA-10126:Add a warning message for ConsumerPerformance

2020-06-10 Thread GitBox
jiameixie commented on pull request #8845: URL: https://github.com/apache/kafka/pull/8845#issuecomment-642361238 @abbccdda @chia7712 Thanks for your advice. I have updated it. This is an automated message from the Apache Git

[GitHub] [kafka] rhauch commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
rhauch commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642360742 @C0urante the original description doesn't mention that the task metrics for a failed task will also be removed when the connector is deleted (in addition to the worker stopping

[GitHub] [kafka] C0urante commented on pull request #8502: KAFKA-9066: Retain metrics for failed tasks

2020-06-10 Thread GitBox
C0urante commented on pull request #8502: URL: https://github.com/apache/kafka/pull/8502#issuecomment-642357185 @rhauch it'd be nice to verify this in tests but unfortunately I didn't notice your comment earlier in the day and I don't think I have time to adjust/write new test cases to

[GitHub] [kafka] rhauch commented on a change in pull request #7496: KAFKA-9018: Throw clearer exceptions on serialisation errors

2020-06-10 Thread GitBox
rhauch commented on a change in pull request #7496: URL: https://github.com/apache/kafka/pull/7496#discussion_r438497632 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/WorkerSinkTask.java ## @@ -507,6 +508,18 @@ private SinkRecord

[jira] [Updated] (KAFKA-9067) BigDecimal conversion unnecessarily enforces the scale

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9067: - Labels: needs-kip (was: ) > BigDecimal conversion unnecessarily enforces the scale >

[jira] [Updated] (KAFKA-9318) Kafka Connect. Add map entry value extraction SMT

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-9318: - Labels: needs-kip (was: ) > Kafka Connect. Add map entry value extraction SMT >

[jira] [Updated] (KAFKA-10115) Incorporate errors.tolerance with the Errant Record Reporter

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Randall Hauch updated KAFKA-10115: -- Priority: Major (was: Minor) > Incorporate errors.tolerance with the Errant Record Reporter

[jira] [Commented] (KAFKA-10115) Incorporate errors.tolerance with the Errant Record Reporter

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132823#comment-17132823 ] Randall Hauch commented on KAFKA-10115: --- This is related to KAFKA-9971. > Incorporate

[jira] [Commented] (KAFKA-9314) Connect put() and poll() retries not conforming to KIP-298

2020-06-10 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17132822#comment-17132822 ] Randall Hauch commented on KAFKA-9314: -- This seems at least related to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8787: KAFKA-10085: correctly compute lag for optimized source changelogs

2020-06-10 Thread GitBox
ableegoldman commented on a change in pull request #8787: URL: https://github.com/apache/kafka/pull/8787#discussion_r438495057 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -763,18 +778,36 @@ private

  1   2   3   4   >