[GitHub] [kafka] abbccdda commented on a change in pull request #9103: Add redirection for (Incremental)AlterConfig

abbccdda commented on a change in pull request #9103: URL: https://github.com/apache/kafka/pull/9103#discussion_r462738230 ## File path: clients/src/main/java/org/apache/kafka/clients/ClientRequest.java ## @@ -85,11 +89,12 @@ public ApiKeys apiKey() { public RequestHeader

[jira] [Commented] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

[ https://issues.apache.org/jira/browse/KAFKA-10337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169439#comment-17169439 ] Tom Lee commented on KAFKA-10337: - Opened [https://github.com/apache/kafka/pull/9111] to address this

[GitHub] [kafka] thomaslee opened a new pull request #9111: KAFKA-10337: await async commits in commitSync even if no offsets given

thomaslee opened a new pull request #9111: URL: https://github.com/apache/kafka/pull/9111 The contract for `commitSync()` guarantees that the callbacks for all prior async commits will be invoked before it (successfully?) returns. Prior to this change the contract could be violated if

[jira] [Created] (KAFKA-10337) Wait for pending async commits in commitSync() even if no offsets are specified

Tom Lee created KAFKA-10337: --- Summary: Wait for pending async commits in commitSync() even if no offsets are specified Key: KAFKA-10337 URL: https://issues.apache.org/jira/browse/KAFKA-10337 Project: Kafka

[GitHub] [kafka] rhauch commented on pull request #9070: MINOR: speed up release script

rhauch commented on pull request #9070: URL: https://github.com/apache/kafka/pull/9070#issuecomment-667606488 Agreed! This significantly sped up putting together 2.6.0RC2. On Sat, Aug 1, 2020 at 5:35 PM Ismael Juma wrote: > Nice improvement! > > — > You are receiving

[jira] [Commented] (KAFKA-10336) Rolling upgrade with Suppression may throw exceptions

[ https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169432#comment-17169432 ] John Roesler commented on KAFKA-10336: -- Updated the title and description to correct the role of

[jira] [Updated] (KAFKA-10336) Rolling upgrade with Suppression may throw exceptions

[ https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10336: - Description: Tl;dr: If you use Suppress with changelogging enabled, you may experience

[jira] [Updated] (KAFKA-10336) Rolling upgrade with Suppression may throw exceptions

[ https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10336: - Description: Tl;dr: If you use Suppress with changelogging enabled, you may experience

[jira] [Updated] (KAFKA-10336) Rolling upgrade with Suppression may throw exceptions

[ https://issues.apache.org/jira/browse/KAFKA-10336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10336: - Summary: Rolling upgrade with Suppression may throw exceptions (was: Rolling upgrade with

[GitHub] [kafka] ijuma commented on a change in pull request #5374: MINOR: update release.py

ijuma commented on a change in pull request #5374: URL: https://github.com/apache/kafka/pull/5374#discussion_r464007379 ## File path: release.py ## @@ -479,16 +479,16 @@ def select_gpg_key(): for root, dirs, files in os.walk(artifacts_dir): assert

[GitHub] [kafka] ijuma commented on pull request #9070: MINOR: speed up release script

ijuma commented on pull request #9070: URL: https://github.com/apache/kafka/pull/9070#issuecomment-667595437 Nice improvement! This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

ijuma commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r463980962 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log

[GitHub] [kafka] dhruvilshah3 commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

dhruvilshah3 commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r463975069 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The

[jira] [Commented] (KAFKA-10303) kafka producer says connect failed in cluster mode

[ https://issues.apache.org/jira/browse/KAFKA-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169288#comment-17169288 ] Yogesh BG commented on KAFKA-10303: --- Hi this issue is resolved now, we had an issue with node ip

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463936098 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,178 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463937184 ## File path: core/src/test/scala/unit/kafka/server/UpdateFeaturesTest.scala ## @@ -0,0 +1,550 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463937032 ## File path: core/src/main/scala/kafka/server/KafkaApis.scala ## @@ -109,7 +109,9 @@ class KafkaApis(val requestChannel: RequestChannel,

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463936412 ## File path: core/src/main/scala/kafka/server/FinalizedFeatureCache.scala ## @@ -82,18 +108,54 @@ object FinalizedFeatureCache extends Logging {

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463936098 ## File path: core/src/main/scala/kafka/server/BrokerFeatures.scala ## @@ -0,0 +1,178 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463936048 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463935718 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1647,6 +1844,185 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463934948 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -1395,7 +1596,7 @@ class KafkaController(val config: KafkaConfig, if

[GitHub] [kafka] kowshik commented on a change in pull request #9001: KAFKA-10028: Implement write path for feature versioning system (KIP-584)

kowshik commented on a change in pull request #9001: URL: https://github.com/apache/kafka/pull/9001#discussion_r463934710 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -266,6 +275,179 @@ class KafkaController(val config: KafkaConfig, }

[GitHub] [kafka] kowshik commented on a change in pull request #9110: MINOR: Ensure a reason is logged for every segment deletion

kowshik commented on a change in pull request #9110: URL: https://github.com/apache/kafka/pull/9110#discussion_r463914087 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -2227,14 +2210,17 @@ class Log(@volatile private var _dir: File, * @param segments The log

[jira] [Comment Edited] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169052#comment-17169052 ] John Thomas edited comment on KAFKA-10186 at 8/1/20, 7:08 AM: --

[jira] [Comment Edited] (KAFKA-10186) Aborting transaction with pending data should throw non-fatal exception

[ https://issues.apache.org/jira/browse/KAFKA-10186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169052#comment-17169052 ] John Thomas edited comment on KAFKA-10186 at 8/1/20, 7:02 AM: --

[GitHub] [kafka] dongjinleekr commented on pull request #9007: KAFKA-10120: Deprecate DescribeLogDirsResult.all() and .values()

dongjinleekr commented on pull request #9007: URL: https://github.com/apache/kafka/pull/9007#issuecomment-667483663 @tombentley Congratulations! :congratulations: @omkreddy @mimaison Thanks again for the detailed review, as usual! :smiley:

[GitHub] [kafka] chia7712 commented on a change in pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on a change in pull request #9102: URL: https://github.com/apache/kafka/pull/9102#discussion_r463930430 ## File path: clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java ## @@ -228,6 +228,13 @@ public Password getPassword(String key) {

[GitHub] [kafka] chia7712 commented on pull request #9102: KAFKA-10326 Both serializer and deserializer should be able to see th…

chia7712 commented on pull request #9102: URL: https://github.com/apache/kafka/pull/9102#issuecomment-667482560 > Btw, I don't think this is an improvement rather than a bug, as we don't have any guarantee to see client id in serdes before. There is another reason. We do pass