[GitHub] [kafka] tombentley commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

2020-12-04 Thread GitBox
tombentley commented on pull request #9593: URL: https://github.com/apache/kafka/pull/9593#issuecomment-739139662 Thanks @rayokota, obvious in hindsight. I've opened https://github.com/apache/kafka/pull/9701 This is an

[GitHub] [kafka] tombentley commented on pull request #9701: KAFKA-10713: (redux) Also allow underscore in protocol name

2020-12-04 Thread GitBox
tombentley commented on pull request #9701: URL: https://github.com/apache/kafka/pull/9701#issuecomment-739139614 @mimaison @rayokota please take a look This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] tombentley opened a new pull request #9701: KAFKA-10713: (redux) Also allow underscore in protocol name

2020-12-04 Thread GitBox
tombentley opened a new pull request #9701: URL: https://github.com/apache/kafka/pull/9701 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-10604) The StreamsConfig.STATE_DIR_CONFIG's default value does not reflect the JVM parameter or OS-specific settings

2020-12-04 Thread Dongjin Lee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244416#comment-17244416 ] Dongjin Lee commented on KAFKA-10604: - ALL // Great. Let's continue the discussion on the PR! :D >

[GitHub] [kafka] dongjinleekr commented on pull request #8404: KAFKA-10787: Introduce an import order in Java sources

2020-12-04 Thread GitBox
dongjinleekr commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-739135617 @mjsax And here are some explanation of why I did not adopt any auto-import reorganization or auto-formatting. At first, I tried to add some configuration to

[GitHub] [kafka] dongjinleekr commented on pull request #8404: KAFKA-10787: Introduce an import order in Java sources

2020-12-04 Thread GitBox
dongjinleekr commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-739135487 @mjsax Rebased onto the latest trunk. Since this PR touches so many files, this PR will be broken every time the latest trunk updates. I will follow up on the latest trunk

[GitHub] [kafka] dongjinleekr commented on pull request #9414: KAFKA-10585: Kafka Streams should clean up the state store directory from cleanup

2020-12-04 Thread GitBox
dongjinleekr commented on pull request #9414: URL: https://github.com/apache/kafka/pull/9414#issuecomment-739132524 Rebased onto the latest trunk. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: Change log4j dependency into log4j2

2020-12-04 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-739132477 Rebased onto the latest trunk. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dengziming commented on pull request #9649: MINOR: Combine repeated top-level error test in AlterIsrManagerTest

2020-12-04 Thread GitBox
dengziming commented on pull request #9649: URL: https://github.com/apache/kafka/pull/9649#issuecomment-739116990 @mumrah Hi, this class is created by you so I think you can have a look, thank you. This is an automated

[GitHub] [kafka] ning2008wisc commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-04 Thread GitBox
ning2008wisc commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-739114982 @rhauch if your pr is merged first, I will be happy to rebase on https://github.com/apache/kafka/pull/9698

[GitHub] [kafka] dengziming closed pull request #9664: KAFKA-10780; Rewrite ControllerZNode struct with auto-generated protocol

2020-12-04 Thread GitBox
dengziming closed pull request #9664: URL: https://github.com/apache/kafka/pull/9664 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] chia7712 commented on pull request #9694: MINOR:Modify aclsResources, discard Collection

2020-12-04 Thread GitBox
chia7712 commented on pull request #9694: URL: https://github.com/apache/kafka/pull/9694#issuecomment-739113376 @chris8099 Could you rebase code to include https://github.com/apache/kafka/commit/b9640a71c42ad117ed418209f87dc2962173469d?

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244391#comment-17244391 ] Chia-Ping Tsai commented on KAFKA-10790: [~Geordie] go for it > Detect/Prevent Deadlock on

[GitHub] [kafka] abbccdda opened a new pull request #9700: KAFKA-10813: InvalidProducerEpoch should be caught and throw as TaskMigrated

2020-12-04 Thread GitBox
abbccdda opened a new pull request #9700: URL: https://github.com/apache/kafka/pull/9700 We should catch InvalidProducerEpoch and rethrow as TaskMigrated, similar to ProducerFenced. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation

[GitHub] [kafka] bertber commented on pull request #9699: MINOR: add a description for calling resetToDatetime's function to resetByDuration and remove unnecessary loop code

2020-12-04 Thread GitBox
bertber commented on pull request #9699: URL: https://github.com/apache/kafka/pull/9699#issuecomment-739097621 Hello! I have updated StreamsResetter of class. I add a description for calling resetToDatetime's function to resetByDuration and remove unnecessary loop code.

[GitHub] [kafka] bertber opened a new pull request #9699: MINOR: add a description for calling resetToDatetime's function to re…

2020-12-04 Thread GitBox
bertber opened a new pull request #9699: URL: https://github.com/apache/kafka/pull/9699 …setByDuration Add a request that it will call resetToDatetime of description to resetByDuration of function. *More detailed description of your change, if necessary. The PR title and

[jira] [Assigned] (KAFKA-10813) StreamsProducer should catch InvalidProducerEpoch and throw TaskMigrated in all cases

2020-12-04 Thread Boyang Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Boyang Chen reassigned KAFKA-10813: --- Assignee: Boyang Chen > StreamsProducer should catch InvalidProducerEpoch and throw

[jira] [Created] (KAFKA-10813) StreamsProducer should catch InvalidProducerEpoch and throw TaskMigrated in all cases

2020-12-04 Thread Boyang Chen (Jira)
Boyang Chen created KAFKA-10813: --- Summary: StreamsProducer should catch InvalidProducerEpoch and throw TaskMigrated in all cases Key: KAFKA-10813 URL: https://issues.apache.org/jira/browse/KAFKA-10813

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

2020-12-04 Thread GitBox
wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r536416836 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -145,6 +148,26 @@

[GitHub] [kafka] C0urante commented on pull request #9698: KAFKA-10811: Correct the MirrorConnectorsIntegrationTest to correctly mask the exit procedures

2020-12-04 Thread GitBox
C0urante commented on pull request #9698: URL: https://github.com/apache/kafka/pull/9698#issuecomment-739086987 @rhauch it's not so much about the stack traces in these tests as it is about them presumably appearing when MM2 is run for real, and being caused by unclean worker shutdown.

[jira] [Created] (KAFKA-10812) Unclean worker shutdown in MirrorConnectorsIntegrationTest

2020-12-04 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-10812: - Summary: Unclean worker shutdown in MirrorConnectorsIntegrationTest Key: KAFKA-10812 URL: https://issues.apache.org/jira/browse/KAFKA-10812 Project: Kafka

[GitHub] [kafka] rhauch commented on pull request #9698: KAFKA-10811: Correct the MirrorConnectorsIntegrationTest to correctly mask the exit procedures

2020-12-04 Thread GitBox
rhauch commented on pull request #9698: URL: https://github.com/apache/kafka/pull/9698#issuecomment-739084805 @C0urante is there a KAFKA issue for those stack traces? If not, please create one. This is an automated message

[GitHub] [kafka] C0urante commented on pull request #9698: KAFKA-10811: Correct the MirrorConnectorsIntegrationTest to correctly mask the exit procedures

2020-12-04 Thread GitBox
C0urante commented on pull request #9698: URL: https://github.com/apache/kafka/pull/9698#issuecomment-739083240 This is definitely an improvement not only to the flaky MM2 test but to the integration testing framework in general. ✅ As a follow-up item, could we track the unclean

[GitHub] [kafka] rhauch commented on pull request #9224: KAFKA-10304: refactor MM2 integration tests

2020-12-04 Thread GitBox
rhauch commented on pull request #9224: URL: https://github.com/apache/kafka/pull/9224#issuecomment-739083056 @ning2008wisc, @mimaison: Please see https://issues.apache.org/jira/browse/KAFKA-10811 and #9698 for a required fix to the `MirrorConnectorsIntegrationTest` to prevent the

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2020-12-04 Thread Randall Hauch (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244361#comment-17244361 ] Randall Hauch commented on KAFKA-9013: -- See also KAFKA-10811 for when

[GitHub] [kafka] rhauch commented on pull request #9698: KAFKA-10811: Correct the MirrorConnectorsIntegrationTest to correctly mask the exit procedures

2020-12-04 Thread GitBox
rhauch commented on pull request #9698: URL: https://github.com/apache/kafka/pull/9698#issuecomment-739081612 @C0urante as mentioned offline, here is my fix for the MM2 integration test frequently exiting the builds. This

[GitHub] [kafka] rhauch opened a new pull request #9698: KAFKA-10811: Correct the MirrorConnectorsIntegrationTest to correctly mask the exit procedures

2020-12-04 Thread GitBox
rhauch opened a new pull request #9698: URL: https://github.com/apache/kafka/pull/9698 Normally the `EmbeddedConnectCluster` class masks the `Exit` procedures using within the Connect worker. This normally works great when a single instance of the embedded cluster is used. However, the

[GitHub] [kafka] rayokota edited a comment on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

2020-12-04 Thread GitBox
rayokota edited a comment on pull request #9593: URL: https://github.com/apache/kafka/pull/9593#issuecomment-739080185 This breaks existing client configurations that use `bootstrap.servers=SASL_PLAINTEXT://localhost:49767` (due to the `_`)

[jira] [Created] (KAFKA-10811) System exit from MirrorConnectorsIntegrationTest#testReplication

2020-12-04 Thread Randall Hauch (Jira)
Randall Hauch created KAFKA-10811: - Summary: System exit from MirrorConnectorsIntegrationTest#testReplication Key: KAFKA-10811 URL: https://issues.apache.org/jira/browse/KAFKA-10811 Project: Kafka

[GitHub] [kafka] rayokota commented on pull request #9593: KAFKA-10713: Stricter protocol parsing in hostnames

2020-12-04 Thread GitBox
rayokota commented on pull request #9593: URL: https://github.com/apache/kafka/pull/9593#issuecomment-739080185 This breaks existing client configurations that use `bootstrap.brokers=SASL_PLAINTEXT://localhost:49767` (due to the `_`)

[jira] [Updated] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10792: -- Description: If a source task blocks during its {{stop}} method, the herder thread will also

[jira] [Updated] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10792: -- Fix Version/s: 2.8.0 > Source tasks can block herder thread by hanging during stop >

[jira] [Updated] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-10792: -- Description: If a source task blocks during its {{stop}} method, the herder thread will also

[jira] [Resolved] (KAFKA-10792) Source tasks can block herder thread by hanging during stop

2020-12-04 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-10792. --- Fix Version/s: 2.7.1 Resolution: Fixed > Source tasks can block herder thread by

[jira] [Assigned] (KAFKA-7458) Avoid enforced processing during bootstrap phase

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-7458: --- Assignee: John Roesler (was: Guozhang Wang) > Avoid enforced processing during bootstrap

[jira] [Assigned] (KAFKA-8478) Poll for more records before forced processing

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-8478: --- Assignee: John Roesler > Poll for more records before forced processing >

[jira] [Commented] (KAFKA-8315) Historical join issues

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244330#comment-17244330 ] John Roesler commented on KAFKA-8315: - Hello, all, I have just proposed KIP-695, which I think would

[jira] [Commented] (KAFKA-8478) Poll for more records before forced processing

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244329#comment-17244329 ] John Roesler commented on KAFKA-8478: - Hello, all, I have just proposed KIP-695, which I think would

[jira] [Commented] (KAFKA-7458) Avoid enforced processing during bootstrap phase

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244327#comment-17244327 ] John Roesler commented on KAFKA-7458: - Hello, all, I have just proposed KIP-695, which I think would

[jira] [Commented] (KAFKA-10091) Improve task idling

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244326#comment-17244326 ] John Roesler commented on KAFKA-10091: -- Hello, all! I have just started the discussion in the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9697: KAFKA-10810: Replace stream threads

2020-12-04 Thread GitBox
wcarlson5 commented on a change in pull request #9697: URL: https://github.com/apache/kafka/pull/9697#discussion_r536416836 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StreamsUncaughtExceptionHandlerIntegrationTest.java ## @@ -145,6 +148,26 @@

[GitHub] [kafka] wcarlson5 opened a new pull request #9697: KAFKA-10810: Replace stream threads

2020-12-04 Thread GitBox
wcarlson5 opened a new pull request #9697: URL: https://github.com/apache/kafka/pull/9697 StreamThreads can now be replaced in the streams uncaught exception handler ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] guozhangwang merged pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-04 Thread GitBox
guozhangwang merged pull request #9667: URL: https://github.com/apache/kafka/pull/9667 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] ableegoldman commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
ableegoldman commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r536406055 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -916,11 +917,12 @@ public void

[GitHub] [kafka] vvcephei commented on a change in pull request #9616: POC: fix task idling

2020-12-04 Thread GitBox
vvcephei commented on a change in pull request #9616: URL: https://github.com/apache/kafka/pull/9616#discussion_r536403001 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -78,15 +89,147 @@ RecordQueue queue() {

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536391337 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536241597 ## File path: core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala ## @@ -236,13 +310,22 @@ class ClientQuotasRequestTest extends

[GitHub] [kafka] lct45 opened a new pull request #9696: MINOR: Clean up streams metric sensors

2020-12-04 Thread GitBox
lct45 opened a new pull request #9696: URL: https://github.com/apache/kafka/pull/9696 Follow-up from https://github.com/apache/kafka/pull/9614, updates streams metrics sensor logic This is an automated message from the

[GitHub] [kafka] lct45 commented on pull request #9696: MINOR: Clean up streams metric sensors

2020-12-04 Thread GitBox
lct45 commented on pull request #9696: URL: https://github.com/apache/kafka/pull/9696#issuecomment-739012738 @cadonna @mjsax for review This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9695: KAFKA-10500: Remove thread

2020-12-04 Thread GitBox
wcarlson5 commented on a change in pull request #9695: URL: https://github.com/apache/kafka/pull/9695#discussion_r536354418 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -924,28 +924,69 @@ private StreamThread createStreamThread(final

[GitHub] [kafka] wcarlson5 closed pull request #9647: KAFKA-10500: Remove thread

2020-12-04 Thread GitBox
wcarlson5 closed pull request #9647: URL: https://github.com/apache/kafka/pull/9647 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] wcarlson5 commented on pull request #9647: KAFKA-10500: Remove thread

2020-12-04 Thread GitBox
wcarlson5 commented on pull request #9647: URL: https://github.com/apache/kafka/pull/9647#issuecomment-738992835 closed in favor of https://github.com/apache/kafka/pull/9695 This is an automated message from the Apache Git

[GitHub] [kafka] wcarlson5 opened a new pull request #9695: KAFKA-10500: Remove thread

2020-12-04 Thread GitBox
wcarlson5 opened a new pull request #9695: URL: https://github.com/apache/kafka/pull/9695 Add the ability to remove running threads ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status -

[GitHub] [kafka] mjsax commented on pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-12-04 Thread GitBox
mjsax commented on pull request #9660: URL: https://github.com/apache/kafka/pull/9660#issuecomment-738989889 Thanks for the KIP and PR @rohitrmd! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-12-04 Thread GitBox
mjsax commented on pull request #8965: URL: https://github.com/apache/kafka/pull/8965#issuecomment-738989558 Thanks a lot for the PR @highluck! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax commented on pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-12-04 Thread GitBox
mjsax commented on pull request #8965: URL: https://github.com/apache/kafka/pull/8965#issuecomment-738989301 Merged to `trunk` and cherry-picked to `2.7` and `2.6` branches. This is an automated message from the Apache Git

[GitHub] [kafka] mjsax merged pull request #8965: KAFKA-8147: Add changelog topic configuration to KTable suppress

2020-12-04 Thread GitBox
mjsax merged pull request #8965: URL: https://github.com/apache/kafka/pull/8965 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r536339499 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -916,11 +917,12 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r536338913 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -792,24 +790,35 @@ public void

[GitHub] [kafka] chris8099 commented on pull request #9694: MINOR:Modify aclsResources, discard Collection

2020-12-04 Thread GitBox
chris8099 commented on pull request #9694: URL: https://github.com/apache/kafka/pull/9694#issuecomment-738978021 @chia7712 PTAL thanks This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] chris8099 opened a new pull request #9694: MINOR:Modify aclsResources, discard Collection

2020-12-04 Thread GitBox
chris8099 opened a new pull request #9694: URL: https://github.com/apache/kafka/pull/9694 Modify DescribeAclsResponse, remove Collection and change to Iterable, Modify KafkaApis, aclsResources method This is an automated

[GitHub] [kafka] ableegoldman commented on a change in pull request #9688: KAFKA-10017: fix flaky EOS-beta upgrade test

2020-12-04 Thread GitBox
ableegoldman commented on a change in pull request #9688: URL: https://github.com/apache/kafka/pull/9688#discussion_r536321595 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -916,11 +917,12 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #9606: [KAFKA-10722] doc: Improve JavaDoc for KGroupedStream.aggregate

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9606: URL: https://github.com/apache/kafka/pull/9606#discussion_r536328242 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/KGroupedStream.java ## @@ -381,7 +381,8 @@ * {@link

[jira] [Comment Edited] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244252#comment-17244252 ] GeordieMai edited comment on KAFKA-10790 at 12/4/20, 7:23 PM: -- [~chia7712] 

[jira] [Commented] (KAFKA-10790) Detect/Prevent Deadlock on Producer Network Thread

2020-12-04 Thread GeordieMai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244252#comment-17244252 ] GeordieMai commented on KAFKA-10790: [~chia7712] Can I take this issue? when flush method is called

[GitHub] [kafka] mjsax merged pull request #9615: KAFKA-10500: Add thread option

2020-12-04 Thread GitBox
mjsax merged pull request #9615: URL: https://github.com/apache/kafka/pull/9615 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] wcarlson5 commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-04 Thread GitBox
wcarlson5 commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r536318737 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -845,67 +856,118 @@ private KafkaStreams(final

[jira] [Created] (KAFKA-10810) Add a replace thread option to the streams uncaught exception handler

2020-12-04 Thread Walker Carlson (Jira)
Walker Carlson created KAFKA-10810: -- Summary: Add a replace thread option to the streams uncaught exception handler Key: KAFKA-10810 URL: https://issues.apache.org/jira/browse/KAFKA-10810 Project:

[GitHub] [kafka] mjsax commented on pull request #9691: HOTFIX: fix failed build caused by StreamThreadTest

2020-12-04 Thread GitBox
mjsax commented on pull request #9691: URL: https://github.com/apache/kafka/pull/9691#issuecomment-738957750 Thanks for the quick fix @chia7712! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] mjsax merged pull request #9691: HOTFIX: fix failed build caused by StreamThreadTest

2020-12-04 Thread GitBox
mjsax merged pull request #9691: URL: https://github.com/apache/kafka/pull/9691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] rohitrmd commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-12-04 Thread GitBox
rohitrmd commented on a change in pull request #9660: URL: https://github.com/apache/kafka/pull/9660#discussion_r533099003 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -254,6 +265,19 @@ public TopologyTestDriver(final

[GitHub] [kafka] rohitrmd commented on a change in pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-12-04 Thread GitBox
rohitrmd commented on a change in pull request #9660: URL: https://github.com/apache/kafka/pull/9660#discussion_r532104028 ## File path: streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java ## @@ -298,8 +322,14 @@ private TopologyTestDriver(final

[GitHub] [kafka] mjsax merged pull request #9660: Kafka 10629 - TopologyTestDriver should not require a Properties argument

2020-12-04 Thread GitBox
mjsax merged pull request #9660: URL: https://github.com/apache/kafka/pull/9660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] mumrah commented on a change in pull request #9693: Refactor ZK ISR updates to use AlterIsrManager

2020-12-04 Thread GitBox
mumrah commented on a change in pull request #9693: URL: https://github.com/apache/kafka/pull/9693#discussion_r536307517 ## File path: core/src/main/scala/kafka/server/ZkIsrManager.scala ## @@ -0,0 +1,51 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] mumrah opened a new pull request #9693: Refactor ZK ISR updates to use AlterIsrManager

2020-12-04 Thread GitBox
mumrah opened a new pull request #9693: URL: https://github.com/apache/kafka/pull/9693 In an effort to consolidate the ISR write paths, this PR adapts the ZK ISR update into the new AlterIsrManager trait. This will allow us minimize divergence in the ISR update code in Partition.scala.

[GitHub] [kafka] d8tltanc commented on a change in pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-04 Thread GitBox
d8tltanc commented on a change in pull request #9485: URL: https://github.com/apache/kafka/pull/9485#discussion_r536305219 ## File path: clients/src/main/java/org/apache/kafka/server/authorizer/Authorizer.java ## @@ -139,4 +150,129 @@ * @return Iterator for ACL

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244226#comment-17244226 ] James Galasyn commented on KAFKA-2967: -- Cool! I'll go ahead and stand up a sandboxed site, then we

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244218#comment-17244218 ] Tom Bentley commented on KAFKA-2967: {quote}I just took a look at Tom Bentley's proposal, and it

[GitHub] [kafka] mjsax commented on pull request #8404: KAFKA-10787: Introduce an import order in Java sources

2020-12-04 Thread GitBox
mjsax commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-738948918 About https://github.com/apache/kafka/pull/8404#issuecomment-645357204 As "spotless" can reformat code, could we use it to re-order imports? This might be the best solution.

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244200#comment-17244200 ] James Galasyn commented on KAFKA-2967: -- [~vvcephei] Yes, at the very least we can manually author

[GitHub] [kafka] d8tltanc commented on pull request #9485: KAKFA-10619: Idempotent producer will get authorized once it has a WRITE access to at least one topic

2020-12-04 Thread GitBox
d8tltanc commented on pull request #9485: URL: https://github.com/apache/kafka/pull/9485#issuecomment-738942757 Make a new aggregated index called ResourceIndex, which is a combination of ACE, ResourceType, and PatternType. New benchmark looks much better:

[GitHub] [kafka] mjsax commented on pull request #8404: KAFKA-10787: Introduce an import order in Java sources

2020-12-04 Thread GitBox
mjsax commented on pull request #8404: URL: https://github.com/apache/kafka/pull/8404#issuecomment-738941710 @dongjinleekr The PR shows merge conflict. Can you rebase it? This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #9615: KAFKA-10500: Add thread option

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9615: URL: https://github.com/apache/kafka/pull/9615#discussion_r536285505 ## File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java ## @@ -845,67 +856,118 @@ private KafkaStreams(final InternalTopologyBuilder

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244180#comment-17244180 ] John Roesler commented on KAFKA-2967: - I just took a look at [~tombentley]'s proposal, and it seems

[GitHub] [kafka] guozhangwang commented on a change in pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-04 Thread GitBox
guozhangwang commented on a change in pull request #9667: URL: https://github.com/apache/kafka/pull/9667#discussion_r536282550 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -465,7 +465,11 @@ boolean

[GitHub] [kafka] guozhangwang commented on pull request #9667: MINOR: Do not print log4j for memberId required

2020-12-04 Thread GitBox
guozhangwang commented on pull request #9667: URL: https://github.com/apache/kafka/pull/9667#issuecomment-738931337 > Maybe add an explanation here for why to skip the member.id required exception? (as it's transient) Ack, will do.

[GitHub] [kafka] tombentley commented on pull request #9441: KAFKA-10614: Ensure group state (un)load is executed in the submitted order

2020-12-04 Thread GitBox
tombentley commented on pull request #9441: URL: https://github.com/apache/kafka/pull/9441#issuecomment-738925531 You're right @guozhangwang, `ScheduledFutureTask` contains a sequence number to break ties, so the executor _is_ FIFO. So you're saying that the wrong network thread handling

[GitHub] [kafka] rhauch merged pull request #9669: KAFKA-10792: Prevent source task shutdown from blocking herder thread

2020-12-04 Thread GitBox
rhauch merged pull request #9669: URL: https://github.com/apache/kafka/pull/9669 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Comment Edited] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244159#comment-17244159 ] James Galasyn edited comment on KAFKA-2967 at 12/4/20, 5:37 PM:

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread James Galasyn (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244159#comment-17244159 ] James Galasyn commented on KAFKA-2967: -- [~tombentley] I'm not sure that could generate links, but it

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536257595 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -472,6 +512,134 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[GitHub] [kafka] mjsax commented on a change in pull request #9668: MINOR: add test for repartition/source-topic/changelog optimization

2020-12-04 Thread GitBox
mjsax commented on a change in pull request #9668: URL: https://github.com/apache/kafka/pull/9668#discussion_r536256494 ## File path: streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java ## @@ -463,7 +463,36 @@ public void

[GitHub] [kafka] splett2 commented on a change in pull request #9628: KAFKA-10747: Implement APIs for altering and describing IP connection rate quotas

2020-12-04 Thread GitBox
splett2 commented on a change in pull request #9628: URL: https://github.com/apache/kafka/pull/9628#discussion_r536250843 ## File path: core/src/main/scala/kafka/admin/ConfigCommand.scala ## @@ -864,11 +885,21 @@ object ConfigCommand extends Config { } } +

[GitHub] [kafka] bertber closed pull request #9692: MINOR: add a description for calling resetToDatetime's function to resetByDuration

2020-12-04 Thread GitBox
bertber closed pull request #9692: URL: https://github.com/apache/kafka/pull/9692 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (KAFKA-10161) Update Documentation

2020-12-04 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot reassigned KAFKA-10161: --- Assignee: David Jacot > Update Documentation > > >

[jira] [Commented] (KAFKA-2967) Move Kafka documentation to ReStructuredText

2020-12-04 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-2967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244118#comment-17244118 ] Tom Bentley commented on KAFKA-2967: [~JimGalasyn] so it looks like we could do useful stuff with

  1   2   >