[GitHub] [kafka] MarcoLotz commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-10 Thread GitBox
MarcoLotz commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r592126995 ## File path: build.gradle ## @@ -1635,8 +1627,14 @@ project(':streams:examples') { archivesBaseName = "kafka-streams-examples" dependencies {

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592022166 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592124191 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592123658 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] [kafka] chia7712 commented on a change in pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

2021-03-10 Thread GitBox
chia7712 commented on a change in pull request #10298: URL: https://github.com/apache/kafka/pull/10298#discussion_r592112634 ## File path: tests/kafkatest/tests/client/client_compatibility_features_test.py ## @@ -109,7 +109,7 @@ def invoke_compatibility_program(self,

[jira] [Commented] (KAFKA-10034) Clarify Usage of "batch.size" and "max.request.size" Producer Configs

2021-03-10 Thread Badai Aqrandista (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299349#comment-17299349 ] Badai Aqrandista commented on KAFKA-10034: -- Just got around to do this ticket. To put this on

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592096637 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592071729 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] dongjoon-hyun commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796479622 Thank you, @ijuma . This is an automated message from the Apache Git Service. To respond to the message,

[jira] [Commented] (KAFKA-6798) Kafka leader rebalance failures

2021-03-10 Thread SeaAndHill (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299324#comment-17299324 ] SeaAndHill commented on KAFKA-6798: --- [~rdzimmer] the issue resolved now or how resolved? i encounter

[jira] [Commented] (KAFKA-10821) Send cluster id information with the FetchSnapshot request

2021-03-10 Thread Rohit Deshpande (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299322#comment-17299322 ] Rohit Deshpande commented on KAFKA-10821: - ok thanks [~jagsancio] can you please assign me some

[GitHub] [kafka] highluck commented on pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper

2021-03-10 Thread GitBox
highluck commented on pull request #10302: URL: https://github.com/apache/kafka/pull/10302#issuecomment-79647 @mjsax Would this be what you want? thanks! This is an automated message from the Apache Git Service.

[GitHub] [kafka] highluck opened a new pull request #10302: KAFKA-7785: move internal DefaultPartitionGrouper

2021-03-10 Thread GitBox
highluck opened a new pull request #10302: URL: https://github.com/apache/kafka/pull/10302 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] ijuma commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
ijuma commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796471625 Sounds good. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] dongjoon-hyun edited a comment on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun edited a comment on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796460374 Since the new features are not used, you may right. However, I believe the benefits are three-fold. - There exists ZSTD side bug-fixes at ZSTD 1.4.9. - There

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592075662 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592074962 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] dongjoon-hyun edited a comment on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun edited a comment on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796460374 Since the new features are not used, you may right. However, I believe the benefits are three-fold. - There exists ZSTD side bug-fixes at ZSTD 1.4.9. - There

[GitHub] [kafka] dongjoon-hyun edited a comment on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun edited a comment on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796460374 Since the new features are not used, you may right. However, I believe the benefits are three-fold. - There exists ZSTD side bug-fixes at ZSTD 1.4.9. - There

[GitHub] [kafka] dongjoon-hyun commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796460374 Since the new feature is not used. You may right. However, I believe the benefits are three-fold. - There exists ZSTD side bug-fixes at ZSTD 1.4.9. - There exists

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592071729 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,173 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592070871 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r592070871 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] [kafka] highluck commented on a change in pull request #9851: KAFKA-10769 Remove JoinGroupRequest#containsValidPattern as it is dup…

2021-03-10 Thread GitBox
highluck commented on a change in pull request #9851: URL: https://github.com/apache/kafka/pull/9851#discussion_r592069877 ## File path: clients/src/main/java/org/apache/kafka/common/requests/JoinGroupRequest.java ## @@ -59,38 +59,12 @@ public String toString() { public

[GitHub] [kafka] showuon commented on a change in pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

2021-03-10 Thread GitBox
showuon commented on a change in pull request #10301: URL: https://github.com/apache/kafka/pull/10301#discussion_r592065468 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -426,40 +448,51 @@ public void

[GitHub] [kafka] showuon commented on pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

2021-03-10 Thread GitBox
showuon commented on pull request #10301: URL: https://github.com/apache/kafka/pull/10301#issuecomment-796449322 @mjsax @ableegoldman @abbccdda , could you help review this PR? Thank you. This is an automated message from

[GitHub] [kafka] showuon opened a new pull request #10301: KAFKA-9831: increase max.poll.interval.ms to avoid unexpected rebalance

2021-03-10 Thread GitBox
showuon opened a new pull request #10301: URL: https://github.com/apache/kafka/pull/10301 Found the root cause about why the the test `shouldNotViolateEosIfOneTaskFailsWithState` failed sometimes with unexpected committed/uncommitted result. The reason is unexpected rebalance during

[jira] [Updated] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-10 Thread Patrick O'Keeffe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick O'Keeffe updated KAFKA-12453: - Description: Since the introduction of KStream.toTable() in Kafka 2.6.x, the decision

[jira] [Updated] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-10 Thread Patrick O'Keeffe (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12453?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Patrick O'Keeffe updated KAFKA-12453: - Description: Since the introduction of KStream.toTable() in Kafka 2.6.x, the decision

[jira] [Created] (KAFKA-12453) Guidance on whether a topology is eligible for optimisation

2021-03-10 Thread Patrick O'Keeffe (Jira)
Patrick O'Keeffe created KAFKA-12453: Summary: Guidance on whether a topology is eligible for optimisation Key: KAFKA-12453 URL: https://issues.apache.org/jira/browse/KAFKA-12453 Project: Kafka

[GitHub] [kafka] mjsax commented on a change in pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

2021-03-10 Thread GitBox
mjsax commented on a change in pull request #10300: URL: https://github.com/apache/kafka/pull/10300#discussion_r592036244 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorNode.java ## @@ -37,7 +37,6 @@ public class ProcessorNode {

[GitHub] [kafka] mjsax commented on a change in pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

2021-03-10 Thread GitBox
mjsax commented on a change in pull request #10300: URL: https://github.com/apache/kafka/pull/10300#discussion_r592035201 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/ProcessorContext.java ## @@ -189,29 +189,6 @@ Cancellable schedule(final Duration

[GitHub] [kafka] mjsax opened a new pull request #10300: KAFKA-12452: Remove deprecated overloads of ProcessorContext#forward

2021-03-10 Thread GitBox
mjsax opened a new pull request #10300: URL: https://github.com/apache/kafka/pull/10300 ProcessorContext#forward was changed via KIP-251 in 2.0.0 release. This PR removes the old and deprecated overloads. Call for review @guozhangwang @ableegoldman

[GitHub] [kafka] dongjoon-hyun commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-796392392 Hi, @ijuma . Could you review this PR please? This is an automated message from the Apache Git Service.

[GitHub] [kafka] kowshik commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
kowshik commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591905906 ## File path: remote-storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed

[GitHub] [kafka] levzem opened a new pull request #10299: KAFKA-10070: parameterize Connect unit tests to remove code duplication

2021-03-10 Thread GitBox
levzem opened a new pull request #10299: URL: https://github.com/apache/kafka/pull/10299 Signed-off-by: Lev Zemlyanov *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping

[jira] [Assigned] (KAFKA-12452) Remove deprecated overloads for ProcessorContext#forward

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12452: --- Assignee: Matthias J. Sax > Remove deprecated overloads for

[jira] [Commented] (KAFKA-12446) Define KGroupedTable#aggregate subtractor + adder order of execution

2021-03-10 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299226#comment-17299226 ] A. Sophie Blee-Goldman commented on KAFKA-12446: Thanks for the ticket! This issue seems

[jira] [Commented] (KAFKA-10821) Send cluster id information with the FetchSnapshot request

2021-03-10 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10821?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299222#comment-17299222 ] Jose Armando Garcia Sancio commented on KAFKA-10821: FYI [~rohitdeshaws] , It looks

[GitHub] [kafka] ijuma commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-10 Thread GitBox
ijuma commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r592000778 ## File path: build.gradle ## @@ -1635,8 +1627,14 @@ project(':streams:examples') { archivesBaseName = "kafka-streams-examples" dependencies { +

[GitHub] [kafka] dengziming commented on a change in pull request #10289: KAFKA-12440: ClusterId validation for Vote, BeginQuorum, EndQuorum and FetchSnapshot

2021-03-10 Thread GitBox
dengziming commented on a change in pull request #10289: URL: https://github.com/apache/kafka/pull/10289#discussion_r592000720 ## File path: checkstyle/suppressions.xml ## @@ -68,7 +68,7 @@

[jira] [Resolved] (KAFKA-12287) Add WARN logging on consumer-groups when reset-offsets by timestamp or duration can't find an offset and defaults to latest.

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12287. - Fix Version/s: 3.0.0 Resolution: Fixed > Add WARN logging on consumer-groups

[GitHub] [kafka] mjsax merged pull request #10092: KAFKA-12287: Add WARN logging on consumer-groups when reset-offsets by timestamp or duration can't find an offset and defaults to latest

2021-03-10 Thread GitBox
mjsax merged pull request #10092: URL: https://github.com/apache/kafka/pull/10092 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] mjsax commented on a change in pull request #10131: KAFKA-5146 / move kafka-streams example to a new module

2021-03-10 Thread GitBox
mjsax commented on a change in pull request #10131: URL: https://github.com/apache/kafka/pull/10131#discussion_r591997331 ## File path: build.gradle ## @@ -1416,14 +1416,6 @@ project(':streams') { dependencies { api project(':clients') -// use `api` dependency

[jira] [Created] (KAFKA-12452) Remove deprecated overloads for ProcessorContext#forward

2021-03-10 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12452: --- Summary: Remove deprecated overloads for ProcessorContext#forward Key: KAFKA-12452 URL: https://issues.apache.org/jira/browse/KAFKA-12452 Project: Kafka

[GitHub] [kafka] jolshan edited a comment on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-10 Thread GitBox
jolshan edited a comment on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796317046 @chia7712 here's the commit. As mentioned in the commit message: > Left a few todos. Still need to clean up, optimize code, and fix flaky and broken tests in

[GitHub] [kafka] jolshan commented on pull request #9944: KAFKA-10580: Add topic ID support to Fetch request

2021-03-10 Thread GitBox
jolshan commented on pull request #9944: URL: https://github.com/apache/kafka/pull/9944#issuecomment-796317046 @chia7712 here's the commit. As mentioned in the commit message: > Left a few todos. Still need to clean up, optimize code, and fix flaky and broken tests in

[GitHub] [kafka] mjsax merged pull request #10284: KAFKA-12441: remove deprecated method StreamsBuilder#addGlobalStore

2021-03-10 Thread GitBox
mjsax merged pull request #10284: URL: https://github.com/apache/kafka/pull/10284 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] rohitrmd commented on pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-03-10 Thread GitBox
rohitrmd commented on pull request #9744: URL: https://github.com/apache/kafka/pull/9744#issuecomment-796309030 thank you @mjsax for all the help and guidance. This is an automated message from the Apache Git Service. To

[jira] [Updated] (KAFKA-12253) Add tests that cover all of all of the cases for ReplicatedLog::validateOffsetAndEpoch

2021-03-10 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12253: --- Description: Add tests for the cases that

[jira] [Updated] (KAFKA-12451) Remove deprecation annotation on long-based read operations in WindowStore

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12451: Description: Related to KIP-358

[jira] [Updated] (KAFKA-12450) Remove deprecated methods from ReadOnlyWindowStore

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12450: Description: Related to KIP-358

[jira] [Updated] (KAFKA-12449) Remove deprecated WindowStore#put

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12449: Description: Related to KIP-474: 

[GitHub] [kafka] mjsax commented on pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

2021-03-10 Thread GitBox
mjsax commented on pull request #10293: URL: https://github.com/apache/kafka/pull/10293#issuecomment-796276922 Seem this PR is related to KIP-474 https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=115526545. We should rather tag the KIPs that did the deprecation of

[GitHub] [kafka] mjsax commented on a change in pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

2021-03-10 Thread GitBox
mjsax commented on a change in pull request #10293: URL: https://github.com/apache/kafka/pull/10293#discussion_r591938958 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -710,73 +710,9 @@ public void

[jira] [Updated] (KAFKA-12451) Remove deprecation annotation on long-based read operations in WindowStore

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12451: Component/s: streams > Remove deprecation annotation on long-based read operations in

[jira] [Updated] (KAFKA-12449) Remove deprecated WindowStore#put

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12449: Component/s: streams > Remove deprecated WindowStore#put >

[jira] [Updated] (KAFKA-12450) Remove deprecated methods from ReadOnlyWindowStore

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-12450: Component/s: streams > Remove deprecated methods from ReadOnlyWindowStore >

[jira] [Resolved] (KAFKA-12448) STATE_DIR_CONFIG path cannot be found in windows due to usage of setPosixFilePermissions

2021-03-10 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax resolved KAFKA-12448. - Resolution: Duplicate This should already be fixed via

[GitHub] [kafka] rondagostino commented on pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

2021-03-10 Thread GitBox
rondagostino commented on pull request #10298: URL: https://github.com/apache/kafka/pull/10298#issuecomment-796245045 This needs to be cherry-picked to `2.8` This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rondagostino opened a new pull request #10298: MINOR: Disable client compatibility system test for Raft quorums

2021-03-10 Thread GitBox
rondagostino opened a new pull request #10298: URL: https://github.com/apache/kafka/pull/10298 The client compatibility system test cannot pass for Raft-based quorums because several APIs have not yet been implemented, and these not-yet-implemented APIs were disabled via

[GitHub] [kafka] mjsax commented on pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-03-10 Thread GitBox
mjsax commented on pull request #9744: URL: https://github.com/apache/kafka/pull/9744#issuecomment-796231276 Merged to `trunk`. Congrats @rohitrmd and thank you for your contribution! This is an automated message from

[GitHub] [kafka] mjsax merged pull request #9744: KAFKA-10062: Add a method to retrieve the current timestamp as known by the Streams app

2021-03-10 Thread GitBox
mjsax merged pull request #9744: URL: https://github.com/apache/kafka/pull/9744 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] jsancio commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

2021-03-10 Thread GitBox
jsancio commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591909832 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -35,21 +34,14 @@ import scala.compat.java8.OptionConverters._ final class

[GitHub] [kafka] rondagostino commented on pull request #10297: MINOR: fix failing ZooKeeper system tests

2021-03-10 Thread GitBox
rondagostino commented on pull request #10297: URL: https://github.com/apache/kafka/pull/10297#issuecomment-796196452 Will need to be cherry-picked to `2.8`. This is an automated message from the Apache Git Service. To

[GitHub] [kafka] rondagostino opened a new pull request #10297: MINOR: fix failing ZooKeeper system tests

2021-03-10 Thread GitBox
rondagostino opened a new pull request #10297: URL: https://github.com/apache/kafka/pull/10297 ZooKeeper-related system tests in `zookeeper_security_upgrade_test.py` and `zookeeper_tls_test.py` broke due to https://github.com/apache/kafka/pull/10199/. That patch changed the logic of

[GitHub] [kafka] hachikuji commented on a change in pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-03-10 Thread GitBox
hachikuji commented on a change in pull request #10275: URL: https://github.com/apache/kafka/pull/10275#discussion_r591903496 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/PartitionLeaderStrategy.java ## @@ -0,0 +1,185 @@ +/* + * Licensed to the

[GitHub] [kafka] hachikuji commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

2021-03-10 Thread GitBox
hachikuji commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591870272 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -35,21 +34,14 @@ import scala.compat.java8.OptionConverters._ final class

[GitHub] [kafka] jsancio commented on a change in pull request #10289: KAFKA-12440: ClusterId validation for Vote, BeginQuorum, EndQuorum and FetchSnapshot

2021-03-10 Thread GitBox
jsancio commented on a change in pull request #10289: URL: https://github.com/apache/kafka/pull/10289#discussion_r591851864 ## File path: checkstyle/suppressions.xml ## @@ -68,7 +68,7 @@

[GitHub] [kafka] jsancio commented on a change in pull request #10276: Kafka 12253: Add tests that cover all of all of the cases for ReplicatedLog-validateOffsetAndEpoch

2021-03-10 Thread GitBox
jsancio commented on a change in pull request #10276: URL: https://github.com/apache/kafka/pull/10276#discussion_r591824754 ## File path: core/src/test/scala/kafka/raft/KafkaMetadataLogTest.scala ## @@ -340,6 +340,124 @@ final class KafkaMetadataLogTest {

[GitHub] [kafka] kowshik commented on a change in pull request #10173: KAFKA-9548 Added SPIs and public classes/interfaces introduced in KIP-405 for tiered storage feature in Kafka.

2021-03-10 Thread GitBox
kowshik commented on a change in pull request #10173: URL: https://github.com/apache/kafka/pull/10173#discussion_r591829798 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataManager.java ## @@ -0,0 +1,200 @@ +/* + * Licensed to

[jira] [Updated] (KAFKA-12253) Add tests that cover all of all of the cases for ReplicatedLog::validateOffsetAndEpoch

2021-03-10 Thread Jose Armando Garcia Sancio (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-12253: --- Description: Add tests for the cases that

[GitHub] [kafka] jeqo opened a new pull request #10296: remove supressing warning for a invalid deprecation

2021-03-10 Thread GitBox
jeqo opened a new pull request #10296: URL: https://github.com/apache/kafka/pull/10296 Complete https://cwiki.apache.org/confluence/display/KAFKA/KIP-667%3A+Remove+deprecated+methods+from+ReadOnlyWindowStore by removing deprecation annotation on long-based read operations in WindowStore.

[jira] [Assigned] (KAFKA-12451) Remove deprecation annotation on long-based read operations in WindowStore

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-12451: Assignee: Jorge Esteban Quilcate Otoya > Remove

[GitHub] [kafka] wcarlson5 closed pull request #10295: Merge master 3 10 21

2021-03-10 Thread GitBox
wcarlson5 closed pull request #10295: URL: https://github.com/apache/kafka/pull/10295 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [kafka] wcarlson5 opened a new pull request #10295: Merge master 3 10 21

2021-03-10 Thread GitBox
wcarlson5 opened a new pull request #10295: URL: https://github.com/apache/kafka/pull/10295 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[jira] [Commented] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2021-03-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299042#comment-17299042 ] Konstantine Karantasis commented on KAFKA-10062: The KIP has been approved and according

[jira] [Updated] (KAFKA-10062) Add a method to retrieve the current timestamp as known by the Streams app

2021-03-10 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10062: --- Fix Version/s: 3.0.0 > Add a method to retrieve the current timestamp as

[jira] [Commented] (KAFKA-10340) Source connectors should report error when trying to produce records to non-existent topics instead of hanging forever

2021-03-10 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17299037#comment-17299037 ] Mickael Maison commented on KAFKA-10340: [~vvcephei] Are we picking this change in 2.8? I

[GitHub] [kafka] jeqo opened a new pull request #10294: [KAFKA-12450] Remove deprecated methods from ReadOnlyWindowStore

2021-03-10 Thread GitBox
jeqo opened a new pull request #10294: URL: https://github.com/apache/kafka/pull/10294 Implement first part of https://cwiki.apache.org/confluence/display/KAFKA/KIP-667%3A+Remove+deprecated+methods+from+ReadOnlyWindowStore. Preparing it for v3.0 ### Committer Checklist (excluded

[jira] [Assigned] (KAFKA-12450) Remove deprecated methods from ReadOnlyWindowStore

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-12450: Assignee: Jorge Esteban Quilcate Otoya > Remove

[jira] [Assigned] (KAFKA-12449) Remove deprecated WindowStore#put

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jorge Esteban Quilcate Otoya reassigned KAFKA-12449: Assignee: Jorge Esteban Quilcate Otoya > Remove

[GitHub] [kafka] jeqo closed pull request #10288: [KAFKA-10434] KIP-667 implementation

2021-03-10 Thread GitBox
jeqo closed pull request #10288: URL: https://github.com/apache/kafka/pull/10288 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] jeqo opened a new pull request #10293: [KAFKA-12449] Remove deprecated WindowStore#put

2021-03-10 Thread GitBox
jeqo opened a new pull request #10293: URL: https://github.com/apache/kafka/pull/10293 Following changes from https://cwiki.apache.org/confluence/display/KAFKA/KIP-667%3A+Remove+deprecated+methods+from+ReadOnlyWindowStore for the upcoming v3.0, this PR proposes to remove WindowStore#put

[jira] [Created] (KAFKA-12450) Remove deprecated methods from ReadOnlyWindowStore

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-12450: Summary: Remove deprecated methods from ReadOnlyWindowStore Key: KAFKA-12450 URL: https://issues.apache.org/jira/browse/KAFKA-12450

[jira] [Created] (KAFKA-12451) Remove deprecation annotation on long-based read operations in WindowStore

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-12451: Summary: Remove deprecation annotation on long-based read operations in WindowStore Key: KAFKA-12451 URL:

[jira] [Created] (KAFKA-12449) Remove deprecated WindowStore#put

2021-03-10 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-12449: Summary: Remove deprecated WindowStore#put Key: KAFKA-12449 URL: https://issues.apache.org/jira/browse/KAFKA-12449 Project: Kafka

[GitHub] [kafka] chia7712 commented on pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-10 Thread GitBox
chia7712 commented on pull request #10292: URL: https://github.com/apache/kafka/pull/10292#issuecomment-795771368 oh, it tests raft also. will update code to fix that. This is an automated message from the Apache Git

[jira] [Assigned] (KAFKA-12437) Ensure all metadata records are covered by BrokerMetadataListenerTest

2021-03-10 Thread YI-CHEN WANG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YI-CHEN WANG reassigned KAFKA-12437: Assignee: YI-CHEN WANG > Ensure all metadata records are covered by

[GitHub] [kafka] jsancio commented on a change in pull request #9756: KAFKA-10652: Adding size based linger semnatics to Raft metadata

2021-03-10 Thread GitBox
jsancio commented on a change in pull request #9756: URL: https://github.com/apache/kafka/pull/9756#discussion_r566237380 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -474,6 +474,7 @@ public void

[jira] [Assigned] (KAFKA-12442) Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread YI-CHEN WANG (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] YI-CHEN WANG reassigned KAFKA-12442: Assignee: (was: YI-CHEN WANG) > Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1 >

[GitHub] [kafka] dongjoon-hyun commented on pull request #10285: KAFKA-12442: Upgrade ZSTD JNI from 1.4.8-4 to 1.4.9-1

2021-03-10 Thread GitBox
dongjoon-hyun commented on pull request #10285: URL: https://github.com/apache/kafka/pull/10285#issuecomment-795683313 Thank you, @chia7712 and @dongjinleekr . This is an automated message from the Apache Git Service. To

[GitHub] [kafka] jsancio commented on a change in pull request #10021: KAFKA-12205: Delete snapshots less than the snapshot at the log start

2021-03-10 Thread GitBox
jsancio commented on a change in pull request #10021: URL: https://github.com/apache/kafka/pull/10021#discussion_r591629749 ## File path: core/src/main/scala/kafka/raft/KafkaMetadataLog.scala ## @@ -35,21 +34,14 @@ import scala.compat.java8.OptionConverters._ final class

[GitHub] [kafka] chia7712 opened a new pull request #10292: MINOR: fix client_compatibility_features_test.py

2021-03-10 Thread GitBox
chia7712 opened a new pull request #10292: URL: https://github.com/apache/kafka/pull/10292 related to https://github.com/apache/kafka/pull/10105 kafka nodes are set to **older version** so resolved script path is linked to **older assembly**. the 0.10.x versions do not have

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591603442 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591585302 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/InmemoryRemoteLogMetadataManager.java ## @@ -0,0 +1,170 @@ +/* + *

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591603442 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591595247 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591591507 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed to the

[GitHub] [kafka] satishd commented on a change in pull request #10218: KAFKA-12368: Added inmemory implementations for RemoteStorageManager and RemoteLogMetadataManager.

2021-03-10 Thread GitBox
satishd commented on a change in pull request #10218: URL: https://github.com/apache/kafka/pull/10218#discussion_r591588474 ## File path: clients/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogMetadataCache.java ## @@ -0,0 +1,152 @@ +/* + * Licensed to the

  1   2   >