[jira] [Updated] (KAFKA-10493) KTable out-of-order updates are not being ignored

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10493: Summary: KTable out-of-order updates are not being ignored (was: Ktable out-of-order

[jira] [Assigned] (KAFKA-9195) Use Randomized State Directory Names in Streams System Tests

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-9195: -- Assignee: (was: Matthias J. Sax) > Use Randomized State Directory Names in

[GitHub] [kafka] mjsax commented on pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-12 Thread GitBox
mjsax commented on pull request #10532: URL: https://github.com/apache/kafka/pull/10532#issuecomment-818450072 Was also wondering about a potential error message -- not sure atm what error message a user would get if they run against 2.3 brokers and if the error message would be clear.

[GitHub] [kafka] mjsax commented on pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-12 Thread GitBox
mjsax commented on pull request #10532: URL: https://github.com/apache/kafka/pull/10532#issuecomment-818449362 As test against older broker versions, I started https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4463/ -- maybe we need to update some system tests... --

[GitHub] [kafka] ijuma commented on pull request #10531: KAFKA-12658: Include kafka-shell jar and dependencies in release tar

2021-04-12 Thread GitBox
ijuma commented on pull request #10531: URL: https://github.com/apache/kafka/pull/10531#issuecomment-818447856 This change has no impact on tests and the build part of the PR builder had succeeded. I went ahead and merged to trunk and 2.8. cc @vvcephei -- This is an automated message

[GitHub] [kafka] mjsax opened a new pull request #10532: KAFKA-8531: Change default replication factor config

2021-04-12 Thread GitBox
mjsax opened a new pull request #10532: URL: https://github.com/apache/kafka/pull/10532 Call for review @cadonna @ableegoldman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] ijuma merged pull request #10531: KAFKA-12658: Include kafka-shell jar and dependencies in release tar

2021-04-12 Thread GitBox
ijuma merged pull request #10531: URL: https://github.com/apache/kafka/pull/10531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] rodesai commented on a change in pull request #10460: KAFKA-10357: Use validate and setup during internal topics creation

2021-04-12 Thread GitBox
rodesai commented on a change in pull request #10460: URL: https://github.com/apache/kafka/pull/10460#discussion_r612131444 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/ChangelogTopics.java ## @@ -34,83 +40,64 @@ public class

[GitHub] [kafka] showuon commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-12 Thread GitBox
showuon commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-818440268 OK, let's see what other reviewer's thought. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-12 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818439327 @ableegoldman , the failed tests are un-related: ``` Build / ARM /

[GitHub] [kafka] hachikuji commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-12 Thread GitBox
hachikuji commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r612131031 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeTransactionsHandler.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to

[jira] [Commented] (KAFKA-12608) Simple identity pipeline sometimes loses data

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319890#comment-17319890 ] Matthias J. Sax commented on KAFKA-12608: - Could you provide the used input data to allow us to

[jira] [Updated] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12658: Affects Version/s: (was: 2.8.0) (was: 3.0.0) >

[jira] [Updated] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-12658: Fix Version/s: 2.8.0 > bin/kafka-metadata-shell.sh cannot find or load main class >

[GitHub] [kafka] ijuma opened a new pull request #10531: KAFKA-12658: Include kafka-shell jar in release tar

2021-04-12 Thread GitBox
ijuma opened a new pull request #10531: URL: https://github.com/apache/kafka/pull/10531 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes)

[GitHub] [kafka] mjsax commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-12 Thread GitBox
mjsax commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r612094560 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -118,20 +142,47 @@ final

[GitHub] [kafka] predatorray edited a comment on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-12 Thread GitBox
predatorray edited a comment on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-818424067 Hi, @showuon. Thanks for your review! As per your question, I just follow the suggestion from @viktorsomogyi in the previous pr #5858 . I think maybe a subclass of

[GitHub] [kafka] predatorray commented on pull request #10525: KAFKA-7572: Producer should not send requests with negative partition id

2021-04-12 Thread GitBox
predatorray commented on pull request #10525: URL: https://github.com/apache/kafka/pull/10525#issuecomment-818424067 Hi, @showuon. Thanks for your review! As per your question, I just follow the suggestion from @viktorsomogyi in the previous pr #5858 . I think maybe a subclass of

[GitHub] [kafka] ijuma merged pull request #10491: MINOR: Switch to using the Gradle RAT plugin

2021-04-12 Thread GitBox
ijuma merged pull request #10491: URL: https://github.com/apache/kafka/pull/10491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] ableegoldman commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10529: URL: https://github.com/apache/kafka/pull/10529#issuecomment-818405468 > admin.deleteTopic would never return null in production, and thus handling null within InternalTopicManager for this case seems not to make sense. Agreed, making

[jira] [Updated] (KAFKA-12661) ConfigEntry#equal does not compare other fields when value is NOT null

2021-04-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai updated KAFKA-12661: --- Priority: Minor (was: Major) > ConfigEntry#equal does not compare other fields when value

[GitHub] [kafka] dongjinleekr commented on pull request #10526: KAFKA-12655: CVE-2021-28165 - Upgrade jetty to 9.4.39

2021-04-12 Thread GitBox
dongjinleekr commented on pull request #10526: URL: https://github.com/apache/kafka/pull/10526#issuecomment-818401991 @omkreddy @edwin092 @showuon Thanks!!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Assigned] (KAFKA-12661) ConfigEntry#equal does not compare other fields when value is NOT null

2021-04-12 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai reassigned KAFKA-12661: -- Assignee: Chia-Ping Tsai > ConfigEntry#equal does not compare other fields when

[jira] [Created] (KAFKA-12661) ConfigEntry#equal does not compare other fields when value is NOT null

2021-04-12 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-12661: -- Summary: ConfigEntry#equal does not compare other fields when value is NOT null Key: KAFKA-12661 URL: https://issues.apache.org/jira/browse/KAFKA-12661 Project:

[GitHub] [kafka] chia7712 commented on a change in pull request #10446: MINOR: [ConfigEntry.class] add 'type' to 'toString' and 'hashCode'

2021-04-12 Thread GitBox
chia7712 commented on a change in pull request #10446: URL: https://github.com/apache/kafka/pull/10446#discussion_r612095615 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java ## @@ -149,24 +149,28 @@ public boolean equals(Object o) {

[GitHub] [kafka] mjsax commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-12 Thread GitBox
mjsax commented on pull request #10529: URL: https://github.com/apache/kafka/pull/10529#issuecomment-818392640 Updated the PR. > (although, why would the max poll interval impact a timeout related to the admin client? Or do I not understand where this timeout is ultimately coming

[GitHub] [kafka] mjsax commented on a change in pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-12 Thread GitBox
mjsax commented on a change in pull request #10529: URL: https://github.com/apache/kafka/pull/10529#discussion_r612089734 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -153,7 +156,8 @@ public void

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-12 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818386632 @ableegoldman , thank you. I'll monitor the PR build, and update here. You can go take a rest, and check it tomorrow (your time).  -- This is an automated message from the

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-12 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818378362 @ableegoldman , I updated the PR to wait until all streams reach "RUNNING" state before consuming records. Let's wait and see the test results. :) -- This is an automated

[jira] [Assigned] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-12658: --- Assignee: Ismael Juma > bin/kafka-metadata-shell.sh cannot find or load main class >

[jira] [Created] (KAFKA-12660) Do not update offset commit sensor after append failure

2021-04-12 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-12660: --- Summary: Do not update offset commit sensor after append failure Key: KAFKA-12660 URL: https://issues.apache.org/jira/browse/KAFKA-12660 Project: Kafka

[GitHub] [kafka] dengziming commented on pull request #10275: KAFKA-12434; Admin support for `DescribeProducers` API

2021-04-12 Thread GitBox
dengziming commented on pull request #10275: URL: https://github.com/apache/kafka/pull/10275#issuecomment-818372912 > Merging to trunk. @chia7712 Yeah, we should create some jiras. I was going to wait until the other use cases in KIP-664 had been fleshed out, but I guess there's no harm

[GitHub] [kafka] ableegoldman commented on pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10529: URL: https://github.com/apache/kafka/pull/10529#issuecomment-818368666 Personally I would slightly prefer to just increase the max.poll.interval if that's what defines the timeout (although, why would the max poll interval impact a timeout

[jira] [Resolved] (KAFKA-12637) Remove deprecated PartitionAssignor interface

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12637?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-12637. Resolution: Fixed > Remove deprecated PartitionAssignor interface >

[GitHub] [kafka] ableegoldman merged pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-12 Thread GitBox
ableegoldman merged pull request #10512: URL: https://github.com/apache/kafka/pull/10512 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] ableegoldman commented on pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10512: URL: https://github.com/apache/kafka/pull/10512#issuecomment-818367236 Merged to trunk -- thanks @dengziming ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] ableegoldman commented on pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10512: URL: https://github.com/apache/kafka/pull/10512#issuecomment-818366846 Well there were a large number of failures, but all of them are unrelated. Left a comment/reopened the ticket for all of the following:

[jira] [Reopened] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-8391: --- [~rhauch] [~kkonstantine] this test failed again -- based on the error message

[jira] [Created] (KAFKA-12659) Mirrormaker 2 - seeking to wrong offsets on restart

2021-04-12 Thread stuart (Jira)
stuart created KAFKA-12659: -- Summary: Mirrormaker 2 - seeking to wrong offsets on restart Key: KAFKA-12659 URL: https://issues.apache.org/jira/browse/KAFKA-12659 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319797#comment-17319797 ] A. Sophie Blee-Goldman commented on KAFKA-9013: --- Failed again:

[jira] [Reopened] (KAFKA-12284) Flaky Test MirrorConnectorsIntegrationSSLTest#testOneWayReplicationWithAutoOffsetSync

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reopened KAFKA-12284: Assignee: (was: Luke Chen) Failed again, on both the SSL and plain

[jira] [Commented] (KAFKA-12629) Flaky Test RaftClusterTest

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319794#comment-17319794 ] A. Sophie Blee-Goldman commented on KAFKA-12629: I'm seeing at least one failure in

[jira] [Updated] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-12658: - Priority: Blocker (was: Major) > bin/kafka-metadata-shell.sh cannot find or load main class >

[jira] [Assigned] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler reassigned KAFKA-12658: Assignee: (was: John Roesler) > bin/kafka-metadata-shell.sh cannot find or load main

[jira] [Created] (KAFKA-12658) bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell

2021-04-12 Thread Israel Ekpo (Jira)
Israel Ekpo created KAFKA-12658: --- Summary: bin/kafka-metadata-shell.sh cannot find or load main class org.apache.kafka.shell.MetadataShell Key: KAFKA-12658 URL: https://issues.apache.org/jira/browse/KAFKA-12658

[GitHub] [kafka] ableegoldman merged pull request #10411: KAFKA-7606: Remove deprecated options from StreamsResetter

2021-04-12 Thread GitBox
ableegoldman merged pull request #10411: URL: https://github.com/apache/kafka/pull/10411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [kafka] mumrah commented on a change in pull request #10505: MINOR: fix some bugs in ControllerApis.scala

2021-04-12 Thread GitBox
mumrah commented on a change in pull request #10505: URL: https://github.com/apache/kafka/pull/10505#discussion_r612039100 ## File path: core/src/main/scala/kafka/server/ControllerApis.scala ## @@ -343,21 +366,22 @@ class ControllerApis(val requestChannel: RequestChannel,

[GitHub] [kafka] showuon commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-12 Thread GitBox
showuon commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818309573 Sure, I'll update the PR later. I removed it because I tried before and it doesn't work well. Let's try it again  -- This is an automated message from the Apache Git

[jira] [Resolved] (KAFKA-12643) Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function)

2021-04-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-12643. --- Resolution: Duplicate Thanks for confirming! > Kafka Streams 2.7 with Kafka Broker 2.6.x

[jira] [Commented] (KAFKA-12642) Improve Rebalance reason upon metadata change

2021-04-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319766#comment-17319766 ] Guozhang Wang commented on KAFKA-12642: --- Hi [~nicolas.guyomar] Maybe in the existing log message,

[GitHub] [kafka] kpatelatwork opened a new pull request #10530: KAFKA-10231 fail bootstrap of Rest server if the host name in the adv…

2021-04-12 Thread GitBox
kpatelatwork opened a new pull request #10530: URL: https://github.com/apache/kafka/pull/10530 …ertised uri is invalid and other nodes can't reach it. Node names have rules about what characters they can have and maximum length like in RFC-1123. The node-node communication over REST API

[jira] [Assigned] (KAFKA-8605) Warn users when they have same connector in their plugin-path more than once

2021-04-12 Thread Kalpesh Patel (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kalpesh Patel reassigned KAFKA-8605: Assignee: Kalpesh Patel > Warn users when they have same connector in their plugin-path

[GitHub] [kafka] mjsax commented on pull request #10506: MINOR: Improve description of `max.poll.records` config

2021-04-12 Thread GitBox
mjsax commented on pull request #10506: URL: https://github.com/apache/kafka/pull/10506#issuecomment-818278763 Merged to `trunk` and cherry-picked to `2.8` and `2.7` branches. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (KAFKA-12643) Kafka Streams 2.7 with Kafka Broker 2.6.x regression: bad timestamp in transform/process (this.context.schedule function)

2021-04-12 Thread David EVANO (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319735#comment-17319735 ] David EVANO commented on KAFKA-12643: - Hello, Yes, this seems to be a duplicate of the mentioned

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611957903 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[GitHub] [kafka] mjsax merged pull request #10506: MINOR: Improve description of `max.poll.records` config

2021-04-12 Thread GitBox
mjsax merged pull request #10506: URL: https://github.com/apache/kafka/pull/10506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Created] (KAFKA-12657) Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop

2021-04-12 Thread Matthias J. Sax (Jira)
Matthias J. Sax created KAFKA-12657: --- Summary: Flaky Tests BlockingConnectorTest.testWorkerRestartWithBlockInConnectorStop Key: KAFKA-12657 URL: https://issues.apache.org/jira/browse/KAFKA-12657

[jira] [Comment Edited] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319715#comment-17319715 ] Matthias J. Sax edited comment on KAFKA-12566 at 4/12/21, 8:59 PM: ---

[jira] [Commented] (KAFKA-12566) Flaky Test MirrorConnectorsIntegrationSSLTest#testReplication

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319715#comment-17319715 ] Matthias J. Sax commented on KAFKA-12566: -

[GitHub] [kafka] mjsax commented on pull request #10493: MINOR: cleanup Jenkins workspace before build

2021-04-12 Thread GitBox
mjsax commented on pull request #10493: URL: https://github.com/apache/kafka/pull/10493#issuecomment-818144809 Thanks @ijuma! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [kafka] mjsax closed pull request #10493: MINOR: cleanup Jenkins workspace before build

2021-04-12 Thread GitBox
mjsax closed pull request #10493: URL: https://github.com/apache/kafka/pull/10493 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-12 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611915606 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-12 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611915696 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[jira] [Commented] (KAFKA-12654) separate checkAllSubscriptionEqual and getConsumerToOwnedPartitions methods

2021-04-12 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319675#comment-17319675 ] A. Sophie Blee-Goldman commented on KAFKA-12654: To be honest, the sticky assignment

[GitHub] [kafka] ableegoldman commented on pull request #10409: KAFKA-9295: improve KTableKTableForeignKeyInnerJoinMultiIntegrationTest

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10409: URL: https://github.com/apache/kafka/pull/10409#issuecomment-818077023 It looks like the test failed in this most recent run -- however that's not unexpected since I think you may have accidentally taken out the other fix which probably

[GitHub] [kafka] ableegoldman commented on pull request #10512: KAFKA-12637: Remove deprecated PartitionAssignor interface

2021-04-12 Thread GitBox
ableegoldman commented on pull request #10512: URL: https://github.com/apache/kafka/pull/10512#issuecomment-818074480 Hm, the build was aborted -- looks like the gradle daemon was killed or crashed for some reason? I'll kick off a new run, let's hope this one passes -- This is an

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-12 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611882455 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamJoin.java ## @@ -102,14 +127,98 @@ public void process(final

[GitHub] [kafka] spena commented on a change in pull request #10462: KAFKA-10847: Fix spurious results on left/outer stream-stream joins

2021-04-12 Thread GitBox
spena commented on a change in pull request #10462: URL: https://github.com/apache/kafka/pull/10462#discussion_r611878043 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamImplJoin.java ## @@ -211,6 +246,66 @@ private void

[jira] [Created] (KAFKA-12656) JMX exporter is leaking a lot of file descriptors

2021-04-12 Thread Liang Xia (Jira)
Liang Xia created KAFKA-12656: - Summary: JMX exporter is leaking a lot of file descriptors Key: KAFKA-12656 URL: https://issues.apache.org/jira/browse/KAFKA-12656 Project: Kafka Issue Type: Bug

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611863824 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -194,14 +196,45 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611859318 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -194,14 +196,45 @@ private void completeCurrentBatch() {

[GitHub] [kafka] hachikuji commented on a change in pull request #10506: MINOR: Improve description of `max.poll.records` config

2021-04-12 Thread GitBox
hachikuji commented on a change in pull request #10506: URL: https://github.com/apache/kafka/pull/10506#discussion_r611840016 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java ## @@ -66,7 +66,8 @@ /** max.poll.records */

[GitHub] [kafka] kowshik commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-12 Thread GitBox
kowshik commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r611830920 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason {

[jira] [Updated] (KAFKA-10888) Sticky partition leads to uneven product msg, resulting in abnormal delays in some partitions

2021-04-12 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10888?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-10888: -- Summary: Sticky partition leads to uneven product msg, resulting in abnormal delays in some

[GitHub] [kafka] mjsax opened a new pull request #10529: KAFKA-12650: fix NPE in InternalTopicManagerTest

2021-04-12 Thread GitBox
mjsax opened a new pull request #10529: URL: https://github.com/apache/kafka/pull/10529 The NPE arrises, if we cannot setup topics quickly enough, and run into a timeout -- for this case, we try to call `admit.delete` (note that `admin` is mocked) that returns `null`. However, we

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611787145 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -194,14 +196,45 @@ private void completeCurrentBatch() {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611781359 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private

[GitHub] [kafka] satishd commented on a change in pull request #10478: KAFKA-12553: Refactor recovery logic to introduce LogLoader

2021-04-12 Thread GitBox
satishd commented on a change in pull request #10478: URL: https://github.com/apache/kafka/pull/10478#discussion_r611789255 ## File path: core/src/main/scala/kafka/log/Log.scala ## @@ -255,19 +261,21 @@ case object SnapshotGenerated extends LogStartOffsetIncrementReason {

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611781359 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611781359 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611781359 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private

[GitHub] [kafka] mjsax commented on pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-12 Thread GitBox
mjsax commented on pull request #10042: URL: https://github.com/apache/kafka/pull/10042#issuecomment-817951507 Thanks for the fix @MarcoLotz! -- Merged to `trunk`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] mjsax merged pull request #10042: KAFKA-9527: fix NPE when using time-based argument for Stream Resetter

2021-04-12 Thread GitBox
mjsax merged pull request #10042: URL: https://github.com/apache/kafka/pull/10042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Commented] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319549#comment-17319549 ] Matthias J. Sax commented on KAFKA-12650: -

[jira] [Assigned] (KAFKA-12650) NPE in InternalTopicManager#cleanUpCreatedTopics

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-12650: --- Assignee: Matthias J. Sax > NPE in InternalTopicManager#cleanUpCreatedTopics >

[jira] [Commented] (KAFKA-9013) Flaky Test MirrorConnectorsIntegrationTest#testReplication

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319546#comment-17319546 ] Matthias J. Sax commented on KAFKA-9013:

[jira] [Commented] (KAFKA-12629) Flaky Test RaftClusterTest

2021-04-12 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319548#comment-17319548 ] Matthias J. Sax commented on KAFKA-12629: - Another timeout:

[GitHub] [kafka] jsancio commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
jsancio commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r611772289 ## File path: raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java ## @@ -1876,12 +1836,12 @@ private void appendBatch( } private

[GitHub] [kafka] dielhennr commented on a change in pull request #10480: KAFKA-12265: Move the BatchAccumulator in KafkaRaftClient to LeaderState

2021-04-12 Thread GitBox
dielhennr commented on a change in pull request #10480: URL: https://github.com/apache/kafka/pull/10480#discussion_r610281681 ## File path: raft/src/main/java/org/apache/kafka/raft/internals/BatchAccumulator.java ## @@ -202,6 +203,25 @@ private void completeCurrentBatch() {

[jira] [Commented] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-04-12 Thread amuthan Ganeshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17319521#comment-17319521 ] amuthan Ganeshan commented on KAFKA-12559: -- Thanks, [~ableegoldman], for the explanation; yep,

[jira] [Assigned] (KAFKA-12559) Add a top-level Streams config for bounding off-heap memory

2021-04-12 Thread amuthan Ganeshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] amuthan Ganeshan reassigned KAFKA-12559: Assignee: amuthan Ganeshan > Add a top-level Streams config for bounding

[GitHub] [kafka] jthurne commented on pull request #10491: MINOR: Switch to using the Gradle RAT plugin

2021-04-12 Thread GitBox
jthurne commented on pull request #10491: URL: https://github.com/apache/kafka/pull/10491#issuecomment-817901760 Interesting. When I run the rat task locally, those three files are identified (correctly) as binary files and RAT skips them. I'm not sure why they are being detected as

[GitHub] [kafka] C0urante commented on pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2021-04-12 Thread GitBox
C0urante commented on pull request #10528: URL: https://github.com/apache/kafka/pull/10528#issuecomment-817894272 @ncliang @gharris1727 @kpatelatwork @ddasarathan could one or two of you take a look at this when you have time? -- This is an automated message from the Apache Git Service.

[GitHub] [kafka] dajac commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-12 Thread GitBox
dajac commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r611717669 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/DescribeTransactionsHandler.java ## @@ -0,0 +1,181 @@ +/* + * Licensed to the

[GitHub] [kafka] dajac commented on a change in pull request #10483: KAFKA-12586; Add `DescribeTransactions` Admin API

2021-04-12 Thread GitBox
dajac commented on a change in pull request #10483: URL: https://github.com/apache/kafka/pull/10483#discussion_r611715337 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeTransactionsResult.java ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] C0urante opened a new pull request #10528: KAFKA-12497: Skip unnecessary source task offset commits

2021-04-12 Thread GitBox
C0urante opened a new pull request #10528: URL: https://github.com/apache/kafka/pull/10528 [Jira](https://issues.apache.org/jira/browse/KAFKA-12497) This change serves two purposes: 1. Eliminate unnecessary log messages for offset commit of tasks that don't need to perform offset

[GitHub] [kafka] kkonstantine merged pull request #10503: KAFKA-9988: Suppress uncaught exceptions in log messages during Connect task shutdown

2021-04-12 Thread GitBox
kkonstantine merged pull request #10503: URL: https://github.com/apache/kafka/pull/10503 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[jira] [Resolved] (KAFKA-7249) Provide an official Docker Hub image for Kafka

2021-04-12 Thread Timothy Higinbottom (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Timothy Higinbottom resolved KAFKA-7249. Resolution: Not A Problem > Provide an official Docker Hub image for Kafka >

[jira] [Resolved] (KAFKA-12408) Document omitted ReplicaManager metrics

2021-04-12 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12408?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tom Bentley resolved KAFKA-12408. - Fix Version/s: 3.0.0 Reviewer: Tom Bentley Resolution: Fixed > Document omitted

[GitHub] [kafka] vvcephei commented on pull request #10527: Merge trunk 04/12

2021-04-12 Thread GitBox
vvcephei commented on pull request #10527: URL: https://github.com/apache/kafka/pull/10527#issuecomment-817865515 Oy, just saw that, too. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

  1   2   >