[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416280171 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/FallbackPriorTaskAssignor.java ## @@ -0,0 +1,49 @@ +/* + *

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-27 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620359124 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-27 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620370010 Java 11: org.apache.kafka.streams.examples.wordcount.WordCountDemoTest.testOneWord

[GitHub] [kafka] ivanyu commented on pull request #8196: KAFKA-9478: Remove zombie partition reassignments from ZooKeeper

2020-04-27 Thread GitBox
ivanyu commented on pull request #8196: URL: https://github.com/apache/kafka/pull/8196#issuecomment-620371657 @jtrenholm-jask that's pretty much the only workaround I've found so far This is an automated message from the

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416283374 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -713,23 +713,18 @@ private boolean

[GitHub] [kafka] vvcephei commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-27 Thread GitBox
vvcephei commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-620376298 Just to be sure we don't break the system tests upon merging, I've kicked off the branch-builder: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3919/console

[GitHub] [kafka] guozhangwang commented on a change in pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-27 Thread GitBox
guozhangwang commented on a change in pull request #8568: URL: https://github.com/apache/kafka/pull/8568#discussion_r416327335 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/IntegrationTestUtils.java ## @@ -210,16 +210,21 @@ public static void

[GitHub] [kafka] kkonstantine commented on a change in pull request #8560: MINOR: update raft borken link

2020-04-27 Thread GitBox
kkonstantine commented on a change in pull request #8560: URL: https://github.com/apache/kafka/pull/8560#discussion_r416289639 ## File path: docs/design.html ## @@ -366,7 +366,7 @@ Replicated Logs: Q There are a rich variety of algorithms in this family including

[GitHub] [kafka] showuon commented on a change in pull request #8560: MINOR: Update raft broken link

2020-04-27 Thread GitBox
showuon commented on a change in pull request #8560: URL: https://github.com/apache/kafka/pull/8560#discussion_r416291423 ## File path: docs/design.html ## @@ -366,7 +366,7 @@ Replicated Logs: Q There are a rich variety of algorithms in this family including

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-27 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620359206 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-27 Thread GitBox
vvcephei commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620359460 test this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8540: KAFKA-9127: don't create StreamThreads for global-only topology

2020-04-27 Thread GitBox
vvcephei commented on pull request #8540: URL: https://github.com/apache/kafka/pull/8540#issuecomment-620359273 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on pull request #8564: KAFKA-9921: disable caching on stores configured to retain duplicates

2020-04-27 Thread GitBox
vvcephei commented on pull request #8564: URL: https://github.com/apache/kafka/pull/8564#issuecomment-620359328 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] bseenu commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-27 Thread GitBox
bseenu commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-620363500 @thspinto Thanks, I tried to test it today. And see the case where consumer group not existing at the target site works fine, But if it exists but has no active members does not

[GitHub] [kafka] guozhangwang opened a new pull request #8568: KAFKA-9176: Retry on getting local stores from KafkaStreams

2020-04-27 Thread GitBox
guozhangwang opened a new pull request #8568: URL: https://github.com/apache/kafka/pull/8568 This PR fixes and improves two major issues: 1. When calling `KafkaStreams#store` we can always get an InvalidStateStoreException, and even waiting for Streams state to become RUNNING is

[GitHub] [kafka] cmccabe opened a new pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-27 Thread GitBox
cmccabe opened a new pull request #8569: URL: https://github.com/apache/kafka/pull/8569 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] kkonstantine commented on pull request #8561: MINOR: Fix typos in test mm2 config

2020-04-27 Thread GitBox
kkonstantine commented on pull request #8561: URL: https://github.com/apache/kafka/pull/8561#issuecomment-620345871 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on a change in pull request #8541: KAFKA-6145: KIP-441: Add TaskAssignor class config

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8541: URL: https://github.com/apache/kafka/pull/8541#discussion_r416297248 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -712,31 +712,32 @@ private boolean

[GitHub] [kafka] vvcephei commented on a change in pull request #8254: KIP-557: Add Emit On Change Support

2020-04-27 Thread GitBox
vvcephei commented on a change in pull request #8254: URL: https://github.com/apache/kafka/pull/8254#discussion_r416313567 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KTableSource.java ## @@ -108,7 +126,9 @@ public void process(final K key,

[GitHub] [kafka] bseenu edited a comment on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-27 Thread GitBox
bseenu edited a comment on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-620363500 @thspinto Thanks, I tried to test it today. And see the case where consumer group not existing at the target site works fine, But if it exists but has no active members

[GitHub] [kafka] kkonstantine commented on pull request #8559: KAFKA-9922:Update examples README

2020-04-27 Thread GitBox
kkonstantine commented on pull request #8559: URL: https://github.com/apache/kafka/pull/8559#issuecomment-620391246 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] chia7712 commented on a change in pull request #8556: MINOR: Add a duplicate() method to Message classes

2020-04-27 Thread GitBox
chia7712 commented on a change in pull request #8556: URL: https://github.com/apache/kafka/pull/8556#discussion_r415539913 ## File path: generator/src/main/java/org/apache/kafka/message/MessageDataGenerator.java ## @@ -2112,6 +2131,83 @@ private void

[GitHub] [kafka] chia7712 opened a new pull request #8557: MINOR: fix typo "transation" in AddPartitionsToTxnRequest.json

2020-04-27 Thread GitBox
chia7712 opened a new pull request #8557: URL: https://github.com/apache/kafka/pull/8557 **transation** -> **transaction** ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ]

[GitHub] [kafka] zhaohaidao opened a new pull request #8550: KAFKA-9850 Move KStream#repartition operator validation during Topolo…

2020-04-25 Thread GitBox
zhaohaidao opened a new pull request #8550: URL: https://github.com/apache/kafka/pull/8550 Tickets: KAFKA-9850 Move some repartition operator validation to topology.build() This is an automated message from

[GitHub] [kafka] omkreddy commented on a change in pull request #8184: KAKFA-9612 CLI Dynamic Configuration with file input

2020-04-25 Thread GitBox
omkreddy commented on a change in pull request #8184: URL: https://github.com/apache/kafka/pull/8184#discussion_r415020856 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -424,12 +483,33 @@ class ConfigCommandTest extends ZooKeeperTestHarness

[GitHub] [kafka] omkreddy commented on a change in pull request #8184: KAKFA-9612 CLI Dynamic Configuration with file input

2020-04-25 Thread GitBox
omkreddy commented on a change in pull request #8184: URL: https://github.com/apache/kafka/pull/8184#discussion_r415015661 ## File path: core/src/test/scala/unit/kafka/admin/ConfigCommandTest.scala ## @@ -40,8 +41,8 @@ import org.junit.Assert._ import org.junit.Test import

[GitHub] [kafka] tombentley opened a new pull request #8571: KAFKA-7613: Enable -Xlint:rawtypes for connect, fixing warnings

2020-04-28 Thread GitBox
tombentley opened a new pull request #8571: URL: https://github.com/apache/kafka/pull/8571 Fix all existing javac warnings about use of raw types in Kafka Connect add -Xlint:rawtypes to the connect the javac options in build.gradle. This addresses part of KAFKA-7613, but further work will

[GitHub] [kafka] tombentley commented on pull request #8571: KAFKA-7613: Enable -Xlint:rawtypes for connect, fixing warnings

2020-04-28 Thread GitBox
tombentley commented on pull request #8571: URL: https://github.com/apache/kafka/pull/8571#issuecomment-620496101 @ijuma and @ewencp could one of you take a look at this? This is an automated message from the Apache Git

[GitHub] [kafka] leonardge commented on pull request #8566: Fix minor code issue

2020-04-28 Thread GitBox
leonardge commented on pull request #8566: URL: https://github.com/apache/kafka/pull/8566#issuecomment-620445718 Is this due to flaky tests? The failed test is: kafka.api.PlaintextAdminIntegrationTest.testCreatePartitions

[GitHub] [kafka] Hangleton commented on a change in pull request #8569: KIP-551: Expose disk read and write metrics

2020-04-28 Thread GitBox
Hangleton commented on a change in pull request #8569: URL: https://github.com/apache/kafka/pull/8569#discussion_r416391699 ## File path: core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala ## @@ -0,0 +1,96 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [kafka] ijuma commented on pull request #8533: KAFKA-9589: Fixed bug in V2 log validator tests

2020-04-26 Thread GitBox
ijuma commented on pull request #8533: URL: https://github.com/apache/kafka/pull/8533#issuecomment-619696479 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mateuszjadczykDna commented on a change in pull request #8553: KAFKA-9891: Add integration test to replicate standby task failover

2020-04-28 Thread GitBox
mateuszjadczykDna commented on a change in pull request #8553: URL: https://github.com/apache/kafka/pull/8553#discussion_r416421730 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskFailOverIntegrationTest.java ## @@ -0,0 +1,283 @@ +/* + *

[GitHub] [kafka] tombentley commented on pull request #8312: KAFKA-9432 automated protocol for DescribeConfigs

2020-04-28 Thread GitBox
tombentley commented on pull request #8312: URL: https://github.com/apache/kafka/pull/8312#issuecomment-620478691 Rebased for conflict. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] tombentley commented on pull request #8204: Ensure ConfigProviders are closed

2020-04-28 Thread GitBox
tombentley commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-620481500 @kkonstantine any change of merging this? This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] mateuszjadczykDna commented on a change in pull request #8553: KAFKA-9891: Add integration test to replicate standby task failover

2020-04-28 Thread GitBox
mateuszjadczykDna commented on a change in pull request #8553: URL: https://github.com/apache/kafka/pull/8553#discussion_r416422911 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskFailOverIntegrationTest.java ## @@ -0,0 +1,283 @@ +/* + *

[GitHub] [kafka] mateuszjadczykDna commented on a change in pull request #8553: KAFKA-9891: Add integration test to replicate standby task failover

2020-04-28 Thread GitBox
mateuszjadczykDna commented on a change in pull request #8553: URL: https://github.com/apache/kafka/pull/8553#discussion_r416423660 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskFailOverIntegrationTest.java ## @@ -0,0 +1,283 @@ +/* + *

[GitHub] [kafka] mateuszjadczykDna commented on a change in pull request #8553: KAFKA-9891: Add integration test to replicate standby task failover

2020-04-28 Thread GitBox
mateuszjadczykDna commented on a change in pull request #8553: URL: https://github.com/apache/kafka/pull/8553#discussion_r416423943 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/StandbyTaskFailOverIntegrationTest.java ## @@ -0,0 +1,283 @@ +/* + *

[GitHub] [kafka] bseenu commented on a change in pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-28 Thread GitBox
bseenu commented on a change in pull request #7577: URL: https://github.com/apache/kafka/pull/7577#discussion_r416436144 ## File path: connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointTask.java ## @@ -190,4 +227,103 @@ public void

[GitHub] [kafka] leonardge opened a new pull request #8570: Change type to optional in config entry

2020-04-28 Thread GitBox
leonardge opened a new pull request #8570: URL: https://github.com/apache/kafka/pull/8570 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621550649 When a record triggers a retry exception and the retry is processed successfully, its offset does not commit

[GitHub] [kafka] jiangchuan-java removed a comment on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java removed a comment on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621551646 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621571077 > @jiangchuan-java what's the purpose of this PR? > > You'll need to keep only the relevant commits and target your PR against `trunk` When a record triggers

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621576489 > @jiangchuan-java what's the purpose of this PR? > > You'll need to keep only the relevant commits and target your PR against `trunk`

[GitHub] [kafka] jiangchuan-java removed a comment on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java removed a comment on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621576489 > @jiangchuan-java what's the purpose of this PR? > > You'll need to keep only the relevant commits and target your PR against `trunk`

[GitHub] [kafka] wj1918 commented on pull request #8563: MINOR: Fix broken JMX URL in docs

2020-04-29 Thread GitBox
wj1918 commented on pull request #8563: URL: https://github.com/apache/kafka/pull/8563#issuecomment-621584636 duplicate with #8587 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei opened a new pull request #8588: [WIP] KAFKA-6145: KIP-441: Validate balanced assignment

2020-04-29 Thread GitBox
vvcephei opened a new pull request #8588: URL: https://github.com/apache/kafka/pull/8588 Add validation that task assignment is always balanced after convergence. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test

[GitHub] [kafka] vvcephei edited a comment on pull request #8588: [WIP] KAFKA-6145: KIP-441: Validate balanced assignment

2020-04-29 Thread GitBox
vvcephei edited a comment on pull request #8588: URL: https://github.com/apache/kafka/pull/8588#issuecomment-621590516 Oh, and just to put it out there, I know I need to fix the messy diff computations. I just stamped out something quick to see what you thought about the approach.

[GitHub] [kafka] vvcephei commented on pull request #8588: [WIP] KAFKA-6145: KIP-441: Validate balanced assignment

2020-04-29 Thread GitBox
vvcephei commented on pull request #8588: URL: https://github.com/apache/kafka/pull/8588#issuecomment-621590516 Oh, and just to put it out there, I know I need to fix the diff computations. I just stamped out something quick to see what you thought about the approach.

[GitHub] [kafka] kkonstantine commented on pull request #8554: KAFKA-9919: Add logging to KafkaBasedLog::readToLogEnd

2020-04-29 Thread GitBox
kkonstantine commented on pull request #8554: URL: https://github.com/apache/kafka/pull/8554#issuecomment-621592493 Only flaky failures in unrelated tests: `GlobalKTableIntegrationTest` failed in all builds and `PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition` failed

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417738801 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -0,0 +1,1123 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417739068 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -0,0 +1,1123 @@ +/* + * Licensed to the

[GitHub] [kafka] kkonstantine commented on pull request #8036: Minor: fix the unused arguments used by formatting string

2020-04-30 Thread GitBox
kkonstantine commented on pull request #8036: URL: https://github.com/apache/kafka/pull/8036#issuecomment-621630861 Merged to `trunk`, `2.5` and `2.4` This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] showuon commented on a change in pull request #8581: MINOR: Fix typo and rephrase content in docs

2020-04-30 Thread GitBox
showuon commented on a change in pull request #8581: URL: https://github.com/apache/kafka/pull/8581#discussion_r417773241 ## File path: docs/ops.html ## @@ -676,7 +676,7 @@ 6.4 Java Version From a security perspective, we recommend you use the latest released version of

[GitHub] [kafka] Maatary commented on pull request #6428: KAFKA-7224: [WIP] Persistent Suppress [WIP]

2020-04-29 Thread GitBox
Maatary commented on pull request #6428: URL: https://github.com/apache/kafka/pull/6428#issuecomment-621618656 Would be nice to have someone resume on this. Feature is very critical and important. It would solve a rather very critical scenario, especially if implemented together with

[GitHub] [kafka] showuon commented on pull request #8581: MINOR: Fix typo and rephrase content in docs

2020-04-29 Thread GitBox
showuon commented on pull request #8581: URL: https://github.com/apache/kafka/pull/8581#issuecomment-621625513 Hi @kkonstantine , if you have time, would you please help review this small PR? Thank you. This is an automated

[GitHub] [kafka] feyman2016 opened a new pull request #8589: KAFKA-9146: Add option to force delete active members in StreamsResetter

2020-04-30 Thread GitBox
feyman2016 opened a new pull request #8589: URL: https://github.com/apache/kafka/pull/8589 This PR is mainly to enhance https://issues.apache.org/jira/browse/KAFKA-9146. - `KafkaAdminClient#removeMembersFromConsumerGroup` now support "removeAll" members in a given group - New

[GitHub] [kafka] kkonstantine commented on a change in pull request #8581: MINOR: Fix typo and rephrase content in docs

2020-04-29 Thread GitBox
kkonstantine commented on a change in pull request #8581: URL: https://github.com/apache/kafka/pull/8581#discussion_r417767601 ## File path: docs/ops.html ## @@ -676,7 +676,7 @@ 6.4 Java Version From a security perspective, we recommend you use the latest released

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417738371 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -1064,14 +1071,16 @@ private void

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417738073 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -388,6 +388,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417738193 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -881,6 +882,10 @@ public void close() { }

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417739843 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -0,0 +1,1123 @@ +/* + * Licensed to the

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-29 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-621530837 @vvcephei Looks like I forgot to push. You can retrigger the tests after this one. This is an

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-04-29 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r417687040 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerder.java ## @@ -191,32 +192,71 @@ public

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-04-29 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r377915173 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -808,38 +813,45 @@ public ConnectMetrics metrics() {

[GitHub] [kafka] kkonstantine commented on a change in pull request #8069: KAFKA-9374: Make connector interactions asynchronous

2020-04-29 Thread GitBox
kkonstantine commented on a change in pull request #8069: URL: https://github.com/apache/kafka/pull/8069#discussion_r377915173 ## File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Worker.java ## @@ -808,38 +813,45 @@ public ConnectMetrics metrics() {

[GitHub] [kafka] showuon opened a new pull request #8587: MINOR: Fix broken JMX link by adding missing starting double quote

2020-04-29 Thread GitBox
showuon opened a new pull request #8587: URL: https://github.com/apache/kafka/pull/8587 The `href` attribute missed the starting double quote, so the hyperlink is interpreted as `https://docs.oracle.com/.../agent.html"`, with a redundant tailing double quote. Add the missing starting

[GitHub] [kafka] kkonstantine commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
kkonstantine commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621577922 If your intention is to report an issue, my recommendation would be to first open a jira ticket in: https://issues.apache.org/jira/projects/KAFKA/issues Then, if

[GitHub] [kafka] vvcephei commented on pull request #8588: [WIP] KAFKA-6145: KIP-441: Validate balanced assignment

2020-04-29 Thread GitBox
vvcephei commented on pull request #8588: URL: https://github.com/apache/kafka/pull/8588#issuecomment-621589430 Hey @ableegoldman @cadonna , I thought it would be good to add verification that the converged assignment is actually balanced to our randomized test. Really, I had

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417740290 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -0,0 +1,1123 @@ +/* + * Licensed to the

[GitHub] [kafka] mjsax commented on pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on pull request #8496: URL: https://github.com/apache/kafka/pull/8496#issuecomment-621599022 Updated this PR. Call for review. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] kkonstantine commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
kkonstantine commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621535084 @jiangchuan-java what's the purpose of this PR? You'll need to keep only the relevant commits and target your PR against `trunk`

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621572060 > @jiangchuan-java what's the purpose of this PR? > > You'll need to keep only the relevant commits and target your PR against `trunk` my kafka version :

[GitHub] [kafka] ConcurrencyPractitioner commented on pull request #8254: KIP-557: Add Emit On Change Support

2020-04-29 Thread GitBox
ConcurrencyPractitioner commented on pull request #8254: URL: https://github.com/apache/kafka/pull/8254#issuecomment-621583048 @vvcephei Alright, all tests passed (looks like there were some flakies) and all comments addressed.

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417739443 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosBetaUpgradeIntegrationTest.java ## @@ -0,0 +1,1123 @@ +/* + * Licensed to the

[GitHub] [kafka] hachikuji commented on a change in pull request #8586: KAFKA-9939; Fix overcounting delayed fetches in request rate metrics

2020-04-29 Thread GitBox
hachikuji commented on a change in pull request #8586: URL: https://github.com/apache/kafka/pull/8586#discussion_r417688549 ## File path: core/src/test/scala/unit/kafka/server/SimpleFetchTest.scala ## @@ -1,206 +0,0 @@ -/** - * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621551646 if (msgs.count() > 0) origOffsets.clear(); Solve the problem This is an automated message

[GitHub] [kafka] jiangchuan-java commented on pull request #8583: 2.2 WorkerSinkTask.convertMessages loss of offset

2020-04-29 Thread GitBox
jiangchuan-java commented on pull request #8583: URL: https://github.com/apache/kafka/pull/8583#issuecomment-621576206 > @jiangchuan-java what's the purpose of this PR? > > You'll need to keep only the relevant commits and target your PR against `trunk` log detail

[GitHub] [kafka] mjsax commented on a change in pull request #8496: KAFKA-9748: Add Streams eos-beta integration test

2020-04-29 Thread GitBox
mjsax commented on a change in pull request #8496: URL: https://github.com/apache/kafka/pull/8496#discussion_r417737952 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1283,9 +1284,6 @@ private void

[GitHub] [kafka] viktorsomogyi commented on pull request #6011: [WIP] KAFKA-6794: Incremental partition reassignment

2020-04-30 Thread GitBox
viktorsomogyi commented on pull request #6011: URL: https://github.com/apache/kafka/pull/6011#issuecomment-621716362 Closing this as the discussions on the related kip resulted in delaying the related work. This is an

[GitHub] [kafka] vvcephei commented on pull request #8578: KAFKA-9875: Make integration tests more resilient

2020-04-29 Thread GitBox
vvcephei commented on pull request #8578: URL: https://github.com/apache/kafka/pull/8578#issuecomment-621425603 Thanks, @guozhangwang ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #7082: KAFKA-8659: SetSchemaMetadata SMT fails on records with null value and schema

2020-04-30 Thread GitBox
kkonstantine commented on pull request #7082: URL: https://github.com/apache/kafka/pull/7082#issuecomment-621703287 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] kkonstantine commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-30 Thread GitBox
kkonstantine commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-621707808 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] viktorsomogyi commented on pull request #7716: Group and Txn metadata topics should be queried directly from the controller

2020-04-30 Thread GitBox
viktorsomogyi commented on pull request #7716: URL: https://github.com/apache/kafka/pull/7716#issuecomment-621710869 Hey folks, I'm closing this PR due to the lack of interest. If anyone interested, please feel free to pick up the related jira.

[GitHub] [kafka] feyman2016 commented on pull request #8020: KAFKA-9146 [WIP]: Add option to force delete active members in StreamsResetter

2020-04-30 Thread GitBox
feyman2016 commented on pull request #8020: URL: https://github.com/apache/kafka/pull/8020#issuecomment-621709849 Hi, all, sorry for the delay, I have created another PR, and request for review, thanks! https://github.com/apache/kafka/pull/8589/files

[GitHub] [kafka] feyman2016 edited a comment on pull request #8020: KAFKA-9146 [WIP]: Add option to force delete active members in StreamsResetter

2020-04-30 Thread GitBox
feyman2016 edited a comment on pull request #8020: URL: https://github.com/apache/kafka/pull/8020#issuecomment-621709849 Hi, @abbccdda, sorry for the delay, I have created another PR, and request for review, thanks! https://github.com/apache/kafka/pull/8589/files

[GitHub] [kafka] feyman2016 removed a comment on pull request #8020: KAFKA-9146 [WIP]: Add option to force delete active members in StreamsResetter

2020-04-30 Thread GitBox
feyman2016 removed a comment on pull request #8020: URL: https://github.com/apache/kafka/pull/8020#issuecomment-621224680 @abbccdda, I haven't pushed my local change after we have updated the KIP-571, will still update in this PR.

[GitHub] [kafka] viktorsomogyi commented on pull request #5620: KAFKA-1880: Add support for checking binary/source compatibility

2020-04-30 Thread GitBox
viktorsomogyi commented on pull request #5620: URL: https://github.com/apache/kafka/pull/5620#issuecomment-621715924 @ijuma @cmccabe any opinions if this can get merged in if I rebase it? I'm trying to clean up my open PR list so if you guys think this one is useful and something that

[GitHub] [kafka] kkonstantine commented on a change in pull request #7950: KAFKA-9419: Integer Overflow Possible with CircularIterator

2020-04-30 Thread GitBox
kkonstantine commented on a change in pull request #7950: URL: https://github.com/apache/kafka/pull/7950#discussion_r417807918 ## File path: clients/src/main/java/org/apache/kafka/common/utils/CircularIterator.java ## @@ -14,36 +14,89 @@ * See the License for the specific

[GitHub] [kafka] kkonstantine commented on pull request #5824: MINOR: Change logging level for not-found-plugin-class-loader message

2020-04-30 Thread GitBox
kkonstantine commented on pull request #5824: URL: https://github.com/apache/kafka/pull/5824#issuecomment-621673142 This is no more applicable, after https://github.com/apache/kafka/pull/7964 Closing without merging This

[GitHub] [kafka] kkonstantine commented on pull request #4958: Minor: Empty list returned by poll() destroys the source task when assert is enabled

2020-04-30 Thread GitBox
kkonstantine commented on pull request #4958: URL: https://github.com/apache/kafka/pull/4958#issuecomment-621681282 Closing this PR in favor of https://github.com/apache/kafka/pull/7491 which seems to have fixed the issue.

[GitHub] [kafka] tombentley commented on pull request #8204: KAFKA-9633: Ensure ConfigProviders are closed

2020-04-30 Thread GitBox
tombentley commented on pull request #8204: URL: https://github.com/apache/kafka/pull/8204#issuecomment-621697783 @kkonstantine I should have run all the tests. Lesson learned, and sorry for wasting your time. Now fixed (and tested).

[GitHub] [kafka] jeqo opened a new pull request #8584: MINOR: fix docs typo baseTimestamp to firstTimestamp

2020-04-29 Thread GitBox
jeqo opened a new pull request #8584: URL: https://github.com/apache/kafka/pull/8584 nit. `baseTimestamp` is used when `firstTimestamp` is defined on the on-disk format and implementation. This is an automated message from

[GitHub] [kafka] cadonna commented on pull request #8157: KAFKA-9088: Consolidate InternalMockProcessorContext and MockInternalProcessorContext

2020-04-30 Thread GitBox
cadonna commented on pull request #8157: URL: https://github.com/apache/kafka/pull/8157#issuecomment-621743226 @pierDipi Thank you for the updates. I will try to review it next week. This is an automated message from the

[GitHub] [kafka] WJL3333 edited a comment on pull request #5519: KAFKA-7186: Avoid re-instantiating UpdateMetadataReuqest and struct objects to reduce controller memory usage

2020-04-29 Thread GitBox
WJL edited a comment on pull request #5519: URL: https://github.com/apache/kafka/pull/5519#issuecomment-621137606 i think this patch can also save a lot of memory This is an automated message from the Apache Git Service.

[GitHub] [kafka] WJL3333 commented on pull request #5519: KAFKA-7186: Avoid re-instantiating UpdateMetadataReuqest and struct objects to reduce controller memory usage

2020-04-29 Thread GitBox
WJL commented on pull request #5519: URL: https://github.com/apache/kafka/pull/5519#issuecomment-621137606 i think this patch can also save a lot of memory usage This is an automated message from the Apache Git Service.

[GitHub] [kafka] cadonna commented on pull request #8590: KAFKA-6145: Remove check to reuse previous assignment

2020-04-30 Thread GitBox
cadonna commented on pull request #8590: URL: https://github.com/apache/kafka/pull/8590#issuecomment-621796799 Call for review: @ableegoldman @vvcephei This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] cadonna opened a new pull request #8590: KAFKA-6145: Remove check to reuse previous assignment

2020-04-30 Thread GitBox
cadonna opened a new pull request #8590: URL: https://github.com/apache/kafka/pull/8590 Since we cannot guarantee to reassign the correct number of stand-by tasks when reusing the previous assignment and the reassignment is rather a micro-optimization, it is removed to keep the

[GitHub] [kafka] mimaison commented on issue #8224: KAFKA-9704: Fix the issue z/OS won't let us resize file when mmap.

2020-04-23 Thread GitBox
mimaison commented on issue #8224: URL: https://github.com/apache/kafka/pull/8224#issuecomment-618536956 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] bseenu edited a comment on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
bseenu edited a comment on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618596724 @thspinto @ning2008wisc i am trying this , but i do not see the consumer offsets being populated on the target side, my consumer group is not dead i am polling for messages

[GitHub] [kafka] abbccdda commented on pull request #8326: KAFKA-8639: Replace AddPartitionsToTxn with Automated Protocol

2020-04-23 Thread GitBox
abbccdda commented on pull request #8326: URL: https://github.com/apache/kafka/pull/8326#issuecomment-618627112 Test only fails the flaky test: kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

<    5   6   7   8   9   10   11   12   13   14   >