[GitHub] [kafka] highluck commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

2020-05-07 Thread GitBox


highluck commented on a change in pull request #8114:
URL: https://github.com/apache/kafka/pull/8114#discussion_r421935086



##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -212,7 +212,7 @@
  * {@link KafkaStreams#store(StoreQueryParameters) 
KafkaStreams#store(...)}:
  * {@code
  * KafkaStreams streams = ...
- * ReadOnlyKeyValueStore> localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.>timestampedKeyValueStore());
+ * ReadOnlyKeyValueStore> localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.> 
timestampedKeyValueStore());

Review comment:
   thanks i updated!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [kafka] highluck commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

2020-04-20 Thread GitBox


highluck commented on a change in pull request #8114:
URL: https://github.com/apache/kafka/pull/8114#discussion_r411791026



##
File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java
##
@@ -208,13 +208,13 @@
  * streamBuilder.table(topic, Consumed.with(Serde.String(), 
Serde.String()), Materialized.as(storeName))
  * }
  * 
- * To query the local {@link KeyValueStore} it must be obtained via
+ * To query the local {@link ReadOnlyKeyValueStore} it must be obtained via
  * {@link KafkaStreams#store(StoreQueryParameters) 
KafkaStreams#store(...)}:
  * {@code
  * KafkaStreams streams = ...
- * ReadOnlyKeyValueStore localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.keyValueStore());
- * String key = "some-key";
- * Long valueForKey = localStore.get(key); // key must be local 
(application state is shared over all running Kafka Streams instances)
+ * ReadOnlyKeyValueStore> localStore = 
streams.store(queryableStoreName, QueryableStoreTypes.>timestampedKeyValueStore());

Review comment:
   ok! thanks :)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org