[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16626992#comment-16626992 ] Viktor Somogyi commented on KAFKA-3268: --- Published KIP-375 about TopicCommand. I'd be happy if anyone wants to participate the discussion: https://cwiki.apache.org/confluence/display/KAFKA/KIP-375%3A+TopicCommand+to+use+AdminClient > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16625545#comment-16625545 ] Viktor Somogyi commented on KAFKA-3268: --- [~enothereska] I'll publish a KIP this week about KAFKA-5561 (TopicCommand) and KAFKA-5722 is on its way too. Unfortunately lately I got stuck in other things. I'd be very happy if you could pick up KAFKA-5723 or KAFKA-5601, I think neither got continued. I'd gladly help in the KIP discussions or in the implementation too. > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16623611#comment-16623611 ] Eno Thereska commented on KAFKA-3268: - Is there an update on these? If not, might be good to release so others in the community can participate. > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16162553#comment-16162553 ] Paolo Patierno commented on KAFKA-3268: --- [~adyachkov] [~viktorsomogyi] regarding the common CommandOptions class (with some other utils) we need for tools refactoring I have pushed the proposal with this [https://github.com/apache/kafka/pull/3453]. It's not strictly related to command tools refactoring but the issue needed a refactoring for being more testable and it went in our direction. Feel free to comment the PR. I'm waiting for [~ijuma] review so that we could have this merged and a first version of the common stuff we need. > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16121405#comment-16121405 ] Paolo Patierno commented on KAFKA-3268: --- Great to see this JIRA as umbrella for the others. [~viktorsomogyi] I'm working on the TopicCommand refactoring. It could be great if you could take a look on the related PR (it's a WIP) just to be aligned on the way we handle parameters from the command line because in Java we are using a different tool then Scala for doing that (parsing CLI arguments and so on). We should agree on a way in order to have all the tools behave in the same way from this point of view. What do you think ? > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112603#comment-16112603 ] Tom Bentley commented on KAFKA-3268: [~viktorsomogyi] there is no tracking JIRA that I'm aware of. Rather than closing this one only to create a tracking one let's just use this JIRA. You're right, both those other commands will also need to be changed, so creating JIRAs and KIPs for those is fine with me. > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (KAFKA-3268) Refactor existing CLI scripts to use KafkaAdminClient
[ https://issues.apache.org/jira/browse/KAFKA-3268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16112591#comment-16112591 ] Viktor Somogyi commented on KAFKA-3268: --- [~tombentley], thanks for the heads up, I didn't know about these. I guess we can close this jira then? Do you know if there are any more jiras around refactoring the admin clients? Is there an umbrella jira which tracks the subtasks? I can see two tasks I'd be happy to do: refactoring the BrokerApiVersionsCommand command (this uses metadata request to collect the info, although through the deprecated AdminClient) and ConfigCommand (uses zookeeper directly, therefore probably needs kip). Shall I open jiras/kips accordingly? > Refactor existing CLI scripts to use KafkaAdminClient > - > > Key: KAFKA-3268 > URL: https://issues.apache.org/jira/browse/KAFKA-3268 > Project: Kafka > Issue Type: Sub-task >Reporter: Grant Henke >Assignee: Viktor Somogyi > -- This message was sent by Atlassian JIRA (v6.4.14#64029)
