[jira] [Commented] (KAFKA-5711) Bulk Restore Should Handle Deletes

2017-08-10 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16122053#comment-16122053
 ] 

ASF GitHub Bot commented on KAFKA-5711:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3644


> Bulk Restore Should Handle Deletes
> --
>
> Key: KAFKA-5711
> URL: https://issues.apache.org/jira/browse/KAFKA-5711
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Bill Bejeck
>Assignee: Bill Bejeck
> Fix For: 1.0.0
>
>
> During bulk restoration null values indicate a delete (possibly not compacted 
> yet) and should be deleted accordingly from RocksDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5711) Bulk Restore Should Handle Deletes

2017-08-08 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118782#comment-16118782
 ] 

ASF GitHub Bot commented on KAFKA-5711:
---

GitHub user bbejeck opened a pull request:

https://github.com/apache/kafka/pull/3644

KAFKA-5711: batch restore should handle deletes



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/bbejeck/kafka 
KAFKA-5711_bulk_restore_should_handle_deletes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3644.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3644


commit 10f7be8c08ed18476120be2fc010f93d9caeb3d8
Author: Bill Bejeck 
Date:   2017-08-08T18:12:11Z

KAFKA-5711: batch restore should handle deletes




> Bulk Restore Should Handle Deletes
> --
>
> Key: KAFKA-5711
> URL: https://issues.apache.org/jira/browse/KAFKA-5711
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Bill Bejeck
>Assignee: Bill Bejeck
> Fix For: 1.0.0
>
>
> During bulk restoration null values indicate a delete (possibly not compacted 
> yet) and should be deleted accordingly from RocksDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5711) Bulk Restore Should Handle Deletes

2017-08-08 Thread Guozhang Wang (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118753#comment-16118753
 ] 

Guozhang Wang commented on KAFKA-5711:
--

[~bbejeck] It sounds like a severe regression introduced in KIP-167, should we 
fix it asap?

> Bulk Restore Should Handle Deletes
> --
>
> Key: KAFKA-5711
> URL: https://issues.apache.org/jira/browse/KAFKA-5711
> Project: Kafka
>  Issue Type: Bug
>  Components: streams
>Reporter: Bill Bejeck
>Assignee: Bill Bejeck
> Fix For: 1.0.0
>
>
> During bulk restoration null values indicate a delete (possibly not compacted 
> yet) and should be deleted accordingly from RocksDB



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)