[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-08 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-626071906 Oh hm actually I can't seem to reproduce it on trunk anymore, at least not as frequently as on this branch. Maybe we should block merging this PR until we have the test hook

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-08 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-626019634 Messed up the system test logs during the rebase, kicked off a new version probing test: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3935

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-08 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-625969800 Kicking off the version probing system test again after rebasing on top of Bruno's changes/fix (because I can't run it locally again...  ) --

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622661309 System test run passed (as did all three builds, wow!) This is an automated message from the Apache Git

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622652864 Version probing test passing locally now, kicked off a branch builder to confirm: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/3927/

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-05-01 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622628637 Also cc @mjsax for some feedback on making the rebalancing comprehensible in system test logs This is an

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-04-30 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622218685 Kicked off the version probing since test since I'm mucking around in the rebalance triggering code and log messages, and I've broken it that way before  :

[GitHub] [kafka] ableegoldman commented on pull request #8596: KAFKA-9821: persist followup rebalance in assignment and consolidate rebalance triggering mechanisms

2020-04-30 Thread GitBox
ableegoldman commented on pull request #8596: URL: https://github.com/apache/kafka/pull/8596#issuecomment-622206057 @guozhangwang @vvcephei @cadonna This is an automated message from the Apache Git Service. To respond to