cmccabe commented on a change in pull request #8396:
URL: https://github.com/apache/kafka/pull/8396#discussion_r411654793
##########
File path:
tools/src/main/java/org/apache/kafka/trogdor/workload/ProduceBenchSpec.java
##########
@@ -72,6 +75,8 @@
private final TopicsSpec activeTopics;
private final TopicsSpec inactiveTopics;
private final boolean useConfiguredPartitioner;
+ private final boolean ignoreProduceErrors;
+ private final int topicVerificationRetries;
Review comment:
It would be better to call this "topicVerificationTries" since 0 is then
an unreasonable value. For REtries, 0 is a reasonable value and not something
that we should assume is equivalent to "use the default."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
