fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1409100823
> Thanks for doing this. One thing I didn't understand is why the shared
classes are in `server-common` instead of `tools`. Is this because `core` also
uses the class?
Good
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1402347644
> we have pushed Exit.exit(1) down into CommandLineUtils.
@clolov it wasn't pushed down, that's the original logic. The code you are
referring to in ZkSecurityMigrator.scala:103 is
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1399304541
@clolov @vamossagar12 I took your suggestions. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1397311675
Take a look at `DumpLogSegments` to see how `CommandDefaultOptions` is used.
It is much better than building the option list at the start of the
`main/execute` method.
--
This is an
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396923697
@clolov @vamossagar12 @tinaselenge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
fvaleri commented on PR #13131:
URL: https://github.com/apache/kafka/pull/13131#issuecomment-1396922639
@mimaison @ijuma
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
