hachikuji commented on a change in pull request #8570:
URL: https://github.com/apache/kafka/pull/8570#discussion_r418756784



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/ConfigEntry.java
##########
@@ -99,7 +100,7 @@ public String name() {
     /**
      * Return the value or null. Null is returned if the config is unset or if 
isSensitive is true.
      */
-    public String value() {
+    public Optional<String> value() {

Review comment:
       Note that `ConfigEntry` is considered a public API. This change is not 
backwards compatible, but we could consider exposing a separate method to 
expose the value as an optional. There is a process for changing public APIs: 
https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to