[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444538711 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444526844 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444526844 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java ## @@ -474,6 +492,7 @@ public void

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444518329 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444517907 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444517746 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,92 +675,166 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r444516858 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsMetadataState.java ## @@ -152,9 +152,9 @@ public StreamsMetadata

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443938725 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443875108 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871959 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -542,7 +542,12 @@ private void close(final boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443871712 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443760619 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443759806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -679,58 +675,75 @@ private void cleanupTask(final

[GitHub] [kafka] mjsax commented on a change in pull request #8900: KAFKA-10169: swallow non-fatal KafkaException and don't abort transaction during clean close

mjsax commented on a change in pull request #8900: URL: https://github.com/apache/kafka/pull/8900#discussion_r443067211 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/RecordCollectorImpl.java ## @@ -267,7 +283,17 @@ public void close() {