[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-26 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650247166 Huge thanks to all reviewers and committers for providing valuable comments and testing results This is an

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-26 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-650209463 @mimaison If the one failed test is not relevant, are we ready to merge, or anything I can do? Thanks This

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-25 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649827931 seems unrelated test failed: ``` kafka.api.PlaintextConsumerTest > testLowMaxFetchSizeForRequestAndPartition FAILED ```

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-25 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649747116 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-25 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649744933 retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-25 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649744836 unrelated test failures: ``` kafka.api.SaslGssapiSslEndToEndAuthorizationTest > testProduceConsumeWithWildcardAcls FAILED

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-25 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649599205 @mimaison thanks so much for your fast response :) I have addressed your above 3 comments and please take the final review pass

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-24 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-649092864 bump for attention @mimaison ^ given that https://issues.apache.org/jira/browse/KAFKA-9076 is slipped to the next release (2.7.0) and some people may be already

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-06-05 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-639276582 Hello @mimaison thanks for your comments. I have addressed them in the latest push and please take another review. Thanks

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-05-22 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-632527159 @ryannedolan @mimaison I added the Integration tests for testing this automated consumer offset sync in MM 2.0. When available, I am appreciated for your first pass of

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-05-05 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-624399781 hi @bseenu @thspinto I updated the PR to handle both cases: (1) new consumer (2) new topic/partition in existing consumer. Please go ahead if you want to test it out sooner.

[GitHub] [kafka] ning2008wisc commented on pull request #7577: KAFKA-9076: support consumer offset sync across clusters in MM 2.0

2020-04-23 Thread GitBox
ning2008wisc commented on pull request #7577: URL: https://github.com/apache/kafka/pull/7577#issuecomment-618732741 Hi @bseenu , it will be very helpful to elaborate the operational sequence of your testing case? e.g. which cluster your consumer initially consume from? Did you switch your