showuon commented on a change in pull request #8581:
URL: https://github.com/apache/kafka/pull/8581#discussion_r417773241
##########
File path: docs/ops.html
##########
@@ -676,7 +676,7 @@ <h3><a id="java" href="#java">6.4 Java Version</a></h3>
From a security perspective, we recommend you use the latest released
version of JDK 1.8 as older freely available versions have disclosed security
vulnerabilities.
- LinkedIn is currently running JDK 1.8 u5 (looking to upgrade to a newer
version) with the G1 collector. LinkedIn's tuning looks like this:
+ At the time when we write this, LinkedIn is running JDK 1.8 u5 (looking to
upgrade to a newer version) with the G1 collector. LinkedIn's tuning looks like
this:
Review comment:
Good suggestion. Fixed in the commit
https://github.com/apache/kafka/pull/8581/commits/355f93c0ac8dbc0723ea46c4780df2cbdc423c71
. Thank you
##########
File path: docs/ops.html
##########
@@ -676,7 +676,7 @@ <h3><a id="java" href="#java">6.4 Java Version</a></h3>
From a security perspective, we recommend you use the latest released
version of JDK 1.8 as older freely available versions have disclosed security
vulnerabilities.
- LinkedIn is currently running JDK 1.8 u5 (looking to upgrade to a newer
version) with the G1 collector. LinkedIn's tuning looks like this:
+ At the time when we write this, LinkedIn is running JDK 1.8 u5 (looking to
upgrade to a newer version) with the G1 collector. LinkedIn's tuning looks like
this:
Review comment:
@kkonstantine , Good suggestion. Fixed in the commit
https://github.com/apache/kafka/pull/8581/commits/355f93c0ac8dbc0723ea46c4780df2cbdc423c71
. Thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
