[jira] [Commented] (KAFKA-12199) Migrate connect:runtime module to JUnit 5
[ https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17776230#comment-17776230 ] Ismael Juma commented on KAFKA-12199: - [~jackwangcs] You can pick this up if you like. Note that it is dependent on the migration away from PowerMock. > Migrate connect:runtime module to JUnit 5 > - > > Key: KAFKA-12199 > URL: https://issues.apache.org/jira/browse/KAFKA-12199 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-12199) Migrate connect:runtime module to JUnit 5
[ https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17623917#comment-17623917 ] jackwangcs commented on KAFKA-12199: Hi [~chia7712] , are you still working on this? I would like to take this ticket. > Migrate connect:runtime module to JUnit 5 > - > > Key: KAFKA-12199 > URL: https://issues.apache.org/jira/browse/KAFKA-12199 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (KAFKA-12199) Migrate connect:runtime module to JUnit 5
[ https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266034#comment-17266034 ] Chia-Ping Tsai commented on KAFKA-12199: Thanks for your response. I plan to file another jira (maybe umbrella jira since it is indeed a heavy job) to unify mock tool - migrate from PowerMock/EasyMock to Mockito. > Migrate connect:runtime module to JUnit 5 > - > > Key: KAFKA-12199 > URL: https://issues.apache.org/jira/browse/KAFKA-12199 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12199) Migrate connect:runtime module to JUnit 5
[ https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266032#comment-17266032 ] Ismael Juma commented on KAFKA-12199: - We have already picked Mockito as our mocking library. I converted the clients module a while back and the tools module more recently. So, yes, it makes sense to do that first for modules that have a lot of PowerMock usage. Note that we will want to coordinate with one of the Connect reviewers to make sure they have the cycles to review it. > Migrate connect:runtime module to JUnit 5 > - > > Key: KAFKA-12199 > URL: https://issues.apache.org/jira/browse/KAFKA-12199 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-12199) Migrate connect:runtime module to JUnit 5
[ https://issues.apache.org/jira/browse/KAFKA-12199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265720#comment-17265720 ] Chia-Ping Tsai commented on KAFKA-12199: [~ijuma] PowerMock does not yet have native support for Junit5 (https://github.com/powermock/powermock/issues/830) and there are a lot of test depending on PowerMock functions. It means this PR could get bigger and more complicated as we not only migrate junit 4 to junit 5 but also migrate PowerMock to other mock tool. In order to simplify the review works, we should address following tasks before upgrading junit. 1. select a mock tool which can work with junit 5 - I prefer Mockito as it works well with junit 5 2. rewrite all tests which are depending on PowerMock - this task can be separate to different sub-task as I believe the new mock tool can bring a bunch of changes. WDYT? > Migrate connect:runtime module to JUnit 5 > - > > Key: KAFKA-12199 > URL: https://issues.apache.org/jira/browse/KAFKA-12199 > Project: Kafka > Issue Type: Sub-task >Reporter: Chia-Ping Tsai >Assignee: Chia-Ping Tsai >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
