[ 
https://issues.apache.org/jira/browse/KAFKA-5096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110866#comment-16110866
 ] 

ASF GitHub Bot commented on KAFKA-5096:
---------------------------------------

Github user asfgit closed the pull request at:

    https://github.com/apache/kafka/pull/2990


> Only log invalid user configs and overwrite with correct one
> ------------------------------------------------------------
>
>                 Key: KAFKA-5096
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5096
>             Project: Kafka
>          Issue Type: Improvement
>          Components: streams
>            Reporter: Matthias J. Sax
>            Assignee: Mariam John
>            Priority: Minor
>              Labels: beginner, newbie
>             Fix For: 1.0.0
>
>
> Streams does not allow to overwrite some config parameters (eg, 
> {{enable.auto.commit}}) Currently, we throw an exception, but this is 
> actually not required, as Streams can just ignore/overwrite the user provided 
> value.
> Thus, instead of throwing, we should just log a WARN message and overwrite 
> the config with the values that suits Streams. (atm it's only one parameter 
> {{enable.auto.commit}}), but with exactly-once it's going to be more (cf. 
> KAFKA-4923). Thus, the scope of this ticket depends when it will be 
> implemented (ie, before or after KAFKA-4923).
> This ticket should also include JavaDoc updates that explain what parameters 
> cannot be specified by the user.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to