[jira] [Commented] (KAFKA-5888) Transactions system test should check for message order

2017-09-28 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16184769#comment-16184769
 ] 

ASF GitHub Bot commented on KAFKA-5888:
---

Github user asfgit closed the pull request at:

https://github.com/apache/kafka/pull/3969


> Transactions system test should check for message order
> ---
>
> Key: KAFKA-5888
> URL: https://issues.apache.org/jira/browse/KAFKA-5888
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Apurva Mehta
>  Labels: exactly-once
> Fix For: 1.0.0
>
>
> Currently, the transactions system test doesn't check for correct ordering of 
> the messages in a transaction. With KAFKA-5494, we can have multiple inflight 
> requests for a single transaction, which could yield to out of order messages 
> in the log if there are bugs. So we should assert that order is maintained in 
> our system tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5888) Transactions system test should check for message order

2017-09-26 Thread ASF GitHub Bot (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16181956#comment-16181956
 ] 

ASF GitHub Bot commented on KAFKA-5888:
---

GitHub user apurvam opened a pull request:

https://github.com/apache/kafka/pull/3969

KAFKA-5888: System test to check ordering of messages with transactions and 
max.in.flight > 1



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apurvam/kafka 
KAFKA-5888-system-test-which-check-ordering

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3969.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3969


commit bb6b3cf2545984a03d8177d6eaa205261540a0dd
Author: Apurva Mehta 
Date:   2017-09-27T01:18:27Z

Initial commit of transaction system test which checks for message ordering

commit 2dc508603266407f1fc5de10954a8807bfa85440
Author: Apurva Mehta 
Date:   2017-09-27T04:16:56Z

Small refactor to use the ducktape @matrix feature to run tests which check 
order as well as tests that don't




> Transactions system test should check for message order
> ---
>
> Key: KAFKA-5888
> URL: https://issues.apache.org/jira/browse/KAFKA-5888
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Apurva Mehta
>  Labels: exactly-once
> Fix For: 1.0.0
>
>
> Currently, the transactions system test doesn't check for correct ordering of 
> the messages in a transaction. With KAFKA-5494, we can have multiple inflight 
> requests for a single transaction, which could yield to out of order messages 
> in the log if there are bugs. So we should assert that order is maintained in 
> our system tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (KAFKA-5888) Transactions system test should check for message order

2017-09-25 Thread Apurva Mehta (JIRA) 

[ 
https://issues.apache.org/jira/browse/KAFKA-5888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16179527#comment-16179527
 ] 

Apurva Mehta commented on KAFKA-5888:
-

This is a test for new functionality added in 1.0.0,  so it can go in before 
the code freeze. Changing the target version back to 1.0.0.

> Transactions system test should check for message order
> ---
>
> Key: KAFKA-5888
> URL: https://issues.apache.org/jira/browse/KAFKA-5888
> Project: Kafka
>  Issue Type: Sub-task
>Reporter: Apurva Mehta
>Assignee: Apurva Mehta
>  Labels: exactly-once
> Fix For: 1.0.0
>
>
> Currently, the transactions system test doesn't check for correct ordering of 
> the messages in a transaction. With KAFKA-5494, we can have multiple inflight 
> requests for a single transaction, which could yield to out of order messages 
> in the log if there are bugs. So we should assert that order is maintained in 
> our system tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)