[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2019-01-14 Thread Zhanxiang (Patrick) Huang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741921#comment-16741921 ] Zhanxiang (Patrick) Huang commented on KAFKA-7297: -- Sorry for being late to the

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-17 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723236#comment-16723236 ] Dong Lin commented on KAFKA-7297: - [~ijuma] Hmm.. I think we may have different understanding. Jun

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-15 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722350#comment-16722350 ] Ismael Juma commented on KAFKA-7297: Yeah, you'd lock during writes and keep reads lock free. There

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-15 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722347#comment-16722347 ] Dong Lin commented on KAFKA-7297: - [~ijuma] Atomic update is another good alternative to the read/write

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-15 Thread Ismael Juma (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722342#comment-16722342 ] Ismael Juma commented on KAFKA-7297: Another way to handle this is for mutating operations to update

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-15 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722331#comment-16722331 ] Dong Lin commented on KAFKA-7297: - [~junrao] Yeah I agree. [~hzxa21] does this solution sounds

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-15 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722217#comment-16722217 ] Jun Rao commented on KAFKA-7297: [~lindong], good points. The current implementation is not causing

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-14 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16722044#comment-16722044 ] Dong Lin commented on KAFKA-7297: - [~junrao] After going through the code and the Java doc, it appears

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-14 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16721960#comment-16721960 ] Jun Rao commented on KAFKA-7297: [~lindong], Ismael pointed out thatĀ ConcurrentSkipListMap supportsĀ 

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-13 Thread Dong Lin (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720876#comment-16720876 ] Dong Lin commented on KAFKA-7297: - [~junrao] Ah I would not be able to work on this. Is this an urgent

[jira] [Commented] (KAFKA-7297) Both read/write access to Log.segments should be protected by lock

2018-12-13 Thread Jun Rao (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720710#comment-16720710 ] Jun Rao commented on KAFKA-7297: To follow up on that, another related issue is that currently, we are