[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241139#comment-17241139 ] Matthias J. Sax commented on KAFKA-7918: The existing caching layer also collapses writes into

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-30 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17240908#comment-17240908 ] Ming Liu commented on KAFKA-7918: - We also had the code to optimize the changelog supporting it.  We only

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-24 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238334#comment-17238334 ] Matthias J. Sax commented on KAFKA-7918: We decided to go with bytes-based in-memory stores,

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2020-11-23 Thread Ming Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17237861#comment-17237861 ] Ming Liu commented on KAFKA-7918: - [~ableegoldman], [~guozhang] [~mjsax],  one good benefit of generics

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-28 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781184#comment-16781184 ] ASF GitHub Bot commented on KAFKA-7918: --- guozhangwang commented on pull request #6328: KAFKA-7918:

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-27 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779417#comment-16779417 ] ASF GitHub Bot commented on KAFKA-7918: --- bbejeck commented on pull request #6327: KAFKA-7918:

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777554#comment-16777554 ] ASF GitHub Bot commented on KAFKA-7918: --- guozhangwang commented on pull request #6293: KAFKA-7918:

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777550#comment-16777550 ] ASF GitHub Bot commented on KAFKA-7918: --- ableegoldman commented on pull request #6328: KAFKA-7918:

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-25 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777426#comment-16777426 ] ASF GitHub Bot commented on KAFKA-7918: --- ableegoldman commented on pull request #6327: KAFKA-7918:

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767765#comment-16767765 ] Matthias J. Sax commented on KAFKA-7918: Judgment call in the end how much you put together into

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Sophie Blee-Goldman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767663#comment-16767663 ] Sophie Blee-Goldman commented on KAFKA-7918: Makes sense, I will consider the caching layer

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767623#comment-16767623 ] Matthias J. Sax commented on KAFKA-7918: In general I think yes. However, it implies a little

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Sophie Blee-Goldman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767611#comment-16767611 ] Sophie Blee-Goldman commented on KAFKA-7918: In light of the decision to close KAFKA-7917 

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767580#comment-16767580 ] Guozhang Wang commented on KAFKA-7918: -- +1. [~ableegoldman] Thanks for looking into it. > Streams

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread Matthias J. Sax (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767446#comment-16767446 ] Matthias J. Sax commented on KAFKA-7918: SGTM. > Streams store cleanup: inline byte-store

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-13 Thread John Roesler (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16767386#comment-16767386 ] John Roesler commented on KAFKA-7918: - Should we also consider simplifying the StoreChangeLogger by

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-11 Thread Sophie Blee-Goldman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765593#comment-16765593 ] Sophie Blee-Goldman commented on KAFKA-7918: A number of tests will need to be reworked, but

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-11 Thread Sophie Blee-Goldman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765587#comment-16765587 ] Sophie Blee-Goldman commented on KAFKA-7918: For the LRUStore, there are two classes this

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-11 Thread Sophie Blee-Goldman (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765585#comment-16765585 ] Sophie Blee-Goldman commented on KAFKA-7918: The RocksDB key-value store is actually already

[jira] [Commented] (KAFKA-7918) Streams store cleanup: inline byte-store generic parameters

2019-02-11 Thread Guozhang Wang (JIRA)
[ https://issues.apache.org/jira/browse/KAFKA-7918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765583#comment-16765583 ] Guozhang Wang commented on KAFKA-7918: -- I made a quick pass on the current code base, and it seems