[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007697#comment-17007697
]
Matthias J. Sax commented on KAFKA-7994:
Feel free to update the ticket – but we should create
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17007124#comment-17007124
]
Sophie Blee-Goldman commented on KAFKA-7994:
The gist of this ticket is "Partition-time, the
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006224#comment-17006224
]
Matthias J. Sax commented on KAFKA-7994:
This particular issue about stream time is resolved. We
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933680#comment-16933680
]
ASF GitHub Bot commented on KAFKA-7994:
---
mjsax commented on pull request #6694: [KAFKA-7994]
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923359#comment-16923359
]
Bruno Cadonna commented on KAFKA-7994:
--
I applied PR #6694 on the example I presented in my comment
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853388#comment-16853388
]
Matthias J. Sax commented on KAFKA-7994:
Well. `suppress()` in not "affected" because
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853118#comment-16853118
]
Mateusz Owczarek commented on KAFKA-7994:
-
Bruno's example above indicates it actually does
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849022#comment-16849022
]
Richard Yu commented on KAFKA-7994:
---
Hi Bruno. I think this one of the cases which this issue is
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848791#comment-16848791
]
Bruno Cadonna commented on KAFKA-7994:
--
I run into a case where the reset of the stream time to -1
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848610#comment-16848610
]
Richard Yu commented on KAFKA-7994:
---
cc [~mjsax] Made the change.
> Improve Stream-Time for rebalances
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848607#comment-16848607
]
Matthias J. Sax commented on KAFKA-7994:
Yes. Please rebase the PR to only include the "preserve
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848534#comment-16848534
]
Richard Yu commented on KAFKA-7994:
---
Sure [~mjsax] I'm all for it, since it looks like the global
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16846857#comment-16846857
]
Matthias J. Sax commented on KAFKA-7994:
I think it might actually be worth to split the two
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845381#comment-16845381
]
Sophie Blee-Goldman commented on KAFKA-7994:
Hi [~Yohan123], I think we need to be careful in
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16845338#comment-16845338
]
Richard Yu commented on KAFKA-7994:
---
[~guozhang] [~mjsax] and [~vvcephei] I created a KIP for this
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843739#comment-16843739
]
Matthias J. Sax commented on KAFKA-7994:
I am personally not convinced, that using headers is the
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843540#comment-16843540
]
Richard Yu commented on KAFKA-7994:
---
Ok, after digging around, I figured this much out:
# Headers are
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843534#comment-16843534
]
Richard Yu commented on KAFKA-7994:
---
Oh, just realized what was wrong with my approach. You are right:
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843517#comment-16843517
]
Matthias J. Sax commented on KAFKA-7994:
> So this might handle how partition time is
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843463#comment-16843463
]
Richard Yu commented on KAFKA-7994:
---
Yeah, those are some nice points. ProcessorContext is indeed
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843402#comment-16843402
]
Matthias J. Sax commented on KAFKA-7994:
Adding partition time to the context might be a good
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843223#comment-16843223
]
Richard Yu commented on KAFKA-7994:
---
Oh, just realized that there should be more changes. Sorry, didn't
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16839868#comment-16839868
]
Richard Yu commented on KAFKA-7994:
---
Hi all, could we get some reviews on the PR? There hasn't been too
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835192#comment-16835192
]
ASF GitHub Bot commented on KAFKA-7994:
---
ConcurrencyPractitioner commented on pull request #6694:
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16833952#comment-16833952
]
Richard Yu commented on KAFKA-7994:
---
Alright, so I posted a small patch which might help resolve this
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822589#comment-16822589
]
Richard Yu commented on KAFKA-7994:
---
Oh, I'm fine doing some digging though. I might try to take a hack
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822535#comment-16822535
]
Matthias J. Sax commented on KAFKA-7994:
It's a little unclear how to tackle the issue atm, and
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16822327#comment-16822327
]
Richard Yu commented on KAFKA-7994:
---
[~mjsax] Do you think it would be fine if I took this issue?
>
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785150#comment-16785150
]
Guozhang Wang commented on KAFKA-7994:
--
| It wouldn't be terrible if we sometimes held on to records
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785144#comment-16785144
]
Guozhang Wang commented on KAFKA-7994:
--
Just to add: even in the KIP to add negative timestamp
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782206#comment-16782206
]
Matthias J. Sax commented on KAFKA-7994:
Thanks [~vvcephei]. Sounds convincing! Glad that
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782178#comment-16782178
]
John Roesler commented on KAFKA-7994:
-
I did some mental math when I made that last change to stream
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778810#comment-16778810
]
Matthias J. Sax commented on KAFKA-7994:
{quote}So I'm feeling that if we can tackle those issues
[
https://issues.apache.org/jira/browse/KAFKA-7994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778460#comment-16778460
]
Guozhang Wang commented on KAFKA-7994:
--
Thanks for brining this up! I've also thought about this
34 matches
Mail list logo
