[GitHub] [kafka] feyman2016 commented on pull request #8760: Kafka-10064 Add documentation for KIP-571

2020-06-02 Thread GitBox
feyman2016 commented on pull request #8760: URL: https://github.com/apache/kafka/pull/8760#issuecomment-637307313 Thanks! @mjsax This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659711 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/Task.java ## @@ -59,14 +58,9 @@ * ||

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659955 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660276 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[jira] [Commented] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-02 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123377#comment-17123377 ] Cheng Tan commented on KAFKA-9800: -- Recap the discussion in Github. We want to implement a per-request

[GitHub] [kafka] prehistoric-penguin closed pull request #6403: KAFKA-6188; Fix windows clean log fail caused shut down

2020-06-02 Thread GitBox
prehistoric-penguin closed pull request #6403: URL: https://github.com/apache/kafka/pull/6403 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [kafka] mjsax commented on pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on pull request #8776: URL: https://github.com/apache/kafka/pull/8776#issuecomment-637327785 Call for review @guozhangwang @abbccdda @vvcephei @ableegoldman This is an automated message from the Apache Git

[GitHub] [kafka] mjsax opened a new pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax opened a new pull request #8776: URL: https://github.com/apache/kafka/pull/8776 - make task manager agnostic to task state - make tasks state transitions idempotent This is an automated message from the Apache Git

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433661972 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -613,10 +604,14 @@ private long

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433662342 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -2637,11 +2646,17 @@ private File

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433662426 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java ## @@ -2637,11 +2646,17 @@ private File

[GitHub] [kafka] d8tltanc commented on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-02 Thread GitBox
d8tltanc commented on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554 @skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments. This patch was made when I was new to Kafka. It's kind of naive to me at this time as I gained more

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659277 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659175 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433659050 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamTask.java ## @@ -247,48 +251,75 @@ public void completeRestoration()

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660588 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -529,11 +524,7 @@ void handleLostAll() {

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r433660588 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -529,11 +524,7 @@ void handleLostAll() {

[jira] [Created] (KAFKA-10082) fix failed kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment

2020-06-02 Thread Luke Chen (Jira)
Luke Chen created KAFKA-10082: - Summary: fix failed kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment Key: KAFKA-10082 URL: https://issues.apache.org/jira/browse/KAFKA-10082 Project:

[GitHub] [kafka] showuon commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

2020-06-02 Thread GitBox
showuon commented on pull request #8777: URL: https://github.com/apache/kafka/pull/8777#issuecomment-637344872 @ableegoldman , could you check this PR to fix the failed tests? Thanks. This is an automated message from the

[GitHub] [kafka] d8tltanc edited a comment on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-02 Thread GitBox
d8tltanc edited a comment on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554 @skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments. This patch was made when I was new to Kafka. It's kind of naive to me at this time as I gained

[jira] [Comment Edited] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-02 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123377#comment-17123377 ] Cheng Tan edited comment on KAFKA-9800 at 6/2/20, 7:53 AM: --- Recap the

[jira] [Commented] (KAFKA-7538) Improve locking model used to update ISRs and HW

2020-06-02 Thread Viktor Somogyi-Vass (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123415#comment-17123415 ] Viktor Somogyi-Vass commented on KAFKA-7538: [~rsivaram] has subcase 1 and 3 been fixed since

[GitHub] [kafka] showuon opened a new pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

2020-06-02 Thread GitBox
showuon opened a new pull request #8777: URL: https://github.com/apache/kafka/pull/8777 Fix the failed `testMultiConsumerStickyAssignment` by modify the logic error in `allSubscriptionsEqual` method. We will create the `consumerToOwnedPartitions` to keep the set of previously owned

[GitHub] [kafka] kkonstantine commented on a change in pull request #8630: KAFKA-9969: Exclude ConnectorClientConfigRequest from class loading isolation

2020-06-02 Thread GitBox
kkonstantine commented on a change in pull request #8630: URL: https://github.com/apache/kafka/pull/8630#discussion_r433640144 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/isolation/PluginUtilsTest.java ## @@ -114,68 +90,264 @@ public void

[GitHub] [kafka] dajac commented on a change in pull request #8768: KAFKA-10023: Enforce broker-wide and per-listener connection creation…

2020-06-02 Thread GitBox
dajac commented on a change in pull request #8768: URL: https://github.com/apache/kafka/pull/8768#discussion_r433696374 ## File path: core/src/main/scala/kafka/network/SocketServer.scala ## @@ -1287,15 +1309,97 @@ class ConnectionQuotas(config: KafkaConfig, time: Time)

[GitHub] [kafka] chia7712 commented on a change in pull request #8755: KAFKA-10069 The user-defined "predicate" and "negate" are not removed…

2020-06-02 Thread GitBox
chia7712 commented on a change in pull request #8755: URL: https://github.com/apache/kafka/pull/8755#discussion_r433724296 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ConnectorConfigTest.java ## @@ -434,5 +436,52 @@ public void configure(Map

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-02 Thread Mateusz Jadczyk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123542#comment-17123542 ] Mateusz Jadczyk commented on KAFKA-9891: [~bchen225242] yes, it should be materialized. Duplicate

[jira] [Commented] (KAFKA-9891) Invalid state store content after task migration with exactly_once and standby replicas

2020-06-02 Thread Mateusz Jadczyk (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123544#comment-17123544 ] Mateusz Jadczyk commented on KAFKA-9891: The reason we need at least one materialized key is that

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433920350 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -117,24 +123,51 @@ public void

[GitHub] [kafka] bbejeck commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-02 Thread GitBox
bbejeck commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-637586221 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Comment Edited] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-02 Thread Cheng Tan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123377#comment-17123377 ] Cheng Tan edited comment on KAFKA-9800 at 6/2/20, 3:12 PM: --- Recap the

[GitHub] [kafka] mjsax removed a comment on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-02 Thread GitBox
mjsax removed a comment on pull request #8774: URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655696 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] mjsax commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-02 Thread GitBox
mjsax commented on pull request #8774: URL: https://github.com/apache/kafka/pull/8774#issuecomment-637655627 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] ableegoldman commented on a change in pull request #8778: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests

2020-06-02 Thread GitBox
ableegoldman commented on a change in pull request #8778: URL: https://github.com/apache/kafka/pull/8778#discussion_r434008302 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -43,7 +43,7 @@ public static

[GitHub] [kafka] showuon opened a new pull request #8778: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests

2020-06-02 Thread GitBox
showuon opened a new pull request #8778: URL: https://github.com/apache/kafka/pull/8778 The failed test is because we changed the class member `partitionMovements` initialization to the class instance created, from initialized when used within `assign` method. This won't have any issue

[GitHub] [kafka] bbejeck commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-02 Thread GitBox
bbejeck commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-637540041 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] nizhikov commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
nizhikov commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433899761 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -117,24 +123,51 @@ public void

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433903099 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -0,0 +1,175 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-637569220 Oh, one more thing, let's please add an entry to `upgrade.html`. This is an automated message from the Apache Git

[GitHub] [kafka] nizhikov commented on pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

2020-06-02 Thread GitBox
nizhikov commented on pull request #8779: URL: https://github.com/apache/kafka/pull/8779#issuecomment-637570728 Hello @ableegoldman It looks like your patch breaks spot bug check. I prepared oneliner fix for it. Can you, please, take a look?

[GitHub] [kafka] d8tltanc edited a comment on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-02 Thread GitBox
d8tltanc edited a comment on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554 @skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments. This patch was made when I was new to Kafka. It's kind of naive to me at this time as I gained

[GitHub] [kafka] d8tltanc edited a comment on pull request #8421: KAFKA-9800: [KIP-580] Admin Client Exponential Backoff Implementation

2020-06-02 Thread GitBox
d8tltanc edited a comment on pull request #8421: URL: https://github.com/apache/kafka/pull/8421#issuecomment-637300554 @skaundinya15 @ijuma @abbccdda Thanks for all the feedback and comments. This patch was made when I was new to Kafka. It's kind of naive to me at this time as I gained

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-637647620 @nizhikov I think we're good to merge this after the non code suggestions above are addressed (assuming we can get a Jenkins build, I merged your other PR fixing the build issue).

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433981892 ## File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java ## @@ -49,11 +50,12 @@ public static final String

[GitHub] [kafka] ijuma merged pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

2020-06-02 Thread GitBox
ijuma merged pull request #8779: URL: https://github.com/apache/kafka/pull/8779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433990762 ## File path: docs/upgrade.html ## @@ -18,6 +18,10 @@

[GitHub] [kafka] mjsax merged pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-02 Thread GitBox
mjsax merged pull request #8774: URL: https://github.com/apache/kafka/pull/8774 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Assigned] (KAFKA-9943) Enable TLSv.1.3 in system tests "run all" execution.

2020-06-02 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma reassigned KAFKA-9943: -- Assignee: Nikolay Izhikov > Enable TLSv.1.3 in system tests "run all" execution. >

[jira] [Updated] (KAFKA-9943) Enable TLSv.1.3 in system tests "run all" execution.

2020-06-02 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-9943: --- Fix Version/s: 2.6.0 > Enable TLSv.1.3 in system tests "run all" execution. >

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433892269 ## File path: clients/src/test/java/org/apache/kafka/common/network/SslVersionsTransportLayerTest.java ## @@ -117,24 +123,51 @@ public void

[GitHub] [kafka] nizhikov opened a new pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

2020-06-02 Thread GitBox
nizhikov opened a new pull request #8779: URL: https://github.com/apache/kafka/pull/8779 Fixing nit in c6633a157eec1712116d294eb3785a96cba4e331. This commit break spotbug check with the "Dead store to isFreshAssignment in

[GitHub] [kafka] chia7712 commented on pull request #8774: KAFKA-10081: Remove an unused local variable to pass spotbugsMain check

2020-06-02 Thread GitBox
chia7712 commented on pull request #8774: URL: https://github.com/apache/kafka/pull/8774#issuecomment-637570083 ```testReassignmentWithRandomSubscriptionsAndChanges``` is traced by #8778 ```testMultiConsumerStickyAssignment``` is traced by #8777 +1 to merge this hotfix :)

[GitHub] [kafka] ijuma edited a comment on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-02 Thread GitBox
ijuma edited a comment on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637592541 @guozhangwang Looks like 2.6, 2.5 and 2.4 are broken too. You should generally also build locally when cherry-picking.

[GitHub] [kafka] ijuma commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-02 Thread GitBox
ijuma commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637592541 @guozhangwang Looks like 2.6, 2.5 and 2.4 are broken too. You should generally build locally when cherry-picking.

[GitHub] [kafka] collabH opened a new pull request #8781: Read kafka

2020-06-02 Thread GitBox
collabH opened a new pull request #8781: URL: https://github.com/apache/kafka/pull/8781 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] collabH closed pull request #8781: Read kafka

2020-06-02 Thread GitBox
collabH closed pull request #8781: URL: https://github.com/apache/kafka/pull/8781 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433987384 ## File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java ## @@ -64,7 +66,17 @@ public static final String

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-637574517 I think, currently, the trunk is broken with the c6633a157eec1712116d294eb3785a96cba4e331 I prepared oneliner fix for it - #8779

[GitHub] [kafka] ijuma commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-637573626 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] vvcephei commented on pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-02 Thread GitBox
vvcephei commented on pull request #8775: URL: https://github.com/apache/kafka/pull/8775#issuecomment-637578416 Ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ijuma commented on pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-02 Thread GitBox
ijuma commented on pull request #8668: URL: https://github.com/apache/kafka/pull/8668#issuecomment-637591555 Did we check the build before merging this? It seems to have broken it: https://github.com/apache/kafka/pull/8779

[jira] [Commented] (KAFKA-9800) [KIP-580] Client Exponential Backoff Implementation

2020-06-02 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123935#comment-17123935 ] Ismael Juma commented on KAFKA-9800: I think you should apply the same backoff strategy for all

[GitHub] [kafka] collabH closed pull request #8780: Read kafka

2020-06-02 Thread GitBox
collabH closed pull request #8780: URL: https://github.com/apache/kafka/pull/8780 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] collabH opened a new pull request #8780: Read kafka

2020-06-02 Thread GitBox
collabH opened a new pull request #8780: URL: https://github.com/apache/kafka/pull/8780 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of testing

[GitHub] [kafka] ijuma commented on a change in pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
ijuma commented on a change in pull request #8695: URL: https://github.com/apache/kafka/pull/8695#discussion_r433987384 ## File path: clients/src/main/java/org/apache/kafka/common/config/SslConfigs.java ## @@ -64,7 +66,17 @@ public static final String

[jira] [Created] (KAFKA-10083) fix failed testReassignmentWithRandomSubscriptionsAndChanges

2020-06-02 Thread Luke Chen (Jira)
Luke Chen created KAFKA-10083: - Summary: fix failed testReassignmentWithRandomSubscriptionsAndChanges Key: KAFKA-10083 URL: https://issues.apache.org/jira/browse/KAFKA-10083 Project: Kafka

[GitHub] [kafka] itantiger commented on pull request #8753: KAFKA-10043:Some parameters will be overwritten which was configured …

2020-06-02 Thread GitBox
itantiger commented on pull request #8753: URL: https://github.com/apache/kafka/pull/8753#issuecomment-637519467 @guozhangwang Can you take a look at this? This is an automated message from the Apache Git Service. To respond

[jira] [Commented] (KAFKA-9148) Consider forking RocksDB for Streams

2020-06-02 Thread adam Retter (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123597#comment-17123597 ] adam Retter commented on KAFKA-9148: Thanks [~ableegoldman].   I just wanted to be understand

[GitHub] [kafka] astubbs commented on pull request #8771: MINOR: Add explanation for disabling forwarding from value transformers

2020-06-02 Thread GitBox
astubbs commented on pull request #8771: URL: https://github.com/apache/kafka/pull/8771#issuecomment-637501018 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please

[jira] [Commented] (KAFKA-10075) Kafka client stucks after Kafka-cluster unavailability

2020-06-02 Thread Tom Bentley (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17123656#comment-17123656 ] Tom Bentley commented on KAFKA-10075: - Is the JVM in which you're running the client(s) caching DNS

[GitHub] [kafka] showuon commented on pull request #8778: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests

2020-06-02 Thread GitBox
showuon commented on pull request #8778: URL: https://github.com/apache/kafka/pull/8778#issuecomment-637512220 @ableegoldman , could you review this PR to fix the failed tests? Thanks. This is an automated message from the

[jira] [Updated] (KAFKA-10083) fix failed testReassignmentWithRandomSubscriptionsAndChanges

2020-06-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10083: -- Description: [https://builds.apache.org/job/kafka-pr-jdk14-scala2.13/815/]   h3. Error Message

[GitHub] [kafka] nizhikov commented on pull request #8695: KAFKA-9320: Enable TLSv1.3 by default (KIP-573)

2020-06-02 Thread GitBox
nizhikov commented on pull request #8695: URL: https://github.com/apache/kafka/pull/8695#issuecomment-637515040 @ijuma I found explanation of the test behavior. Full information can be found in the

[jira] [Updated] (KAFKA-10083) fix failed testReassignmentWithRandomSubscriptionsAndChanges

2020-06-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10083?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10083: -- Description: [https://builds.apache.org/job/kafka-pr-jdk14-scala2.13/815/] It can also locally

[jira] [Updated] (KAFKA-10082) fix failed kafka.api.PlaintextConsumerTest.testMultiConsumerStickyAssignment

2020-06-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-10082: -- Reviewer: Sophie Blee-Goldman > fix failed

[GitHub] [kafka] vvcephei commented on a change in pull request #8775: KAFKA-10079: improve thread-level stickiness

2020-06-02 Thread GitBox
vvcephei commented on a change in pull request #8775: URL: https://github.com/apache/kafka/pull/8775#discussion_r433923120 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -938,57 +930,9 @@ private void

[jira] [Assigned] (KAFKA-7599) Trogdor - Allow configuration for not throttling Benchmark Workers and expose messages per second in task status

2020-06-02 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski reassigned KAFKA-7599: -- Assignee: (was: Stanislav Kozlovski) > Trogdor - Allow configuration for

[jira] [Assigned] (KAFKA-8264) Flaky Test PlaintextConsumerTest#testLowMaxFetchSizeForRequestAndPartition

2020-06-02 Thread Stanislav Kozlovski (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stanislav Kozlovski reassigned KAFKA-8264: -- Assignee: (was: Stanislav Kozlovski) > Flaky Test

[GitHub] [kafka] dongjinleekr commented on pull request #7898: KAFKA-9366: please consider upgrade log4j to log4j2 due to critical security problem CVE-2019-17571

2020-06-02 Thread GitBox
dongjinleekr commented on pull request #7898: URL: https://github.com/apache/kafka/pull/7898#issuecomment-637684403 All // Sorry for being late, I just got out from my last project; I will have a look at this PR this weekend.

[GitHub] [kafka] hachikuji commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434098545 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala ## @@ -285,15 +280,16 @@ class

[GitHub] [kafka] vvcephei commented on pull request #8785: KAFKA-10084: Fix EosTestDriver end offset

2020-06-02 Thread GitBox
vvcephei commented on pull request #8785: URL: https://github.com/apache/kafka/pull/8785#issuecomment-637751829 I ran the system tests, and they pass: ``` test_id:

[GitHub] [kafka] vvcephei commented on pull request #8785: KAFKA-10084: Fix EosTestDriver end offset

2020-06-02 Thread GitBox
vvcephei commented on pull request #8785: URL: https://github.com/apache/kafka/pull/8785#issuecomment-637752017 Hey @mjsax , thanks for the help on this. Can you take a look at the PR? This is an automated message from the

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434117796 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java ## @@ -390,19 +387,17 @@ boolean

[GitHub] [kafka] chia7712 commented on pull request #8657: KAFKA-8334 Make sure the thread which tries to complete delayed reque…

2020-06-02 Thread GitBox
chia7712 commented on pull request #8657: URL: https://github.com/apache/kafka/pull/8657#issuecomment-637668386 @junrao Could you take a look? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

2020-06-02 Thread GitBox
guozhangwang commented on pull request #8777: URL: https://github.com/apache/kafka/pull/8777#issuecomment-637677433 Cherry-picked to 2.6 / 2.5 / 2.4 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] chia7712 commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
chia7712 commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434038469 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala ## @@ -215,8 +215,6 @@ class

[GitHub] [kafka] ableegoldman commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
ableegoldman commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434051190 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final

[jira] [Updated] (KAFKA-10084) System test failure: StreamsEosTest.test_failure_and_recovery_complex

2020-06-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10084: - Affects Version/s: 2.6.0 > System test failure:

[GitHub] [kafka] abbccdda commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
abbccdda commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434107127 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -1799,8 +1799,8 @@ public void

[jira] [Updated] (KAFKA-10084) System test failure: StreamsEosTest.test_failure_and_recovery_complex

2020-06-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10084: - Affects Version/s: 2.7.0 > System test failure:

[jira] [Updated] (KAFKA-10084) System test failure: StreamsEosTest.test_failure_and_recovery_complex

2020-06-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10084: - Fix Version/s: 2.6.0 2.7.0 > System test failure:

[GitHub] [kafka] ableegoldman commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
ableegoldman commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434118800 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final

[jira] [Updated] (KAFKA-10084) System test failure: StreamsEosTest.test_failure_and_recovery_complex

2020-06-02 Thread John Roesler (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10084?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Roesler updated KAFKA-10084: - Component/s: streams > System test failure: StreamsEosTest.test_failure_and_recovery_complex >

[jira] [Created] (KAFKA-10086) Write Integration Test for StreamsTaskAssignor/HighAvailabilityTaskAssignor

2020-06-02 Thread John Roesler (Jira)
John Roesler created KAFKA-10086: Summary: Write Integration Test for StreamsTaskAssignor/HighAvailabilityTaskAssignor Key: KAFKA-10086 URL: https://issues.apache.org/jira/browse/KAFKA-10086 Project:

[GitHub] [kafka] ableegoldman commented on pull request #8778: KAFKA-10083: fix failed testReassignmentWithRandomSubscriptionsAndChanges tests

2020-06-02 Thread GitBox
ableegoldman commented on pull request #8778: URL: https://github.com/apache/kafka/pull/8778#issuecomment-637665071 cc @mjsax @guozhangwang , should be cherrypicked to 2.6, 2.5, and 2.4 (once my comment above is addressed)

[GitHub] [kafka] ableegoldman commented on pull request #8777: KAFKA-10082: Fix the failed testMultiConsumerStickyAssignment

2020-06-02 Thread GitBox
ableegoldman commented on pull request #8777: URL: https://github.com/apache/kafka/pull/8777#issuecomment-637664149 cc @mjsax @guozhangwang , should be cherrypicked to 2.6, 2.5, and 2.4 This is an automated message from the

[GitHub] [kafka] ableegoldman commented on a change in pull request #8668: KAFKA-9987: optimize sticky assignment algorithm for same-subscription case

2020-06-02 Thread GitBox
ableegoldman commented on a change in pull request #8668: URL: https://github.com/apache/kafka/pull/8668#discussion_r434021704 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java ## @@ -65,9 +72,206 @@ public

[GitHub] [kafka] guozhangwang commented on pull request #8779: [MINOR] Fixing spotbug fail - removing unused variable.

2020-06-02 Thread GitBox
guozhangwang commented on pull request #8779: URL: https://github.com/apache/kafka/pull/8779#issuecomment-637676075 Cherry-picked to 2.6 / 2.5 / 2.4 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] dongjinleekr commented on pull request #8117: KAFKA-8403: Suppress needs a Materialized variant

2020-06-02 Thread GitBox
dongjinleekr commented on pull request #8117: URL: https://github.com/apache/kafka/pull/8117#issuecomment-637683206 @vvcephei Sorry for being late, I just got out from my last project; I will have a look. This is an

[GitHub] [kafka] mjsax commented on a change in pull request #8776: KAFKA-9441: Improve Kafka Streams task management

2020-06-02 Thread GitBox
mjsax commented on a change in pull request #8776: URL: https://github.com/apache/kafka/pull/8776#discussion_r434110314 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StandbyTask.java ## @@ -247,6 +247,9 @@ private void close(final boolean

  1   2   3   >