[GitHub] [kafka] ncliang commented on a change in pull request #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-04-20 Thread GitBox
ncliang commented on a change in pull request #8511: URL: https://github.com/apache/kafka/pull/8511#discussion_r411610839 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/health/ConnectClusterStateImplTest.java ## @@ -87,7 +88,13 @@ public Void

[GitHub] [kafka] junrao commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
junrao commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616751692 @ConcurrencyPractitioner : We now have https://github.com/apache/kafka/blob/trunk/.asf.yaml. You can add yourself to Jenkins's whitelist by following

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r411544719 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] harshitshah4 commented on issue #8512: KAFKA-6024: Consider moving validation in KafkaConsumer ahead of call to acquireAndEnsureOpen()

2020-04-20 Thread GitBox
harshitshah4 commented on issue #8512: URL: https://github.com/apache/kafka/pull/8512#issuecomment-616683601 @omkreddy can you review the changes ? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] guozhangwang commented on issue #8514: MINOR: Further reduce runtime for metrics integration tests

2020-04-20 Thread GitBox
guozhangwang commented on issue #8514: URL: https://github.com/apache/kafka/pull/8514#issuecomment-616718841 Merged to trunk. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] abbccdda commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-20 Thread GitBox
abbccdda commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r411528794 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] C0urante commented on issue #8511: KAFKA-9888: Copy connector configs before passing to REST extensions

2020-04-20 Thread GitBox
C0urante commented on issue #8511: URL: https://github.com/apache/kafka/pull/8511#issuecomment-616743204 Thanks @ncliang! @kkonstantine, @rhauch would one of you mind taking a look at this when you get a chance? This is an

[GitHub] [kafka] apovzner commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-20 Thread GitBox
apovzner commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-616658368 @dajac I did initially add a unit test to `KafkaApisTest` for UpdateMetadataRequest. However, since `KafkaApisTest` mocks pretty much every other component (like replica manager, etc),

[GitHub] [kafka] hachikuji commented on issue #8509: KAFKA-9839: Broker should accept control requests with newer broker epoch

2020-04-20 Thread GitBox
hachikuji commented on issue #8509: URL: https://github.com/apache/kafka/pull/8509#issuecomment-61736 ok to test This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] maseiler commented on issue #8431: MINOR: Rename description of flatMapValues transformation

2020-04-20 Thread GitBox
maseiler commented on issue #8431: URL: https://github.com/apache/kafka/pull/8431#issuecomment-616676054 @bbejeck @ijuma This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8114: URL: https://github.com/apache/kafka/pull/8114#discussion_r411570528 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -208,13 +208,13 @@ * streamBuilder.table(topic,

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616773372 ok to test This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r411544719 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] guozhangwang commented on issue #8445: KAFKA-9823: Remember the sent generation for the coordinator request

2020-04-20 Thread GitBox
guozhangwang commented on issue #8445: URL: https://github.com/apache/kafka/pull/8445#issuecomment-616757320 retest this please This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] mjsax commented on a change in pull request #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

2020-04-20 Thread GitBox
mjsax commented on a change in pull request #8519: URL: https://github.com/apache/kafka/pull/8519#discussion_r411639992 ## File path: jenkins.sh ## @@ -29,12 +29,17 @@ --profile --no-daemon --continue -PtestLoggingEvents=started,passed,skipped,failed "$@" \ || {

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616776614 @junrao Cool. It's just that should I edit the ```.asf.yml``` as part of this PR? Or will I need to do it some other way?

[GitHub] [kafka] cmccabe commented on a change in pull request #8396: KAFKA-9754 - Trogdor - Ignore produce errors, better error statistics.

2020-04-20 Thread GitBox
cmccabe commented on a change in pull request #8396: URL: https://github.com/apache/kafka/pull/8396#discussion_r411654793 ## File path: tools/src/main/java/org/apache/kafka/trogdor/workload/ProduceBenchSpec.java ## @@ -72,6 +75,8 @@ private final TopicsSpec activeTopics;

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411672041 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ValidClientsByTaskLoadQueue.java ## @@ -0,0 +1,108 @@ +/* + *

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616808689 @vvcephei @mjsax Call for a review This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] vvcephei commented on a change in pull request #8520: Add explicit grace period to tumbling window example

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8520: URL: https://github.com/apache/kafka/pull/8520#discussion_r411704050 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -3262,12 +3262,15 @@ KTable-KTable Foreign-Key import

[GitHub] [kafka] mjsax commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
mjsax commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616831664 Retest this please. This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616839537 Run 350 times on local and no failure. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616840036 @mjsax I suppose this should help for all integration tests, as they share `EmbeddedBroker` This is an automated

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411734468 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -89,95 +88,72 @@

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411738965 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411739644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] mjsax commented on issue #8114: KAFKA-9290: Update IQ related JavaDocs

2020-04-20 Thread GitBox
mjsax commented on issue #8114: URL: https://github.com/apache/kafka/pull/8114#issuecomment-616848801 Ah. Thanks for pointing out the hotfix @highluck. Can you address Sophie's comment? This is an automated message from the

[GitHub] [kafka] junrao commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
junrao commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616787194 @ConcurrencyPractitioner : You can just submit a separate PR to add yourself in .asf.yml. This is an automated message

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411673115 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ConcurrencyPractitioner opened a new pull request #8523: Adding github whitelist

2020-04-20 Thread GitBox
ConcurrencyPractitioner opened a new pull request #8523: URL: https://github.com/apache/kafka/pull/8523 This PR is meant to add ConcurrencyPractitioner to the Jenkins whitelist so that this user can trigger tests. This

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #8523: Adding github whitelist

2020-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #8523: URL: https://github.com/apache/kafka/pull/8523#issuecomment-616818171 @junrao So then we can merge this, right? This is an automated message from the Apache Git Service. To

[GitHub] [kafka] mjsax commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
mjsax commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411719647 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -84,7 +84,7 @@ public

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616776257 ok to test This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] vvcephei commented on a change in pull request #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8508: URL: https://github.com/apache/kafka/pull/8508#discussion_r411667311 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -84,6 +87,10 @@ @Before

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411739644 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ijuma commented on issue #8519: MINOR: Upgrade gradle plugins and test libraries for Java 14 support

2020-04-20 Thread GitBox
ijuma commented on issue #8519: URL: https://github.com/apache/kafka/pull/8519#issuecomment-616802690 2 flaky tests, one in each job: * org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta] *

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-20 Thread GitBox
mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616828656 Updated this PR. Will merge after Jenkins passe. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411779358 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411787822 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] abbccdda opened a new pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda opened a new pull request #8522: URL: https://github.com/apache/kafka/pull/8522 This PR tries to fix the flaky EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore by making the bootstrapping of the test to be less painful with fewer number of

[GitHub] [kafka] mjsax commented on a change in pull request #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-20 Thread GitBox
mjsax commented on a change in pull request #8508: URL: https://github.com/apache/kafka/pull/8508#discussion_r411712314 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopicManagerTest.java ## @@ -84,6 +87,10 @@ @Before

[GitHub] [kafka] abbccdda commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411727585 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -84,7 +84,7 @@ public

[GitHub] [kafka] soenkeliebau commented on issue #8464: KAFKA-9852: Change the max duration that calls to the buffer pool can block from 2000ms to 10ms

2020-04-20 Thread GitBox
soenkeliebau commented on issue #8464: URL: https://github.com/apache/kafka/pull/8464#issuecomment-616782288 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] ConcurrencyPractitioner commented on issue #7884: [KAFKA-8522] Streamline tombstone and transaction marker removal

2020-04-20 Thread GitBox
ConcurrencyPractitioner commented on issue #7884: URL: https://github.com/apache/kafka/pull/7884#issuecomment-616819297 @junrao Alright, got it done. This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] ijuma commented on issue #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

2020-04-20 Thread GitBox
ijuma commented on issue #8517: URL: https://github.com/apache/kafka/pull/8517#issuecomment-616875521 Unrelated flaky test: > org.apache.kafka.streams.integration.EOSUncleanShutdownIntegrationTest.shouldWorkWithUncleanShutdownWipeOutStateStore[exactly_once_beta]

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411799045 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] cadonna commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
cadonna commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411366111 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -89,95 +88,72 @@

[GitHub] [kafka] abbccdda commented on a change in pull request #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on a change in pull request #8522: URL: https://github.com/apache/kafka/pull/8522#discussion_r411680309 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/utils/EmbeddedKafkaCluster.java ## @@ -98,6 +98,7 @@ public void start() throws

[GitHub] [kafka] lbradstreet commented on a change in pull request #8518: MINOR: add support for kafka 2.4 and 2.5 to downgrade test

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8518: URL: https://github.com/apache/kafka/pull/8518#discussion_r411692621 ## File path: tests/kafkatest/tests/core/downgrade_test.py ## @@ -67,11 +67,18 @@ def setup_services(self, kafka_version, compression_types,

[GitHub] [kafka] LiamClarkeNZ commented on issue #8520: Add explicit grace period to tumbling window example

2020-04-20 Thread GitBox
LiamClarkeNZ commented on issue #8520: URL: https://github.com/apache/kafka/pull/8520#issuecomment-616842780 Yep, fine by me. :) On Tue, Apr 21, 2020 at 9:32 AM John Roesler wrote: > *@vvcephei* commented on this pull request. > > Hey @LiamClarkeNZ

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411743597 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] highluck commented on a change in pull request #8114: KAFKA-9290: Update IQ related JavaDocs

2020-04-20 Thread GitBox
highluck commented on a change in pull request #8114: URL: https://github.com/apache/kafka/pull/8114#discussion_r411791026 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsBuilder.java ## @@ -208,13 +208,13 @@ * streamBuilder.table(topic,

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411797135 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411797135 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411676361 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-20 Thread GitBox
mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616806079 Java 8 passed. Java11: `kafka.api.ConsumerBounceTest.testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup` Java14 failed due to #8519 (already merged).

[GitHub] [kafka] ijuma commented on a change in pull request #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

2020-04-20 Thread GitBox
ijuma commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411779855 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with Logging {

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411810700 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813351 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411828397 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411828565 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411845809 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] mjsax commented on issue #8508: MINOR: Improve usage of LogCaptureAppender

2020-04-20 Thread GitBox
mjsax commented on issue #8508: URL: https://github.com/apache/kafka/pull/8508#issuecomment-616934105 Java 8: `org.apache.kafka.streams.integration.StandbyTaskEOSIntegrationTest.surviveWithOneTaskAsStandby[exactly_once_beta]` Java 11:

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411858555 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1610,79 +1610,6 @@ public

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411858808 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignorTest.java ## @@ -1610,79 +1610,6 @@ public

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411866042 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411814466 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813832 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411847662 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411864699 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411864205 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411863881 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411812127 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r41182 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
chia7712 commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411846617 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: avoid unnecessary delay conversion in isDelayed check

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411821681 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411821268 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] abbccdda commented on issue #8522: KAFKA-9868: Reduce transaction log partitions for embed broker

2020-04-20 Thread GitBox
abbccdda commented on issue #8522: URL: https://github.com/apache/kafka/pull/8522#issuecomment-616917436 Got 2/3 green, one failed test is due to ``` kafka.api.SaslSslConsumerTest.testCoordinatorFailover java.lang.AssertionError: expected: but was: ```

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411826785 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411826782 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411841909 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411863591 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411813053 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] ableegoldman commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
ableegoldman commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411815724 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411815738 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411818919 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411818806 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411840027 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -33,7 +33,11 @@ class DelayedItem(val delayMs: Long) extends Delayed with

[GitHub] [kafka] lbradstreet commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem

2020-04-20 Thread GitBox
lbradstreet commented on a change in pull request #8517: URL: https://github.com/apache/kafka/pull/8517#discussion_r411866242 ## File path: core/src/main/scala/kafka/utils/DelayedItem.scala ## @@ -21,24 +21,24 @@ import java.util.concurrent._ import

[GitHub] [kafka] vvcephei commented on a change in pull request #8497: KAFKA-6145: KIP-441 Build state constrained assignment from balanced one

2020-04-20 Thread GitBox
vvcephei commented on a change in pull request #8497: URL: https://github.com/apache/kafka/pull/8497#discussion_r411825756 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/TaskMovement.java ## @@ -16,128 +16,94 @@ */ package

[GitHub] [kafka] LiamClarkeNZ commented on a change in pull request #8520: Add explicit grace period to tumbling window example

2020-04-21 Thread GitBox
LiamClarkeNZ commented on a change in pull request #8520: URL: https://github.com/apache/kafka/pull/8520#discussion_r412007274 ## File path: docs/streams/developer-guide/dsl-api.html ## @@ -3262,12 +3262,15 @@ KTable-KTable Foreign-Key import

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412049922 ## File path: streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java ## @@ -1127,7 +1127,7 @@ public void

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412020510 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -93,6 +96,29 @@ long partitionTimestamp(final

[GitHub] [kafka] avalsa commented on a change in pull request #8221: KAFKA-9561: update task input partitions after rebalance

2020-04-21 Thread GitBox
avalsa commented on a change in pull request #8221: URL: https://github.com/apache/kafka/pull/8221#discussion_r412020510 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/PartitionGroup.java ## @@ -93,6 +96,29 @@ long partitionTimestamp(final

[GitHub] [kafka] tombentley commented on issue #8311: KAFKA-9434: automated protocol for alterReplicaLogDirs

2020-04-21 Thread GitBox
tombentley commented on issue #8311: URL: https://github.com/apache/kafka/pull/8311#issuecomment-617069226 @dajac thanks for the review, I've addressed all your comments. This is an automated message from the Apache Git

[GitHub] [kafka] dajac opened a new pull request #8525: [WIP] KAFKA-9885; Evict last members of a group when the maximum allowed is reached

2020-04-21 Thread GitBox
dajac opened a new pull request #8525: URL: https://github.com/apache/kafka/pull/8525 WIP ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including

  1   2   3   4   5   6   7   8   9   10   >