[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem
chia7712 commented on a change in pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#discussion_r412284404
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,23 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
/**
- * The remaining delay time
+ * true if the item is still delayed
*/
- def getDelay(unit: TimeUnit): Long = {
-unit.convert(max(dueMs - Time.SYSTEM.milliseconds, 0),
TimeUnit.MILLISECONDS)
+ def isDelayed: Boolean = {
+time.nanoseconds < dueNs
}
- def compareTo(d: Delayed): Int = {
-val other = d.asInstanceOf[DelayedItem]
-java.lang.Long.compare(dueMs, other.dueMs)
+ def compareTo(d: DelayedItem): Int = {
Review comment:
This method was from ```Delayed``` so it seems to me it is ok to remove
this method if this class does not extend ```Delayed``` anymore
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem
chia7712 commented on a change in pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#discussion_r412279368
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,24 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
Review comment:
> I think it's very unlikely we'll ever hit it given our normal delays.
you are right :)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem
chia7712 commented on a change in pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#discussion_r411847662
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,24 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
Review comment:
Should we handle the overflow?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem
chia7712 commented on a change in pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#discussion_r411846617
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,24 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
/**
- * The remaining delay time
+ * true if the item is still delayed
*/
- def getDelay(unit: TimeUnit): Long = {
-unit.convert(max(dueMs - Time.SYSTEM.milliseconds, 0),
TimeUnit.MILLISECONDS)
+ def isDelayed: Boolean = {
+dueNs - time.nanoseconds > 0
}
def compareTo(d: Delayed): Int = {
val other = d.asInstanceOf[DelayedItem]
-java.lang.Long.compare(dueMs, other.dueMs)
+java.lang.Long.compare(dueNs, other.dueNs)
}
+ override def toString: String = {
+"DelayedItem(delayMs="+(dueNs-time.nanoseconds())+")"
Review comment:
typo: delayMs -> delayNs
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #8517: MINOR: use monotonic clock for replica fetcher DelayedItem
chia7712 commented on a change in pull request #8517:
URL: https://github.com/apache/kafka/pull/8517#discussion_r411845809
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,24 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
/**
- * The remaining delay time
+ * true if the item is still delayed
*/
- def getDelay(unit: TimeUnit): Long = {
-unit.convert(max(dueMs - Time.SYSTEM.milliseconds, 0),
TimeUnit.MILLISECONDS)
+ def isDelayed: Boolean = {
+dueNs - time.nanoseconds > 0
}
def compareTo(d: Delayed): Int = {
Review comment:
Is it necessary to accept Delayed type now?
##
File path: core/src/main/scala/kafka/utils/DelayedItem.scala
##
@@ -21,24 +21,24 @@ import java.util.concurrent._
import org.apache.kafka.common.utils.Time
-import scala.math._
+class DelayedItem(val delayMs: Long, val time: Time) extends Logging {
+ def this(delayMs: Long) = this(delayMs, Time.SYSTEM)
-class DelayedItem(val delayMs: Long) extends Delayed with Logging {
-
- private val dueMs = Time.SYSTEM.milliseconds + delayMs
-
- def this(delay: Long, unit: TimeUnit) = this(unit.toMillis(delay))
+ private val dueNs = time.nanoseconds + TimeUnit.MILLISECONDS.toNanos(delayMs)
/**
- * The remaining delay time
+ * true if the item is still delayed
*/
- def getDelay(unit: TimeUnit): Long = {
-unit.convert(max(dueMs - Time.SYSTEM.milliseconds, 0),
TimeUnit.MILLISECONDS)
+ def isDelayed: Boolean = {
+dueNs - time.nanoseconds > 0
Review comment:
How about dueNs > time.nanoseconds ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
