[GitHub] [kafka] hachikuji commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434306556 ## File path: core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala ## @@ -86,6 +90,70 @@ class

[GitHub] [kafka] hachikuji commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434218326 ## File path: core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala ## @@ -86,6 +90,70 @@ class

[GitHub] [kafka] hachikuji commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434153210 ## File path: core/src/test/scala/unit/kafka/coordinator/transaction/TransactionMarkerChannelManagerTest.scala ## @@ -221,7 +221,6 @@ class

[GitHub] [kafka] hachikuji commented on a change in pull request #8782: KAFKA-10080; Fix race condition on txn completion which can cause duplicate appends

2020-06-02 Thread GitBox
hachikuji commented on a change in pull request #8782: URL: https://github.com/apache/kafka/pull/8782#discussion_r434098545 ## File path: core/src/main/scala/kafka/coordinator/transaction/TransactionMarkerChannelManager.scala ## @@ -285,15 +280,16 @@ class