rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-633058812
All Connect unit and integration tests passed in all of the builds, but each
of the builds failed due to a few flaky integration tests in either Core or
Streams.
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-632920985
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-632288718
FYI: previous builds had no failures related to Connect.
This is an automated message from the Apache Git Service.
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-632288310
Incorporated @kkonstantine's more recent suggestions, and further changed
`TopicAdmin` to use existing `TopicConfig` constants rather than string
literals.
Rebased to pick
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762530
Thanks for the review, @kkonstantine. I think I've incorporated all of your
suggestions.
This is an automated
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-631762616
ok to test
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-628885132
I've added some integration tests for creating the internal topic, including
verifying some existing functionality w/r/t the replication factor and number
of partitions with
rhauch commented on pull request #8654:
URL: https://github.com/apache/kafka/pull/8654#issuecomment-628682601
BTW, I've improved the error message when Connect's `TopicAdmin` fails to
create a topic because of an unknown topic setting:
> Uncaught exception in herder work thread,
