Re: [PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
github-actions[bot] commented on PR #21224: URL: https://github.com/apache/kafka/pull/21224#issuecomment-4504852095 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label should be removed to prevent this automation from happening again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
vbakke commented on PR #21224: URL: https://github.com/apache/kafka/pull/21224#issuecomment-4489565538 Using `wmic` should be removed from the script altogether. (See #19703 for a better solution.) I suggest closing this issue, and approving #19703. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
github-actions[bot] commented on PR #21224: URL: https://github.com/apache/kafka/pull/21224#issuecomment-4211368861 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label should be removed to prevent this automation from happening again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
github-actions[bot] commented on PR #21224: URL: https://github.com/apache/kafka/pull/21224#issuecomment-4196425879 This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please leave a comment asking for a review. If the PR has merge conflicts, update it with the latest from the base branch. If you are having difficulty finding a reviewer, please reach out on the [mailing list](https://kafka.apache.org/contact). If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
github-actions[bot] commented on PR #21224: URL: https://github.com/apache/kafka/pull/21224#issuecomment-3717195019 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label should be removed to prevent this automation from happening again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
[PR] KAFKA-20024: wmic os get osarchitecture is unreliable for detecting OS bitness in bat scripts [kafka]
AbyssFishRover opened a new pull request, #21224: URL: https://github.com/apache/kafka/pull/21224 Hello，During my usage of Kafka, I identified an issue. In the kafka-server-start.bat script, there is a logic that sets different startup parameters based on the bitness (32-bit/64-bit) of the operating system. The relevant code is as follows: https://github.com/user-attachments/assets/c7730e58-1e30-47a1-82d5-7b8e327eb5d5"; /> It first queries wmic os get osarchitecture, then determines whether the operating system is 32-bit or 64-bit by checking if the result contains the string "32-bit". However, my actual tests show that this method is not reliable—the returned results vary across Windows systems with different languages and regional settings, as shown below: English Windows: https://github.com/user-attachments/assets/42acc377-fb49-45d2-ba15-ac6049f556d1"; /> Chinese Windows: https://github.com/user-attachments/assets/b7b1a606-54a9-40ef-b3bd-ed5172af3681"; /> French Windows: https://github.com/user-attachments/assets/2a85348e-a13c-402a-9c7d-dcd658837db5"; /> German Windows: https://github.com/user-attachments/assets/22661fba-7375-4f5b-9a65-f57db1f37677"; /> Japanese Windows: https://github.com/user-attachments/assets/6fb4f9df-bf5e-4479-b7f0-80aed045765e"; /> Older Windows XP systems: https://github.com/user-attachments/assets/fbb381a3-2591-4543-bdbf-88bab26027ad"; /> Kafka has users across the globe, and the current approach lacks universality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
