[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052221#comment-18052221
]
Abhijit commented on KAFKA-19331:
-
*PR:* [https://github.com/apache/kafka/pull/21316]
[~showuon] , I have submitted a PR addressing this issue. I’d appreciate it if
you could review it when convenient.
Thanks!
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Abhijit
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18052215#comment-18052215
]
Abhijit commented on KAFKA-19331:
-
[~showuon] I am assigning this task to myself, I’ve started contributing to
Apache Kafka and found a problem that I believe is suitable for me to work on.
Please let me know if there are any concerns.
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Abhijit
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18045038#comment-18045038
]
Pawandeep Singh commented on KAFKA-19331:
-
[~showuon] Can you please review the PR?
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042665#comment-18042665
]
Pawandeep Singh commented on KAFKA-19331:
-
Ack. [~showuon] Can you please assign the task to me?
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042431#comment-18042431
]
Ming-Yen Chung commented on KAFKA-19331:
[~showuon] OK! [~devtrace404], Feel free to take it. :)
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042380#comment-18042380
]
Luke Chen commented on KAFKA-19331:
---
[~mingyen066], is it OK [~devtrace404] takes it over?
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042379#comment-18042379
]
Ming-Yen Chung commented on KAFKA-19331:
[~devtrace404] I'm really sorry I haven't submitted the PR yet. Could you give
me three more days? After that, feel free to take the ticket.
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18042360#comment-18042360
]
Pawandeep Singh commented on KAFKA-19331:
-
[~showuon] Since there is no activity on this issue from last 5 months, I am
starting to work on this.
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17986422#comment-17986422
]
Naman Kumar Singh commented on KAFKA-19331:
---
[~mingyen066] perfect ! hope you will add it soon.
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979354#comment-17979354
]
Ming-Yen Chung commented on KAFKA-19331:
[~naman_singh] Sorry, I’ve already reviewed the relevant code. I’ll send out a
patch this week. :)
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17979315#comment-17979315
]
Naman Kumar Singh commented on KAFKA-19331:
---
[~mingyen066] if you are not working on this can i add a patch for this ?
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954042#comment-17954042
]
Luke Chen commented on KAFKA-19331:
---
Assigned to you. Thanks [~mingyen066] !
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Assignee: Ming-Yen Chung
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (KAFKA-19331) No error handling for leader not appeared in applyLocalFollowersDelta
[
https://issues.apache.org/jira/browse/KAFKA-19331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17954040#comment-17954040
]
Ming-Yen Chung commented on KAFKA-19331:
Hi [~showuon] , could you assign this ticket to me?
> No error handling for leader not appeared in applyLocalFollowersDelta
> --
>
> Key: KAFKA-19331
> URL: https://issues.apache.org/jira/browse/KAFKA-19331
> Project: Kafka
> Issue Type: Bug
>Reporter: Luke Chen
>Priority: Major
> Labels: newbie
>
> In ReplicaManager#applyLocalFollowersDelta, when we prepare for fetching from
> the leader, we'll check if the leader node info is in metadata image. If
> somehow it didn't include in the newImage, we'll log something like:
>
> {code:java}
> [2025-05-26 15:25:58,124] TRACE [Broker id=4] Unable to start fetching
> quickstart-events-0 with topic ID Some(Dn9K0BB8QWuj4PqcJD0nrA) from leader
> Some(2) because it is not alive. (state.change.logger)
> [2025-05-26 15:25:58,124] INFO [Broker id=4] Started fetchers as part of
> become-follower for 1 partitions (state.change.logger)
> {code}
>
> It's confusing to users to see it's unable to fetch, then start fetch. And in
> the end, it's not actually fetching... We should handling the error well by
> updating the `FailedPartition` and not updating other successful result
> status.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
