[jira] [Commented] (KAFKA-5575) SchemaBuilder should have a method to clone an existing Schema.
[
https://issues.apache.org/jira/browse/KAFKA-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16373925#comment-16373925
]
Ewen Cheslack-Postava commented on KAFKA-5575:
--
[~rhauch] I think I didn't trigger a vote on the KIP yet though. Really I just
grab public API changes that someone's hesitating on KIPs for and write the KIP
because I think the 15min it takes for the simple ones isn't a big deal and
gives the community, and especially frequent, direct contributors, a chance to
catch issues like incompatibilities. I think a few minutes investment + a
couple of days turn-around time for a public API change in an API that's used
very broadly is actually quite a low cost. In this case, there's really nothing
I can see that would be a problem beyond what's already mentioned in the KIP,
so I think we should just move forward w/ voting and execution.
> SchemaBuilder should have a method to clone an existing Schema.
> ---
>
> Key: KAFKA-5575
> URL: https://issues.apache.org/jira/browse/KAFKA-5575
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Reporter: Jeremy Custenborder
>Assignee: Jeremy Custenborder
>Priority: Minor
> Labels: needs-kip
>
> Now that Transformations have landed in Kafka Connect we should have an easy
> way to do quick modifications to schemas. For example changing the name of a
> schema shouldn't be much more than. I should be able to do more stuff like
> this.
> {code:java}
> return SchemaBuilder.from(Schema.STRING_SCHEMA).name("MyNewName").build()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KAFKA-5575) SchemaBuilder should have a method to clone an existing Schema.
[
https://issues.apache.org/jira/browse/KAFKA-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16358653#comment-16358653
]
Randall Hauch commented on KAFKA-5575:
--
[~ewencp], is this an example of something that we would not need a KIP for
because it is a simple addition, or should we just do a KIP for everything?
> SchemaBuilder should have a method to clone an existing Schema.
> ---
>
> Key: KAFKA-5575
> URL: https://issues.apache.org/jira/browse/KAFKA-5575
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Reporter: Jeremy Custenborder
>Assignee: Jeremy Custenborder
>Priority: Minor
>
> Now that Transformations have landed in Kafka Connect we should have an easy
> way to do quick modifications to schemas. For example changing the name of a
> schema shouldn't be much more than. I should be able to do more stuff like
> this.
> {code:java}
> return SchemaBuilder.from(Schema.STRING_SCHEMA).name("MyNewName").build()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (KAFKA-5575) SchemaBuilder should have a method to clone an existing Schema.
[
https://issues.apache.org/jira/browse/KAFKA-5575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16079890#comment-16079890
]
ASF GitHub Bot commented on KAFKA-5575:
---
GitHub user jcustenborder opened a pull request:
https://github.com/apache/kafka/pull/3511
KAFKA-5575 - Add SchemaBuilder.from
Added `SchemaBuilder.from` method which allows creating a schema builder
prepopulated with the details from the schema. Added tests for structs, maps,
arrays, primitives, and logical types.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jcustenborder/kafka KAFKA-5575
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3511.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3511
commit 1acb99a6b96b50958956659c770a055c3fd4d133
Author: Jeremy Custenborder
Date: 2017-07-10T05:36:38Z
KAFKA-5575 Added `SchemaBuilder.from` method which allows creating a schema
builder prepopulated with the details from the schema. Added tests for structs,
maps, arrays, primitives, and logical types.
> SchemaBuilder should have a method to clone an existing Schema.
> ---
>
> Key: KAFKA-5575
> URL: https://issues.apache.org/jira/browse/KAFKA-5575
> Project: Kafka
> Issue Type: Improvement
> Components: KafkaConnect
>Reporter: Jeremy Custenborder
>Assignee: Jeremy Custenborder
>Priority: Minor
>
> Now that Transformations have landed in Kafka Connect we should have an easy
> way to do quick modifications to schemas. For example changing the name of a
> schema shouldn't be much more than. I should be able to do more stuff like
> this.
> {code:java}
> return SchemaBuilder.from(Schema.STRING_SCHEMA).name("MyNewName").build()
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
