[jira] [Commented] (KAFKA-5596) TopicCommand methods fail to handle topic name with "."

2017-07-17 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089425#comment-16089425
 ] 

ASF GitHub Bot commented on KAFKA-5596:
---

Github user sh-z closed the pull request at:

https://github.com/apache/kafka/pull/3533


> TopicCommand methods fail to handle topic name with "."
> ---
>
> Key: KAFKA-5596
> URL: https://issues.apache.org/jira/browse/KAFKA-5596
> Project: Kafka
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Shuai Zhang
> Fix For: 0.12.0.0
>
>
> When there is one topic which name includes ".", then we invoke *list*, 
> *describe*, *alter*, *delete* functions and set this topic name, those 
> functions will not only operate this topic, but also operate all other topics 
> that have same name regex pattern.
> For example, there are two topics on Kafka cluster:
> * test.a
> * test_a
> If you run command "--describe --topic test.a", it will return both of 
> *test.a* and *test_a*. Other functions have the same effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KAFKA-5596) TopicCommand methods fail to handle topic name with "."

2017-07-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088679#comment-16088679
 ] 

ASF GitHub Bot commented on KAFKA-5596:
---

GitHub user sh-z opened a pull request:

https://github.com/apache/kafka/pull/3533

KAFKA-5596: TopicCommand methods fail to handle topic name with "."

When there is one topic which name includes `.`, then we invoke `list`, 
`describe`, `alter`, `delete` functions and set this topic name, those 
functions will not only operate this topic, but also operate all other topics 
that have same name regex pattern.
For example, there are two topics on Kafka cluster:
- test.a
- test_a

If you run command `--describe --topic test.a`, it will return both of 
`test.a` and `test_a`. Other functions have the same effect.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sh-z/kafka KAFKA-5596

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/kafka/pull/3533.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3533


commit 339a6df77c5ddff5bf84923950ce42500392c6ca
Author: Shuai Zhang 
Date:   2017-07-15T17:36:23Z

escape '.' for topic name regex




> TopicCommand methods fail to handle topic name with "."
> ---
>
> Key: KAFKA-5596
> URL: https://issues.apache.org/jira/browse/KAFKA-5596
> Project: Kafka
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Shuai Zhang
> Fix For: 0.12.0.0
>
>
> When there is one topic which name includes ".", then we invoke *list*, 
> *describe*, *alter*, *delete* functions and set this topic name, those 
> functions will not only operate this topic, but also operate all other topics 
> that have same name regex pattern.
> For example, there are two topics on Kafka cluster:
> * test.a
> * test_a
> If you run command "--describe --topic test.a", it will return both of 
> *test.a* and *test_a*. Other functions have the same effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Commented] (KAFKA-5596) TopicCommand methods fail to handle topic name with "."

2017-07-15 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/KAFKA-5596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088675#comment-16088675
 ] 

ASF GitHub Bot commented on KAFKA-5596:
---

Github user sh-z closed the pull request at:

https://github.com/apache/kafka/pull/3532


> TopicCommand methods fail to handle topic name with "."
> ---
>
> Key: KAFKA-5596
> URL: https://issues.apache.org/jira/browse/KAFKA-5596
> Project: Kafka
>  Issue Type: Bug
>  Components: admin
>Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.1, 0.10.2.1, 0.11.0.0
>Reporter: Shuai Zhang
> Fix For: 0.12.0.0
>
>
> When there is one topic which name includes ".", then we invoke *list*, 
> *describe*, *alter*, *delete* functions and set this topic name, those 
> functions will not only operate this topic, but also operate all other topics 
> that have same name regex pattern.
> For example, there are two topics on Kafka cluster:
> * test.a
> * test_a
> If you run command "--describe --topic test.a", it will return both of 
> *test.a* and *test_a*. Other functions have the same effect.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)