[jira] [Commented] (KAFKA-7597) Trogdor - Support transactions in ProduceBenchWorker

2018-11-27 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701009#comment-16701009
 ] 

ASF GitHub Bot commented on KAFKA-7597:
---

cmccabe closed pull request #5885: KAFKA-7597: Make Trogdor ProduceBenchWorker 
support transactions
URL: https://github.com/apache/kafka/pull/5885
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/build.gradle b/build.gradle
index 4d514dfcf97..5ce648adf77 100644
--- a/build.gradle
+++ b/build.gradle
@@ -565,6 +565,7 @@ project(':core') {
   dependencies {
 compile project(':clients')
 compile libs.jacksonDatabind
+compile libs.jacksonJDK8Datatypes
 compile libs.joptSimple
 compile libs.metrics
 compile libs.scalaLibrary
@@ -830,6 +831,7 @@ project(':clients') {
 compile libs.snappy
 compile libs.slf4jApi
 compileOnly libs.jacksonDatabind // for SASL/OAUTHBEARER bearer token 
parsing
+compileOnly libs.jacksonJDK8Datatypes
 
 jacksonDatabindConfig libs.jacksonDatabind // to publish as provided scope 
dependency.
 
@@ -839,6 +841,7 @@ project(':clients') {
 
 testRuntime libs.slf4jlog4j
 testRuntime libs.jacksonDatabind
+testRuntime libs.jacksonJDK8Datatypes
   }
 
   task determineCommitId {
@@ -918,6 +921,7 @@ project(':tools') {
 compile project(':log4j-appender')
 compile libs.argparse4j
 compile libs.jacksonDatabind
+compile libs.jacksonJDK8Datatypes
 compile libs.slf4jApi
 
 compile libs.jacksonJaxrsJsonProvider
@@ -1347,6 +1351,7 @@ project(':connect:json') {
   dependencies {
 compile project(':connect:api')
 compile libs.jacksonDatabind
+compile libs.jacksonJDK8Datatypes
 compile libs.slf4jApi
 
 testCompile libs.easymock
diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 7dd3604db08..59f56fcd4ab 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -103,6 +103,7 @@ libs += [
   bcpkix: "org.bouncycastle:bcpkix-jdk15on:$versions.bcpkix",
   easymock: "org.easymock:easymock:$versions.easymock",
   jacksonDatabind: 
"com.fasterxml.jackson.core:jackson-databind:$versions.jackson",
+  jacksonJDK8Datatypes: 
"com.fasterxml.jackson.datatype:jackson-datatype-jdk8:$versions.jackson",
   jacksonJaxrsJsonProvider: 
"com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:$versions.jackson",
   jaxbApi: "javax.xml.bind:jaxb-api:$versions.jaxb",
   jaxrsApi: "javax.ws.rs:javax.ws.rs-api:$versions.jaxrs",
diff --git a/tests/bin/trogdor-run-transactional-produce-bench.sh 
b/tests/bin/trogdor-run-transactional-produce-bench.sh
new file mode 100755
index 000..fd5ff0a01f2
--- /dev/null
+++ b/tests/bin/trogdor-run-transactional-produce-bench.sh
@@ -0,0 +1,51 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+COORDINATOR_ENDPOINT="localhost:8889"
+TASK_ID="produce_bench_$RANDOM"
+TASK_SPEC=$(
+cat < transactionGenerator;
 private final Map producerConf;
 private final Map adminClientConf;
 private final Map commonClientConf;
@@ -53,6 +83,7 @@ public ProduceBenchSpec(@JsonProperty("startMs") long startMs,
  @JsonProperty("maxMessages") int maxMessages,
  @JsonProperty("keyGenerator") PayloadGenerator 
keyGenerator,
  @JsonProperty("valueGenerator") PayloadGenerator 
valueGenerator,
+ @JsonProperty("transactionGenerator") 
Optional txGenerator,
  @JsonProperty("producerConf") Map 
producerConf,
  @JsonProperty("commonClientConf") Map 
commonClientConf,
  @JsonProperty("adminClientConf") Map 
adminClientConf,
@@ -67,6 +98,7 @@ public ProduceBenchSpec(@JsonProperty("startMs") long startMs,
 new SequentialPayloadGenerator(4, 0) : keyGenerator;
 this.valueGenerator = valueGenerator == null ?
 new ConstantPayloadGenerator(512, new byte[0]) 

[jira] [Commented] (KAFKA-7597) Trogdor - Support transactions in ProduceBenchWorker

2018-11-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/KAFKA-7597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676787#comment-16676787
 ] 

ASF GitHub Bot commented on KAFKA-7597:
---

stanislavkozlovski opened a new pull request #5885: KAFKA-7597: Make Trogdor 
ProduceBenchWorker support transactions
URL: https://github.com/apache/kafka/pull/5885
 
 
   It now accepts a new "messagesPerTransaction" field, which, if present, will 
enable transactional functionality in the bench worker.
   The producer will open N transactions with X messages each (bounded by the 
mandatory "maxMessages" field)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Trogdor - Support transactions in ProduceBenchWorker
> 
>
> Key: KAFKA-7597
> URL: https://issues.apache.org/jira/browse/KAFKA-7597
> Project: Kafka
>  Issue Type: Improvement
>Reporter: Stanislav Kozlovski
>Assignee: Stanislav Kozlovski
>Priority: Minor
>
> The `ProduceBenchWorker` allows you to schedule a benchmark of a Kafka 
> Producer.
> It would prove useful if we supported transactions in this producer, as to 
> allow benchmarks with transactions.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)