[jira] [Commented] (KAFKA-9294) Enhance DSL Naming Guide to Include All Naming Rules
[ https://issues.apache.org/jira/browse/KAFKA-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17015426#comment-17015426 ] ASF GitHub Bot commented on KAFKA-9294: --- mjsax commented on pull request #7927: KAFKA-9294: Add tests for Named parameter URL: https://github.com/apache/kafka/pull/7927 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enhance DSL Naming Guide to Include All Naming Rules > > > Key: KAFKA-9294 > URL: https://issues.apache.org/jira/browse/KAFKA-9294 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Bill Bejeck >Assignee: Bill Bejeck >Priority: Major > > We already have a naming guide in the docs, but we should expand it to cover > how all components of the DSL get named. > -Seems there is a broken link, too: > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-api.html#naming-a-streams-app] > links to > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-topology-naming.html] > (that does not work)- > > EDIT: Link to the naming guide is fixed now. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9294) Enhance DSL Naming Guide to Include All Naming Rules
[ https://issues.apache.org/jira/browse/KAFKA-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012347#comment-17012347 ] ASF GitHub Bot commented on KAFKA-9294: --- mjsax commented on pull request #7927: KAFKA-9294: Add tests for Named parameter URL: https://github.com/apache/kafka/pull/7927 Part (2) -- stateful KStream operators Follow up to #7878 KStream interface contains some method reordering (I also renamed some parameters as highlighted) Call for review @bbejeck @vvcephei This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enhance DSL Naming Guide to Include All Naming Rules > > > Key: KAFKA-9294 > URL: https://issues.apache.org/jira/browse/KAFKA-9294 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Bill Bejeck >Assignee: Bill Bejeck >Priority: Major > > We already have a naming guide in the docs, but we should expand it to cover > how all components of the DSL get named. > -Seems there is a broken link, too: > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-api.html#naming-a-streams-app] > links to > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-topology-naming.html] > (that does not work)- > > EDIT: Link to the naming guide is fixed now. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9294) Enhance DSL Naming Guide to Include All Naming Rules
[ https://issues.apache.org/jira/browse/KAFKA-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17012299#comment-17012299 ] ASF GitHub Bot commented on KAFKA-9294: --- mjsax commented on pull request #7874: KAFKA-9294: Add tests for Named parameter URL: https://github.com/apache/kafka/pull/7874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enhance DSL Naming Guide to Include All Naming Rules > > > Key: KAFKA-9294 > URL: https://issues.apache.org/jira/browse/KAFKA-9294 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Bill Bejeck >Assignee: Bill Bejeck >Priority: Major > > We already have a naming guide in the docs, but we should expand it to cover > how all components of the DSL get named. > -Seems there is a broken link, too: > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-api.html#naming-a-streams-app] > links to > [https://kafka.apache.org/24/documentation/streams/developer-guide/dsl-topology-naming.html] > (that does not work)- > > EDIT: Link to the naming guide is fixed now. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (KAFKA-9294) Enhance DSL Naming Guide to Include All Naming Rules
[ https://issues.apache.org/jira/browse/KAFKA-9294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17005073#comment-17005073 ] ASF GitHub Bot commented on KAFKA-9294: --- mjsax commented on pull request #7874: KAFKA-9294: Add tests for Named parameter URL: https://github.com/apache/kafka/pull/7874 During the work on KIP-150, we encountered some inconsistencies with regard to `Named` parameter, ie, not all methods check for `null` (what should not be allowed). Going over the code, and to make sure we don't forget any case, I reordered couple of methods to keep an overview (ie, same order in interface, implementation, and tests). I'll highlight the actual changes in the code. Call for review @vvcephei This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Enhance DSL Naming Guide to Include All Naming Rules > > > Key: KAFKA-9294 > URL: https://issues.apache.org/jira/browse/KAFKA-9294 > Project: Kafka > Issue Type: Improvement > Components: streams >Reporter: Bill Bejeck >Assignee: Bill Bejeck >Priority: Major > > We already have a naming guide in the docs, but we should expand it to cover > how all components of the DSL get named. -- This message was sent by Atlassian Jira (v8.3.4#803005)
