Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
chia7712 merged PR #21260: URL: https://github.com/apache/kafka/pull/21260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
chia7712 commented on PR #21260: URL: https://github.com/apache/kafka/pull/21260#issuecomment-3717669173 ``` chia7712@fedora:~/project/kafka$ javap -verbose streams/streams-scala/build/classes/scala/main/org/apache/kafka/streams/scala/FunctionsCompatConversions.class | grep -i major major version: 55 ``` verified locally. LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
FrankYang0529 merged PR #21259: URL: https://github.com/apache/kafka/pull/21259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
Nikita-Shupletsov commented on PR #21258: URL: https://github.com/apache/kafka/pull/21258#issuecomment-3717172297 @FrankYang0529 4.0: https://github.com/apache/kafka/pull/21260 4.1: https://github.com/apache/kafka/pull/21259 thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
Nikita-Shupletsov commented on PR #21259: URL: https://github.com/apache/kafka/pull/21259#issuecomment-3717170880 the original PR: https://github.com/apache/kafka/pull/21258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
Nikita-Shupletsov commented on PR #21260: URL: https://github.com/apache/kafka/pull/21260#issuecomment-3717170618 the original PR: https://github.com/apache/kafka/pull/21258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
FrankYang0529 commented on PR #21258: URL: https://github.com/apache/kafka/pull/21258#issuecomment-3717015705 @Nikita-Shupletsov I cherry-pick the commit to 4.2 https://github.com/apache/kafka/commit/9f9cc21130e2593f8d139a95ce13544950084994. Both 4.1 and 4.0 have conflicts, could you create PRs to these two branches. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
FrankYang0529 merged PR #21258: URL: https://github.com/apache/kafka/pull/21258 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] KAFKA-20046: switched the java version for streams-scala from 17 to 11. [kafka]
chia7712 commented on code in PR #21258:
URL: https://github.com/apache/kafka/pull/21258#discussion_r2666263164
##
build.gradle:
##
@@ -46,7 +46,7 @@ plugins {
ext {
minClientJavaVersion = 11
minNonClientJavaVersion = 17
- modulesNeedingJava11 = [":clients", ":generator", ":streams",
":streams:test-utils", ":streams:examples", ":streams-scala",
":test-common:test-common-util"]
+ modulesNeedingJava11 = [":clients", ":generator", ":streams",
":streams:test-utils", ":streams:examples", ":streams:streams-scala",
":test-common:test-common-util"]
Review Comment:
ugh, it seems we made a major mistake. Thanks for this fix! I will backport
it to 4.x branches
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
